GitLab

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258,710901
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2836373003
Cr-Commit-Position: refs/heads/master@{#467619}

Set the class var to nullptr in the constructor. Missing initialization
is suspected to cause crash.

BUG=715826

Review-Url: https://codereview.chromium.org/2842373002
Cr-Commit-Position: refs/heads/master@{#467618}

This is needed so that subclass destructors will be called when
destroying a PermissionPromptDelegate pointer. This currently has no
impact on behavior since there are no subclass destructors.

BUG=596786

Review-Url: https://codereview.chromium.org/2836093006
Cr-Commit-Position: refs/heads/master@{#467617}

Before we can generate StyleInheritedData, we must first remove any
references to it outside of ComputedStyle. A lot of files include the
header file for StyleInheritedData, but do not use it. This will cause
a compile error when we remove the file to generate it instead.

This patch removes the unused includes, as lead-up to generating
StyleInheritedData.

BUG=628043

Review-Url: https://codereview.chromium.org/2844613002
Cr-Commit-Position: refs/heads/master@{#467616}

This change fixes two issues:

1. Clamp instead of casting double values from parser to internal
   unsigned storage.
2. Promote width/height/numerator/denominator multiplications to double
   to avoid integer overflow for large numerator/denominators.

R=yoav@yoav.ws,suzyh@chromium.org
BUG=676709,714079

Review-Url: https://codereview.chromium.org/2836613002
Cr-Commit-Position: refs/heads/master@{#467615}

Add 'pending AssociatedInterfacePtr connection error with reason' test to associated_interface_ptr.html

BUG=695635

Review-Url: https://codereview.chromium.org/2843183002
Cr-Commit-Position: refs/heads/master@{#467614}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2842263003
Cr-Commit-Position: refs/heads/master@{#467613}

This patch prunes the deprecated function from
DOMSelection::deleteFromDocument to improve code health.

BUG=698633
TEST=n/a; no behaviorial change

Review-Url: https://codereview.chromium.org/2844983002
Cr-Commit-Position: refs/heads/master@{#467612}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2837863003
Cr-Commit-Position: refs/heads/master@{#467611}

Accodring to Android documentation [1] read and write operations for
Ndef technology, should not throw IllegalStateException, however, those
operations do throw exception that must be handled. Unit tests are
updated to check that exception is handled and correct error reported
to caller.

[1] https://developer.android.com/reference/android/nfc/tech/Ndef.html

BUG=714039

Review-Url: https://codereview.chromium.org/2845463004
Cr-Commit-Position: refs/heads/master@{#467610}

I'm going to start writing different implementations of DocumentMarkerList for
the different MarkerTypes. This CL prepares us to be able to easily specify the
marker list class we want to use for each MarkerType.

BUG=707867

Review-Url: https://codereview.chromium.org/2826493003
Cr-Commit-Position: refs/heads/master@{#467609}

When the migration UI is notified by cryptohome that cryptohome gets unexpected
errors during migration and it gives up migration, we should remove the
user's cryptohome to make sure that the user will be able to log in to
the Desktop next time.

After the user's cryptohome is removed, we get password verification errors
on the existing user pod three times.
It seems an independent issue, so I filed crbug.com/715474 and will look into separately.

BUG=713556
TEST=manually tested by forcing cryptohome fail during migration and confirming the cryptohome is gone.

Review-Url: https://codereview.chromium.org/2838303003
Cr-Commit-Position: refs/heads/master@{#467608}

This changes TestStore to inherit from Store, allowing tests to use
more production code paths. It also adds a new flag to TestStore which
allows page actions to be handled normally (rather than preventing them
from executing), which is useful for integration testing.

BUG=697706

Review-Url: https://codereview.chromium.org/2839393002
Cr-Commit-Position: refs/heads/master@{#467607}

This patch does two things:
- Remove public methods on StyleBoxData. This is because these methods
  will no longer exist once we generate StyleBoxData.
- Rename vertical_align_ -> vertical_align_length_, to differentiate it
  from the keyword part of vertical-align (also called vertical_align_,
  stored in ComputedStyleBase)

This is preparation for generating StyleBoxData.

BUG=628043

Review-Url: https://codereview.chromium.org/2844163002
Cr-Commit-Position: refs/heads/master@{#467606}

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827003002
Cr-Commit-Position: refs/heads/master@{#467605}

- Process the output of 'ninja' live through the pipe rather than
  waiting for it to finish.
- Use multiprocessing.

Benchmark results using pypy:
Before:
17.10user 14.38system 0:20.05elapsed 157%CPU (0avgtext+0avgdata 1708036maxresident)k
18.06user 15.63system 0:21.92elapsed 153%CPU (0avgtext+0avgdata 1710912maxresident)k
17.94user 13.72system 0:19.91elapsed 158%CPU (0avgtext+0avgdata 1172128maxresident)k

After:
15.28user 7.11system 0:06.25elapsed 357%CPU (0avgtext+0avgdata 319236maxresident)k
16.03user 7.74system 0:06.84elapsed 347%CPU (0avgtext+0avgdata 319396maxresident)k
15.24user 8.16system 0:06.36elapsed 367%CPU (0avgtext+0avgdata 318272maxresident)k

BUG=661774

Review-Url: https://codereview.chromium.org/2842513003
Cr-Original-Commit-Position: refs/heads/master@{#466900}
Review-Url: https://codereview.chromium.org/2846473002
Cr-Commit-Position: refs/heads/master@{#467604}

Currently:
- width and height share the same initial method InitialSize
- minWidth and minHeight share the same initial method InitialMinSize
- maxWidth and maxHeight share the same initial method InitialMaxSize

This patch makes each of those properties use its own initial method so
that they can be more easily generated (the generator does not support
sharing of initial methods).

Diff of generated files:
https://gist.github.com/d058699c786d95762067b28ccfbc1774/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2841353002
Cr-Commit-Position: refs/heads/master@{#467603}

This CL expands the comment for the UMA_HISTOGRAM_SPARSE_SLOWLY macro.
It is inspired by a recent code review discussion with isherman@.

BUG=none

Review-Url: https://codereview.chromium.org/2831543002
Cr-Commit-Position: refs/heads/master@{#467602}

Test network annotation tags added to network requests of:
net/base/layered_network_delegate_unittest.cc
net/filter/sdch_policy_delegate_unittest.cc
net/log/net_log_util_unittest.cc
net/log/write_to_file_net_log_observer_unittest.cc
net/nqe/network_quality_estimator_test_util.cc
net/nqe/network_quality_estimator_unittest.cc
net/nqe/throughput_analyzer_unittest.cc
net/quic/chromium/quic_network_transaction_unittest.cc
net/spdy/spdy_network_transaction_unittest.cc
net/test/embedded_test_server/embedded_test_server_unittest.cc
net/websockets/websocket_end_to_end_test.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2833983002
Cr-Commit-Position: refs/heads/master@{#467601}

https://skia.googlesource.com/skia.git/+log/b8a1392b021f..ac0e705af1d6

$ git log b8a1392b0..ac0e705af --date=short --no-merges --format='%ad %ae %s'
2017-03-07 amaury.leleyzour Fix new IT blocks ARMv8

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I1727756725ce39d1bff9b837f91204a3e423942e
Reviewed-on: https://chromium-review.googlesource.com/487739Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467600}

DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createNodeIterator/createTreeWalker.

We used to return values wrapped by NodeIterator interface. The DOM specification
doesn't define such behavior, and Edge, Firefox, and Safari do not.

The core part of this CL is CPP_VALUE_TO_V8_VALUE in v8_types.py. We return a v8
value stored in V8NodeFilterCondition.

Because we don't need to wrap values by NodeFilter, this CL has simplification like:

- Cleanup of indirection ownership;
 Old: NodeIteratorBase -> NodeFilter -> V8NodeFilterCondition as NodeFilterCondition
 New: NodeIteratorBase -> V8NodeFilterCondition

- Removal of a V8PrivateProperty
 It can be replaced with TraceWrapper.

This CL fixes 1,106 failures in external/wpt/dom/.

BUG=591919, 715418

Review-Url: https://codereview.chromium.org/2840163002
Cr-Commit-Position: refs/heads/master@{#467599}

They will show improvement of upcoming optimization changes.

Review-Url: https://codereview.chromium.org/2842313002
Cr-Commit-Position: refs/heads/master@{#467598}

Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are
covered in the intent below.

Intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9CAAJ

BUG=585875

Review-Url: https://codereview.chromium.org/2837293002
Cr-Commit-Position: refs/heads/master@{#467597}

Idle time spell checker fetches positions to check from undo stack, but
the positions can be invalid since undo stack can store stale information.

This patch corrects the position before calculating the checking range,
so that we don't pass an invalid position to TextIterator, and hence,
fixes the crash.

BUG=715107

Review-Url: https://codereview.chromium.org/2845863002
Cr-Commit-Position: refs/heads/master@{#467596}

This patch renames:
- ComputedStyle::style_inherited_data_ -> ComputedStyle::inherited_data_
  (to be consistent with the other data refs like box_data_)
- Members of StyleInheritedData to have trailing underscore.

so that StyleInheritedData can be generated without name changes showing
up in the diff.

BUG=628043

Review-Url: https://codereview.chromium.org/2845463003
Cr-Commit-Position: refs/heads/master@{#467595}

We are looking into changing gattserverdisconnected to
gattserverdisconnect.

Review-Url: https://codereview.chromium.org/2841293002
Cr-Commit-Position: refs/heads/master@{#467594}

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553

Review-Url: https://codereview.chromium.org/2842513004
Cr-Commit-Position: refs/heads/master@{#467593}

Add LayoutNG versions of the DrawText and DrawEmphasisMarks methods that
operate on TextFragmentPaintInfo instances (wrapping text fragment data)
instead of TextRunPaintInfo instances. Reuses impl when at all possible.

Also adds support for bloberizing emphasis marks for text fragments with
the addition of a FillTextEmphasisGlyphs StringView/ShapeResult version.

BUG=714962
R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/2845883002
Cr-Commit-Position: refs/heads/master@{#467592}

Test network annotation tags added to network requests of:
net/url_request/url_request_context_builder_unittest.cc
net/url_request/url_request_file_dir_job_unittest.cc
net/url_request/url_request_file_job_unittest.cc
net/url_request/url_request_filter_unittest.cc
net/url_request/url_request_ftp_fuzzer.cc
net/url_request/url_request_ftp_job_unittest.cc
net/url_request/url_request_fuzzer.cc
net/url_request/url_request_http_job_unittest.cc
net/url_request/url_request_job_factory_impl_unittest.cc
net/url_request/url_request_job_unittest.cc
net/url_request/url_request_quic_unittest.cc
net/url_request/url_request_simple_job_unittest.cc
net/url_request/url_request_throttler_simulation_unittest.cc
net/url_request/url_request_throttler_unittest.cc
net/url_request/url_request_unittest.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2837543002
Cr-Commit-Position: refs/heads/master@{#467591}

Add a bunch of basic tests for the PromoDialog/PromoDialogLayout
that confirm that elements appear when they should, and that
clicking on them triggers the right events.

BUG=712836,712833

Review-Url: https://codereview.chromium.org/2842943002
Cr-Commit-Position: refs/heads/master@{#467590}

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Original-Commit-Position: refs/heads/master@{#466780}
Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c
Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#467589}

Bug: 709815
Change-Id: Ib4ceec1a6a369a055e24f60ca54e6c694b6a70d1
Reviewed-on: https://chromium-review.googlesource.com/488161Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467588}

And reset selection to original language.

BUG=703887

Review-Url: https://codereview.chromium.org/2842113002
Cr-Commit-Position: refs/heads/master@{#467587}

https://pdfium.googlesource.com/pdfium.git/+log/e47e0c96009b..827db14d7f3d

$ git log e47e0c960..827db14d7 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 tsepez Remove a few more |new|s.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ic141641351bed83fd7c458eddf3f9b8107203e54
Reviewed-on: https://chromium-review.googlesource.com/488169
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467586}

A couple of places in our code-based were hand-written to check for
whether the code was running on Android O, before we added support
for this through BuildInfo#isAtLeastO().

This CL makes them both call the generic method, so if that
generic method is changed, they will both benefit from that.

BUG=704209

Change-Id: I44b583af0744a67c889ef786eef7e6a96ddf8eed
Reviewed-on: https://chromium-review.googlesource.com/488129Reviewed-by: Dan Alcantara <dfalcantara@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467585}

Note that this only changes the one overload that matches the semantics
of std::basic_string<T>::replace(): STL doesn't provide an overload to
find a pattern and replace that pattern.

Bug: 709815
Change-Id: If1ef5a6233fd39d02f76cadb1e5d18d9d6905831
Reviewed-on: https://chromium-review.googlesource.com/487902Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467584}

TBR=yzshen@chromium.org

Bug: 709815
Change-Id: Ic2967caa96c4a42782766541472494aa27bc6179
Reviewed-on: https://chromium-review.googlesource.com/488170
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467583}

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}

There were two issues preventing focus from working correctly:
. In ash there is a single FocusClient used. FocusSynchronizer didn't
  work well with this, and as a result never told mus about focus
  changes.
. Mushrome mode was never configuring activation parents in mus. This
  meant even once the previous item was fixed mus would ignore the
  focus request. The fix is to move configuration of activation
  parents to the right place.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2843193002
Cr-Commit-Position: refs/heads/master@{#467581}

There's a race where we could receive a new click event before receving
notification of a remote frame becoming focused as a result of advancing
(using the tab key for example) to that frame.

If we already think we're focused we would never reply back to the
browser to refocus this frame.

BUG=713977
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2844563002
Cr-Commit-Position: refs/heads/master@{#467580}