GitLab

In this patch we add a |NGPhysicalFragment::IsPaintedAtomically| flag
to determine if a fragment should be painted atomically.

This is treated as the source of truth, v.s. checking if something is
an atomic-inline, a flex-item, etc.

This bit also in the |NGConstraintSpace| as a parent layout will
determine if a child should be painted atomically (as it typically has
this information).
See calls to |NGConstraintSpaceBuilder::SetIsPaintedAtomically|.

This passes two additional tests.

Bug: 845235
Change-Id: I145ca8c53c667727ed776d6901bb1b76bfd9063c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924877Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726166}

Using TerminateProcess to exit from utility processes has dropped the
crash rate significantly so it makes sense to apply the same recipe to
ppapi processes. Over 80% of utility and ppapi process crashes are
during shutdown so using TerminateProcess will get rid of most of the
crashes, thus making triage easier.

TerminateProcess is also faster.

Bug: 1024560
Change-Id: I214e0bdcaddfdac41a7d6f5dd2ff3a0e749871a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972896Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726165}

Replaces waiting on a histogram recording to know when a navigation is
complete with a content::WaitForLoadStop(). This seems to address the
flakey timeout I was reproducing locally.

Bug: 1032558, 1035377
Change-Id: I2a6e032ea6b112988699ea06275bbd28ec261362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974431
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726164}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ibaa2022172bc5395ec295f1a639a18c4f560d467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726163}

The reason for this issue is a bubble dialog does not get the correct
bounds if the anchor window changes bounds when the anchor window has an
un-identity transform in place. This CL forces the bubble dialog
relayout itself when the anchor window's transform reset to the identity
transform.

Bug: 1035512
Change-Id: I3e73400320ecb5df99016ff1f53e6325dca2a1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974594Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726162}

The metric is sending twice as much data as it should, and we
are about to add a corresponding compositor latency metric. Hence
we need to reduce the sampling rate by a factor of 4.

Bug: 1035531
Change-Id: If3dfcce9db624d28495c1f44c4887f55cf004326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974610
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726161}

Instead it (and its devired class WebRtcAudioDeviceImpl) operate
over WTF::String.

BUG=923394
R=guidou@chromium.org

Change-Id: I13928733af68463d789170ebb7aa7a6836288b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970138Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726160}

https://pdfium.googlesource.com/pdfium.git/+log/8cb6a652ad24..3567a9a85896

git log 8cb6a652ad24..3567a9a85896 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 thestig@chromium.org Roll third_party/depot_tools/ fe18a43d5..603782044 (20 commits; 3 trivial rolls)
2019-12-18 thestig@chromium.org Avoid crash in CPDF_SecurityHandler::GetUserPassword().
2019-12-18 tsepez@chromium.org Unify FPDF_FORMFILLINFO versioning and mark V2 as experimental
2019-12-18 dhoss@chromium.org Add --disable-javascript flag to test_runner.py

Created with:
  gclient setdep -r src/third_party/pdfium@3567a9a85896

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Icabc3e679d59004acfd783a8be4b70793cbd44d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974592Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726159}

Update chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/OWNERS
with the UI>Browser>NewTabPage>ExploreSites component. This should help
triaging, and I think will make FindIt automatically apply the label
the bugs found in running these tests.

Bug: None
Change-Id: I6b39fcbcc59ccb78a69573ef29ffbefece3e7344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974597Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726158}

The root of the Fuchsia semantic tree always has root id 0. This isn't
a constraint in Chromium, so some special handling has been added to
ensure the semantic tree received by Fuchsia maintains a consistent,
valid state.

Test: Expanded AccessibilityBridgeTest.

Bug: fuchsia:42172
Change-Id: Ic1e2398e0a6793bcbfef36643af64b78f79fea22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954321
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726157}

Right now, the extension may need to reset the state of an engine w/o
deactivating it. For example, if the user starts voice input, we need
to reset the engine state (voice input is not an engine; if it was an
engine, everything will work because we would deactivate the current
engine before starting voice input).

So far, this has been fine because the extension contained both UI
and IME code. But when we move to a native model, UI will no longer
contain IME code, so it will need to signal to IMF to reset the state
of the engine.

We add a new private API for resetting the engine.

Bug: 1009903
Change-Id: I7e0b9a18a308d5e9834a4a341d71192b37745b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971047Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726156}

... to use WTF::Vector instead.

BUG=923394
R=guidou@chromium.org

Change-Id: I08ddf7cbaac201f8b6e93aa1f4ba1addbc55f3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970133Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726155}

This change will alter the focus behavior for the quick settings
and message center when chrome vox is enabled. The initial focus
will now go to the entire widgets rather than the first element.

Bug: 1021133
Change-Id: Ifea0cc6e1ee59bd94f8a52a846e8f0abdfcb5744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973157Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726154}

Note that the CL introduces a copy routine, prior to
calling the backed libwebrtc functionality.

BUG=787254
R=guidou@chromium.org

Change-Id: Ia571015e723b3f9338308319647bd3496eb42d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969611Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726153}

-Splits bookmarkCurrentTabWithTitle into 2 methods: bookmarkCurrentTabWithTitle
and waitForBookmarkModelLoaded.

-Creates setupBookmarksWhichExceedsScreenHeight, removeBookmarkWithTitle and
moveBookmarkWithTitle, verifyBookmarksWithTitle on BookmarkEarlGrey and
their equivalent on the AppInterface.

- Various changes on BookmarkEarlGreyUI to fix EG2 errors.

Change-Id: I8d6ed0247dbf23b8157917942d96598342a5362c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973363
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726152}

It is not injected anymore and has been replaced by
SharedPreferencesManager.

Bug: 1022102
Change-Id: Ia4e42bbc4706766ca7b7adba8110c4784b7e8df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955809
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726151}

Adds tests for the Hunspell fallback logic (Windows hybrid spell checking)
submitted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1918277

- Adds browser tests for SpellCheckHostChromeImpl
- Adds component tests for the new SpellcheckHostMetrics
- Adds component test coverage for the new SpellcheckPlatform methods in the
  Windows platform test
    - Created a bug to track splitting the single test into multiple ones
- Adds component tests for SpellcheckProvider
    - Creates a new FakeSpellCheck class to fake the count of enabled spell
      check locales, which is needed to control when to call into the
      browser spell checker

Bug: 463364, 1035450
Change-Id: Ie3e692c0d5d5970ed2ab7612018198bf42049139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972573
Auto-Submit: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726150}

- On devices that support AEQ enable it by default.
- Make sure support is always tested regardless of pref value.
- Turn off AEQ by default in tests because most nightlight tests
  need it off to verify the night light colors.

Bug: 1034068
Test: manual
Change-Id: I5b3e97ef81d97c73f6496c30da12ddbe129e9c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974815Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726149}

... to use the corresponding WTF constructions.

BUG=787254
R=haraken@chromium.org

Change-Id: I964c991d53e1b28e93bce5f5fc9c26a0f7d29afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973993
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726148}

Other clean-up includes the following:
 * Modify updateToolbarColor() to take the theme as a parameter
   instead of deriving it directly from the <body>'s classes.
 * Rename & generalize getThemeForElement() to work for other
   lists of classes.
 * Remove get*Class methods. The input string and output class name
   were always identical.

Bug: 1027612
Change-Id: Ib3d80741a3b27dbb452ab4f948c47a71a7aa6b4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960721
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726147}

It is not currently used, but needs to be there for when a new
feature flag is cached.

Bug: 1022108,1012975

Change-Id: I759940be55dc5ae3bb2d72207a1e376a491324f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970370
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726146}

<This change is hidden behind a flag>

As part of migrating PK rule-based IMEs to native code, this CL migrates
reset to native code path.

We port RuleBasedController#onCompositionCancelled in
chos/pk/rulebasedcontroller.js.

Note that we need onReset to call through to the extension, as it has
side effects that may affect the extension when it is running (e.g.
when VK is up).

Note that the JS code has already been guarded by the runtime flag.

Bug: 1009903
Change-Id: Ic1efc191fb7c963916b58cea4e8055d1d8ae6743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968776
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726145}

Add “WebState_” to make it easier to read breadcrumb events. Without
this identifier, the WebState's unique_id is ambiguos.

Bug: 1003922
Change-Id: Ie223622a6566a1fc7d58a5dafff68937b19f1bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974814
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726144}

Change-Id: I914d4af9b1b0999a24a42aac40fc7faacfff10f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974835
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726143}

The underlying issue seems to be related to a sandboxed process failing
to open or truncate its log file. All the tests shared the same file,
leading to flaky issues despite the tests running with --single-process.

To avoid this issue, we now tell the
cleaner/reporter process and their spawned sandboxes to log to a
temporary folder.

Bug: 1030333
Change-Id: If339c623b148b8b458a32e4d974d6a642bc4f12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972494
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726142}

Bug: 1035266
Change-Id: Ied9ff05e0bedf2d9c4470d4ed68055e977713ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973551Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726141}

When the status area overflows and is in the expanded state, we show a gradient
background over the shelf.

Screenshot:
https://screenshot.googleplex.com/5WO6NUnED4m

BUG=1026072

Change-Id: Ia90fb50a85694edba8a22d9a029912c7e1ac80a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973355
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726140}

This CL is deceptively large to ensure that test cases with the same
feature flags are somewhat colocated.

Bug: 1035004
Change-Id: Ia09794fab81801269920d0e2403adb5a49e97d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974750
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726139}

Bug: 1024086
Change-Id: I9ad0d1d7ab2bb0b65c1c31257b451ecb4b327610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970831Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Auto-Submit: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#726138}

Without this, a shift could hide from LayoutShiftTracker if the layout
tree had to be rebuilt due to a change in an ancestor's 'display'
property.

Bug: 1003459
Change-Id: Ib00772ff7846251533080b29d16f6cbaafc8189b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958191
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726137}

* Creating a class which handles reparenting the current tab when the
  theme is swapped.
* Hooking that class into ChromeActivity.
* Adding plumbing to a few ReparentingTask/TabReparentingParams to
  facilitate the process.

Bug: 944302
Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726136}

I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/wB7mDJqrUZ8/ClecA5-qAgAJ
Bug: 1023967
Change-Id: I7f2108dce7e240a050a30fc436391692857062f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949481
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726135}

https://chromium.googlesource.com/angle/angle.git/+log/17b3c2f3f8b1..20432bf38dfe

git log 17b3c2f3f8b1..20432bf38dfe --date=short --first-parent --format='%ad %ae %s'
2019-12-18 ianelliott@google.com Vulkan: Update GLES 3.1 expectations for now-passing tests.
2019-12-18 courtneygo@google.com Reset binding offset & size when unbinding

Created with:
  gclient setdep -r src/third_party/angle@20432bf38dfe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: I4ed3077a305c80bbc4bfc433011656ce36d30fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726134}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=guidou@chromium.org

Bug: 1023677
Change-Id: I31c5dfab9cfb46fa70639b5a1f1f5a04a1bce2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957503
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726133}

R=bsheedy@chromium.org, harringtond@chromium.org, yliuyliu@chromium.org

Bug: 1028976
Change-Id: I08ab250686b7f714488597a3e82bcb529ab541d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974534Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726132}

This CL was created automatically with tools/perf/update_wpr script

R=crouleau@chromium.org

Bug: 878390
Change-Id: I7b2f914297110f7c7daa0da4e58f5339f7b9d18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971915
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726131}

Update the function name from OnWindowVisibilityChanging to
OnWindowVisibilityChanged.

Update the Chrome app checking, because when the app is an extension,
it could be opened in browser, so we should check the browser context
in AppService instance to decide whether that is a Chrome app, which
is opened in AppWindow. Otherwise, it could crash the browser should
manage those apps.

Fix the bug found by the new browser test:
1. The AppServiceInstanceRegistryHelper should be shared by
browser_status_monitor and AppServiceAppWindowLauncherController, and
owned by AppServiceAppWindowLauncherController, because
browser_status_monitor updates the record in
AppServiceInstanceRegistryHelper, if they use separate one, then
AppServiceAppWindowLauncherController can't know which apps are managed
by the browser.
2. When switch between the window, the AppServiceInstanceRegistryHelper
should update the apps opened in the browser.

BUG=1011235

Change-Id: I98080bca6ed6dc80a2c20ab1e9096e455d47187d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973971Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726130}

TBR=govind@chromium.org

Change-Id: I0d2560e3b7ef3263b854dc0b43106f320286130c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974491Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726129}

<This change is hidden behind a flag>

As part of migrating PK IMEs to native code, this CL migrates key
handling to native code path.

We port Background#maybeHandleKeyEvent [1] and
RuleBasedController#handleEvent [2].

[1] chos/background.js
[2] chos/pk/rulebasedcontroller.js

Note that the JS code has already been guarded by the runtime flag.

Bug: 1009903
Change-Id: I801505f11af95dbc066b12d7bb70f6a9765fea65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921589Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726128}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b65f3282baa9..d94b7f19dbf6


Created with:
  gclient setdep -r src-internal@d94b7f19dbf6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic63c2cb085bc2f2cfeec35a8e31576b2701d532a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974642Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726127}