GitLab

This logic can also be used for keyboards, mice, touchpads, and tablets.

TEST=chrome on link_freon & rush_ryu
BUG=437539

Review URL: https://codereview.chromium.org/791743004

Cr-Commit-Position: refs/heads/master@{#308082}

BUG=

Review URL: https://codereview.chromium.org/799893003

Cr-Commit-Position: refs/heads/master@{#308081}

This patch removes all uses of ShowDesktopNotificationHostMsgParams and replaces
it with a more directed PlatformNotificationData. The PlatformNotificationData
structure has the same content as the WebNotificationData structure in the Blink
API, and included are canonical conversion functions between the two.

The reason for this change is two-folded:
  (1) The content/ layer now has the ability to initialize Web Notification
      objects, whereas this previously could only be done by Blink. This means
      that we have to carry all associated data around.

      The primary user for this are Persistent Notifications, which can outlive
      the page they were created by (and thereby the JavaScript objects).

  (2) The Web Notification specification is being updated with new features, a
      number of which will eventually have to be known to the browser process.
      This makes future plumbing significantly clearer.

Also, the *Desktop*Notification.. name is outdated.

BUG=432527

Review URL: https://codereview.chromium.org/794633002

Cr-Commit-Position: refs/heads/master@{#308080}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/799753002

Cr-Commit-Position: refs/heads/master@{#308079}

This patch optimizes the way we do eviction at the tiling level.

Instead of using sort, it uses a reverse spiral iterator to iterate
tiles in reverse order of what they would have been rasterized in.

In addition to that, shared tiles are returned only by one tiling set
eviction queue. This way tiling set eviction queues can skip shared
tiles those priorities for tree priority are closer to those of unshared
tiles of the twin tiling. This lessen the number of out of reversed
priority order tiles returned by tiling set eviction queues (which
were previously handled by sorting). This will also allow eviction tile
priority queue not to check for shared tiles returned twice.

Review URL: https://codereview.chromium.org/736753002

Cr-Commit-Position: refs/heads/master@{#308078}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/757d75a..8e6fc6d

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/799873002

Cr-Commit-Position: refs/heads/master@{#308077}

BUG=382924
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/801753002

Cr-Commit-Position: refs/heads/master@{#308076}

Prompt for notifications if the Notification permission was not
previously granted.

Refactor a bit the browser tests to accomodate pages with
different manifests.

BUG=432930
TBR=fgorski

Review URL: https://codereview.chromium.org/785993003

Cr-Commit-Position: refs/heads/master@{#308075}

The reason for this separation is to distinguish the glue layer code
(which is shared amongst all of the WebView .apks) from the apk-specific
bits (which are not shared at all).

BUG=440792

Review URL: https://codereview.chromium.org/802453002

Cr-Commit-Position: refs/heads/master@{#308074}

According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html

aria-pressed {true, mixed} should set STATE_SYSTEM_PRESSED and false should
clear STATE_SYSTEM_PRESSED

This CL depends on https://codereview.chromium.org/767183002/

BUG=171625

Review URL: https://codereview.chromium.org/771583002

Cr-Commit-Position: refs/heads/master@{#308073}

Review URL: https://codereview.chromium.org/790803002

Cr-Commit-Position: refs/heads/master@{#308072}

The CL separates the X11 implementation into an independent file so
one may implement different versions for other platforms (e.g.,
ozone). To avoid compilation error, a stub ozone implementation is
also added.

Contributed by sheckylin@chromium.org

BUG=400022
TEST=link and link_freon ChromeOS build

Review URL: https://codereview.chromium.org/794943003

Cr-Commit-Position: refs/heads/master@{#308071}

TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/796963003

Cr-Commit-Position: refs/heads/master@{#308070}

Add a wrapper around libwebp to decompress WebP images and re-encode them
to uncompressed TIFF (if small enough) or JPEG/PNG (dependending on image
features).

BUG=436897

Review URL: https://codereview.chromium.org/771723002

Cr-Commit-Position: refs/heads/master@{#308069}

Revert of Use Surfaces on Windows, Linux, and Mac OS (second try) (patchset #1 id:1 of https://codereview.chromium.org/796693003/)

Reason for revert:
Speculative revert: virtual/slimmingpaint/fast/text/fallback-traits-fixup.html is crashing on Mac.

Example build: http://goo.gl/Ol8CHS

Flakiness dashboard: http://goo.gl/KGLmLS

Original issue's description:
> Use Surfaces on Windows, Linux, and Mac OS (second try)
>
> Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.
>
> BUG=334090
> TBR=piman@chromium.org
>
> Committed: https://crrev.com/8a61bd41b8a04bde04d7b538e3d9a42acd7c4ec7
> Cr-Commit-Position: refs/heads/master@{#308028}

TBR=piman@chromium.org,jbauman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=334090

Review URL: https://codereview.chromium.org/802683002

Cr-Commit-Position: refs/heads/master@{#308068}

Cr-Commit-Position: refs/heads/master@{#308067}

Revert of Isolate remaining tests under ui/ (patchset #21 id:400001 of https://codereview.chromium.org/724603004/)

Reason for revert:
Speculatively reverting due to chromium.win not triggered testers at all.

http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5439/
succeeded in triggering testers
http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5440/
didn't.

There was no build.git commit nor recipe change.

BUG=441690

Original issue's description:
> Isolate remaining tests under ui/
>
> BUG=98637
> R=maruel@chromium.org,jam@chromium.org
>
> Committed: https://crrev.com/4d293d79bd67b683942fd727c46f2b3173d7f03e
> Cr-Commit-Position: refs/heads/master@{#307954}

TBR=jam@chromium.org,phajdan.jr@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=98637

Review URL: https://codereview.chromium.org/802673002

Cr-Commit-Position: refs/heads/master@{#308066}

PFM serves potentially multiple frames by providing (auto)fill
information for each. That happens through drivers, which are
recently one per frame. The PFM only supports one driver so far.

This CL makes it handle a queue of drivers until it retrieves
the credentials from the store, and then serve each of the
associated frames through the drivers.

BUG=440438

Review URL: https://codereview.chromium.org/795183002

Cr-Commit-Position: refs/heads/master@{#308065}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a274a19..757d75a

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/801683003

Cr-Commit-Position: refs/heads/master@{#308064}

Note: https://codereview.chromium.org/754963009 removes the usage of
textTrackIndex() and has to be applied first.

BUG=440777
R=philipj@opera.com

Review URL: https://codereview.chromium.org/787343003

Cr-Commit-Position: refs/heads/master@{#308063}

Cr-Commit-Position: refs/heads/master@{#308062}

Revert of Updating OTS repo from https://github.com/khaledhosny/ots.git (patchset #4 id:60001 of https://codereview.chromium.org/775893002/)

Reason for revert:
Broke bots

Original issue's description:
> The original CL is https://codereview.chromium.org/658573004
>
> Updating with to new OTS repo from https://github.com/khaledhosny/ots.git
> Hash tag imported: c24a839b1c66c4de09e58fabaacb82bf3bd692a4
>
> Some important differences between new and old version of OTS:
> 1. Support for MATH table
> 2. Implementation changes related to new WOFF 2.0
> 3. Bug fixes related to OTF tables (GDEF, GSUB etc) parsing
> 4. Accept platform 0 encoding 1 cmap subtables
> 5. Allow fonts with CMAP format-12 or format-13 table
>
> A dummy version of EnableWOFF() is added to get Blink compiled.
> After the following CL is landed in Blink, it'll be removed.
> Blink CL: https://codereview.chromium.org/774253008
>
> # TODO(jschuh): 4267, 4334 are 64-bit cleanness issue. http://crbug.com/167187
>
> # TODO(h.joshi) : Make 4800 go away. <https://github.com/khaledhosny/ots/issues/44>.
> Currently patch to github (https://github.com/himanshuispresent/ots/commit/02f724f758ddb1cb264cc0259ffd5ef1cafa164a) is
> submitted so that taking OTS repository to Chromium should not cause issue on Windows bots.
>
> TEST: Blink layout tests: fast/css/font-face*
> BUG=339857
>
> Committed: https://crrev.com/3b6cd2d4bf9e0b4a9311343a2997ef9363530b14
> Cr-Commit-Position: refs/heads/master@{#308054}

TBR=jshin@chromium.org,behdad@chromium.org,h.joshi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=339857

Review URL: https://codereview.chromium.org/797183002

Cr-Commit-Position: refs/heads/master@{#308061}

Review URL: https://codereview.chromium.org/795853002

Cr-Commit-Position: refs/heads/master@{#308060}

In ServiceWorkerURLRequestJob::DidDispatchFetchEvent(), if response.stream_url of ServiceWorkerHostMsg_FetchEventFinished is set, ServiceWorkerURLRequestJob starts reading the body of the response from the stream instead of the blob.

But the stream may not be registered yet.
It is because ServiceWorkerHostMsg_FetchEventFinished is sent from the worker thread but StreamHostMsg_StartBuilding which triggers the stream registration is sent from the main thread of the ServiceWorker process.
So if ServiceWorkerURLRequestJob can't get the stream in DidDispatchFetchEvent(), call StreamRegistry::SetRegisterObserver() to receive the stream registration event.

When ServiceWorkerURLRequestJob successfuly gets the stream, it starts reading the stream.
The codes for reading the stream is almost same as the codes in StreamURLRequestJob.

This change depends on these changes:
  https://codereview.chromium.org/760823002
  https://codereview.chromium.org/759823003

BUG=436424

Review URL: https://codereview.chromium.org/759203002

Cr-Commit-Position: refs/heads/master@{#308059}

- key_silk_cases (disabled)
- sync_scroll.key_mobile_sites (enabled on Android)

Disabled/Enabled attributes are added referring Smoothness test.

BUG=438074

Review URL: https://codereview.chromium.org/791923002

Cr-Commit-Position: refs/heads/master@{#308058}

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "image_util.js"

Review URL: https://codereview.chromium.org/791363003

Cr-Commit-Position: refs/heads/master@{#308057}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c996f78..a274a19

TBR=rtoy@chromium.org,lushnikov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/799773002

Cr-Commit-Position: refs/heads/master@{#308056}

Cr-Commit-Position: refs/heads/master@{#308055}

Updating with to new OTS repo from https://github.com/khaledhosny/ots.git
Hash tag imported: c24a839b1c66c4de09e58fabaacb82bf3bd692a4

Some important differences between new and old version of OTS:
1. Support for MATH table
2. Implementation changes related to new WOFF 2.0
3. Bug fixes related to OTF tables (GDEF, GSUB etc) parsing
4. Accept platform 0 encoding 1 cmap subtables
5. Allow fonts with CMAP format-12 or format-13 table

A dummy version of EnableWOFF() is added to get Blink compiled.
After the following CL is landed in Blink, it'll be removed.
Blink CL: https://codereview.chromium.org/774253008

# TODO(jschuh): 4267, 4334 are 64-bit cleanness issue. http://crbug.com/167187

# TODO(h.joshi) : Make 4800 go away. <https://github.com/khaledhosny/ots/issues/44>.
Currently patch to github (https://github.com/himanshuispresent/ots/commit/02f724f758ddb1cb264cc0259ffd5ef1cafa164a) is
submitted so that taking OTS repository to Chromium should not cause issue on Windows bots.

TEST: Blink layout tests: fast/css/font-face*
BUG=339857

Review URL: https://codereview.chromium.org/775893002

Cr-Commit-Position: refs/heads/master@{#308054}

This CL converts AppSearchProvider to use base::Clock which allows for a
easier testing of AppSearchProvider. This CL also fixes an issue which
was revealed during this conversion and adds a test.

BUG=440286

Review URL: https://codereview.chromium.org/789623003

Cr-Commit-Position: refs/heads/master@{#308053}

This CL adds a new page set |key_hit_test_cases|, the reason to have a separate
set is that we only get meaningful data for |thread_times| and adding it to
|key_silk_cases| would clutter the smoothness numbers.

The main metric is |renderer_main_cpu_time_per_frame|, since the page doesn't
do any rendering, all the hit tests get counted under a single frame budget,
which can be used as a signal for the total cost.

BUG=426406

Review URL: https://codereview.chromium.org/789003002

Cr-Commit-Position: refs/heads/master@{#308052}

CONVERT(or HENKAN)/NONCONVERT(or MUHENKAN)/HANKAKU_ZENKAKU keys are
special keys in Japanese Keyboard.

This CL is necessary for supporting remote desktop client application in browser tab.
Note that, the accelerator for IME switching is now pass through to every
applications including web page inside tab but applications running inside tab
can not cancel the IME switching.

This is compatible with Windows's behavior.

BUG=438089
TEST=manually done

Review URL: https://codereview.chromium.org/784823002

Cr-Commit-Position: refs/heads/master@{#308051}

This will allow us to specify which binaries are built by
default by changing what is declared in a group("default")
target in src/BUILD.gn (this was added in r307770).

This rolls buildtools to 4995faa.

TBR=scottmg@chromium.org, brettw@chromium.org
BUG=430215

Review URL: https://codereview.chromium.org/801623002

Cr-Commit-Position: refs/heads/master@{#308050}

R=oshima@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/795423002

Cr-Commit-Position: refs/heads/master@{#308049}

This method is only used with the WebPluginDelegateProxy in the renderer, so only support it on a subclass that can be created by the ChildSharedBitmapManager. This will allow us more flexibility in how we implement SharedBitmaps in the future.

Review URL: https://codereview.chromium.org/802433003

Cr-Commit-Position: refs/heads/master@{#308048}

BUG=440600

Review URL: https://codereview.chromium.org/793573003

Cr-Commit-Position: refs/heads/master@{#308047}

Both the infobar and the infobar container were making use of various infobar
constants that were declared in components/ but (usually) defined in chrome/.
This was a symptom of having put code in the component that really probably
belonged in the embedder.

This CL hoists the relevant logic to a new cross-platform
InfoBarContainerDelegate class defined on the chrome side, which implements some
of the methods of InfoBarContainer::Delegate.  Platforms then subclass this to
implement the remaining, platform-specific bits.

This means that the constants in question now live solely in chrome/, avoiding a
bunch of link-time nastiness when trying to build the components code
separately.

BUG=382924
TEST=none
TBR=finnur

Review URL: https://codereview.chromium.org/793783003

Cr-Commit-Position: refs/heads/master@{#308046}

Background: In a subsequent CL we'll want to plug the scanner into the progress center (as a "task" I believe) so the user can see that there is some activity going on. This is one reason why we don't just gather up all the files in a single swoop, but do some acrobatics to handle each file individually.

* Update MediaScanner to be non-reusable (1 instance per scan).
* Add separate MediaScanner and ScanResult interfaces.
* MediaScanner now tracks scan duration (which will be reported in a subsequent UMA).
* MediaScanner now gathers local storage requirements so that cloud import can report insufficient storage to user...and prohibit import.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/795833002

Cr-Commit-Position: refs/heads/master@{#308045}

Fix a bug just introduced in https://crrev.com/bfea6ecef56cba8beb9816e8e9674a9dc456b20e.

BUG=438005

Review URL: https://codereview.chromium.org/788073003

Cr-Commit-Position: refs/heads/master@{#308044}

BUG=431868

Review URL: https://codereview.chromium.org/800613002

Cr-Commit-Position: refs/heads/master@{#308043}