- 27 Jan, 2020 40 commits
-
-
Alexander Timin authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1929033. Force reloads of error pages to always stay in the same browsing instance. The reason is the autoreload logic relies on the RenderFrame staying the same (see crbug.com/1045524). R=alexmos@chromium.org,nasko@chromium.org CC=mmenke@chromium.org BUG=1043888 Change-Id: Ifd3ee23325c88a82a9008b80784ea5b0c7976b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011924 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735564}
-
Eric Stevenson authored
Change-Id: I9d08a918fac32be8f1abce43f1896fe45fb42b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022617Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: (gone) Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#735563}
-
Joe Downing authored
TBR: tbergquist@chromium.org Bug: 1031801 Change-Id: I56cb5803628e2d25527eec047d03779b2e631028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023193Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735562}
-
Xinghui Lu authored
Database manager will listen to profile destroyed events, and reset rt_lookup_service. This is to make sure that all profile related operations are safe in rt_lookup_service. Bug: 1041912 Change-Id: I80702dacc7cb420854ae5b6423170f63d2ccedcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010017Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735561}
-
Evan Stade authored
This re-lands commit 019a8580 minus the changes to WebLayer shell, which triggered performance regressions for as-yet-undetermined reasons. (See bug 1045609) Original change's description: > WebLayer: add FindInPage API > > New methods are added to Tab: > - beginFindInPage > - activateNextFindInPageMatch > - endFindInPage > > And a new FindInPageCallback interface is introduced with one method: > - onFindResult > > Also add very basic FIP controls to shell to partially exercise the > new API. > > Notes: > 1. The embedder provides the main find in page UI (the text input). > 2. The embedder is responsible for ending the find session as > appropriate (i.e. when the main find in page UI is dismissed), > which cleans up the in-page UI, consisting of a results sidebar and > text highlighting. Commonly this would happen if the user cancels the > find session or if a navigation occurs. > 3. When the active tab loses focus, the find session is ended and the > result bar is removed. > 4. It is generally expected that the embedder-provided find in page UI > will be hosted in the top view. > > TODO: > 1. The top controls should be forced visible when the new web contents > overlay view holds children. That will definitely be desired for > tab modal dialogs, and is probably desired for find in page as well > (at least judging by what Clank does). > 2. Write tests. > > Bug: 1038415 > Change-Id: I6183172dc3944157aae2db5ebb0aed983a34bffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004072 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734691} Bug: 1038415 Change-Id: Ib23d1e8fcb7461fa23942030362408567b57d761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023266Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#735560}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d26ee85fba6d..f329c78b6cb0 git log d26ee85fba6d..f329c78b6cb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 rharrison@chromium.org Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@f329c78b6cb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8328e4d83feafd05326423a4a18c9a760e877b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735559}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I3ecbd89e19813551cc08fc9de8a88296abe1c954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023270Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735558}
-
Tricia Crichton authored
When setting fullscreen window, do not make the call to setWindowBounds. Including both calls has caused occasional DevTools disconnects. Bug: 946023 Change-Id: Icfc934fa6f1654e7a5bd42de205d316f7acabc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020882Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#735557}
-
Ahmed Mehfooz authored
Bug: 960116 Change-Id: I47ded12435e0b1c842eaf3aa2e5b506ca21486e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018445Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735556}
-
François Doray authored
This reverts commit 5b6e70af. Reason for revert: https://crbug.com/1046092 - This rebaseline causes failures on MacOS 10.13 bots. Original change's description: > Rebaseline part of web tests for MacOS 10.14 > > Rebaseline of web tests in custom-elements, editing, and fast directories. > > Bug: 1028242 > Change-Id: Idab238ce374bb3fa01bdc0ac8535f74afe090ac1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022351 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Auto-Submit: John Chen <johnchen@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735450} TBR=wangxianzhu@chromium.org,johnchen@chromium.org Change-Id: I2114b5392395fa01ce5e862dd8cf7108f995533e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028242, 1046092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023274Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735555}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8d07951..5461451d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2afe0ae8f6ac3d8bb3cbda9ed9be3c684785b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023368Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735554}
-
Avi Drissman authored
BUG=1044828 Change-Id: I7ce05c32bb0731a94ae65309a1ca2f625d2390ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015410Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735553}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/60a3d848a8ca..a1f1cce6054f git log 60a3d848a8ca..a1f1cce6054f --date=short --first-parent --format='%ad %ae %s' 2020-01-27 syoussefi@chromium.org Vulkan: updateActiveImages: process each image once Created with: gclient setdep -r src/third_party/angle@a1f1cce6054f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I9458b2d945d7049e3d410d1959f798df796ce27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023426Reviewed-by:
-
Alexander Timin authored
At the moment enabled bfcache fully enables proactive swap of browsing instances. Change this to swap browsing instances only when required by the bfcache experiment settings. R=alexmos@chromium.org,arthursonzogni@chromium.org BUG=1046061 Change-Id: If3793853e8cbd8eefb02b2064d80ebe25aeaae8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023688 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
evliu authored
This CL removes the feature flag and the caption settings feature. The feature has been launched and enabled by default for multiple releases. Bug: 1043314 Change-Id: If8406e8bab4ef5bf47ef109daec66e513a3b499b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007979Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#735550}
-
Henrique Nakashima authored
It acts exactly like FeatureUtilities, but will be what downstream classes will reference while FeatureUtilities is renamed. This is CL 1/5 for renaming FeatureUtilities. Bug: 1012975 Change-Id: I36c073497e7ccb98742a50c2ab5770179ccef5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023668Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735549}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e4f440fdeb6..17a6381c1c98 git log 2e4f440fdeb6..17a6381c1c98 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 srte@webrtc.org Adds fake video codec mode to PeerScenarioClient Created with: gclient setdep -r src/third_party/webrtc@17a6381c1c98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifbe94d709654e63e93ab64a12833af97a76a19b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023176Reviewed-by:
-
Avi Drissman authored
https://chromium.googlesource.com/openscreen/+log/9fe51a969757..3debb43d7a51 $ git log 9fe51a969..3debb43d7 --date=short --no-merges --format='%ad %ae %s' 2020-01-23 avi Remove a file only needed with an old Mac SDK. 2020-01-22 miu Minor UdpPacket constructors clean-up. 2020-01-22 jophba Add FFMPEG+SDL sysroot image 2020-01-16 jophba Move to using separate Open Screen pantheon bucket 2020-01-22 jophba Issue 102: Make Chromium trybots non-optional 2020-01-17 rwkeane mDNS: Probe Implementation Created with: roll-dep src/third_party/openscreen/src Change-Id: I8f1e2cd91697287e3dd8ccfd61bda4aca9360f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017915Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735547}
-
Sasha McIntosh authored
Additionally disable YUV decoding when ImageBitmap::GetSkImageFromDecoder is called, as the bitmap is soon after requesed from the SkImage. Bug: 1041307 Change-Id: I0cdbfd4188d4c44453bab8ea49b199d32235ef07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998973Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735546}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Ic93b8cd2d93d8cae9d60ca7898436b4cd552c85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015600Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735545}
-
Elly Fong-Jones authored
The override just restated the default, so take it out altogether. Bug: 1011446 Change-Id: Iee89b0619d9e3c50f43e4c8ab6437d0f31a7f138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015666Reviewed-by:
-
Luke Sorenson authored
Bug: 1046075 Test: Not necessary. Change-Id: I290bba5e491dcf36fe22b2cc72c6f7eb989c843f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023272Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#735543}
-
Roman Sorokin authored
Bug: 1045311 Change-Id: I14518db877a9482bf3b5a37a34320c705e8b92fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020959Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735542}
-
Miguel Casas authored
crrev.com/c/1863153 introduced a regression when it started looking at the kWebRtcHWH264Encoding flag, which was enabled by default. This was caused by the convoluted logic around h264 sw/hw encoding support. This CL removes that check entirely since the flag was fully enabled anyway [1] so the original check: if (webrtc_h264_sw_enabled || base::FeatureList::IsEnabled(blink::features::kWebRtcHWH264Encoding)) was always true (bc of the second member). This CL thus removes all the code related to that flag, allowing for h264 to be accepted even if there's no sw fallback, hence restoring the original behaviour pre-deprecation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1863153/4/third_party/blink/common/features.cc Bug: webrtc:11244 Change-Id: Id9132181fdca08ede12e22a1cc66590f1062269d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022929 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#735541}
-
David Trainor authored
This patch removes download home dependencies from the DownloadGlue class and the DownloadManagerUiConfig class. - For DownloadGlue, a LegacyDownloadProvider interface is exposed and passed through. This allows the implementation to still live publicly until we can remove the whole chain. - For DownloadManagerUiConfig, pull out the component that reads from ChromeFeatureList and move it to a helper class to build the config from feature flags. Bug: 1025395 Change-Id: I8c36f2dcab192ff3f93aeb0ee2a99c01b568af5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919909 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735540}
-
Francois Doray authored
TBR=pbos@chromium.org Bug: 1046046 Change-Id: Ica565cd15a95ae03053bd6665b82c801da22eda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023294Reviewed-by:
-
Connie Wan authored
Bug: 1043290 Change-Id: I74c497c43f6a34cb2b7c570aeaed42573ada35ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016402 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735538}
-
Justin Gallagher authored
Adds support for moving multiple tabs to a new window from the tab context menu. Also correctly handles pinned tabs, preserving their pinned state in the new window. Since multiple tabs now can be moved, the string was changed to pluralize "tab" to "tabs" when necessary. Bug: 1036002 Change-Id: I3da4b5cd527a35134d5b0dbc7d64e01817078251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020525 Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#735537}
-
dalyk authored
We will continue to run our secure DNS auto-upgrade experiment past M81, so the ability to opt-out via chrome://flags is still needed. Bug: 985589 Change-Id: I82f38a153815817a2dccfec2c697be56678ff88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023286Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#735536}
-
Brett Kilty authored
https://chromium-review.googlesource.com/c/chromium/src/+/1949007 introduced a 100% crash on Android with GPU disabled. No fallback_modes_ are pushed and new code was added to SIGKILL the process in this case. Bug: b/147243153 (internal) Test: Local before/after device test Change-Id: I0788d9562378b5b729a40f4e71db9c3993c6885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018245Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Auto-Submit: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#735535}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4b06e05517f12b1155884da3bfa50165162adc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023227Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#735534}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d93fde1cd5a5..3906f655f40c git log d93fde1cd5a5..3906f655f40c --date=short --first-parent --format='%ad %ae %s' 2020-01-27 bsheedy@chromium.org Capture screenshot in CollectDebugData Created with: gclient setdep -r src/third_party/catapult@3906f655f40c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:369490 Tbr: oysteine@google.com Change-Id: I663727d248aa2659fe2d0f1a66c083bcc3164a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023430Reviewed-by:
-
Karan Bhatia authored
Instead of using RE2::Extract, use RE2::Replace. This is preferred because: - This is the more common variant of substitutions. E.g. Javascript replace also does this. - With this change, it would be easier to add global replace later if need be by adding a single key to the Redirect dictionary. BUG=974391 Change-Id: Id1b3bf2fe9d21b3aa75e5215b1abaa6450d70979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021164 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735532}
-
Taylor Bergquist authored
Bug: 1043376 Change-Id: I66f0b8e85dcfa0b1d7bd8bf5b2728993edc156f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017665Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#735531}
-
kylechar authored
Windows SkiaRenderer was crashing on resize while tab casting. Display::DisableSwapUntilResize() was setting size of 0x0. This stopped the display from calling SwapBuffers() and usually stopped it from drawing. However, if there were CopyOutputRequests then the display would still draw and SkiaOutputSurfaceImpl::Reshape() would be called with 0x0 size. This CL changes Display::DrawAndSwap() to always skip drawing after when DisableSwapUntilResize() is called. This will probably make casting a bit jankier while resizing, since we'll drop CopyOutputRequests, but would make resize smoother since we're doing less work. Bug: 1042007 Change-Id: I2d543a1d0fe58e974e706dd24efd5c5fd0b5c64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011130 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#735530}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28a9b122f5a5..f68213fc4db3 git log 28a9b122f5a5..f68213fc4db3 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 mtklein@google.com draw whole grid 2020-01-27 fmalita@chromium.org [skottie] Cleanup: convert transform adapters to new pattern 2020-01-27 mtklein@google.com rm mtklein@chromium 2020-01-27 bsalomon@google.com Revert "Switch runtime SkSL to always sample at explicit coords" Created with: gclient setdep -r src/third_party/skia@f68213fc4db3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I8d9eac778e230ed8595651b91226526566dd42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023429Reviewed-by:
-
Takashi Toyoshima authored
Since CrComponentsCertificateManagerV3Test.All test depends on OOR-CORS as some other WebUI tests do, we need to flip the OOR-CORS to be enabled explicitly to run the test. Bug: 1045853 Change-Id: I280af083f8660e19242dd404cba3e14855ff6c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022125 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8fdda11ff772..f5d825ac1bb6 git log 8fdda11ff772..f5d825ac1bb6 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 pfaffe@chromium.org Add a new scope chain view for showing wasm variables. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f5d825ac1bb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia54726f1ad4562cb464f44ef054340097cf91db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022968Reviewed-by:
-
Kristi Park authored
Show the initial "Send" animation once per profile instead of once per window. Bug: 1013258 Change-Id: I2a041e597d51a1acdd3a0fdd156627c34935390f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020535Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735526}
-
Henrique Nakashima authored
This will be used in at least two places: OmniboxSuggestion and CtrSuppression. Bug: 1022108 Change-Id: I627aae9bd0bc3c9f260371b2a4ac0ecf5f3dc992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019940Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735525}
-
