- 03 Oct, 2018 40 commits
-
-
Fredrik Söderquist authored
Hoist call to ResolveTargetElement() out of HasCycleUseReferencing(), leaving the latter only checking for cycles. Drop the InUseShadowTree() check from BuildShadowAndInstanceTree since its single caller checks it already. Use ToSVGElementOrNull to simplify the code a bit. Bug: 397525 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idb6cbd9e155d6217db77ef97299e77fa57cd0d8d Reviewed-on: https://chromium-review.googlesource.com/c/1257918Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596202}
-
Aldo Culquicondor authored
Bug: 891495 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6b4aa77dc0c81b79afe681c31ed2b4a06f19dc37 Reviewed-on: https://chromium-review.googlesource.com/c/1257816Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596201}
-
Fabio Tirelo authored
This was requested during UI review for the feature that split the Autofill Settings page into Profiles and Payment methods, so that they will be consistent with the user menu. Screenshots can be found in the bug. Bug: 891454 Change-Id: I2a436d08d2e6bbb9c1f4730cbf43351100006bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1258050Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596200}
-
Eric Seckler authored
The linux jumbo bot is flaking on content nocompile tests due to the nocompilation tests timing out. This patch increases the timeout to twice what it was before. Bug: 882852 Change-Id: Ib2bc0023acd8d677ea77eb2769a5f83da39ed0da Reviewed-on: https://chromium-review.googlesource.com/c/1248601Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#596199}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e44e847c70ac..416018d455bf git log e44e847c70ac..416018d455bf --date=short --no-merges --format='%ad %ae %s' 2018-10-03 kthelgason@webrtc.org Remove deprecated protocol alias RTCEAGLVideoViewRenderer. 2018-10-03 kwiberg@webrtc.org audio_coding_module_unittest: Don't rely on the ACM to create encoders Created with: gclient setdep -r src/third_party/webrtc@416018d455bf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I20c0b24ec78710eadb94a950dfcea4eedd255b84 Reviewed-on: https://chromium-review.googlesource.com/c/1258869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596198}
-
Stephane Zermatten authored
Before this patch, the script executor checked element existence in parallel and the script tracker checked script preconditions in parallel. This doesn't work: element existence checks only work when run one at a time. This meant that precondition on elements were never met, because there were always multiple scripts to check, while WaitForDomProto worked, as it's typically running a check on a single element. With this patch, checking for elements from preconditions works, even when there are more than one script or elements to check. Bug: 806868 Change-Id: Ib5e97a36a7aff5df5eab183da9461375df4f1ec3 Reviewed-on: https://chromium-review.googlesource.com/c/1256794Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596197}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b627af80e3a4..5b2bc879189c git log b627af80e3a4..5b2bc879189c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@5b2bc879189c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Id71ceca29b2521f923bc49c32a66706e1a98fbcb Reviewed-on: https://chromium-review.googlesource.com/c/1258870Reviewed-by:
-
Bence Béky authored
This CL lands the third_party/spdy portion of server change 211551817 by bnc. BUG=488484 Change-Id: I7090d3fcc9ec885114ff5674fd0bba531258130c Reviewed-on: https://chromium-review.googlesource.com/c/1252086 Commit-Queue: Yang Song <yasong@chromium.org> Reviewed-by:
Yang Song <yasong@chromium.org> Cr-Commit-Position: refs/heads/master@{#596195}
-
Hiroki Nakagawa authored
For evolution of worklet thread management there're some dead or duplicate functions in worklet codebase. This CL removes them for cleanup. Bug: n/a Change-Id: I744146854e7f1cbcbb1a48cc60bac6cae34cad35 Reviewed-on: https://chromium-review.googlesource.com/c/1257475Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596194}
-
Sylvain Defresne authored
The script was incorrect as no args.root_dir was defined, thus causing the script to fail if invoked directly (went unnoticed as the code is usually loaded as a python module). Also fix some minor style issues. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia92f2596d1cb30e7bbd6de3aa8f0911a70c97205 Reviewed-on: https://chromium-review.googlesource.com/c/1255732Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596193}
-
Fredrik Söderquist authored
This can save a conversion to UTF-8 (and copy to CString) for ASCII-only URLs. Bug: 889183 Change-Id: Ie5edad4a95da70bac0acd27b01d6e03cd1315bbd Reviewed-on: https://chromium-review.googlesource.com/c/1257926 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/extensions/api/mdns. This CL was uploaded by git cl split. TBR=vitalybuka@chromium.org Bug: 809610 Change-Id: I8796684bd7f2948bcf7463a804698aa148a2cfcb Reviewed-on: https://chromium-review.googlesource.com/c/1246171Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596191}
-
Nico Weber authored
We ship this code, it should have a test. It almost still builds, and it still passes, so there's no reason to keep it disabled. Bug: 845389 Change-Id: I15066058d3189276edade9f6f4448add94ba2814 Reviewed-on: https://chromium-review.googlesource.com/c/1255983Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596190}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82dac3df06b9..cd9050823b91 git log 82dac3df06b9..cd9050823b91 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 fmayer@google.com Merge "profiling: Add ClientConfiguration for sampling rate." Created with: gclient setdep -r src/third_party/perfetto@cd9050823b91 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I21ac3efea583a9df835cb5d89ba46ad2c92a2d52 Reviewed-on: https://chromium-review.googlesource.com/c/1258867Reviewed-by:
-
Greg Thompson authored
BUG=none R=pastarmovj@chromium.org Change-Id: If47183f4d79d9aa1a91f193d8bebc123c260eafb Reviewed-on: https://chromium-review.googlesource.com/c/1233495 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596188}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be8193c9313a..b627af80e3a4 git log be8193c9313a..b627af80e3a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 borenet@google.com [infra] Try another workaround for go_deps asset creation Created with: gclient setdep -r src/third_party/skia@b627af80e3a4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I14eebb488107e526c01bff25e0e057affdf42268 Reviewed-on: https://chromium-review.googlesource.com/c/1258868Reviewed-by:
-
Fergal Daly authored
This reverts commit 6592bd30. Reason for revert: OK checking owners took a long time: 1813ms Traceback (most recent call last): File "/home/bratell/src/google/depot_tools/metrics.py", line 225, in print_notice_and_exit yield File "/home/bratell/src/google/depot_tools/git_cl.py", line 6110, in <module> sys.exit(main(sys.argv[1:])) File "/home/bratell/src/google/depot_tools/git_cl.py", line 6092, in main return dispatcher.execute(OptionParser(), argv) File "/home/bratell/src/google/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/home/bratell/src/google/depot_tools/git_cl.py", line 5086, in CMDupload return cl.CMDUpload(options, args, orig_args) File "/home/bratell/src/google/depot_tools/git_cl.py", line 1551, in CMDUpload change=change, parallel=options.parallel) File "/home/bratell/src/google/depot_tools/git_cl.py", line 1485, in RunHook parallel=parallel) File "/home/bratell/src/google/depot_tools/presubmit_support.py", line 1547, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File "/home/bratell/src/google/depot_tools/presubmit_support.py", line 1454, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "<string>", line 182, in CheckChangeOnUpload File "<string>", line 164, in _CheckForForbiddenChromiumCode File "tools/audit_non_blink_usage.py", line 604, in check if not _check_entries_for_identifier(entries, identifier): File "tools/audit_non_blink_usage.py", line 548, in _check_entries_for_identifier if entry['disallowed'].match(identifier): AttributeError: 'list' object has no attribute 'match' Original change's description: > Add the ability to give advice on forbidden identifiers. > > Add addvice for base::Bind* > > Currently we are told not to use something, but it's not always clear what > we should use instead. This allows adding advice for the correct alternative > to the forbidden identifies. > > Change-Id: Iaadab609452d2413fdd39a31c80e3924467c42d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1253526 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596178} TBR=tkent@chromium.org,tzik@chromium.org,fergal@chromium.org Change-Id: I16684eee34a7e547cb6d923f38ee669e13394223 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1258812Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596186}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/favicon. This CL was uploaded by git cl split. R=caitkp@chromium.org Bug: 809610 Change-Id: I050d6189e8eb2f2f80a6670ab3649218fabcd1ae Reviewed-on: https://chromium-review.googlesource.com/c/1246170Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596185}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/23eba224241c..e44e847c70ac git log 23eba224241c..e44e847c70ac --date=short --no-merges --format='%ad %ae %s' 2018-10-03 buildbot@webrtc.org Roll chromium_revision 601c715f..14de2307 (596047:596155) 2018-10-03 nisse@webrtc.org Delete pre_decode_image_callback 2018-10-03 ssilkin@webrtc.org Add number of freezes per minute metric. 2018-10-03 saza@webrtc.org Reland "Remove APM-internal usage of EchoControlMobile" Created with: gclient setdep -r src/third_party/webrtc@e44e847c70ac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib17b9714246a56e84c066613cd4ecb48f9e017cf Reviewed-on: https://chromium-review.googlesource.com/c/1258866Reviewed-by:
-
Noel Gordon authored
Untrusted content (HTML here) is rendered in Quick View in a <webview> element. Its parent <file-safe-media> sets the background color of the rendered HTML and that color must be solid white. Test that. Bug: 891150 Change-Id: I10975df3e862b4d8746c97adc43aaf18b248dd4b Reviewed-on: https://chromium-review.googlesource.com/c/1258670Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596183}
-
Findit authored
This reverts commit 051435e2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596148 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDUxNDM1ZTI3MTBiNzk1OGI5ZmE0YTI1NjgyZGEzYTFmOTNiMTI5MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3840 Sample Failed Step: network_service_browser_tests on Ubuntu-16.04 Sample Flaky Test: StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup Original change's description: > The session restore logic is improved. > > The session restore logic looked at the command line of the main browser > process, which resulted in session loss if the browser is first launched > as incognito and then another window is opened with some normal profile. > > This change introduces passing the command line of the new process to > the session restore point so it decides whether to restore the session > according to settings and command line both relevant to the profile that > is to be loaded. > > R=sky@chromium.org > > Change-Id: I69de884b4d270da4d4cc358fe225255b3d4cb3b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1245368 > Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596148} Change-Id: I543e0412a0960c0a540d8c1dd6dd870dbdc62fa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891660 Reviewed-on: https://chromium-review.googlesource.com/c/1258387 Cr-Commit-Position: refs/heads/master@{#596182}
-
Sam McNally authored
This is a reland of 0780e76b. The tests in folder_shortcuts.js are flaky with DriveFS, so continue to not run them as before. Original change's description: > Run more FilesApp tests with DriveFS enabled. > > Run with DriveFS enabled: > - Drive-related context_menu.js tests. > - Drive-related metadata.js tests. > - folder_shortcuts.js tests. > - fileDisplayDrive in tablet mode with DriveFS enabled. > > In order to make those tests pass: > - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return > it in GetMetadata(). > - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching > metadata, trying to get a value for it. > - Remove two unused and incomplete tests in context_menu.js. > - Only perform early-init for the downloads volume for the "user" > profile. > > Bug: 891197 > Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1255086 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596048} Bug: 891197 Tbr: noel@chromium.org Change-Id: Ib85e05c0d940f5a748ef5207b3ff4c3d4e0e7df6 Reviewed-on: https://chromium-review.googlesource.com/c/1257474Reviewed-by:
-
Harald Alvestrand authored
Moved the scheduling of subsequent tones from the webrtc layer to the blink layer. Revised the tests to remove the chance to sneak in extra tonechange events when overriding a remaining tone buffer. Also change "approximate timing" to "at least this long". Bug: chromium:816475 Change-Id: Id91011600b61f43152c8fb896d72433ccb871c61 Reviewed-on: https://chromium-review.googlesource.com/c/1236337 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596180}
-
Daniel Bratell authored
According to the coding style guide a sub-namespace should not have the same name as a common top level namespace. That still happens with many "features" namespaces which causes problems whenever the compiler knows about the root ::features namespace. This patch removes the namespace completely and lets the constants live in the safe_browsing namespace directly, making the code a little shorter. Another option would have been to rename the namespace from ::safe_browsing::features to ::safe_browsing_features like was recently done to some other features namespaces, for instance app_list_features. Change-Id: I3655cca7fb56b45a03118a80a957599bd5f316b3 Reviewed-on: https://chromium-review.googlesource.com/c/1251604 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596179}
-
Fergal Daly authored
Add addvice for base::Bind* Currently we are told not to use something, but it's not always clear what we should use instead. This allows adding advice for the correct alternative to the forbidden identifies. Change-Id: Iaadab609452d2413fdd39a31c80e3924467c42d3 Reviewed-on: https://chromium-review.googlesource.com/c/1253526Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/531ee1a13814..1f6d20f5c09f Created with: gclient setdep -r src-internal@1f6d20f5c09f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1b8bf33cb48418d1f328e7fe5857f6f18134c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1258865Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596177}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2cbceb0be548..82dac3df06b9 git log 2cbceb0be548..82dac3df06b9 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 lalitm@google.com Merge "trace_processor: optimize filtering for sched slice and generify" 2018-10-03 fmayer@google.com Re-enable {a|l}san 2018-10-03 primiano@google.com Merge "UI: set ALLOW_MEMORY_GROWTH=1" 2018-10-03 hjd@google.com Merge "perfetto-ui: Fix font bug with ChromeSlices" 2018-10-03 hjd@google.com Merge "perfetto-ui: Add dynamic CPU track" Created with: gclient setdep -r src/third_party/perfetto@82dac3df06b9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I309c2caf3d251f920fa48bc1506c57f0b84d7718 Reviewed-on: https://chromium-review.googlesource.com/c/1258421Reviewed-by:
-
Leszek Swirski authored
Measure the impact of the current trial by seeing what regressed, and disable while waiting for Bug:874080 to be resolved, since there are currently some loading regressions. Bug: 715309 Bug: 885053 Bug: 886668 Change-Id: I4497e11373ffa92d3e5f5844fa9fbe73fef6bf4b Reviewed-on: https://chromium-review.googlesource.com/c/1255946Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#596175}
-
Maksim Sisov authored
Relying on OzoneDrmMojo feature is not a very good idea, because it is mostly intended to be used with the Ozone/Drm platform, which can use both the legacy IPC and mojo for communication. It happened once that the Ozone/Wayland platform regressed due to misunderstandings why that feature flag was used with ifdefs. In Ozone/Wayland, the mojo IPC is a requirement to be able to run the browser in a multi-process mode(there is a separate GPU process). Thus, use PlatformProperties to know if the platform requires mojo communication before the gpu is started. At the moment, only Ozone/Wayland platform requires mojo communication in addition to the Ozone/Drm platform, which can use both legacy IPC and mojo and uses OzoneDrmMojo feature instead. Bug: 578890 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1f0fccb19ec2fc69a50320b55014979556739c2c Reviewed-on: https://chromium-review.googlesource.com/c/1254209 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#596174}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/086cac5c439c..23eba224241c git log 086cac5c439c..23eba224241c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 asapersson@webrtc.org Add support for RtpEncodingParameters num_temporal_layers. Created with: gclient setdep -r src/third_party/webrtc@23eba224241c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I05e54c3bb49127605c383e3f78b515d15f64c04f Reviewed-on: https://chromium-review.googlesource.com/c/1258864Reviewed-by:
-
Findit authored
This reverts commit 0780e76b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596048 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDc4MGU3NmIwMzg4MmQ5MmVjOGI5YjczNDIyNzgzMzA5YzZjZWM1Nww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29332 Sample Failed Step: viz_browser_tests Sample Flaky Test: FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs Original change's description: > Run more FilesApp tests with DriveFS enabled. > > Run with DriveFS enabled: > - Drive-related context_menu.js tests. > - Drive-related metadata.js tests. > - folder_shortcuts.js tests. > - fileDisplayDrive in tablet mode with DriveFS enabled. > > In order to make those tests pass: > - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return > it in GetMetadata(). > - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching > metadata, trying to get a value for it. > - Remove two unused and incomplete tests in context_menu.js. > - Only perform early-init for the downloads volume for the "user" > profile. > > Bug: 891197 > Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1255086 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596048} Change-Id: I918211f80347a93388965b5278c2e3b55d4bfca5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891197, 891641 Reviewed-on: https://chromium-review.googlesource.com/c/1258616 Cr-Commit-Position: refs/heads/master@{#596172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b969b6f368a..531ee1a13814 Created with: gclient setdep -r src-internal@531ee1a13814 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I255c96cdb45da204876fc32de0dc06603b5ef01a Reviewed-on: https://chromium-review.googlesource.com/c/1258862Reviewed-by:
-
Guido Urdaneta authored
The default input device reported by Pulse Audio is not really a default device, but a fallback device. Actual expected default behavior in Pulse Audio is achieved by not specifying a device to use and letting Pulse Audio select it. In this case Pulse first tries to use the device specified by the PULSE_SOURCE environment variable and, if that fails, tries to use the fallback device. There is no API to fetch what device Pulse will actually use by default. A consequence of this is that the groupId reported by the default input device will not correspond to the group ID of the actual device that will be used. This is not ideal, but it is better than the alternative. The groupId constrainable property still works fine with nondefault devices. Bug: 890010 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3473df314f0a36f56094c4986bf8fc9b38265fad Reviewed-on: https://chromium-review.googlesource.com/c/1256832Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#596170}
-
Olivier Robin authored
Sets are never cleared in VariationsHttpHeaderProvider. This means that if VariationsHttpHeaderProvider id initialized in a test with a GoogleVariationID, the trial will be added to variation_ids_set_ and never be removed even by ResetForTesting. This make all tests relying on not having X-Client-Header after this fail. E.g. on iOS, TranslateScriptTest.CheckScriptParameters fails if it runs after PaymentClientTest. Bug: None Change-Id: I3287f3df846ab1b0f56e42980146b07a3707f7d4 Reviewed-on: https://chromium-review.googlesource.com/c/1256803 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596169}
-
Daniel Bratell authored
It was linked into some jumbo build experiments where it triggered link errors. If you include an object file, for instance options_menu_model.o, in an archive, for instance libtranslate.a, and nothing references that object file, then the linker won't care if options_menu_model.o is referencing all kinds of undefined symbols. It's a feature or quirk depending on who you asks. With jumbo compilation this options_menu_model.o would be combined with 7+ other .o files into translate_jumbo_1.o and since the .o file is no longer completely unused, the linker will get upset about the dangling references. So something that used to be "just" dead code compilation with dangling references becomes a linking error when compiling with jumbo. Change-Id: Id15f7e15804efe2fdf959c4db7fdade061477102 Reviewed-on: https://chromium-review.googlesource.com/c/1256685 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#596168}
-
Yutaka Hirano authored
With OOR-CORS, CORS logic is moved out of blink. This is problematic for the memory cache in blink, because the relationship between caching and CORS is different from what is specced. Ignore headers added by blink-initiated revalidation. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I64346ee908cd4b3ab5b6cd8442dfaa8f8d7a2368 Reviewed-on: https://chromium-review.googlesource.com/c/1244998 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The client is getting OnStartLoadingResponseBody before OnResponseReceived. See if ThrottlingURLLoader is buggy. Bug: 882661 Change-Id: I3de4e907d502c8140c1a0736468868775c43d691 Reviewed-on: https://chromium-review.googlesource.com/c/1256382Reviewed-by:
-
Hajime Hoshi authored
The default task runner should be avoided if possible. Bug: 870606 Change-Id: Id4a3a5cc11d7a101b9f80fc339142f43ad41e9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1256473Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596165}
-
Yuta Kitamura authored
Now, (almost) nobody uses blink::WebThread in non-Blink code. This CL removes unused #include of web_thread.h in those files. Note that two files related to testing were still using WebThread indirectly. They call Platform()->MainThread()->GetTaskRunner() to obtain a task runner. These calls were replaced with scheduler:: GetSingleThreadTaskRunnerForTesting(). Bug: 826203 Change-Id: I954eb67e99f76bd992f0bcdd73498cfdccba0726 Reviewed-on: https://chromium-review.googlesource.com/c/1255747 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596164}
-
Takashi Toyoshima authored
Now that the dynamic instantiation mode is the only mode that MidiService and MidiManager support, we can ensure that any MidiManager instance will be constructed and destructed on the same IO thread. This will allow us to remove complicated shutdown system that relies on Shutdown() and Finalize(). Now destructor should just work. Bug: 672793 Change-Id: I50cc843dd997f9de68492c13d7d845810020dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1249421 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596163}
-
