GitLab

This reverts commit 0f06f8fd.

Reason for revert: CIPD doesn't allow multiple .ensure files to coexist, crbug.com/789809

Original change's description:
> Fuchsia: use CIPD to check out arch-specific QEMU binaries.
> 
> These binaries allow us to run QEMU on ARM; the current deployment
> in the Fuchsia SDK folder is x86-64 only.
> 
> The "qemu" folder can safely be removed from the Fuchsia SDK
> once this CL lands and the trybots are confirmed to still be in
> working order.
> 
> Also modify the runner script to use arch-specific QEMU binaries.
> 
> 
> Bug: 786193
> Change-Id: I1515bdf330f496ff47f88ba3b131629d4e24fea3
> Reviewed-on: https://chromium-review.googlesource.com/783699
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519536}

TBR=dpranke@chromium.org,kmarshall@chromium.org,scottmg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 786193
Change-Id: I320cf80f222c337b38e91e0f10ef2a3479f45f9d
Reviewed-on: https://chromium-review.googlesource.com/810088
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521990}

VolumeReaderJavaScriptStream::Seek() doesn't return error even when the
file is not readable. Also the error in Read() was not handled before.
This was causing infinite loop when the archive became inaccessible,
such as when the archive was deleted by the user.
This change adds error handling on Read().

Bug: 791924
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2774e53ed25eea50e6abe62ec7c52f4237c24c25
Reviewed-on: https://chromium-review.googlesource.com/808524
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521989}

BUG=690825

Change-Id: I6c4d4bc7dfe074d5a7b1a63a1ce527bc074ca506
Reviewed-on: https://chromium-review.googlesource.com/809647Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521988}

Bug: 754889
Change-Id: Iabbd43da20b9e1bf8f318b78b141b75f62dd62fd
Reviewed-on: https://chromium-review.googlesource.com/804827
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521987}

This reverts commit 134ea9de.

Reason for revert: Broke WinMSVC64 (dbg) Build:
https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/740

Original change's description:
> Ribbonize ComputedStyleCSSValueMapping colors
> 
> This CL also changes the behavior for ColumnRuleColor.
> It used to call VisitedDependentColor(CSSPropertyOutlineColor),
> but that seemed wrong so I changed it to use
> VisitedDependentColor(CSSPropertyColumnRuleColor).
> 
> There will be more CLs immediately following to finish Ribbonizing
> this class. Please ping me for a link to the design doc.
> 
> Bug: 775360
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2b204146eafdd1fd7a74d8a9b8c8bb707d5f3eea
> Reviewed-on: https://chromium-review.googlesource.com/781442
> Reviewed-by: Darren Shen <shend@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521980}

TBR=aboxhall@chromium.org,haraken@chromium.org,rjwright@chromium.org,meade@chromium.org,shend@chromium.org

Change-Id: Ia95e9bd383940bdef3201d7f325973ff9649678c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775360
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/810324Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521986}

BUG=791788
TEST=crash reports
R=piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic7a68b18e42241b4c67188098bc536c37c2fdeef
Reviewed-on: https://chromium-review.googlesource.com/810049Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521985}

TypingCommand::InsertText(const String&, bool, EditingState*) is sort of messed
up right now because it calls AdjustSelectionAfterIncrementalInsertion(), which
calls FrameSelection::SetSelection(), which we want to hoist out of here (see
discussion at https://goo.gl/GFgLF3).

This CL removes AdjustSelectionAfterIncrementalInsertion's call to
SetSelection() and replaces it with some logic in
InputMethodController::SetComposition() to pull the ending selection out of the
most recent UndoStep. This sets us up to avoid an unnecessary selectionchange
event. Currently, SetComposition() does the following:

1. Selects the composition range.
2. Replaces the selection with the new text (requesting that the new text be
   left selected).
3. Converts the selection back into a composition range.

This CL sets us up to avoid actually selecting the range in step 2; instead, we
can make TypingCommand::InsertText() set it as the ending selection, and
InputMethodController can retrieve it from the UndoStep.

Bug: 790801
Change-Id: I9111af255f61c34f5bdaf27b94a5e8a659750860
Reviewed-on: https://chromium-review.googlesource.com/807151Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521984}

The test seems to be passing reliably.

BUG=chromium:667371
TBR=dgozman

Change-Id: I2a277bcf08d8c4b3820a8553e228a88df0ee66e1
Reviewed-on: https://chromium-review.googlesource.com/809776Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521983}

Change-Id: Ie30782130f7c28ad3b271c25bff73fd6ff4bb507
Reviewed-on: https://chromium-review.googlesource.com/804671
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521982}

This CL moves service_worker_installed_scripts_manager.mojom from
content/common/service_worker/ into
third_party/WebKit/common/service_worker/, in preparation to merge
content::WebServiceWorkerInstalledScriptsManagerImpl into Blink.

BUG=789854,789846

Change-Id: Ice64bb4ad56602370fc14fa6cd21fd124d454a42
Reviewed-on: https://chromium-review.googlesource.com/807761
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521981}

This CL also changes the behavior for ColumnRuleColor.
It used to call VisitedDependentColor(CSSPropertyOutlineColor),
but that seemed wrong so I changed it to use
VisitedDependentColor(CSSPropertyColumnRuleColor).

There will be more CLs immediately following to finish Ribbonizing
this class. Please ping me for a link to the design doc.

Bug: 775360
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2b204146eafdd1fd7a74d8a9b8c8bb707d5f3eea
Reviewed-on: https://chromium-review.googlesource.com/781442Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521980}

This simplifies some constructors.

Change-Id: I5ca3d141c6ad7d4837cd0d97bdcc17524914629d
Reviewed-on: https://chromium-review.googlesource.com/805414
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521979}

This patch makes EFillAttachment, EFillBox, EFillRepeat and EFillLayerType
to be enum class for better type safety.

Bug: 684966
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1738b905c71a566d7063a8467afbe920f4497509
Reviewed-on: https://chromium-review.googlesource.com/776409Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521978}

This CL introduces Mojom struct for content::MediaDeviceInfo and removes
its IPC_STRUCT_TRAITS in favor of StructTraits.
This is in preparation for migration of MediaDevices.enumerateDevices()
processing from content to Blink.

Bug: 764680
Change-Id: Idc17f1b53963d2fb7a80b4ac98890913cb5ad521
Reviewed-on: https://chromium-review.googlesource.com/807840
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521977}

Bug: 768278
Change-Id: I3d5f1aadba1ca967ecf8cb2a0f07e1e22de92559
Reviewed-on: https://chromium-review.googlesource.com/807404
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521976}

In GPU raster mode, only one raster task can be active at a time. This means
that these rasters have to happen quickly, or they will block other work.
For this reason, we should not allow pre-paint GPU raster tasks which might
have very slow performance to execute, because otherwise they will block
future high-priority on-screen raster tasks.

Raster tasks can have at-raster image decoding if the memory for storing
pre-decoded images has been exhausted. This is the case in the website
referenced in the bug. In these cases, rather than allowing the raster
to proceed and potentially jank display due to long image decodes, we
abort the raster, but still proceed with the image decodes (which don't
block other raster, and may be useful to decode in any case).

Bug: 768799
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2ec78361739b7b8f455f26211f21a5f8e995a8b6
Reviewed-on: https://chromium-review.googlesource.com/806855
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521975}

Previously, much of the BLE code was keyed by RemoteDevice instead. This
can cause subtle race conditions; for example:
  (1) Register remote device A.
  (2) CryptAuth sync occurs; device A is updated.
  (3) Register remote device A again. Since device fields have changed,
      this would be considered a different device.
  (4) Multiple connections are attempted to the same device.

These issues are recoverable, since the MessageTransferOperation which
registered the original device (before the update) will eventually
finish and unregister the device; however, during this time period,
connections are prone to errors.

Bug: 777610, 672263
Change-Id: I9e6ed9c2ad69cb318863268f041db7b5f5ec3bd5
Reviewed-on: https://chromium-review.googlesource.com/738467
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521974}

This changes the function which checks whether permissions are
controlled by the DSE to take an extra argument for the
ContentSettingsType which allows querying whether a particular type is
allowed. This simplifies code at callsites since we can centralise the
check for the Notifications feature flag and it also means that we can
have a central location for the list of supported permissions.

As a side effect of this change, the Page Info bubble will now
correctly display the text "Allow/Block for the current search engine"
next to the notifications permission, when the GrantNotificationsToDSE
feature is enabled.

Bug: 780344
Change-Id: I0300397e337c47e4eee83a10dd4900d8ca7d86f0
Reviewed-on: https://chromium-review.googlesource.com/795520Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521973}

Removed SetConfig for optional audio codecs, those are useless and
only produce noise in test logs. Also marked PCM/PCM_16BE as mandatory.

Bug: none
Test: cast_media_unittests
Change-Id: I73ea213f109e1bbc26194a88a09d946db47ce346
Reviewed-on: https://chromium-review.googlesource.com/810124
Commit-Queue: Sergey Volk <servolk@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521972}

This CL introduces Mojom enum for content::MediaDeviceType and removes
its IPC_ENUM_TRAITS in favor of EnumTraits.
This is in preparation for migration of MediaDevices.enumerateDevices()
processing from content to Blink.

Bug: 764680
Change-Id: I5e3c96adb7fd96e1d0ea41dff933ecac017228fa
Reviewed-on: https://chromium-review.googlesource.com/806054Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#521971}

This makes SearchPermissionService preserve the correct content setting
values when content setting enterprise policies are in effect. It is
changed to use GetUserModifiableContentSetting which will always return
the user defined content setting, even when an enterprise policy is in
place.

Bug: 780344
Change-Id: I8b9362ddd6580c602270f7b5d8d9dafbb467a896
Reviewed-on: https://chromium-review.googlesource.com/807865Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521970}

When parsing custom properties or retrieving them from CSSOM, we need
to return a CSSUnparsedValue.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#normalize-tokens

Bug: 788570, 779477
Change-Id: Ia2fa289dc076ffd6dbacf03822907663209c6284
Reviewed-on: https://chromium-review.googlesource.com/804920Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521969}

This CL wraps "xyz B" shown on Data saver screen for data statistics
with TtsSpan of type TYPE_MEASURE so that TTS engine announces it as "xyz bytes"

Bug: 461909, 786947
Change-Id: I8924a3cc904e9dc1f0cccc1dc1fa955f9d52a2b2
Reviewed-on: https://chromium-review.googlesource.com/784052
Commit-Queue: Isha Bobra <ibobra@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521968}

new bots were added at
https://chromium.googlesource.com/chromium/src.git/+/b7cd67a303ff371a2b04c9f3dcbc24322fa86ebb

bots are renamed
 https://chromium.googlesource.com/chromium/tools/build/+/dff3a4e2f2a4ca45a6f5d6f9459630a672ab2a55
 https://chromium.googlesource.com/chromium/tools/build/+/6bed769f844ca3b714071e1bd7deea35ba42da46
 https://chrome-internal.googlesource.com/infradata/master-manager/+/781eb935a1025b53fe88fad8e92d2e4cb02cc0f9

ToTWin Goma Canary was removed. http://crbug.com/791837

Bug: 740416
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc4d2f53864f175b0d9e0f037b0be5edb7d8962b
Reviewed-on: https://chromium-review.googlesource.com/807640Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521967}

Bug: 785420
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I67ddf477232a12d3a1848b9982695abce3ec397c
Reviewed-on: https://chromium-review.googlesource.com/773635Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521966}

On disk timestamps were using second resolution, while in memory and
sync representations were using microsecond. This meant that by round
tripping data to disk, the actual values would chance slightly. There
were several places that compared timestamps, and these difference did
no fix themselves, but rather resulted in repeated churn. The database
columns were already 64 bit integers, so this change doesn't even
modify the schema, just changes the format of data stored.

Bug: 775049
Change-Id: I03886d249c4b9195f20b897d309da6063db4bf6f
Reviewed-on: https://chromium-review.googlesource.com/806646
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521965}

This CL moves
  third_party/WebKit/public/platform/modules/serviceworker/*.mojom
into
  third_party/WebKit/common/service_worker/

Eventually third_party/WebKit/public/platform/modules/serviceworker/
will be removed completely, other public types defined there will
disappear via Onion Soup effort or be moved into
third_party/WebKit/common/service_worker/, too.

BUG=789846

Change-Id: I780f1e19e0b824cf3cb2806adc5268745ceee950
Reviewed-on: https://chromium-review.googlesource.com/802817Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#521964}

The DeclarativeNetRequestBrowserTest.BlockRequests_ResourceTypes can sometimes
timeout causing it to flake. Take care of this by splitting it into two tests.

BUG=787957, 696822

Change-Id: I6245e14ac2ad064d15c06792c5d492606a364d04
Reviewed-on: https://chromium-review.googlesource.com/807745
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521963}

Bug: 755477
Change-Id: Ia8554341cf4a27b8b64367c5fb40f3cda689f74d
Reviewed-on: https://chromium-review.googlesource.com/688954Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521962}

This change includes multiple fixes for various cases where
SourceBufferStream requires notification of a new coded frame group when
buffering by PTS (currently available via kMseBufferByPts feature) even
if there is no MSE coded frame processing algorithm DTS discontinuity
detected. This additional granularity allows for SourceBufferStream to
understand that the next buffers appended to it may overlap recently
appended buffers, and also allows for handling cases where the next
keyframe (continuous in DTS) jumps significantly forward in PTS but
still needs to remain continuous with the current append sequence.

On every keyframe, when buffering by PTS, FrameProcessor now considers
doing the extra signalling if DTS is continuous and buffering ByPts,
and:
a) keyframe PTS jumps significantly into the future relative to the
   highest PTS emitted already in the current coded frame group (in
   which case the highest PTS emitted already in the current CFG is used
   as the signalled PTS value), or
b) keyframe PTS is before the highest PTS emitted already in the current
   coded frame group (in which case the keyframe PTS is used as the
   signalled PTS value and tracking of the highest PTS emitted is reset
   to enable correct detection and signalling of both (a) and (b) cases
   for future keyframes in the continuous DTS append sequence.)

This change also includes a fix to SourceBufferStream when buffering
ByPts to appropriately split a range that is being overlap-appended.

A benign DCHECK is also removed from SBS::UpdateLastAppendStateForRemove
which could fail for a SAP Type 2 GOP at the beginning of a range (the
last appended buffer in that range might indeed be a non-keyframe with a
PTS prior to the range start time, which could be as late as the PTS of
the keyframe of that non-keyframe's GOP.)

New and updated unit tests are included. I locally confirmed this fixes
bugs 773115 and 788344, and appears to fix nest.com and twitch.com
renderer crashes with dcheck_always_on=true.

Pre-existing bug 791095 is demonstrated, but not yet fixed, by new
unit tests:
  BufferingByPts_ContinuousDts_SapType2_and_PtsJumpForward
  BufferingByPts_ContinuousDts_NewSap2GopEndOverlapsLastGop_1

Pre-existing bug 763620 is demonstrated, but not yet fixed, by new
unit tests:
  BufferingByPts_ContinuousDts_NewGopEndOverlapsLastGop_2
  BufferingByPts_ContinuousDts_NewSap2GopEndOverlapsLastGop_2
  BufferingByPts_ContinuousDts_GopKeyframePtsOrder_2_1_3

BUG=773115,788344,791095,763620

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6f95cf85e1d1fa5b5f74ed1d99a3853ec6ccf686
Reviewed-on: https://chromium-review.googlesource.com/777778Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521961}

This test is newly-introduced but doesn't work on Fuchsia.

Bug: 792300
Change-Id: Ice4288e9c5e199ff49e323c0d79470883da0e659
Reviewed-on: https://chromium-review.googlesource.com/809838
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521960}

Bug: b/66944165
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia22b2b815bbaa6e26a30044fc06a58cf9a142807
Reviewed-on: https://chromium-review.googlesource.com/807363Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521959}

Previously the new tab desktop in-product help promo bubble was too
close to the new tab button. Thus, I had to move the the promo bubble
further from the anchor_view of the button. I also removed the shadow
from the new tab promo bubble. Note that new tab promo bubbles are
inactive.

Bug: 734132
Change-Id: I5ba93f841413d3985ff810fbb0f009b8627289bb
Reviewed-on: https://chromium-review.googlesource.com/797920
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521958}

If test output is over kOutputSnippetBytesLimit, which is 300kb, then
TestLauncher::OnTestFinished() trunactes the string to the last 5000
bytes. It looks like this a mix up of kOutputSnippetBytesLimit and
kOutputSnippetLinesLimit.

Bug: 788739
Change-Id: I4aacc4b62f51f764143060bdaeef00031053d1b5
Reviewed-on: https://chromium-review.googlesource.com/809085Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521957}

Worklet requires a valid Frame object, but GetFrame() from the window
can be nullptr. This CL blocks out such case.

Bug: 792108
Change-Id: Ie3fe64c707447956fcfeac687d4df9f5bf7b26d1
Reviewed-on: https://chromium-review.googlesource.com/809299Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521956}

When we specify CSS variables in a property value (e.g. color: var(--A))
we need to return a CSSUnparsedValue. This patch implements this
by first trying to parse the property value according to the property's
grammar. If it fails, we then check if it has var references and parse
it as a variable reference. The code for converting a variable reference
to a CSSUnparsedValue was already in the codebase so we just hook into
that.

Bug: 788570
Change-Id: I65b32d29e80918c61e1731e7a0424b72e7d9b1d7
Reviewed-on: https://chromium-review.googlesource.com/804980
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521955}

1- Updates WKSystemCookieStore so it can use wkcookiestore only from
   the main thread.
2- Update the CookieCreationTimeManager to only be used on IO thread
   (aside from creation on Main thread)

Bug: 779106,759229
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifa0f9e5bb2d2c33c488759467dc8a25403f6e0ed
Reviewed-on: https://chromium-review.googlesource.com/809531
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521954}

Bug: 778051
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5aea1c4412721a7b1bc549a3d14f52bd3de73bb
Reviewed-on: https://chromium-review.googlesource.com/809783Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521953}

- Remove ProduceTextureCHROMIUM from GLES2Interface.  Change all call sites
  to use ProduceTextureDirectCHROMIUM.
- Remove <target> from ProduceTextureDirectCHROMIUM.
- Remove <target> from CreateAndConsumeTextureCHROMIUM.

BUG=757607

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic50059a0db3edfaeb51690645bce096f4f64228e
Reviewed-on: https://chromium-review.googlesource.com/780807
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521952}

If the fetch of the warmup URL (aka probe URL) fails, the
corresponding proxy is disabled, and the config is reloaded.

A future CL will add retries -- If the fetch of the probe URL
due to network flakiness fails, then the probe will be retried
(up to 3 times) on the same proxy.

Bug: 760294
Change-Id: Ib255f8178ef106f5e2882ad3dc32bde143c40a90
Reviewed-on: https://chromium-review.googlesource.com/807592Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521951}