- 18 Sep, 2020 40 commits
-
-
Egor Pasko authored
This is often necessary on Android to read /proc/self/pagemap. Without prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on Canary. This potentially leads to bias in reporting MappedAndResidentMemoryFootprint2. Bug: 1070618 Change-Id: Ic7f965099c4b3ba822baf248eb80d33678996188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416377 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#808298}
-
Olivier Robin authored
1. pendingUserActivity is handled even when session is not active Revert the faulty change 2. Only send notification if presentingModalOverlay changes This is a fix for crrev.com/c/2409300 Bug: 1129638 Change-Id: I1c63d83e03ceb31179b4a836d03dc6078a734b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417892Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808297}
-
Hwanseung Lee authored
the menu used a checkbox to change value. it is more user-friendly to use switch-toggle in this case. Bug: 1112076 Change-Id: Ia96fa48b1c3ce452beb5dbfb4fe94cb66df588c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392193Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#808296}
-
Keishi Hattori authored
Updates COMPONENT for jinja2 and mako since Blink>Internals is getting deprecated. https: //docs.google.com/document/d/14CcSzzy_Q0_mg-E9WZKESobpoR66JoWlaJhHzQZKSFA/preview Bug: None Change-Id: I55ec8972b845181e3eecbb977b27f724308d7c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416214 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808295}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a2a14855653..855c5cdcd364 2020-09-18 changhaohan@chromium.org TypeScriptify elements/ComputedStyleModel.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd1291220daa7b72ecbe239eeaa12d441d21969b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808294}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I563b96f33cf86e01816aa487ecc79a6fa3efd162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416348 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#808293}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34ef0c3fdc8e..50ae4c5f4427 2020-09-18 afdx@google.com Fix header guard macros (#3811) 2020-09-18 antonikarp@google.com spirv-fuzz: Fix TransformationDuplicateRegionWithSelection (#3815) 2020-09-17 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Add DeviceIndex (#3812) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I06be9bb43a2a9d22736c7ea1d263cf0b8e99605f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808292}
-
Boris Sazonov authored
If kMobileIdentityConsistency is enabled - check unconsented primary account while building X-Chrome-Connected header. Bug: 1095128 Change-Id: Idc46c0352f5371bf3d92e9ec4a7e513f9c401b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416352Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808291}
-
Anqing Zhao authored
This test is reported as random failure, but cannot be reproduced on local machine. So adding more logs to identify the root cause. Bug: 10948093 Change-Id: I543ce995c4db17267bfe82abf27ec27c074a3110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416521Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#808290}
-
Victor Hugo Vianna Silva authored
AndroidSyncSettings registers a listener that is called by the Android system on a background thread. Before this CL, the listener directly modified the state of the class when notified. Because AndroidSyncSettings is also used from another thread (UI), this required it to be implemented in a thread-safe manner. In this CL, we modify the listener to rather post the update to the UI thread, one step towards having this class be used from a single thread. As a bonus, objects that in turn observe AndroidSyncSettings will now only be notified on the UI thread, which solves the linked bug. Cleaning up the observers so they don't post to the UI thread themselves is left for the next CL. We also take the time to brush up MockSyncContentResolverDelegate, namely simplify its notification logic and use a global lock for the class. Bug: 1028568 Change-Id: Iac820125bc37796eade94b503b8e0983b171108f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415150Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#808289}
-
Keishi Hattori authored
Updates COMPONENT for public/mojom/leak_detector since Blink>Internals is getting deprecated. https: //docs.google.com/document/d/14CcSzzy_Q0_mg-E9WZKESobpoR66JoWlaJhHzQZKSFA/preview Bug: None Change-Id: Ia4a3e6de4eda42637542494d8147262cc002d944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417774 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#808288}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0d796260035458dd9ab196ad24618e545ff16932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417465Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808287}
-
Keishi Hattori authored
Updates COMPONENT for core/frame since Blink>Internals is getting deprecated. https: //docs.google.com/document/d/14CcSzzy_Q0_mg-E9WZKESobpoR66JoWlaJhHzQZKSFA/preview Bug: None Change-Id: I095b4d349802e15821f9825701e8b37a7b453db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417772Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808286}
-
Gyuyoung Kim authored
As EditingBehavior enum type was moved to Blink, it would be good if we can use it in the whole area without converting. So, this CL replaces the existing enum type and all uses with web_pref::EditingBehaviorType after moving editing_behavior_type.h from renderer/core/editing to public/common/web_preferences. Bug: 919392 Change-Id: I3b79a55a36f43c16ee532bcb71171f0277807184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417470Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#808285}
-
Dominik Röttsches authored
Wire it from content::features to a Blink RuntimeEnabledFeature in order to enable potential A/B testing for this font retrieval path. Bug: 1115064 Change-Id: I81fb92591b7a78b3a136205d4863a423e003ab9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416380Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#808284}
-
Colin Blundell authored
I fixed the underlying source of the flake in https://chromium-review.googlesource.com/c/chromium/src/+/2410488, so these should be safe to re-enable. I'll monitor after this CL lands. TBR=martiniss@chromium.org Bug: 1108306 Bug: 997376 Change-Id: I75747fe429f3c1a94b75136951b2e9be8ce47540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414397Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#808283}
-
Omar Morsi authored
Bug: 1124656 Change-Id: I040f7189a57b0fbba7e4ca1ce65528f406f4a771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414036Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808282}
-
Fabian Sommer authored
Add an option to initialize ExtensionForceInstallMixin with a MockConfigurationPolicyProvider. Use this option in ForceInstalledAffiliatedExtensionApiTest. Add mixin support to ForceInstalledAffiliatedExtensionApiTest. Bug: 1090941 Change-Id: Ieea931c108e091679be607045f405b55f4186a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416453Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808281}
-
Wei Lee authored
This reverts commit b49f79c4. Reason for revert: https://crbug.com/1129639 Original change's description: > Revert "idle-detection: Implement requestPermission() method" > > This reverts commit 67a8dbc3. > > Reason for revert: https://crbug.com/1129639 > > Original change's description: > > idle-detection: Implement requestPermission() method > > > > This change implements a static requestPermission() method on the > > IdleDetector interface and switches the API from requiring the > > "notifications" permission to the new "idle-detector" permission. > > > > Bug: 878979 > > Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539 > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > > Reviewed-by: Ayu Ishii <ayui@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808019} > > TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org > > Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 878979 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473 > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808208} TBR=shik@chromium.org,reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org Bug: 878979 Change-Id: I4f409d8f37091f384883c22a39e08f7e45762aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417779 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808280}
-
Alexandre Courbot authored
Fix a few warnings reported by clang-tidy. BUG=None TEST=Chrome builds. Change-Id: Id3b7249365d8a9c68fcb59e676c35036a219c21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413944 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808279}
-
Omar Morsi authored
Following up on CL: https://crrev.com/c/2190216: Support disabling Chrome OS native VPNs by policy; this CL adds tests that address the internet page changes which were mainly showing a policy indicator beside the button used for adding a new VPN when VPN is disabled by policy. Bug: 1098653 Change-Id: I54c24d74511f528f1e6dd4dc64af81fceec9bdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414239Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808278}
-
Patrick Brosset authored
The implementation Page.screencastFrameAck method is supposedly here to throttle the frame rate when doing a screencast over CDP. It's supposed to be used like this: on('Page.screencastFrame', frame => { Page.screencastFrameAck({sessionId: frame.sessionId}); }); Page.startScreencast(); But in reality, calling screencastFrameAck or not does not make any difference. The frames are still sent by the backend at the same rate, without waiting. This change fixes the video_consumer code path in PageHandler so it does wait for Page.screencastFrameAck to be called after it has reached the maximum number of inflight frames. Bug: 1126915 Change-Id: I8bc1bc37e48689262b250376879fb9ae726a6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404113 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808277}
-
Leo Lai authored
Removed the owner password from the EULA screen so the secret doesn't expose to attackers that can physically access the devices; also it makes more clean and secure implementation of owner password feature at chrome os side. BUG=chromium:1109629 TEST=browser_tests, with "--gtest_filter=EulaTest*" TEST=check that the System Security Settings is still available, and the look doesn't change. TEST=check that the System Security Settings doesn't show the owner password anymore. Change-Id: I9ee41263f0e73d6a80afe448c57cc2a2148bd816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409661Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#808276}
-
Anders Hartvoll Ruud authored
This reverts commit 33345bc7. Reason for revert: The death test introduced here doesn't work on several bots, for example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868834693840167792/+/steps/accessibility_unittests_on__none__GPU_on_Mac_on_Mac-10.10/0/stdout Original change's description: > Simplify parsing code in ax_enum_util > > Replace the hand-written code to parse each enum from ax_enums with a > templatized function that builds a map from string to attribute value > on-demand. > > This saves a little bit of manual effort each time someone updates an enum. > > Note that these parsing functions are only used by the automation API. > > Bug: None > Change-Id: I4be5e192041cf0686175a20e68782184295a1f9c > AX-Relnotes: N/A > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404164 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808190} TBR=dmazzoni@chromium.org,dtseng@chromium.org,chrishall@chromium.org Change-Id: I61d62255a981ff119933d6110bd39819dcb7b6d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416357Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#808275}
-
Koji Ishii authored
Add inputs/outputs table for each inline layout phase. TBR=yosin@chromium.org NOTRY=True Bug: 982194 Change-Id: I8a90b87b00dab13f9c06de693d8c808a971eb8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417677Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808274}
-
Tomasz Moniuszko authored
Bug: 546640 Change-Id: Id2685a95d05e621012bb0e9aab6b129e88e57cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391144Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#808273}
-
Naoki Fukino authored
Fling (kinetic) scroll event is notified using pointer.axis_stop event in wayland terms, but the event is not supported in wl_pointer v4. This CL upgrade the version from v4 to v5 to handle the events. Doc: go/lacros-fling Bug: 1105310 Change-Id: I0c1ad3391ba772d2f9e4cacfd60d7db1905958c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404224Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808272}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600387025-1a927353a66c94deef84219e25e017cd673d3d66.profdata to chrome-mac-master-1600408803-f0e40d48b8629d1086dbcdc0a0535ae545c69485.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Icfc0fa9e621fed5fb907271f1ba1e1b03ed52b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808271}
-
Boris Sazonov authored
Changes order of calls in SigninManager - now it triggers an update to the account list before setting the primary account. This way, the list of accounts is available by the time the primary account is set. Bug: 1095128, 1121479 Change-Id: Idc596f99e6899624284b9cc86bdf01320f16b954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416520Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0c99c387b38..8cf89f57dc90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126301 Tbr: yutak@google.com Change-Id: If2c11686fc5fb960c5941f0a128caa18f29efdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808269}
-
Johann authored
Converting MIDIDispatcher also allows us to use the HeapMojo wrappers to manage the mojo connections. BUG=chromium:1049056 Change-Id: I1870796a2c99036537f09be71206eeafe59dda11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417468Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#808268}
-
Alex Rudenko authored
The method ResourceStyleSheetText was using stylesheet's href attribute to look up resources stored in the resource_container_. It only worked when the href attribute and the FinalURL() were the same because FinalURL() is used to store resources in the resource_container_. This CL changes ResourceStyleSheetText to use FinalURL() when looking up resources. FinalURL() is the actual URL where stylesheet was loaded from (e.g., after redirects). Fixed: 1128360 Change-Id: Ib2dff7d2c86af582a857493a73f3f9fe27307e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414213Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808267}
-
Sven Zheng authored
TEST: Locally tested on Nexus 5 device. Bug: 1117345 Change-Id: Ia1690ea4800ab1230aebd60addc92ea4a81af9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417254 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808266}
-
Takashi Sakamoto authored
The initial value: the return value of IsWindows8Point1OrGreater() is not trivial. So this requires thread-safe static-local initializer (i.e. _Init_thread_head) on Windows platform. If using _Init_thread_header on the allocatoin path, causes crash while windows crt startup when using PartitionAlloc as malloc. Bug: 1126432 Change-Id: I922f8211603c499c9e5d7cba8de90f8ce752c29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409655Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#808265}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1d3589d0a8c9bd4c1851e3386179f9b443db4243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808264}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600387025-8e83821116dd5b4024f7e67a897d35744d6cd04c.profdata to chrome-linux-master-1600408803-cf78b7068fa61ec1aacbec5ee17841a8e2bbd57a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I02ef44edfd7eb4a52701e980e8ea98cb7337a042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417077Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808263}
-
Yutaka Hirano authored
On network::QuicTransport it is difficult to satisfy the requirement of ArmingPolicy::AUTOMATIC written in SimpleWatcher: // NOTE: It is important when using AUTOMATIC policy that your // ReadyCallback always attempt to change the state of the handle (e.g. // read available messages on a message pipe.) Otherwise this will // result in a potentially large number of avoidable redundant tasks. Use ArmingPolicy::MANUAL instead. Bug: 1129597 Change-Id: Ic7170458687b3086eb212cce987e6ce676ee4ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416154 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#808262}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/795fa782ca1a..ec598d5b00eb 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a8a3ea25b36 to 8d4331eeb5ea (13 revisions) 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 70a60d85 to 33c87dad (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkanTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/*Test: Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webglTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/*Test: Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_* Change-Id: I8e7ba3d468efc128ed63b639b3015e5cfc5bbcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808261}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ac3765e663cd..d6498a41ab4e 2020-09-18 hao.x.li@intel.com Query API: Timestamp Query on Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If9a7928acf17257ea83f6c668b796ed4d69e2f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808260}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd0862c6..e6a7fb53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1283d81408c7c7698c8e516be7e84eb64cbe2ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417854Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808259}
-