- 10 May, 2018 40 commits
-
-
Scott Chen authored
Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I27a757241ae2b8b44453b9acb1000fe8d9ddb69d Reviewed-on: https://chromium-review.googlesource.com/1054217Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557702}
-
Marina Ciocea authored
Use audio service IPC instead of AudioInputController for creating input stream. This change is part of the effort of moving audio out of browser process [1]. By moving audio into a separate process, speech recognition can no longer use AudioInputController directly, and needs to use IPC to create and use input streams provided by audio service. [1] Chrome audio process design doc: http://doc/12vz7UZBQIp1195V-xAYvHIoQ1r536BCmMKcPN7Si-OI Bug: 834706 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1dc98ad670e1e9880320ae4bf054ae0d94f5b48f Reviewed-on: https://chromium-review.googlesource.com/1049685 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557701}
-
Daniele Castagna authored
Modesetting with an x-tiled buffer and then pageflipping to y-tiled buffers on 3 different crtcs is allowed to fail and indeed does on APL devices. This CL makes sure the modeset buffers are allocated with the same modifiers we allocate buffers for the buffer queue. Bug: 819692 Test: pyro with 2 external monitors Change-Id: I392cfecbf598b096947af55c793148933ee83025 Reviewed-on: https://chromium-review.googlesource.com/1054447 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557700}
-
Jian Li authored
This allows the embedder to create a URLLoader and ntercept a navigation request. Bug: 841617 Change-Id: Id6d8c795805413962151be5fbdce91e52322af5d Reviewed-on: https://chromium-review.googlesource.com/1053352Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557699}
-
George Burgess IV authored
In order to use AFDO on Linux, we need to be able to locally unpack the profiles we fetch (which is likely preferable to storing a second, unpacked version in gs://). It used to be that we only needed these for Android, since these profiles were previously only used by Android. This was split out from https://chromium-review.googlesource.com/c/chromium/src/+/1025132 Bug: 805098 Test: Ran install-build-deps.sh Change-Id: I1374b2b84c26f6ef808c00217bfbb51e8fbf980d Reviewed-on: https://chromium-review.googlesource.com/1054613Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#557698}
-
Eric Karl authored
This reverts commit e079f156. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky testWindowRafStopsFiringWhilePresenting_WebXr. > > Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest > testWindowRafStopsFiringWhilePresenting_WebXr because flaky. > > TBR=bsheedy@chromium.org > > Bug: 840883 > Change-Id: I2300a6be8d79d1d6f47d33d5fd06edc9fee5ca41 > Reviewed-on: https://chromium-review.googlesource.com/1051788 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557189} TBR=bsheedy@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840883 Change-Id: I7638d3489db017dc040683e8a6cc6ce47c2df94d Reviewed-on: https://chromium-review.googlesource.com/1054352Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557697}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I0951d87c1baee0f172e6e446f2cc6c5a1ae6cf2a Reviewed-on: https://chromium-review.googlesource.com/1054631Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557696}
-
Christopher Grant authored
- Revert to "new incognito tab" above "close all incognito tabs" - Don't duplicate the UI model logic in each button handler BUG=841501 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I87e625ec75270114567810c595ca3767e7e93b0f Reviewed-on: https://chromium-review.googlesource.com/1054503Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557695}
-
Eugene Ostroukhov authored
Bug: 828601 Change-Id: Ia90474edd65f80e432533974ff12d08c4a149ba8 Reviewed-on: https://chromium-review.googlesource.com/1053060Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557694}
-
Bret Sepulveda authored
GlassBrowserFrameView had a GetTitlebarColor method that was redundant with BrowserNonClientFrameView::GetFrameColor, so this patch deduplicates them. Bug: 841643 Change-Id: If1f0b3724fac814b8b445c1792213753b49e2eda Reviewed-on: https://chromium-review.googlesource.com/1053490 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557693}
-
Ahmed Fakhry authored
The ink drop highlight lingers behind when the window and the caption buttons are growing as a result of maximizing the window. Sometimes it even sticks in the wrong place forever until the mouse is moved. This CL fixes the issue by painting the hover highlight in such a way that simulates the AutoHighlightMode::SHOW_ON_RIPPLE mode. This guarantees the highlight is always painted at the center of button. BUG=840901 Change-Id: I6096fef6605c262ca81c8526fea029e7dc459179 Reviewed-on: https://chromium-review.googlesource.com/1053805Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557692}
-
James Cook authored
More support for WindowService as a library. Expose a method to set the frame decoration metrics (e.g. client area insets). Bug: 839592 Test: added to services_unittests Change-Id: I44ead634ad2c5ceb35020efcf5a301aced6ec603 Reviewed-on: https://chromium-review.googlesource.com/1053557Reviewed-by:
-
Manu Cornet authored
Change-Id: I541a6cd9b41b8ce505ce2e6598a5f35e0c548993 Reviewed-on: https://chromium-review.googlesource.com/1015967 Commit-Queue: Manu Cornet <manucornet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557690}
-
Jonathan Backer authored
Saves 0.4 ms out of 9.4 ms on thread_GPU_cpu_time_per_frame on thread_times.key_silk_cases running on N5 with OOP-R enabled. This CL does a couple of things. (1) dirties GrContext when we make GL calls directly (via api() in RasterDecoderImpl or in helpers like TextureManager) (2) does a hard RestoreState(nullptr) just before we service another decoder using virtual contexts. The correctness/performance of this CL relies on two facts: - RasterDecoder functions don't rely on ContextState persistence between calls (it uses Scoped*Binder and helpers call Restore* on exit). This means we can ignore how GrContext changes state during RasterDecoder execution. - GetContextState is called if and only if we switch virtual contexts (https://cs.chromium.org/chromium/src/ui/gl/gl_context.cc?rcl=7665435ec16705f26cf15259d28b89d24ec80699&l=328) This CL avoids most state resetting in the common case where we OOP-R a bunch of tiles all at once (e.g. page load). Note our resetting is still pessimistic. In particular, I would expect scenarios like this where we still unnecessarily reset/restore state. - client A receives GetContextState - client B made current, but immediately descheduled to wait on a SyncToken provided by A - client A made current again Bug: 836916 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9eecef94a5429861ae4b70acdd3aba0450bded4b Reviewed-on: https://chromium-review.googlesource.com/1047445Reviewed-by:Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557689}
-
Christopher Grant authored
This change reduces the amount of custom code in LinearLayout to the minimum, reducing duplication and keeping things more consistent. BUG= R=acondor Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I11a9c0a766845f9b5b7a86378a12b5e0b6202115 Reviewed-on: https://chromium-review.googlesource.com/1053754Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557688}
-
rodmartin authored
Change-Id: I1096ccdc251b41a91c17d0b4ce6dc778ef33d7dd Reviewed-on: https://chromium-review.googlesource.com/1050970Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#557687}
-
David Jacobo authored
Somehow using Close() to get rid of a WebContents causes a error, while still investigating we can avoid this by: -replacing with ClosePage (which apparently is used more broadly thru the codebase). -Stop directly closing the tab and instead ask PostTask() to do it. Bug: b/79167225 Test: Manual test. Change-Id: I752073c8577bf45a387ed1e7f5d908feea05f8b5 Reviewed-on: https://chromium-review.googlesource.com/1043266 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#557686}
-
https://pdfium.googlesource.com/pdfium.git/+log/80302c77a854..5ad45e2f68bb $ git log 80302c77a..5ad45e2f6 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 dsinclair Cleanup formcalc method generation 2018-05-10 rharrison Clean up post review comments Created with: roll-dep src/third_party/pdfium BUG=chromium:814848 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1d0e111ec94d82eee04e9e8a283f97838d7e5d19 Reviewed-on: https://chromium-review.googlesource.com/1054492Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557685}
-
Eric Orth authored
Bug: 841278 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibc169428f34de3f291756f360a09ee22d4aa2308 Reviewed-on: https://chromium-review.googlesource.com/1053835 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557684}
-
Troy Hildebrandt authored
Adds recording of voice search initialization failures, recorded if we fail to show the speech recognition intent, and a voice search dismissal metric when the voice search is dismissed by the user. Also moves the recording of the voice recognition finished event to capture more of the completions and provide a more realistic ratio of start/finish events. Bug: 840483 Change-Id: I857ef4115482fa4695bd0dd9e7fe3794dac55769 Reviewed-on: https://chromium-review.googlesource.com/1048311Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557683}
-
Sergey Ulanov authored
CollectContextGraphicsInfo() now calls CollectGraphicsInfoGL(), same as on Linux and Mac. Layout tests were failing to start due to CollectContextGraphicsInfo() returning false. Bug: 778467 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If089e57b167fb74f95da4462cbe2b1756a76c2be Reviewed-on: https://chromium-review.googlesource.com/1054265Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557682}
-
Jian Li authored
These new files are simply copies of OfflinePageRequestJob files with name changes. They're not added to compile targets. This will allow easier reviewing for next patch that refactor OfflinePageRequestHandler to support both with network service enabled and without network service enabled. Bug: 841617 Change-Id: I295479cfe2240eddd77a7f9580af4c0346997282 Reviewed-on: https://chromium-review.googlesource.com/1053364Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557681}
-
Xi Han authored
ServiceManager. We need a thread to post/execute tasks when starting the ServiceManager. This thread needs to be created before the browser main loop is initialized, and will be registered as the BrowserThread::IO thread which is currently used by ServiceManager connections. The creation of such a thread is moved to service_manager::main via MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no thread created before calling fork() on posix, we also move the setup of sandbox before creating the IO thread. Bug: 740677, 729596 Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 Reviewed-on: https://chromium-review.googlesource.com/969098 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557680}
-
Evan Stade authored
This is a reland of f57e1c35 which was reverted due to being blamed for the msan failures which were fixed by d8f72fd2 Original change's description: > cros - Update appearance of resolution change notification. > > This removes the last raster asset in ash_resources.grd, so remove that > file and the associated build target. > > Bug: 840509,505953 > Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c > Reviewed-on: https://chromium-review.googlesource.com/1050523 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557292} TBR=jamescook@chromium.org,sky@chromium.org Bug: 840509, 505953 Change-Id: Iae0b07cbf2e14e307b74e11d07d21290ee72291b Reviewed-on: https://chromium-review.googlesource.com/1054222 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557679}
-
Stefan Zager authored
TBR=evanm@chromium.org NOTRY=true Change-Id: I14319a25baa26ed7361e796839ed6b4c689529e5 Reviewed-on: https://chromium-review.googlesource.com/1054491Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#557678}
-
Ehsan Chiniforooshan authored
If the reader of the stream stops reading from it for some reason, a deadlock is possible: - WriteToStream() obtains stream_lock_ but does not release it because it is blocked on writing to the stream that is not read from. - CloseStream() does not close the stream because it waits on the lock that WriteToStream() is not releasing. I will remove the lock alltogether. So, CloseStream() does not wait and just closes the stream. Then, if the BlockingCopyFromString() statement of WriteToStream() is blocked, it will be signaled that the stream is closed. It is not a perfect solution because if CloseStream() closes the stream after the "if (stream_.is_valid())" check of WriteToStream() but before BlockingCopyFromString() reaches the wait statement, the stream handle becomes invalid and a DCHECK will fail. I cannot think of a simple solution right now, but the above-mentioned scenario is very unlikely to happen. For sure, this CL improves the current flakiness. Bug: 837215 Change-Id: I5d064b93dfb6af444c778bb60f156b29b43f1617 Reviewed-on: https://chromium-review.googlesource.com/1054092 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#557677}
-
Leonard Grey authored
Currently, all clicks on a bookmark folder button trigger their action on mouse down, so that the folder menu can open on mouse down as expected. This also includes command click, which, rather than opening the folder menu, opens all the bookmarks in the folder as new tabs. This isn't desirable since: - The expected behavior is that button clicks trigger on mouse up. - Triggering this on mouse down interacts poorly with the nested run loop created by the confirmation dialog we display when the folder has many links. This change causes the action to no longer fire on mouse down if the user is command-clicking the folder button. Bug: 840387 Change-Id: Ic1364160cf26f2f3ea6e67d7dd0d6cf5079082eb Reviewed-on: https://chromium-review.googlesource.com/1053947Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557676}
-
Yuke Liao authored
This CL: 1. Updates out-dated comments about component build. 2. Makes sure logging is configured before it is called, otherwise, all logs will be eaten. Change-Id: Ibe3a162f55e0ab5dbf38ce33e0e192d79bb1057b Reviewed-on: https://chromium-review.googlesource.com/1054345Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
... since it's not overridden by embedder anymore. Bug: 775830 Change-Id: Ic719cb4f542785b5dc198900b3e0fca206ba5e86 Reviewed-on: https://chromium-review.googlesource.com/1045728 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557674}
-
Carlos IL authored
Change-Id: I09fe3e8759bba624fe1d39a796be32120de333de Reviewed-on: https://chromium-review.googlesource.com/1054368Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#557673}
-
Gabriel Charette authored
While having these enums since r396989 makes callsites more readable, I find that most of the time for simple use cases in tests I don't care much about the ResetPolicy (one time usage) and always want it to be NOT_SIGNALED initially. Surverying the codebase yields a slight majority of MANUAL over AUTOMATIC (from experience I've written AUTOMATIC in some places where it didn't matter either way as well). And NOT_SIGNALED is an obvious winner for InitialState. Also, IMO, MANUAL is the less-surprising default (i.e. can be used as a flag). As such I think having default arguments will vastly simplify writeability for code using WaitableEvents (tests in particular). Few sites will need to care and most that do will only need to specify the ResetPolicy. R=danakj@chromium.org Bug: 612843 Change-Id: Ib0ef193b041e64ea9456748633bc49c64af60f19 Reviewed-on: https://chromium-review.googlesource.com/1053843Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557672}
-
Stephen Lanham authored
This permission is needed on Cast devices, including Linux-based builds, but it was removed here: crrev.com/c/1045962. Restore it on Cast builds. BUG=b/79526220 Bug: 79526220 Test: CQ Change-Id: I0678a29e97eb003878db458dface608b6550d2fc Reviewed-on: https://chromium-review.googlesource.com/1054334Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
-
Reid Kleckner authored
Add a missing 'clang::' namespace qualifier. TBR=thakis@chromium.org NOTRY=True BUG=841908 Change-Id: I60e48efbfd92017a3802e9f74d77a9ddcb307b27 Reviewed-on: https://chromium-review.googlesource.com/1054527Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557670}
-
Fady Samuel authored
This CL removes the ChildLocalSurfaceIdAllocator on the Blink main thread. Instead, RenderWidget::DidAutoResize requests a new LocalSurfaceId from the impl thread and continues to use the current LocalSurfaceId provided by the parent. A test was removed that was intended for the pre-child-allocation code path and another was simplified to verify that DidAutoResize requests a new LocalSurfaceId. A separate unit test verifies that the request goes from LayerTreeHost to LayerTreeFrameSink. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8e11ac681aee1c5ea7fa6406d3c6cfd806b79986 Reviewed-on: https://chromium-review.googlesource.com/1051868Reviewed-by:
-
Ryan Tseng authored
This is done by reading the file in as a protobuf file, and then writing it back out again. No data is changed. Notable changes: * "field {" is used instead of "field: {" * All inner fields are ordered by field number, except for "header.id" * All extra spacing removed, except for top level spaces Bug: 840631 Change-Id: Ie91a27bf392834b2b186e9d354046f8eea059f11 Reviewed-on: https://chromium-review.googlesource.com/1053412 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#557668}
-
Pavol Marko authored
Keys that are stored on a user's public token are now recognized by GetKeyLocations. If no locations were found for a key, KeyPermissions::CanUserGrantPermissionsFor now returns false as a safeguard. A mechanism was introduced in nss_util.cc to simulate a separate private slot in Chrome OS browsertests. Bug: 839573 Test: browser_tests --gtest_filter=*PlatformKeysTest* Change-Id: If8b4cd4ef3a5763dd37a158426ec3cf87e1d10ae Reviewed-on: https://chromium-review.googlesource.com/1047208Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557667}
-
David Black authored
The fact that assistant controller is in Ash is self evident. Performing refactor now before code complexity increases. In the CL in which AshAssistantController was introduced, there was also going to be a ChromeAssistantController in browser. This did not actualize and there are no plans for a ChromeAssistantController so it is easier to refer to the singular AssistantController in ash. Bug: b:79493096 Change-Id: I5ff5150b3895274704ea18e20d149e13361b66b3 Reviewed-on: https://chromium-review.googlesource.com/1053365Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#557666}
-
Bence Béky authored
See discussion at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/PJOXupl9ztA Bug: 841899 Change-Id: I58158270f304c5e6d50a85d47e1d3f599b5870d5 Reviewed-on: https://chromium-review.googlesource.com/1053831 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Patrick Monette authored
This is to make the terminology consistent for all the classes related to the Incompatible Applications Warning, which is the name used in the UI. Tbr: pkasting@chromium.org,battre@chromium.org, dpapad@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id4ec87a73d67985458f38d623b7f10a4979d594b Reviewed-on: https://chromium-review.googlesource.com/993699 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#557664}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0a8d63a4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17253 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=markdittmer No-Export: true Change-Id: Ie6671a05bcacb0c331f1db4aa71e467b2fce751e Reviewed-on: https://chromium-review.googlesource.com/1053844 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557663}
-
