GitLab

Bug: 717812
Change-Id: I6d53865348171ba2fe777a8730b08248d05e7f26
Reviewed-on: https://chromium-review.googlesource.com/c/1344222
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613193}

https://pdfium.googlesource.com/pdfium.git/+log/4fbd264904eb..a44efb76a8a4


git log 4fbd264904eb..a44efb76a8a4 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 tsepez@chromium.org Add ability to append narrow strings to CFX_WideTextBuf.


Created with:
  gclient setdep -r src/third_party/pdfium@a44efb76a8a4

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4b730f25264f5f5ffe3ad56db523e2c79d8d8907
Reviewed-on: https://chromium-review.googlesource.com/c/1358803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613192}

The decomposition of a transformation matrix into translations, rotation, scale and skew transforms is not unique. In some cases, the generalized 3-D decomposition does not align with the working draft for CSS transforms (https://drafts.csswg.org/css-transforms/).



In the special case where the transforms being interpolated are both 2-D, a simplified model provides more restricted set of decomposition transforms with less computational overhead.

Bug: 797472
Change-Id: I2b8ba99fe02c2eef878d94f5dfaea55c39652759
Reviewed-on: https://chromium-review.googlesource.com/c/1332253
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613191}

https://skia.googlesource.com/skia.git/+log/b13658891bbd..45723ac93149


git log b13658891bbd..45723ac93149 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 egdaniel@google.com Take into accout the GrBackendFormat when deciding if we can chain textures together.
2018-12-03 reed@google.com update docs for MakeFromString and SkTextEncoding
2018-12-03 brianosman@google.com Fix two GPU image filters handling of subset inputs
2018-12-03 egdaniel@google.com Reland "Add support for Ycbcr Conversion Samplers in vulkan."
2018-12-03 reed@google.com flag to convert to SkTextEncoding


Created with:
  gclient setdep -r src/third_party/skia@45723ac93149

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:905548
TBR=jcgregorio@chromium.org

Change-Id: Ib31eec67290dbff8f2a826b06a7d825bf21a68d0
Reviewed-on: https://chromium-review.googlesource.com/c/1358757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613190}

Prevents showing cached favicons for the previous page during a timing
bug while it's connecting to the new page.

Bug: chromium:907642
Change-Id: Ifb1cfa75ed8fbc6842ec9811b2b92bd10d2442b5
Reviewed-on: https://chromium-review.googlesource.com/c/1358921Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613189}

Source: go/fieldtrial-testing-config#introduction (Google internal)

Bug: 910586
Change-Id: I9bdd750a5712437b952a1220ce5b175dfe4bb21c
Reviewed-on: https://chromium-review.googlesource.com/c/1357541Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613188}

This change also factors out TestTimerFactory to reuse code.

R=khorimoto@chromium.org

Bug: none
Test: DisconnectTetheringOperationTest.*
Change-Id: I5988d6bfdbf145511d9ea5c7451c31b9d929b753
Reviewed-on: https://chromium-review.googlesource.com/c/1357614
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613187}

Remove unhelpful UI modal that is displayed that just says "Configure
phone" which offers to connect to the phone again.  It doesn't seem
to be helpful.

Bug: 862794
Change-Id: I6637d9b9931f0ca1b38b6d57b9326a806dee923e
Reviewed-on: https://chromium-review.googlesource.com/c/1357529
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613186}

Add Release Actions endpoint as required by W3C spec, and connects the
endpoint to a partial implementation, which doesn't yet include the
processing of input cancel list.

Bug: chromedriver:1897
Change-Id: I8c00c6b76233ef325d562c3a5c123f5e94276064
Reviewed-on: https://chromium-review.googlesource.com/c/1357840Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613185}

This removes the need for dumpFrameLoadCallbacks(), which is difficult to make
consistent with and without site isolation

Bug: 619662
Change-Id: I94a553707c306eae4a755a2b2d3ddf45fa145bf7
Reviewed-on: https://chromium-review.googlesource.com/c/1354574Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613184}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=cmumford@chromium.org

Bug: 903957
Change-Id: I0e677a2f89f333b999d71fa83f15646a97c53fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1338415
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613183}

BUG=chromium:910802
TEST=none

Change-Id: I489c8a24e30aece1706af1b2e4e858187d8992fa
Reviewed-on: https://chromium-review.googlesource.com/c/1356965Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613182}

Remove unused ChromeMemex flag and associated code in preparation for
more Toolbar* refactoring.

BUG=

Change-Id: I3f4d2aaf0fba3ecea7806d3d36670cd815a94b21
Reviewed-on: https://chromium-review.googlesource.com/c/1358908Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613181}

Bug: 899318
Change-Id: Idffc1e1577058fcf273dcf4ad082a05814833d0c
Reviewed-on: https://chromium-review.googlesource.com/c/1351540
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613180}

mailto: URL scheme handling using Google UI launched in M67. Now is the
time to remove the legacy implementation.

Bug: 909726
Change-Id: I0ee2fa6ab0f34e51554898be8441d46b913c67a6
Reviewed-on: https://chromium-review.googlesource.com/c/1353895
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613179}

Instantiate TracingSamplerProfiler in RendererMain.

Change-Id: I527be13dcff3a58a4e60c8fe8ca21474515b91b0
Reviewed-on: https://chromium-review.googlesource.com/c/1336075Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613178}

R=jbudorick, martiniss

Bug: 790372
Change-Id: I56f5374182eaa3779459c05203ebb5cb1d94802f
Reviewed-on: https://chromium-review.googlesource.com/c/1359030Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613177}

NavigationItemCommitted is deprecated in favour of DidFinishNavigation.
This change will simplify transition from NavigationItemCommitted to
DidFinishNavigation, because DidFinishNavigation does not pass
NavigationItem as argument.

Bug: 720786
Change-Id: Ic71f49c687aa73957afc0033910dd028a2f942e9
Reviewed-on: https://chromium-review.googlesource.com/c/1356772
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613176}

Only do periodic WiFi scanning when WiFi is enabled.

Hide scanning progress bar as soon as user disables WiFi, even if a
scan is still in progress.

BUG=891947

Change-Id: Ica6cc4116f88743b24fb081b89886501ecd1d2d3
Reviewed-on: https://chromium-review.googlesource.com/c/1356027Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613175}

https://webrtc.googlesource.com/src.git/+log/aa3d8ad71b9d..056f9738bf7a


git log aa3d8ad71b9d..056f9738bf7a --date=short --no-merges --format='%ad %ae %s'
2018-12-03 solenberg@webrtc.org Remove CodecInst pt.1
2018-12-03 orphis@webrtc.org Encode frames at the largest layer resolution instead of last layer
2018-12-03 eladalon@webrtc.org RtcEventLogImpl nits


Created with:
  gclient setdep -r src/third_party/webrtc@056f9738bf7a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I09b50b7a8c0b254791d5b97067a84505c4bae463
Reviewed-on: https://chromium-review.googlesource.com/c/1358755Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613174}

This CL is kept minimal to facilitate merge to M72 (and potentially
M71).

Details on comments 14 and 15 on https://crbug.com/910274

A more complete solution addressing SkiaRenderer,SkDDL will come when
issue 902904 is resolved.

Bug: 910274
Change-Id: Ie0f44443fa30a5ec87045bd138a3a8a08e17e35c
Reviewed-on: https://chromium-review.googlesource.com/c/1358799Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613173}

In addition to fixing the DCHECK, this CL contains a speculative fix
for flaky test (crbug.com/907379). The guess for the flakiness is
(not able to repro the failure locally though):

|RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock|
when recording the CAI event, because the lock is being taken by
|UpdateExistingAccessPointRlz|. In tests, the delay for
|ScheduleDelayedInit| is set to zero, so it's possible for this race
condition to happen. But in production, the delay is non-zero.

I don't think we're losing test coverage by disabling
|UpdateExistingAccessPointRlz| here because the call is a no-op in
tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is
testing its implementation.

Bug: 906293, 907379
Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730
Reviewed-on: https://chromium-review.googlesource.com/c/1353990Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613172}

Tests that new page load calls NavigationItemsPruned callback if there
were forward navigation items.

Bug: 910894
Change-Id: I98bfd1a9960b99d0d7d8511b2b4068f56344b8d1
Reviewed-on: https://chromium-review.googlesource.com/c/1357841Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613171}

https://chromium.googlesource.com/angle/angle.git/+log/317a9ebdb019..c10a023a66f2


git log 317a9ebdb019..c10a023a66f2 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 jmadill@chromium.org Fix fuchsia build of libfeature_support.
2018-12-03 thakis@chromium.org List vulkan_core.h as input of generate_vulkan_layers_json.py.
2018-12-03 Tom.Tan@microsoft.com Don't copy d3dcompiler_47.dll when build target is Windows ARM64
2018-12-03 jmadill@chromium.org Refactor test shader style.
2018-11-30 syoussefi@chromium.org Vulkan: Add dynamic index buffers to graph
2018-11-30 ianelliott@google.com Version-2 API of the A4A opt-in/out (a.k.a. feature-support utilities)


Created with:
  gclient setdep -r src/third_party/angle@c10a023a66f2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:910699,chromium:869348,chromium:893460,chromium:b/113346561
TBR=ynovikov@chromium.org

Change-Id: I29ee936a536269990c413cdd50ad7d46601914a6
Reviewed-on: https://chromium-review.googlesource.com/c/1358758Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613170}

Similar to pull to refresh, pulling the suggestions to the right will
reset the keyboard and the manual fallback view.

Video: https://drive.google.com/file/d/1QpoiU3YPXdFhLQ_ubzZcyJ7VxVo86Zpv/view?usp=sharing

Bug: 845472, 911142
Change-Id: Ie13322d168dac81288d95a8e10a0bcb5bab59339
Reviewed-on: https://chromium-review.googlesource.com/c/1355188
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613169}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a21a7c53d9b2..7808a519be73


git log a21a7c53d9b2..7808a519be73 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 clemensh@chromium.org Fix typo in man page for git new-branch


Created with:
  gclient setdep -r src/third_party/depot_tools@7808a519be73

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ie82b94a503eda12fc79c6fc1d5d16e5d7c0cbf8b
Reviewed-on: https://chromium-review.googlesource.com/c/1358756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613168}

Bug: 841516
Change-Id: I53b327330283cc110eb9a23c68753781edfb4218
Reviewed-on: https://chromium-review.googlesource.com/c/1351274
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613167}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5199b83eef8b..d2eb15071cfa


Created with:
  gclient setdep -r src-internal@d2eb15071cfa

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icbc910923ffb4f795c4f7a486d6e132d27057130
Reviewed-on: https://chromium-review.googlesource.com/c/1358801Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613166}

On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be
called when task is in NSURLSessionTaskStateCompleted state. This
resulted in extra URLFetcherResponseWriter::Finish call (one from
didReceiveData: and one from didCompleteWithError:).
URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so
the test was flaky.

This CL changes DownloadTaskImpl to only call
URLFetcherResponseWriter::Finish from didCompleteWithError:.

Originally Reviewed-on: https://chromium-review.googlesource.com/c/1354233

Bug: 873204
Change-Id: Idece867d9d27c46a0deb57096144ed62df056901
Reviewed-on: https://chromium-review.googlesource.com/c/1355535Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613165}

It looks like the code that called this was removed over 4 years ago by
https://src.chromium.org/viewvc/chrome?revision=285521&view=revision

Change-Id: Ifd62e5c0750b7de02d0adc8c3fef487cb8a3d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1356322
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613164}

Our codes do not match the spec in calculating the animation effect
phases [1] and its active time [2]. This patch updated the current
implementation by spec and fixed the related layout tests.

[1] https://drafts.csswg.org/web-animations/#before-active-boundary-time
[2] https://drafts.csswg.org/web-animations/#calculating-the-active-time

Change-Id: Ia9ccea246835ddd2e2a3970d9279e008de9e699c
Bug: 909785
Reviewed-on: https://chromium-review.googlesource.com/c/1352710
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613163}

Change-Id: I663564ce66a7f41aef466d47373f89557992a2b6
Reviewed-on: https://chromium-review.googlesource.com/c/1358918Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613162}

This change instead updates the animation progress in delta-time
increments, which prevents a bunch of clock math and rewinding of start
timestamps.

Bug: None
Change-Id: I6848e3c3ca2d7c844f56f126d72c9b8420364b2a
Reviewed-on: https://chromium-review.googlesource.com/c/1356261
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613161}

HostFrameSinkManager::InvalidateFrameSinkId() can make a synchronous IPC
to ensure whatever is drawing the platform window is destroyed before
the platform window gets destroyed. However, while waiting for the
synchronous IPC response other synchronous IPCs continue to get
processed. |frame_sink_data_map_| can get mutated in response to a
different synchronous IPC and |data| may no longer point to a valid
memory location when DestroyCompositorFrameSink() returns.

Change the order so that all modifications to |data| happen before the
synchronous IPC. Also add a comment to clarify that FrameSinkIds
shouldn't be reused after they are invalidated. We don't do this today
and it would cause more re-entrancy problems.

Also switch |frame_sink_data_map_| to use std::unordered_map instead of
base::flat_map. This map can get large (tens of elements per open tab)
so std::unordered_map is probably a better choice.

Bug: 907211
Change-Id: Iea42d1eca290f5b61f215c66da9b9021f671c1e0
Reviewed-on: https://chromium-review.googlesource.com/c/1352525Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613160}

The fields are added to DRPPageLoadTiming and added to a submessage in
the pingback to make server-side analysis easier.

This also moves the ServerLitePageStatus enum out of PreviewsUserData
and into a common header for sake of layering.

Bug: 864665
Change-Id: I1844acd4f249397a70848a2d2c2b578e64a54034
Reviewed-on: https://chromium-review.googlesource.com/c/1356119
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613159}

We assume that SkColor <=> Color::Rgb(), so simplify the Color variant
accordingly.

PaintFlags are always passed as constant references, so pass it like
that to the PaintFlags variant too and remove the null-checks. Also
always explicitly copy the PaintFlags so that we get RVO.

Change-Id: I46b6f5aff7cbe175d6b9a2ff8277ff5ce9b4fce8
Reviewed-on: https://chromium-review.googlesource.com/c/1358497Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#613158}

This reverts commit 65e52ac6.

Reason for revert: This appears to be a bot only failure at the moment.

Original change's description:
> Reenable browser_tests InputImeApiTest.BasicApiTest
> 
> This seems to work fine on Linux with --gtest_repeat=10.
> 
> BUG=882338
> TBR=shuchen@chromium.org
> Reenabling a test.
> 
> Change-Id: I993856797c704a4b438402a97453d4e2b60f72f0
> Reviewed-on: https://chromium-review.googlesource.com/c/1356230
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612707}

TBR=robliao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 882338
Change-Id: Ibb22cec2bce9e309b3f8b081a745797910c4e992
Reviewed-on: https://chromium-review.googlesource.com/c/1358916Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613157}

We want to cross-check that we can see the impact of this fix on the
metrics we want to track long term. The fix unfortunately landed at
the same time as a tweak to these metrics and as such we missed that
opportunity the first time around.

This experiment will only be run for two days on Windows Canary.

This is a continuation of this CL by gab@:

https://chromium-review.googlesource.com/c/chromium/src/+/1347585/4

BUG: 890978
Change-Id: I8543d398ea804344dd160066c3f8f1638c7f5770
Reviewed-on: https://chromium-review.googlesource.com/c/1358800Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613156}

Presumably fixes UBSAN crasher. Seemingly so running locally with fuzzer
test case.

Bug: 904037
Change-Id: Ie5804e28835528e65caadbf43308260b961a92b7
Reviewed-on: https://chromium-review.googlesource.com/c/1358446Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613155}

Checking if log parser returns an empty value then
we should return 'command'

Change-Id: Ia6f2b583603f04183349a023365e13aceff95894
Reviewed-on: https://chromium-review.googlesource.com/c/1331950Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613154}