- 31 Jan, 2020 22 commits
-
-
Kenichi Ishibashi authored
This CL adds wrapper methods of following methods: * GetUserDataForAllRegistrations() * GetUserDataForAllRegistrationsByKeyPrefix() The purpose of this change is to reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Adding these wrappers moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage to ServiceWorkerRegistry. Bug: 1039200 Change-Id: Icda6119af51bd6bf9b045667762bf7523439a3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026833 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737145}
-
Alexander Alekseev authored
CfM devices default to static time zone. To expand this into user sessions, new users created on Chrome OS devices will default to static time zone. Otherwise static time zone was limited to signin screen only, which is not what was usually needed. Bug: 1018720 Change-Id: I977119e41238f29434b3a742b950ff7edb87ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030001 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737144}
-
Noel Gordon authored
Original design required --google-blue-100. Later designs changed that to --google-blue-50, so use that. Bug: 992819 Change-Id: I938da4450cd85d8dc921b69f5cf0f919c3ef672b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032484Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737143}
-
Li Lin authored
This CL includes: - Notify Quick Answers client when there is a network error. - Show an error message when notified that there is a error. (UI and message is not final). Bug: 1047042 Test: Unit tests Change-Id: I2e9c3618ef1965d2fe94cc10b04a9851fc7f366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029246Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737142}
-
Lambros Lambrou authored
The host permissions are already checked by the permission-wizard, before the Me2Me service helper starts the host binary. So there is no need to show the old dialog prompts here, particularly when the screen-capture heuristic may sometimes give false negatives. Bug: 1047528 Change-Id: I52c4c4ddec92cfe0db208ce82487cd9bda99ad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032408 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#737141}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ea79fbc6f6f..7fd0c00afadd Created with: gclient setdep -r src-internal@7fd0c00afadd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040871 Tbr: jbudorick@google.com Change-Id: Ic18efe2040748b307ed2dab4b6a319cbe1caf878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737140}
-
Charlene Yan authored
Bug: 1046659 Change-Id: I921cb71a530dd2e9754b64a01e750fa1f5defd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031940Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737139}
-
Allen Bauer authored
Change-Id: Ic7009c85824c74f3dd30dc9d84329c720b572172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032033 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737138}
-
Brandon Maslen authored
Bug: 989663 Change-Id: I3bdc8f4996905c9e57ba2fabc86dfe53301e2ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032051 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Auto-Submit: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737137}
-
Orin Jaworski authored
This CL creates a button row to present actionable items including keyword, tab switch, and pedals. No focus or keyboard handling is considered yet, but the buttons can appear and be clicked. Bug: 1046523 Change-Id: Iff25e0cf83ef711fbff42fe7295a81d91c4f3d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030044 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#737136}
-
Chris Harrelson authored
Change-Id: I1ad5ef4661d1932eb11f4626ef8cc6277700569e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031563Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737135}
-
Marijn Kruisselbrink authored
In addition to adding a basic implementation for an origin scoped permission model, this also changes how usage is determined when this new permission model is enabled to let the usage indicator show up for read-only access as well. The actual usage bubble doesn't entirely work with that yet, UX changes will be made in follow-up CLs. Also adds a UserAction flag not just to GetWritePermissionGrant but also GetReadPermissionGrant. This will be used to get/create permission grants when restoring a handle from IndexedDB (which will only be supported with the new permission model). Also extends the expiration of a bunch of related histograms till after the upcoming new origin trial. All of the mentioned changes are behind a flag, so this doesn't effect the behavior of anything we're shipping until we flip that flag. Bug: 984769 Change-Id: Ie1b7900c4f46b79a6f8115bdda066722fb669be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020614 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#737134}
-
Ahmed Mehfooz authored
Bug: 1046966 Change-Id: I7611a62da0a084471073546fe8390642b887c206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029490 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737133}
-
kdillon authored
Previously, the blink scheduler would run rendering at the same priority as most work on the main thread (eg. postMessage, timers, ect.) which could leave rendering to get starved by other tasks and cause visual lag.This change periodically prioritizes rendering, targeting a lower frame rate of 10 fps, in order to prevent rendering starvation (fixing issues like crbug.com/921335 and crbug.com/943621). Given good results during experimentation, we have decided to enable this behavior by default. This CL also has a small implementation change, using a TickClock to measure time between compositor tasks instead of posting a delayed task to serve as a countdown. Bug: 966177 Change-Id: I4956a9f5dbfb7258d8fdc8ad45e74f62db8917b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030124 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#737132}
-
Lukasz Anforowicz authored
Since r708618 we are using the initiator origin (rather than process lock fallback) for calculating request_initiator_site_lock. Because of this, it should be fine to enable BackToAboutBlank test even if we don't have a guarantee that all processes are locked. Bug: 888079 Change-Id: Ied1feaaff41dbc693416c9072f2f3d0849c7aabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031930Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737131}
-
Takumi Fujimoto authored
crrev.com/c/2006479 converts the supportedMediaCommands value type from bit array to string list. This CL updates CastMediaController to use the new type. Bug: 1045627 Change-Id: I3bf79cf6e34ff636449d260d0ea1474a23aa9c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023269Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#737130}
-
Alexander Alekseev authored
This CL adds new Ash.WM.WindowUnOccludedTime histogram to measure painting newly UnOccluded window paint time. Bug: 1031000 Change-Id: I8abd34cbf757f63f1af50f6be93c2f370d2547cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928078 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima (slow in TOK) <oshima@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#737129}
-
Eric Willigers authored
LaunchApplication() replaces OpenApplicationWindow and OpenApplicationTab. The user's preferred launch container for the web app (standalone window or browser tab) is used. If the app is not installed, a browser window opens at the new tab page. TBR=pbos@chromium.org Bug: 1003610, 1022556 Change-Id: I1655a944ac205a93c4ebfebef8c13e21da4cd79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897377 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#737128}
-
Donn Denman authored
Changes all references to the Contextual Search feature from "Tap to Search" to "Touch to Search", and renaming legacy references to "Tap". Also update the legacy description of how to use the feature that shows in the Settings preferences on how to refine the search. This has been broken for a long time -- it referenced an ability to seamlessly convert from the Overlay to a separate Tab that only worked pre-Hara. Now the description references promoting to a separate Tab to refine the search. BUG=957451,956277 Change-Id: Ie4c4153193c1a02763c36bf866c8c804baa79dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028856Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#737127}
-
Mike Dougherty authored
Xcode 11.3 includes iOS 12.4 and 13.3 simulators, so bots are updated from 12.2 and 13.1 respectively. CIPD packages: infra_internal/ios/xcode/mac 11c29 infra_internal/ios/xcode/ios 11c29 Bug: 1041618 Change-Id: Iffbb393d0957a443f32092396a40a17647c5d0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028249Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737126}
-
Kenichi Ishibashi authored
The fix is landed. Enable the test. Bug: 1043481 Change-Id: I024aa915c694dc77f090bbff727c040dd3044ce8 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032284Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737125}
-
Rouslan Solomakhin authored
This patch sets card use count and last use date using PaymentPreferenceUtil instead of AutofillHelper, because PaymentRequestImpl uses the counts and dates from PaymentPreferenceUtil when calculating frecency score for ordering cards. Bug: 1045774 Change-Id: Ia58783d6889a670ccae057e68dc488013221ff89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031046Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737124}
-
- 30 Jan, 2020 18 commits
-
-
Mitsuru Oshima authored
* The size and scale factor in Display and DisplayInfo could be different in the past, but they're now always the same, except for the unified desktop mode. * panel_rotation() was added recently so use it instead of DisplayInfo::GetLogicalActiveRotation(); ImageCursor can get the panel's orientation from display and no need to create a fake display. Bug: None Test: No functional change. All tests passes. Change-Id: I1a3dd26f96dd201eefcd58841e185eed6ab514ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994672Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Mitsuru Oshima (slow in TOK) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#737123}
-
Robert Sesek authored
In 1e1812f8, the ClipboardHost was moved to the frame's interface broker. But the implementation of CopyToFindPboard() was still attempting to get the ClipboardHost via the process's interface broker, which no longer provides it. Test: Added RenderFrameHostImplBrowserMacTest.CopyToFindPasteboard Bug: 1045982 Change-Id: I7f26f27c20dd96475ae416c9b7c34f79941082be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031672Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737122}
-
Yuichiro Hanada authored
The iterator is possibly invalidated when it's used for erase() because calling CloseLauncherItem() might cause calling OnItemDelegateDiscarded() and the item pointed by the iterator is deleted in it. The similar fix for AppServiceAppWindowArcTracker was made in crrev.com/c/2006899. Bug: b/147206658 Change-Id: I904557a985003ff647f6f246e8d6b53f326f7e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016768Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#737121}
-
Christopher Thompson authored
Change-Id: Id399dee81e49b28339ef321bcc415f31016088f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032052Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#737120}
-
Regan Hsu authored
This CL moves AddDateTimeStrings from browser settings to OS Settings. Browser settings does not use any of those strings. Bug: 967888 Change-Id: I5f0280c117fdcaacb7b0108e31209280827252e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032053Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737119}
-
Alan Cutter authored
This reverts commit 1f961201. Reason for revert: Speculative suspicion this CL didn't cause the fuchsia failures. BUG=1044617e Original change's description: > Revert "Move ManifestUpdateManager and ManifestUpdateTask into web_application:common" > > This reverts commit 68ea97aa. > > Reason for revert: Speculative; suspected root cause of Deterministic Fuchsia failures. > > BUG=1044617e > > Original change's description: > > Move ManifestUpdateManager and ManifestUpdateTask into web_application:common > > > > ManifestUpdateManager and ManifestUpdateTask are not used outside of > > web_applications and are not isolated components, they should live one > > level up while maintaining independence from the BMO/Extension backend. > > > > This CL is in preparation to add a dependency from > > ManifestUpdateManager to SystemWebAppManager. > > > > Bug: 1035242 > > Change-Id: I3a5e8e691079619e5b063ac90653dcae6ee3f76f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973441 > > Auto-Submit: Alan Cutter <alancutter@chromium.org> > > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#733898} > > TBR=alancutter@chromium.org,loyso@chromium.org > > Change-Id: Ie1a4f075a6515b85effd5c853b82d7daeb2aa7b9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1035242 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014922 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734033} TBR=alancutter@chromium.org,loyso@chromium.org,olka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044617e, 1035242 Change-Id: I903e50bfdb95d7f703384a42dd09c177a9cdf5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029530Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#737118}
-
Ovidio Henriquez authored
This change deprecates the Geolocation.GeolocationDispatcherHostImpl.EnableHighAccuracy histogram because it is not longer valuable to keep the metric around. Bug: 1036861 Change-Id: I065a4eeca8aaeb8030c1ed983bc7afc92ed09312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025325Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737117}
-
David Black authored
The number of conversation starters should not exceed our stated max. Note that this CL also updates names of some unittests which contained "_" in their names (which is discouraged). Bug: b:148246719 Change-Id: I01ea72c5ba5967ec489a170c5a6a799de56a731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031666Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#737116}
-
Alex Cooper authored
Fixed: 1043224 Change-Id: Idbdee58a5fc733055bf1cb0de095b3c36ded5b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029330 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#737115}
-
Xi Han authored
The TabContentManager provides APIs to fetch Tab thumbnails from disk, and we want to reuse these APIs in instant start. Thus, we split the creation of TabContentManager into two parts: 1. creation: the constructor is called right after the TabModel is initialized (pre-native). 2. initWithNative: is called after native is initialized. Also, add test fetchThumbnailsPreNativeTest() to verify that the TabContentManager works properly without native initialization. Bug: 1041865 Change-Id: I22eca912f396acf234118a27348edbd7054cdd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992341 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737114}
-
Carlos IL authored
In Android webview, with committed interstitials enabled, the onSafeBrowsingHit callback was called again after proceeding through an interstitial. This adds a check that omits the call if the user is coming from an interstitial and the site is already allowlisted. This also adds a check for the extra call in an existing test. Bug: 1047477 Change-Id: Ifd6e9c59218b3c53f24c31f027681685ffd15333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031671 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737113}
-
rajendrant authored
Bug: 1037037 Change-Id: I8fdb2d9d2011131a88e62e2cb03a5f1df5b9c6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032009 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737112}
-
Adam Langley authored
When the native Windows API is in use, there's no point in being able to go "back" to the transport selection sheet because the only entry will be "Your phone". The native API can be triggered by the drop-down list. BUG=1002262 Change-Id: I4791542c9e18f5214deee211dc6afcac22cacdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032012 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#737111}
-
Tricia Crichton authored
ProcessNextMessage uses a 10 minute timeout as well as the user defined timeout. But the command returns timeout after the shortest timeout expires, so a user timeout of greater than 10 minutes has no effect. This cl uses the default timeout only if the user timeout has not been set. Bug: chromedriver:3312 Change-Id: Icadfdcd150ad7006077a3fff8c0469622297ffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028727Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#737110}
-
Eric Orth authored
This object stores per-context state for use in host resolution. In subsequent CLs, it will be passed through the stack instead of how raw URLRequestContext* is passed today. Will soon be responsible for some data currently stored per-session in DnsSession (in this CL, implementing the DoH probe results, but not yet using the moved results). Because that data will be both per-context and per-session, but because we really only care about it in the most recent "active" session, ResolveContext keeps track of the "current" session and compares session on manipulation or retrieval of the per-session data. Bug: 1022059 Change-Id: Iad75fd590c929357415cce1aee2984355a7df251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003256 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737109}
-
Daniel Rubery authored
If the URL is whitelisted, or the file is known to be dangerous, we should not perform malware scanning. We still should perform DLP scanning, if it's enabled. Change-Id: I568602ef3ad3826413fe75b10a792a511fa05e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030052 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737108}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/691480bbcc7d..58ad98201e2e git log 691480bbcc7d..58ad98201e2e --date=short --first-parent --format='%ad %ae %s' 2020-01-30 treehugger-gerrit@google.com Merge "service: Fix verification of SMB/page sizes" 2020-01-30 fmayer@google.com Remove stale TODO. 2020-01-30 lalitm@google.com Merge "tp: return both the id and row index when inserting into tables" 2020-01-30 fmayer@google.com Merge "Disallow clicking on [merged]." 2020-01-30 fmayer@google.com Check on type mismatch in pprof_builder. Created with: gclient setdep -r src/third_party/perfetto@58ad98201e2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic54cab2ed731b80e6ef857bc0be03147506dd02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737107}
-
Stephen Chenney authored
Currently the enum for document lifecycle update reasons, used in metrics, is duplicated in third_party/blink/public/web/web_widget.h and third_party/blink/renderer/core/dom/document_lifecycle.h. The number of reasons is about to expand significantly to enable better metrics and it is very bad form to duplicate such a large enum. So centralize the enum in third_party/blink/public/common. Bug: 902436 Change-Id: I97767e51a67bdeddf8b5e4df2a6e7af98d5cadcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028193Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#737106}
-