GitLab

BUG=231273
TEST=pass all existing tests

Review URL: https://codereview.chromium.org/13929012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194552 0039d316-1c4b-4281-b951-d872f2087c98

This patch is just for setting up the interface. Actual code
to fire each event will come soon.

BUG=154243
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/14148006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194551 0039d316-1c4b-4281-b951-d872f2087c98

Broken data should be detected and cleared during initialization to avoid fatal bugs.

BUG=232054
TEST=unit_tests

Review URL: https://codereview.chromium.org/14167009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194550 0039d316-1c4b-4281-b951-d872f2087c98

This wires up the standard ConfigurationPolicyProviderTest suite with a
PolicyLoaderWin that is reading policy from GPO PReg files.

BUG=chromium:186445
TEST=unit tests

Review URL: https://codereview.chromium.org/13963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194547 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 194504 "Fix build break"
> 
> > Fix build break
> > R=shishir
> > 
> > Review URL: https://codereview.chromium.org/14307004
> 
> TBR=tburkard@chromium.org
> 
> Review URL: https://codereview.chromium.org/13933017

TBR=kjellander@google.com

Review URL: https://codereview.chromium.org/14235016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194542 0039d316-1c4b-4281-b951-d872f2087c98

> Fix build break
> R=shishir
> 
> Review URL: https://codereview.chromium.org/14307004

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/13933017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194541 0039d316-1c4b-4281-b951-d872f2087c98

Added Unit test to close the socket during spdy_session's
read and verifying that getting new URLs from the same
network session don't result in a failure.

Modified mock socket code to close the connection if
mock_read closes the connection (because of ERR_CONNECTION_CLOSED error).

Implement greedy approach to read all the data and process
it from the ClientSocket until we block.

Implemented the greedy approach to improves the network
stack performance on the mobile.

spdy_session_test_util.* files have the common code between
SpdySessionSpd2Test and SpdySessionSpd3Test.  Created this
file to reduce errors and to avoid duplicating of code.

Review URL: https://chromiumcodereview.appspot.com/11644088

The change adds a scoped_refptr to SpdySession in DoLoop
to clean up the state and to finish pending reads, in case
SpdyFramer receives GOAway and closes all streams.

DoReadComplete was holding the last reference before and
DoLoop was accessing the object after DoReadComplete deleted
the object at the end of the function.

Review URL: https://codereview.chromium.org/12212102

Added unit tests for use after free of SpdySession
and unit test to test yielding + async during Read.

A test that crashes when scoped_refptr to SpdySession
deleted from DoLoop.

Added the following test per rch@ to test interactions of
yielding + async during Read.

Do the following MockReads and verify all the data is
consumed and SpdySession has yielded during Read.

SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K
ASYNC 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K

Review URL: https://chromiumcodereview.appspot.com/12207122

Reverted URL: https://chromiumcodereview.appspot.com/13608003/

BUG=175574, 166958, 224701, 175069
R=rch@chromium.org, jar@chromium.org
TEST=network unit tests

Review URL: https://codereview.chromium.org/13834009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194540 0039d316-1c4b-4281-b951-d872f2087c98

The webNavigation API defines that the signals always arrive in that order.
However, the frame loader can finish loading the document before the parser
actually finished parsing. To work around this, we delay the finished load
signal until after parsing has finished.

BUG=230767
TEST=WebNavigationApiTest.SrcDoc doesn't fail flakily

Review URL: https://codereview.chromium.org/13929020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194539 0039d316-1c4b-4281-b951-d872f2087c98

I'm leaving in NaClProcessHost's enable_exception_handling_ field
because we will want to disable exception handling under PNaCl.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2401
TEST=inbrowser_test_runner in nacl_integration

Review URL: https://codereview.chromium.org/14122010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/13394004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194536 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/13926015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194534 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14096010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/13949012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194530 0039d316-1c4b-4281-b951-d872f2087c98

Move DriveFileSystem::NotifyFileSystemMounted() and
NotifyFileSystemToBeUnmounted() to DriveSystemServiceObserver
in favor of less things to have in DriveFileSystem

BUG=231788
TEST=none

Review URL: https://codereview.chromium.org/13866050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194529 0039d316-1c4b-4281-b951-d872f2087c98

Broke "Linux Tests (dbg)(2)" build.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/33655

[4808:4808:0416/202705:277959527:FATAL:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed 

The error is FATAL with a Debug build but ERROR with a Release build, hence linux_rel try bot passed:
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/117475/steps/interactive_ui_tests/logs/stdio

[10001:10001:0416/181034:1303866619:ERROR:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed

> Add InitWidgets() phase for GTK infobars.
> 
> This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown.  Currently, this generally happens at construction.  Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.
> 
> Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.
> 
> BUG=none
> TEST=none
> 
> Review URL: https://codereview.chromium.org/11775019

TBR=pkasting@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194528 0039d316-1c4b-4281-b951-d872f2087c98

Ports XMPP Invalidation code from drive_file_sync_service in /sync_file_system to /google_apis/drive_notification_manager so it can be shared between ChromeOS file manager and SyncFS.

Please note that to keep this patch streamlined I've only ported over the XMPP invalidation code for now and will port the polling logic in the next patch.

BUG=173339

Review URL: https://codereview.chromium.org/13866037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194526 0039d316-1c4b-4281-b951-d872f2087c98

This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown.  Currently, this generally happens at construction.  Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.

Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11775019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194525 0039d316-1c4b-4281-b951-d872f2087c98

unique function body.

Changed ShutdownWatchDogThread::Alarm's to call
ShutdownCrash(), so it does not get merged by the link time 
optimization.

R=jar@chromium.org, eroman@chromium.org
BUG=232080
Review URL: https://codereview.chromium.org/14250003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194524 0039d316-1c4b-4281-b951-d872f2087c98

* Use ldd to detect chrome for cros local builds. 
* Add browser types debug-cros and release-cros for chrome for cros on linux. 
* Remove browser option --cros-desktop 

BUG=229692
TEST=run_tests works with cros-debug going through the login flow. 
NOTRY=True
Review URL: https://codereview.chromium.org/13891011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194522 0039d316-1c4b-4281-b951-d872f2087c98

Changing ContentBrowserClient::GetAdditionalAllowedSchemesForFileSystem()
not to return std::vector<std::string> as return value (but as an out
parameter) to follow the coding convention.

A follow-up patch for https://chromiumcodereview.appspot.com/13415006

BUG=none
TEST=no new tests as no behavioral changes

Review URL: https://codereview.chromium.org/14200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230968
TEST=Lauch Chrome on Mac with instant extended. Ensure you have no bookmark. On the NTP observe that the "Apps" button does not overlap the empty bookmark bar message.

Review URL: https://codereview.chromium.org/14262013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194516 0039d316-1c4b-4281-b951-d872f2087c98

navigating forward / back to a page generated by a
POST that can not be retrieved from the CACHE.

This was broken (knowingly) in revision 191712
(https://codereview.chromium.org/12277011/).

BUG=174194,226909

Review URL: https://codereview.chromium.org/13811022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194514 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194513 0039d316-1c4b-4281-b951-d872f2087c98

TBR=haraken

Review URL: https://codereview.chromium.org/13972013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194512 0039d316-1c4b-4281-b951-d872f2087c98

We weren't adding apps to the installed_app set when it doesn't have
any storage permissions.

BUG=231167
TEST=ExtensionSpecialStoragePolicyTest.IsInstalled

Review URL: https://codereview.chromium.org/13994010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194511 0039d316-1c4b-4281-b951-d872f2087c98

This fixes two issues related to OnRepaint (window damage) messages:

1.) In the case of a renderer-resized widget, the browser's information about
the size of the widget could be out of date. If the browser widget was asked to
paint in compositing mode before it received the proper size it could send a
ViewMsg_OnRepaint with 0x0 size and then set repaint_ack_pending_, expecting the
renderer to reply. The renderer wasn't actually replying with a frame since
damaging a 0x0 rect doesn't actually require painting anything. This suppresses
sending the OnRepaint message if the browser's size is 0x0. Either the size will
at some point become 0x0, triggering a repaint, or the user will never see it.

2.) In compositing mode on the renderer side we weren't plumbing the OnRepaint
window damage rect properly in to the compositor. Thus the compositor could end
up not producing a frame after receiving an OnRepaint message, confusing the
browser rate limiting logic greatly.

BUG=230766

Review URL: https://codereview.chromium.org/13926009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194510 0039d316-1c4b-4281-b951-d872f2087c98

on mouse over) when a network error happens in an iframe.

Also add the same icon to the main frame error page.

BUG=174194
Review URL: https://codereview.chromium.org/13737002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194509 0039d316-1c4b-4281-b951-d872f2087c98

R=piman
BUG=231715

Review URL: https://codereview.chromium.org/14065015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194508 0039d316-1c4b-4281-b951-d872f2087c98

Broke x64 compile.

> intsafe workaround to separate header
> 
> Allows workaround to work without precompiled headers (as in
> buildtype=Official)
> 
> R=cpu@chromium.org
> BUG=225822
> 
> Review URL: https://codereview.chromium.org/14201003

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13977005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194507 0039d316-1c4b-4281-b951-d872f2087c98

Allows workaround to work without precompiled headers (as in
buildtype=Official)

R=cpu@chromium.org
BUG=225822

Review URL: https://codereview.chromium.org/14201003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194506 0039d316-1c4b-4281-b951-d872f2087c98

> Add the LoggedIn Predictor, to detect which websites a user is likely
> logged into (or has been logged into).
> R=shishir@chromium.org, bauerb@chromium.org
> 
> Review URL: https://codereview.chromium.org/13903018

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/13995007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194505 0039d316-1c4b-4281-b951-d872f2087c98

R=shishir

Review URL: https://codereview.chromium.org/14307004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194504 0039d316-1c4b-4281-b951-d872f2087c98

Reverting seems to fix memory_test test locally on linux.

BUG=230085

> Revert r192949 "Disable shader disk cache by default."
> 
> This reverts commit r192949. The disable has been merged into
> M27 so re-enabling on trunk.
> 
> BUG=228989
> 
> Review URL: https://chromiumcodereview.appspot.com/13872012

TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/13924005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194503 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160311
TBR=ben

Review URL: https://codereview.chromium.org/13998026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194499 0039d316-1c4b-4281-b951-d872f2087c98

These were introduced in https://codereview.chromium.org/13932025/.

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/14081007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/14148004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194497 0039d316-1c4b-4281-b951-d872f2087c98

Add ChangeListLoader::CheckForUpdates()
Make ChangeListLoader::LoadFromServerIfNeeded() private.

BUG=193417
TEST=Open Drive in Files.app; Ctrl-click-on the gear menu and select 'Reload'. Confirm that the files appear shortly.

Review URL: https://codereview.chromium.org/14292002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194496 0039d316-1c4b-4281-b951-d872f2087c98