GitLab

Add a NotificationItemView::NotificationItemViewDelegate, which:
 - Activates notifications.
 - Acts as the SlideOutController::Delegate.
 - Allows for easier testing of NotificationMenuView.

Make NotificationMenuController a NotificationItemViewDelegate.

Pass NotificationMenuController AppMenuModelAdapter:
 - Allows NotificationMenuController to close the menu.

Also added tests.

Bug: 843761
Change-Id: I20474838a0fb5360196a3d0585b7e84620b86e9f
Reviewed-on: https://chromium-review.googlesource.com/1120842
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571993}

- Private constructor for ref-counted class.
- Remove redundant includes.
- Minor style fixes and TODOs.
- Add platform_export.h where needed.

Bug: 783309
Change-Id: I14cc00ef31526ae76f692fd48e3045fa483edb13
Reviewed-on: https://chromium-review.googlesource.com/1122976Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571992}

Bug: 783309
Change-Id: I92091b358d312b12c9fd88f26b4763dc984a6b33
Reviewed-on: https://chromium-review.googlesource.com/1122870
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571991}

Bug: 819372
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8e1dfc647673327587fbc5505488a68ebc62e139
Reviewed-on: https://chromium-review.googlesource.com/1123170
Commit-Queue: Aleks Totic <atotic@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571990}

Replaced contents are clipped by the content box. Normally this is not an
issue because we size the contents layer of a directly composited replaced
element to the clipped area. However in the case of a clip with rounded
corner, a clip still needs to be applied. Previously we incorrectly applied
the main layer state to its contents layer, which did not include the
rounded corner clip. This CL corrects that.

BUG=853943

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9a1a10e651ff2be73d43471ce94d85daf082f67
Reviewed-on: https://chromium-review.googlesource.com/1121538Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571989}

https://chromium.googlesource.com/catapult.git/+log/a14d6738e1fb..153acbd707c0


git log a14d6738e1fb..153acbd707c0 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps


Created with:
  gclient setdep -r src/third_party/catapult@153acbd707c0

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:845700
TBR=sullivan@chromium.org

Change-Id: If682edec4b9cced3c22128c14c89fde52554cc11
Reviewed-on: https://chromium-review.googlesource.com/1123136Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571988}

BUG=chromium:852089

Change-Id: Ie4222eb6ef0056a060a5101dae1ecdd04c091fbf
Reviewed-on: https://chromium-review.googlesource.com/1096289
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571987}

This CL adds WPT tests for http-equiv accept-ch header:
(1) The header is not honored on HTTP pages
(2) Malformed header is not honored
(3) When the header is present, client hints are attached only
    on the same-origin subresources, and not on cross-origin
    subresources in the same navigation.
(4) When the header is present, client hints are attached only
    on the same origin subresources, and not on subresources in
    a new navigation.

Bug: 856700
Change-Id: I3f82df8cd02816b06542256062eb291577ebe8b7
Reviewed-on: https://chromium-review.googlesource.com/1120953
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#571986}

https://pdfium.googlesource.com/pdfium.git/+log/e353d72449a9..319ef06b2f69


git log e353d72449a9..319ef06b2f69 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 tsepez@chromium.org Add pdfium::Vector2D<>()


Created with:
  gclient setdep -r src/third_party/pdfium@319ef06b2f69

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If115371f4c97a14e7e8b96d64bdf6103755fac95
Reviewed-on: https://chromium-review.googlesource.com/1122878Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571985}

TBR=carlosk@chromium.org

Bug: 859605
Change-Id: I8a4c2d01321437cb5c9386f1f2195b2761b8c413
Reviewed-on: https://chromium-review.googlesource.com/1123110Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571984}

https://skia.googlesource.com/skia.git/+log/3913287d8c2c..2309ee36a10b


git log 3913287d8c2c..2309ee36a10b --date=short --no-merges --format='%ad %ae %s'
2018-07-02 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-02 robertphillips@google.com Fix race condition in GrGLCaps
2018-07-02 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-02 brianosman@google.com Remove unused generateTextureProxyForParams
2018-07-02 robertphillips@google.com Don't reject stroked empty rrects in GPU backend


Created with:
  gclient setdep -r src/third_party/skia@2309ee36a10b

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:854778
TBR=ethannicholas@chromium.org

Change-Id: Icfc209e7d0de6aa858bd411eb6eecb853fe8e62c
Reviewed-on: https://chromium-review.googlesource.com/1123077Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571983}

Most of the code there isn't used when the network service is disabled,
and we decided to remove some of the histograms, rather than updating
them to work when the network service is enabled. We may bring some of
these back in the future.

The histograms this CL removes are:
Net.RequestTime2Success.MainFrame
Net.ErrAborted.SentBytes
Net.ErrAborted.ReceivedBytes
Net.RequestTime2Success.Subresource
Net.ResourceLoader.TimeToURLRequestStart

Bug: 859532
Change-Id: Ib48e2b50058771881ef5f1539a5f70d6f142922e
Reviewed-on: https://chromium-review.googlesource.com/1122702Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571982}

https://webrtc.googlesource.com/src.git/+log/9f2e62402443..4d01146f1679


git log 9f2e62402443..4d01146f1679 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 aleloi@webrtc.org Prepare AGC2 for analog gain changes.
2018-07-02 henrik.lundin@webrtc.org NetEq: Fold GetDecisionSpecialized into GetDecision


Created with:
  gclient setdep -r src/third_party/webrtc@4d01146f1679

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1e200264a4441ecf359b77595d22e8d0229a1496
Reviewed-on: https://chromium-review.googlesource.com/1122900Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571981}

Extensions relies upon the mojo bindings for resource_coordinator and
egagement. Add these explicitly to the BUILD.gn file.

Bug: 857027
Change-Id: I2e6a8c99ec6eda77a31c3747ba66d807809ae8f4
Reviewed-on: https://chromium-review.googlesource.com/1122972Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571980}

Make the Harmony dialog record the following metrics. These are existing
metrics already used by the WebUI dialog.

MediaRouter.Ui.Device.Count
MediaRouter.Ui.Action.StartLocalPosition
MediaRouter.Ui.Dialog.Paint

Bug: 853369
Change-Id: Ie49a969faa0d91ec8026a55b2f2be15dd25f26ea
Reviewed-on: https://chromium-review.googlesource.com/1119055
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571979}

This class is largely based on ReadingListCollectionViewController.
Rather than using a custom view for the toolbar, this class uses
ReadingListToolbarButtonManager to create toolbar items to display.

In addition, this CL adds a batch update selector to
ChromeTableViewController that optionally uses the iOS11 batch
functionality.

This CL also renamed ReadingListEmptyCollectionBackground to
EmptyReadingListBackgroundView since it's used by both table- and
collection-based implementations.

Bug: 805209
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id22a71d99748eacc5e6f6bf116a147e9cb39429b
Reviewed-on: https://chromium-review.googlesource.com/1110597
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571978}

This reverts commit 5e0c2251.

Reason for revert: This test will now be fixed as part of re-landing the QuitCurrent*Deprecated() cleanup.

Original change's description:
> Disable test that should be using the new API QuitClosure
> 
> TBR=wez@chromium.org
> NOTRY=True
> 
> Bug: 859151
> Change-Id: Id45c6e679ea50523e99a72cf9ae52a7bd1254286
> Reviewed-on: https://chromium-review.googlesource.com/1121631
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571755}

TBR=wez@chromium.org,yigu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 859151
Change-Id: I94df8df53bc4f58a9c676365db997ab920aa811d
Reviewed-on: https://chromium-review.googlesource.com/1122937Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571977}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3230c43892e..9626d3959de1


git log a3230c43892e..9626d3959de1 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 dgarrett@google.com generic_builders: Create generic_builder.ManifestVersionedBuilder.
2018-07-02 dgarrett@google.com cros_sdk_lib: Make CleanupChrootMount delete consistent.


Created with:
  gclient setdep -r src/third_party/chromite@9626d3959de1

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:855291,chromium:None
TBR=chrome-os-gardeners@chromium.org

Change-Id: I5f0f13d6c8d6a33856b339607d10a933f3517d97
Reviewed-on: https://chromium-review.googlesource.com/1123076Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571976}

Using wpt-import in Chromium 4db6f39b.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20620

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-scoping

TBR=kereliuk

No-Export: true
Change-Id: I32ef7db6ddce7affa78be49ac6daaa70522bef27
Reviewed-on: https://chromium-review.googlesource.com/1122969
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571975}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/079d2806..39f347b1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I6b6761fd02398509e246ece9c90b2f24f31957dc
Reviewed-on: https://chromium-review.googlesource.com/1123033Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571974}

This is no longer needed.

Bug: 859152
Change-Id: I31001d0a03b3ef5dfbea81f3d68f7d2d4af538a9
Reviewed-on: https://chromium-review.googlesource.com/1121957Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571973}

Change-Id: I2d2be9d78f2fdc36929fafac0986b4b58ca0efa2
Reviewed-on: https://chromium-review.googlesource.com/1121635
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571972}

+ Update button background, icon tint, toggles color to #1A73E8

Bug: 834884
Change-Id: I8f7ed70245926edcf8336cd962526463573df174
Reviewed-on: https://chromium-review.googlesource.com/1119200
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571971}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/621c9d28c3d0..d38a2da9f150


git log 621c9d28c3d0..d38a2da9f150 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 sergiyb@chromium.org Use cwd from context instead of kwargs


Created with:
  gclient setdep -r src/third_party/depot_tools@d38a2da9f150

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:793687
TBR=agable@chromium.org

Change-Id: I442d01dd680b1af267783424256013ba00b69252
Reviewed-on: https://chromium-review.googlesource.com/1122898Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571970}

Detect focus or blur in a more straight-forward way.

Bug: 857424
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5be06c7cdbdbaedf20a1c6bc9198bcc539c1be32
Reviewed-on: https://chromium-review.googlesource.com/1119160
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571969}

This reverts commit 89c5e790.

Reason for revert: Testing possible fixes

Original change's description:
> Revert "Reland "gtest perf tests: Output well formed test results json""
> 
> This reverts commit f02c92e1.
> 
> Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315
> 
> Original change's description:
> > Reland "gtest perf tests: Output well formed test results json"
> > 
> > This reverts commit 9eeaba4e.
> > 
> > Reason for revert: Will re-land with fix
> > 
> > Original change's description:
> > > Revert "gtest perf tests: Output well formed test results json"
> > > 
> > > This reverts commit 71b865f4.
> > > 
> > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> > > 
> > > Original change's description:
> > > > gtest perf tests: Output well formed test results json
> > > > 
> > > > This CL changes the run_gtest_perf_test.py script to output well formed
> > > > test results json.
> > > > 
> > > > Bug: 855234
> > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > > > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#570943}
> > > 
> > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > 
> > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 855234
> > > Reviewed-on: https://chromium-review.googlesource.com/1118238
> > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#571083}
> > 
> > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > 
> > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 855234
> > Reviewed-on: https://chromium-review.googlesource.com/1118789
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#571245}
> 
> TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> 
> Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1119445
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#571321}

TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1120798Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571968}

- Non-empty text filters retain their blue outline even when not
  focused.
- Searching the the StylesSidebarPane no longer highlights the
  toolbar yellow, just the selector/prop matches.

Screenshots:
https://imgur.com/a/suybNVy
https://imgur.com/a/s0R04ar

Bug: 808159
Change-Id: I7dc5b89ca96ca181e767bd271cd648bee4cb0ca1
Reviewed-on: https://chromium-review.googlesource.com/1060574Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571967}

Bug: 854009
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I79ac7258d3b35541f0c87188e0cfe944e31635d9
Reviewed-on: https://chromium-review.googlesource.com/1122958Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571966}

https://chromium.googlesource.com/catapult.git/+log/3836c556c4c6..a14d6738e1fb


git log 3836c556c4c6..a14d6738e1fb --date=short --no-merges --format='%ad %ae %s'
2018-07-02 nednguyen@google.com Rename benchmark @Owner decorator to @Info decorator


Created with:
  gclient setdep -r src/third_party/catapult@a14d6738e1fb

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:859524
TBR=sullivan@chromium.org

Change-Id: Id18e3580f596b177fa3173041ddd596bb3d638de
Reviewed-on: https://chromium-review.googlesource.com/1122996Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571965}

CachingCertVerifier::AddEntry is now dead code after r571588

BUG=590875

Change-Id: I4e5bc5845e7ca33972e768ae619033f447cda744
Reviewed-on: https://chromium-review.googlesource.com/1122696Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571964}

Bug: 859233
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifefe2b4f1b25627c53a467c27937271de9efe450
Reviewed-on: https://chromium-review.googlesource.com/1121584
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571963}

Bug: 831648
Change-Id: I2ca7dd2fd1422fa44b0b5e297a0ba8bd7ac196e3
Reviewed-on: https://chromium-review.googlesource.com/1102003
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571962}

I have confirmed that the unused adjusted_paint_offset is not a code
error. It had been used to calculate bounds of DrawingRecorder before
https://chromium-review.googlesource.com/729322.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9f0c71e36842e30f9c96fd093f209c90a276209
Reviewed-on: https://chromium-review.googlesource.com/1122965Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571961}

This CL updates ReadingListMediator to support both UICollectionViews
and UITableViews.  Additionally, ReadingListDataSource and
ReadingListDataSink have been updated to use ReadingListListItems
rather than CollectionViewItems.

ReadingListMediator now takes a ReadingListListItemFactory, which
handles supplying the correct subclass of ListItem to the data sink.
This item factory will take ownership of the custom a11y action factory
as well.

Additionally, this CL moves ReadingListCollectionViewController to its
own file, and renames ReadingListListViewItem* classes to remove the
"View" in their names.

Bug: 805209
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4b22768212a03b661a8b60913948eed6116de461
Reviewed-on: https://chromium-review.googlesource.com/1104896
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571960}

Accessibility values are typically UTF-8 strings.

This addresses a comment on:
https://chromium-review.googlesource.com/c/chromium/src/+/1118828

TBR=rmrossi@chromium.org

Bug: 851578
Test: bots
Change-Id: I05f5cf68d5731b3c22956d86da3a2e865cd8bf1d
Reviewed-on: https://chromium-review.googlesource.com/1121539Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571959}

Bug: 855063,713357
Change-Id: I79e5e5eac6283493f0eb83771fe6edbde1a0496e
Reviewed-on: https://chromium-review.googlesource.com/1122843Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571958}

Change-Id: Ibd351ecb8565b9dc83fe4a6a4109c8fb376eeb7f
Reviewed-on: https://chromium-review.googlesource.com/1122713Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571957}

https://skia.googlesource.com/skia.git/+log/d818ebf4a317..3913287d8c2c


git log d818ebf4a317..3913287d8c2c --date=short --no-merges --format='%ad %ae %s'
2018-07-02 kjlubick@google.com Roll vpython to (speculatively) fix tree


Created with:
  gclient setdep -r src/third_party/skia@3913287d8c2c

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I3f50f60a259fb65e90ee80ffc6d93113f835678f
Reviewed-on: https://chromium-review.googlesource.com/1122899Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571956}

Allow users of BBR to change the high gain value for STARTUP.  Early versions of BBR used 2, which may be preferable for latency sensitive applications.
Merge internal change: 202484730

https://chromium-review.googlesource.com/c/1120507/

Add a comment to QuicConnection about why the send alarm is being cancelled.
Merge internal change: 202483358

https://chromium-review.googlesource.com/c/1120509/

Deprecate FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing4.
Merge internal change: 202125402

https://chromium-review.googlesource.com/c/1121698/

Instead of triggering early termination based on current smoothed rtt and the
rtt upon the start of most recent monitor interval, track the whole rtt
inflation period, during which the latest rtt sample keeps being larger than
smoothed rtt. This can avoid the case when the rtt inflation is within
tolerance with respect to the rtt upon the start of current interval, which in
the worst case can lead to continuous inflation until packet losses appear.
Update the pcc enable flag with a new one, so that we can check
that this change is protected by the new flag.
Merge internal change: 202030099

https://chromium-review.googlesource.com/c/1121697/

In QUIC, do not reset ideal_next_packet_send_time_ in pacing sender. Protected by FLAGS_quic_reloadable_flag_quic_donot_reset_ideal_next_packet_send_time.
Merge internal change: 201861910

https://chromium-review.googlesource.com/c/1121696/

Mark QUIC app-limited if we run out of data to write after writing retransmissions or queued packets.  Protected by FLAGS_quic_reloadable_flag_quic_retransmissions_app_limited.
Merge internal change: 201739950

https://chromium-review.googlesource.com/c/1121295/

Deprecate FLAGS_quic_reloadable_flag_quic_send_max_header_list_size.
Merge internal change: 201726616

https://chromium-review.googlesource.com/c/1121294/

Add a flag count for FLAGS_quic_reloadable_flags_quic_ack_reordered_packets.
Merge internal change: 201725762

https://chromium-review.googlesource.com/c/1121293/

Make sure to force a new port when doing H:P1 -> H:P2 migrations to
avoid the case that occurs when binding to the same port.
Merge internal change: 201717747

https://chromium-review.googlesource.com/c/1121292/

In QUIC, remove the code path closing connection after 3 RTOs. This has no effect as currently no client is sending the connection option.
Merge internal change: 201708082

https://chromium-review.googlesource.com/c/1121291/

Mark all QUIC BBR bandwidth samples in recovery as app-limited if recovery is entered while app-limited.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_app_limited_recovery.
Merge internal change: 201677811

https://chromium-review.googlesource.com/c/1121290/

Add QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_optimize_inflight_check.
Merge internal change: 201632376

https://chromium-review.googlesource.com/c/1121289/

Stop checking QuicUnackedPacketMap::HasUnackedRetransmittableFrames and instead rely on the existing check that bytes_in_flight > 0.  Protected by FLAGS_quic_reloadable_flag_quic_optimize_inflight_check.
Merge internal change: 201567200

https://chromium-review.googlesource.com/c/1121288/

In QUIC, ignore EMSGSIZE write error. Protected by
FLAGS_quic_reloadable_flag_quic_ignore_emsgsize_write_error.
Merge internal change: 201533812

https://chromium-review.googlesource.com/c/1121287/

Disable QUIC v42, protected by FLAGS_quic_reloadable_flag_quic_disable_version_42
Merge internal change: 201519801

https://chromium-review.googlesource.com/c/1121286/

In QuicWriteBlockedList, change static_streams_ from a QuicLinkedHashMap to a StaticStreamCollection. Protected by FLAGS_quic_reloadable_flag_quic_use_static_stream_collection_in_write_blocked_list.
A StaticStreamCollection is a vector of StreamIdBlockedPair(s) plus a eagerly-computed number of blocked static streams.
This is an optimization base on this profile from sof14: https://screenshot.googleplex.com/eaffXNhVcZ8. The parts in the red rectangle are optimized in this cl.
- Since number of static streams is small, and they don't change during the course of a QuicSession's lifetime, saving them into a vector ought to make iteration faster compared to QuicLinkedHashMap. This should make QuicWriteBlockedList::IsStreamBlocked faster.
- The eagerly-computed number of blocked static streams should make QuicWriteBlockedList::NumBlockedSpecialStreams must faster.
Merge internal change: 201519764

https://chromium-review.googlesource.com/c/1121285/

Only send an ack immediately when a previously missing packet is received if an ack with a larger largest acked has already been sent.  Protected by FLAGS_quic_reloadable_flag_quic_ack_reordering_packets.
Also renames QuicUnackedPacketMap::largest_observed_ to largest_acked_ for consistency with the new field.
Merge internal change: 201454269

https://chromium-review.googlesource.com/c/1121284/

Do not log when ack packets get out of order.
Merge internal change: 201249046

https://chromium-review.googlesource.com/c/1121283/

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_fix_probe_bw.
Merge internal change: 201246814

https://chromium-review.googlesource.com/c/1121281/

Disable QUIC v41. Protected by FLAGS_quic_reloadable_flag_quic_disable_version_41_2 (renamed from FLAGS_quic_reloadable_flag_quic_disable_version_41)
Merge internal change: 201241634

https://chromium-review.googlesource.com/c/1121280/

Make a constant drain gain in QUIC BBR settable via set_drain_gain.  Not flag protected, no functional change.
Merge internal change: 201230613

https://chromium-review.googlesource.com/c/1121279/

Removing unused rtt_variance_weight from QUIC's BBR implementation.  It was used when trying to fix BBR's bandwidth crashes due to lack of CWND and is no longer necessary.  No functional change, not flag protected.
Merge internal change: 201182279

https://chromium-review.googlesource.com/c/1121278/

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_slower_startup2.
Merge internal change: 201175853

https://chromium-review.googlesource.com/c/1120999/

Deprecate FLAGS_quic_reloadable_flag_quic_disable_version_38
Merge internal change: 201065250

https://chromium-review.googlesource.com/c/1120998/

Deprecate FLAGS_quic_reloadable_flag_quic_disable_version_37
Merge internal change: 201061334

https://chromium-review.googlesource.com/c/1120997/

Deprecate quic_enable_l1_munge flag.
Merge internal change: 201061065

https://chromium-review.googlesource.com/c/1120996/

R=rch@chromium.org

Change-Id: I44e2a62fe78e15d6a63c1ce9bc3984fb59cd9fc5
Reviewed-on: https://chromium-review.googlesource.com/1121700
Commit-Queue: Hasan Khalil <hkhalil@google.com>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571955}

The copy on GitHub is a canonical source of truth.  Originally, that
file was in Chromium source, but I was aware of third parties that were
interested in embedding it, so I moved it out to a separate repository.
It's currently only used in the unit tests, though it's possible it will
be used in stand-alone tool binaries in the future.

Change-Id: I74be47f2d317c949732eec44c432a36610650938
Reviewed-on: https://chromium-review.googlesource.com/1086967
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571954}