- 04 Aug, 2020 37 commits
-
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: none Change-Id: Ib7e881a73fbdb9ef73e1c94384e1c10cc56511ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334099 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794356}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dedfc814fbb..7eb25ea3b96d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1108963,chromium:1111132,chromium:1112125 Tbr: yutak@google.com Change-Id: I05f4100a7b90d97a0f719893408f42ba7ff334c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335829Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794355}
-
Keishi Hattori authored
Move WebFrame::SetOpener() to after Frame construction so we can move the WebFrame::opener_ field to Frame in a followup CL. LocalFrame::Init() uses the opener to set the security origin. So SetOpener() needs to be called after Frame construction but before LocalFrame::Init(). Bug: 1100056 Change-Id: Ic3967eaff904342983b561ce31889a301cfc8742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331957Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794354}
-
Yuheng Huang authored
This change makes close tab more responsive. Since TabStripModel::CloseWebContentsAt() mostly return false, how fast TabsChanged() is sent to the web/js side depends on the debounce timeout value. Bug: 1099917 Change-Id: Icd7c2a5bc45ba2b8361f8ccc5d61033ed0103462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335505 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#794353}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6b7d25eed32d..7e30909bf44a 2020-08-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5963c7d6..577fe5ff (794142:794277) 2020-08-03 titovartem@google.com Refactor PC level smoke test for adding new network stats reporter 2020-08-03 titovartem@webrtc.org Revert "Stop using RTPFragmentationHeader in sdk/android as unneeded" 2020-08-03 marinaciocea@webrtc.org Revert "Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader" 2020-08-03 philipp.hancke@googlemail.com sdp: reject sdp with malformed b= lines 2020-08-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision adcdc473..5963c7d6 (794031:794142) 2020-08-03 danilchap@webrtc.org Stop using RTPFragmentationHeader in sdk/android as unneeded 2020-08-03 philipel@webrtc.org Revert "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory." 2020-08-03 philipel@webrtc.org Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory. 2020-08-03 danilchap@webrtc.org Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader 2020-08-03 nisse@webrtc.org Delete old name ProcessAllMessageQueues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4afa3bbb44c4f80e2e4b5c47692e3140b528de4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794352}
-
Xinghui Lu authored
Move the FillRequestProto function into the base class. Add a virtual function named GetDMTokenString. For consumer requests, GetDMTokenString always returns an empty string; for enterprise requests, GetDMTokenString returns the value of the dm token. Bug: 1085261 Change-Id: I79e1ae6cdabb7e5024ef77798c8a608ac1c1ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321725Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794351}
-
Victor Costan authored
This CL removes some small differences in the plumbing used by //chrome/browser unit tests that use MockQuotaClient, and fixes clang-tidy warnings. This will make future changes around adapting Quota for the Storage Service easier to review. Change-Id: I16bec46206021629c615ed094f5335e454c393af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330073 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794350}
-
Aaron Colwell authored
This change refactors the extension code so that it stops relying on site URLs to get the StoragePartition for a specific extension ID. This is part of a larger effort to remove site URL usage around the codebase. - Added HasIsolatedStorage() to ExtensionsBrowserClient so that code in extensions/ could access the chrome/ specific logic for determining whether an extension requires isolated storage. - Moved StoragePartitionConfig logic into extensions/browser/ so it could be used by GetStoragePartitionForExtensionId(). - Reworked extensions::util::SiteHasIsolatedStorage() and extensions::util::HasIsolatedStorage() so that the latter has the real logic, and the former just extracts the extension_id from the site URL and calls the HasIsolatedStorage(). - Updated ChromeContentBrowserClient logic in terms of these new functions. Bug: 1085275 Change-Id: I9924e36137ccc7d9667e5040b7647b5bd7a8d067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328211 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#794349}
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: Ia5271e8dff20c316e5ca0391238c27480e83f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332064Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794348}
-
Alexey Baskakov authored
Minor fix for detection if transformation required. This was found while investigating the blurry icons bug. Bug: 1108889 Change-Id: I52514900d5c154983139a1a08c75b3505824a2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331962 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#794347}
-
Kyle Horimoto authored
This includes: (1) Adding 4 new mojom::Feature values: one for the top-level feature, and 3 for sub-features. (2) Adding new preferences for enabled/disabled state as well as enterprise policy state for these features. (3) Integrating these new values into FeatureStateManagerImpl. This process included adding some edge cases (e.g., disabling Phone Hub notifications implicitly disables the Phone Hub notification badge). (4) Adding relevant histograms and updating enum values. Note: Phone Hub will be opted out by default for existing users, but this CL just opts all users in by default. A future CL will implement this functionality. Bug: 1106937 Change-Id: Ia00c814bf81a2a3eaa2238c6caa95ab9a5332dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334398 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794346}
-
Maria Villarreal authored
Change got reverted since SessionRestoreTest.Basic failed on Mac. Since the test relies on focus, moving it to interactive_ui_tests. Description from original change (https://chromium-review.googlesource.com/c/chromium/src/+/2284382): Issue: - When On startup setting is set to "Continue where you left off", the initial focus is not set after launching the browser. - Users have to press Tab to focus the window. - This affects users who rely on screen readers since the window information is not announced on launch (on UIA mode). More context: - The line calling SetInitialFocus was previously in the code but got removed after a startup focus refactor: https://chromium-review.googlesource.com/c/chromium/src/+/1313728 - The refactor added the call to RestoreFocus on BrowserView::OnWidgetActivationChanged if the property restore_focus_on_activation_ is set to True. This property gets set during BrowserView::Show, but only in the case of session restore, Show gets called after OnWidgetActivationChanged so RestoreFocus is never called. - The inverted call stack on session restore is because AddRestoredTab on browser_tabrestore calls Activate before showing the window. Fix: - Similar to what we currently have for MacOS, only call Activate in AddRestoredTab if it is not |from_session_restore|. This way Show will be called before Activate and thus focus will be set as expected. - This change is only made on Windows due to a couple of reasons 1) crbug.com/1102685 is only present on this platform. 2) Making this change on Linux would re-introduce crbug.com/1019048. Bug: 1102685, 1110239, 1110240 Change-Id: Idc61e8ba713bf5a2deb23f085c0cdd08de30eb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324482 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794345}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d22c8786c90..1e1d958fbd8d 2020-08-03 joselea@microsoft.com Logic to log event for panel closed. 2020-08-03 jalyn@microsoft.com Fix Custom Shortcuts styles for narrow screens If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b69b895ca26a0095f018950dcd01c28619c6969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335818Reviewed-by:
-
Rakina Zata Amni authored
It's now possible to disable bfcache through an enterprise policy (and command line) as of crrev.com/c/2329107. We should track this on bfcache's NotRestoredReason metrics. We're also adding another NotRestoredReason for disabling due to low memory device. Bug: 511340 Change-Id: Iee9023549d6e57966362beebc8ccdfc1a2fba6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331994 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Mehrdad Hessar authored
Change-Id: I5130c97e01eaa7a8fe260058fe9c98740f1028b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321717 Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794342}
-
Evan Stade authored
The functionality provided is the same across all three delegates. Fold it into SecurityInterstitialPageController. Bug: 1073624 Change-Id: I060e9bf2a92bbd39e68ca8d2b431041a1acdc621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329156Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#794341}
-
Wei Li authored
LabelButtonLabel class is only used by LabelButton class. To be used in tests, it is still exported. This makes it clearer that this class should not be used externally. Bug: none Change-Id: I3ccf4adb118075dc57db3041f6de7018f5534c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324208Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#794340}
-
Tsuyoshi Horo authored
Bug: 1082020 Change-Id: I8c285e2638c88a3846d7456c341e12f9561b01b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332059Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794339}
-
minch authored
See spec at: https://drive.google.com/file/d/1R6AdSe7kIYzeVceTmVYN5jx567kQbdAh/view See pic with Japanese: https://drive.google.com/file/d/1tRNTMTzIHl-12bVsB0NXKzy5x_6-Zrun/view?usp=sharing Bug: 1076313, 1103952, 1104007, 1104008 Change-Id: I2a3515c6b4c7e8817acaf76fc87e9db9d83f6391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333489Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#794338}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2dc2064dda5..093de4eb2ca9 2020-08-03 reed@google.com Use more of pathbuilder 2020-08-03 jvanverth@google.com Revert "Revise GrMtlGpu::onUpdateBackendTexture." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7a1e94ea52f50b4fe8cc50d7ddb771ac48b03e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335798Reviewed-by:
-
Joel Hockey authored
Follow up with test for crrev.com/c/2316182 Bug: 1108710 Change-Id: I1e13c07dc4afb2d3f762d9361166a5005509326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316966 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#794336}
-
Kenichi Ishibashi authored
The method is used by ServiceWorkerRegistry and it creates a ServiceWorkerVersion in DidGetRegistrationsForOrigins(). The method should pass a ServiceWorkerLiveVersionRef so that a ServiceWorkerVersion can keep it during the lifetime of the ServiceWorkerVersion. This CL: * Merges SerializedServiceWorkerRegistration into ServiceWorkerFindRegistrationResult as these are almost the same. * Moves |status| out of ServiceWorkerFindRegistrationResult because it doesn't much make sense for GetRegistrationsForOrigin() * Tweaks ServiceWorkerStorageControlImpl to create ServiceWorkerLiveVersionRef for GetRegistrationsForOrigin() This CL doesn't pass a live version reference to ServiceWorkerVersion yet. A follow-up CL will pass the reference to it. Bug: 1055677 Change-Id: I408f741e7f6a199fdc162f4e68c98233b2b6a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331961 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f80ffe327978..ce6a663ce577 2020-08-03 bsheedy@chromium.org [Devil] Retry forwarder pkill on -9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: skyostil@google.com Change-Id: I4fb6325dc9aeffc1691bb07e8387d394ed154e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334681Reviewed-by:
-
Melissa Zhang authored
This CL adds app icons to the Sharesheet. It also removes the default margin in ShareActionView. Bug: 1097623 Change-Id: Ia9f58543d89863b97472fbbb11c6d499cad2ee25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331759Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1112086 Change-Id: I62b23330024900b444b7118635df87c5c567c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333872Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794332}
-
Bruce Dawson authored
If you are using a locally installed toolchain (DEPOT_TOOLS_WIN_TOOLCHAIN=0) then the behavior of gn gen depended on whether you had run vcvarsall.bat before running gn gen. That is because vcvarsall.bat appends to several environment variables, these appended values are captured by setup_toolchain.py, so running vcvarsall.bat affects the command line of commands generated by gn gen. This fixes that by clearing INCLUDE, LIB, and LIBPATH so that gn gen is hermetic. This was tested with VS 2019. Bug: 1112456 Change-Id: Ib2388466915d26033937004ddc5ca304f81e5d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333081 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#794331}
-
Jan Wilken Dörrie authored
This change is part of a series of changes that replacs usages of base::string16 with std::wstring in chrome/chrome_cleaner and fixes appropriate includes. This CL fixes the following subdirectories: * chrome/chrome_cleaner/chrome_utils * chrome/chrome_cleaner/components * chrome/chrome_cleaner/crash * chrome/chrome_cleaner/engines This change is a simple search and replace and does not effect any functionality. Bug: 911896 Change-Id: I55ff88d11aac9ae41da7d1d189a45558bc699e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332623 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#794330}
-
Jeroen Dhollander authored
See go/inclusive-codebase. The following words were replaced (if found): - blacklist - whitelist - dummy - sanity-check - he/she/her/him/her - slave - master (Note: still used as branch name for chromeos/assistant/internal, which I'll look at in another commit). - first-class - sane/crazy/insane/cripple - greylist/darklist/lightlist - grandfathered - (black|white|gray|grey) hat - redline - man-in-the-middle - white glove - white label The following directories were searched: - ash/ambient - ash/app_list/views/assistant - ash/assistant - ash/public/cpp/ambient - ash/quick_answers/ui - chrome/browser/chromeos/assistant - chrome/browser/ui/ash/ambient - chrome/browser/ui/ash/assistant - chromeos/assistant - chromeos/assistant/internal - chromeos/components/quick_answers - chromeos/services/assistant This list of directories was collected here: https://docs.google.com/spreadsheets/d/13RlCX_ezze2RwL3rAcgnS0LhGwvIHtw69UvTGyFDdf4/preview?ts=5f2862bf#gid=88888402 Bug: b/161801556 Change-Id: Ic4029c1826838b7cb92d4ca092dca55d34487bbb Tests: compiled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335502 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Tao Wu <wutao@chromium.org> Reviewed-by:
-
Sundoo Kim authored
This patch fixes typo to replace "becase" with "because" in the comment. Change-Id: Id1311e7ce21eabc307d810f9466a8ba28ea60b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332282Reviewed-by:
-
Peter Kasting authored
This is limited to callsites where the old code either looks buggy or using floating-point division (and then rounding) looks like it better achieves the code's underlying intent. Thus these are behavior changes, but hopefully desirable ones. Bug: 1104532 Change-Id: I087c6765fb5f23716322bf7ebd06c966d8a6dc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314873Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#794327}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/953fc9e3..f07b8c19 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2d5f5e6676c7e4a5617e93a5e4a69e0e06bc876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335674Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794326}
-
Kalvin Lee authored
This change moves the PpdMetadataManagerImpl into the anonymous namespace where it was originally intended to go. Bug: chromium:888189 Test: autoninja ... chrome{,os_unittests} Change-Id: I701f50c498a75123ad5a49bc3524fe2e575aaa76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315494Reviewed-by:Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#794325}
-
Alexander Cooper authored
Noticed a few VR directories that should probably trigger the bot, that the existing regex didn't catch. This updates the regex to include those directories. Primarily chrome/browser/android/vr and device/vr/android. Change-Id: I3b6bf0839d36c298685d2dec9f452b484b2a452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333045 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#794324}
-
Darwin Huang authored
Replace ClipboardFormatType's Equals() function with operator==. This should be more consistent with how Chrome classes tend to test for equality. Also, reorder some equality comparisons per Chromium C++ Style Guide[1] (foo == 0 vs 0 == foo). [1]: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#code-formatting Change-Id: Ia1089e838af392808116cb08410d66a69ca722ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333572 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794323}
-
Matthias Körber authored
This CL adds support to store and retrieve the new tokens of more structured names from the SQLite database. The tokens are stored along with their verification status and an additional bit that indicates if the profile uses the more-structured representation. If a profile is migrated from a legacy representation to the more-structured representation, only the full name is written to the profile to guarantee that the name can be completed using parsing heuristics. In case of a back-migration from a more-structured representation to the legacy representation, the new tokens are cleared from the datastore. Change-Id: I591e983dbfd23d6392832a1f6b7ed2e5dc2358b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327553 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
Currently, when running AAudioOutputStream unit tests, we set a flag, and leave it up to the AudioManager to choose which Android audio library it uses. We don't check whether or not we are actually using AAudio. This can result in running tests use OpenSLES, but are listed as AAudio tests when they fail. This CL explicitly checks whether we are using AAudio after setting the flags, and skips tests that fallback to OpenSLES. Bug: 1101283 Change-Id: I0e91c11f0f61c13ce1e68061f579b2637fb971ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335485 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794321}
-
Ben Pastene authored
This reverts commit e1c654b6. Reason for revert: blocking CQ: https://ci.chromium.org/p/chromium/builders/try/mac-arm64-rel?limit=200 Original change's description: > Infra: Adding mac-arm64 compile tryjob > > Bug: 1106950 > Change-Id: I38a6036187992765a077ad771f9c6ef7a4e1ee2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330650 > Commit-Queue: Gary Tong <gatong@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794316} TBR=gbeaty@chromium.org,gatong@chromium.org Change-Id: I80e9cba089b6cde5b26cd1330de1eab9c22eaf0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336178Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#794320}
-
- 03 Aug, 2020 3 commits
-
-
chrome://flagsDavid Trainor authored
Make it possible to easily test the reengagement notification. Bug: 1108002 Change-Id: I1fd85e9338164e55bea18b9e0208806aad47a996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335637 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#794319}
-
Dan Sanders authored
Bug: 1053033, 1088921, 1097906, 1097908, 1100370 Change-Id: Ie27bd532f160eae23a8371dd0e2ec5b744ebd0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321328Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#794318}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6f029c304ca..9a482652ab18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9968ce043abd930d458e6821cf4c042262dc1568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333040Reviewed-by:
-
