GitLab

GetDeviceSessionStatus() now generates information about the current active
kiosk session (if any).

BUG=430908

Review URL: https://codereview.chromium.org/907323002

Cr-Commit-Position: refs/heads/master@{#316567}

Back out 'using' declarations added in 7d588399.  These break
builds where host_clang=0:

BUG=385553

Review URL: https://codereview.chromium.org/921683005

Cr-Commit-Position: refs/heads/master@{#316566}

We used to initialize the command line flags prior to setting the
application context in Android's BrowserStartupController.

When determining the command line flags for the renderer, certain flags
may be dependent on the Android SDK version being used. Getting this value
through base::android::BuildInfo requires the application context to be known.

This change makes sure that we initialize the application context prior to
calling the native SetCommandLineFlags function.

BUG=

Review URL: https://codereview.chromium.org/925423002

Cr-Commit-Position: refs/heads/master@{#316565}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/43902e2..01edaba

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/928403002

Cr-Commit-Position: refs/heads/master@{#316564}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e66d39a6..066d1633

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/933843002

Cr-Commit-Position: refs/heads/master@{#316563}

Move the Java-implementation of Device Motion/Orientation/Light APIs
to run on the UI thread. This is to avoid a blocking call from the
IO thread to the UI thread inside DeviceSensors.java. That call can
lead to deadlock and hence is removed in this patch.

BUG=455767

Review URL: https://codereview.chromium.org/917253002

Cr-Commit-Position: refs/heads/master@{#316562}

BUG=456016
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/927333002

Cr-Commit-Position: refs/heads/master@{#316561}

This fixes sandbox_linux_unittests on Android.

TBR=jln@chromium.org
BUG=459158

Review URL: https://codereview.chromium.org/929213002

Cr-Commit-Position: refs/heads/master@{#316560}

Revert of Add a presubmit check that warns about declaring Singleton<T> in header files (patchset #2 id:20001 of https://codereview.chromium.org/929043002/)

Reason for revert:
Reverting because of presubmit crashes:

Traceback (most recent call last):
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2983, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2969, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/ssd/depot_tools/subcommand.py", line 245, in execute
    return command(parser, args[1:])
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 1614, in CMDpresubmit
    change=cl.GetChange(base_branch, None))
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 936, in RunHook
    rietveld_obj=self.RpcServer())
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1396, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1313, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 1727, in CheckChangeOnCommit
  File "<string>", line 1455, in _CommonChecks
  File "<string>", line 1322, in _CheckSingletonInHeaders
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 472, in ReadFile
    raise IOError('Access outside the repository root is denied.')
IOError: Access outside the repository root is denied.

Original issue's description:
> Add a presubmit check that warns about declaring Singleton<T> in header files
> (except for base/memory/singleton.h)
> This check is copied from presubmit_canned_checks.py in depot_tools/ with an
> added exception for base/memory/singleton.h.
> The corresponding code will be removed from presubmit_canned_checks.py afterwards.
>
> BUG=349861
> R=phajdan.jr@chromium.org,
>
> Committed: https://crrev.com/9b73d0393037452d13358f4e2766cb62adbdede8
> Cr-Commit-Position: refs/heads/master@{#316546}

TBR=phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=349861

Review URL: https://codereview.chromium.org/934723003

Cr-Commit-Position: refs/heads/master@{#316559}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ec53d7e..43902e2

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/931033004

Cr-Commit-Position: refs/heads/master@{#316558}

BUG=314221
TBR=jeremy@chromium.org

Review URL: https://codereview.chromium.org/927663004

Cr-Commit-Position: refs/heads/master@{#316557}

BUG=378158
TBR=erikchen@chromium.org

Review URL: https://codereview.chromium.org/921143004

Cr-Commit-Position: refs/heads/master@{#316556}

- Use pixel-perfect PNGs for icons on toolbar, instead of core-icons(SVG).
- Update hover/focus color to be visible on white and blue background.
- Change the shape of hover/focus background from square to circle.
- Some minor layout change to comply with the latest spec.

BUG=402344
TEST=manually compared with the mock.

Review URL: https://codereview.chromium.org/928353002

Cr-Commit-Position: refs/heads/master@{#316555}

Remove ygorshenin@ from OWNERS/TODOs, replace with
alemate/antrim/dpolukhin/bartfab

BUG=None
TBR=stevenjb@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/925963002

Cr-Commit-Position: refs/heads/master@{#316554}

BUG=456016
TEST=Open a grid view and edit an image. Thumbnail should be updated with animation.

Review URL: https://codereview.chromium.org/931103002

Cr-Commit-Position: refs/heads/master@{#316553}

1. Support PPB_CameraCapabilities_Private.GetSupportedPreviewSizes()
2. Implement basic skeleton of image capture PPAPI

BUG=387547
TEST=Call the API from a trusted plugin and print all preview
sizes.

Review URL: https://codereview.chromium.org/848863002

Cr-Commit-Position: refs/heads/master@{#316552}

BUG=459010

Review URL: https://codereview.chromium.org/934603002

Cr-Commit-Position: refs/heads/master@{#316551}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bfafa58..ec53d7e

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/935543002

Cr-Commit-Position: refs/heads/master@{#316550}

ToT clang now supports building for arm64 so remove the exception forcing
using Xcode clang when targeting arm64 (or fat binaries) on iOS.

BUG=341453

Review URL: https://codereview.chromium.org/932673002

Cr-Commit-Position: refs/heads/master@{#316549}

Previously Files.app can run out of local storage by copying files to Downloads.

The CL let fileManagerPrivate API call FreeDiskSpace before starting copy so
that it can secure available space by removing drive caches.

If it cannot secure available space, the API returns QuotaExceededError.

BUG=230283
TEST=FileSystemTest.FreeDiskSpaceIfNeededFor

Review URL: https://codereview.chromium.org/935513002

Cr-Commit-Position: refs/heads/master@{#316548}

The goal is to get rid of states "I'm opening the bubble now" as it should be an implementation detail of ManagePasswordsUIController.
For bubbles, which can be opened both automatically and later on user interaction, there should be exactly one state (like PENDING_PASSWORD_STATE).
For one-time automatic bubble there are two states. One is while the bubble is visible (e.g. CONFIRMATION_STATE). The second one is after it was closed (e.g. MANAGE_STATE).

BUG=400674
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/928753003

Cr-Commit-Position: refs/heads/master@{#316547}

(except for base/memory/singleton.h)
This check is copied from presubmit_canned_checks.py in depot_tools/ with an
added exception for base/memory/singleton.h.
The corresponding code will be removed from presubmit_canned_checks.py afterwards.

BUG=349861
R=phajdan.jr@chromium.org,

Review URL: https://codereview.chromium.org/929043002

Cr-Commit-Position: refs/heads/master@{#316546}

WebRTC 8372:8381
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/21b6665..8424b76

Libjingle 8369:8381
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/244a04e..f7067cb

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/916183004

Cr-Commit-Position: refs/heads/master@{#316545}

The only way to launch ephemeral apps after this patch is via the
webstore, and only if the kEnableEphemeralAppsInWebstore flag is set.

This is because ephemeral apps are not ready for release, and if/when
they are released for UX reasons theya should only be available from
the webstore.

BUG=459090

Review URL: https://codereview.chromium.org/934683002

Cr-Commit-Position: refs/heads/master@{#316544}

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/921683003

Cr-Commit-Position: refs/heads/master@{#316543}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4d01f64..bfafa58

TBR=tkent@chromium.org,schenney@chromium.org

Review URL: https://codereview.chromium.org/934683003

Cr-Commit-Position: refs/heads/master@{#316542}

Cr-Commit-Position: refs/heads/master@{#316541}

BUG=456016
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/934683004

Cr-Commit-Position: refs/heads/master@{#316540}

Child widgets/webcontents like to steal the event, so purge the
clickzone widget and use ShouldDescendIntoChildForEventHandling to
direct the events at the start page view.

BUG=455787

Review URL: https://codereview.chromium.org/913133007

Cr-Commit-Position: refs/heads/master@{#316539}

These are equivalent syntaxes, the latter is just newer and shorter
and more closely resembles C++/Java.

R=dmazzoni@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/924083004

Cr-Commit-Position: refs/heads/master@{#316538}

This should not make a visible change, but it is pre-emptive in case
tiling artifacts can be seen to the right or bottom edge of the image.

BUG=459088

Review URL: https://codereview.chromium.org/930143003

Cr-Commit-Position: refs/heads/master@{#316537}

BUG=456016
TEST=With opening a file manager, edit a file. Thumbnail will be updated.

Review URL: https://codereview.chromium.org/931603002

Cr-Commit-Position: refs/heads/master@{#316536}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9477637..4d01f64

TBR=tkent@chromium.org,schenney@chromium.org

Review URL: https://codereview.chromium.org/932793002

Cr-Commit-Position: refs/heads/master@{#316535}

BUG=458404

Review URL: https://codereview.chromium.org/926463002

Cr-Commit-Position: refs/heads/master@{#316534}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/512073f..9477637

TBR=tkent@chromium.org,schenney@chromium.org

Review URL: https://codereview.chromium.org/934703003

Cr-Commit-Position: refs/heads/master@{#316533}

R=asvitkine@chromium.org
BUG=chromium:441896

Review URL: https://codereview.chromium.org/930003002

Cr-Commit-Position: refs/heads/master@{#316532}

Currently whenever fitToPage is called on the viewport, it scrolls to
the top of the current page. But this isn't always correct. In the
case of resizing the viewport, we shouldn't change the scroll pos.
Setting the document dimensions also follows this codepath.

BUG=458050

Review URL: https://codereview.chromium.org/931013002

Cr-Commit-Position: refs/heads/master@{#316531}

Previously, the only public method to access tabs from TabList was by index
into an array. The problem with this method is that the array is dynamic, so
there's always the possibility of a race condition causing the index
dereference to explode.

The plan is to migrate the interface entirely over to accessing tabs by key.
For now, add a public method that allows access to tabs by key. Also, make tabs
return the same key as their id property.

BUG=398467, 442546

Review URL: https://codereview.chromium.org/915173012

Cr-Commit-Position: refs/heads/master@{#316530}

BUG=458700
TEST=Click on the edge of a directory item, and confirm that ripple effect fills whole item.

Review URL: https://codereview.chromium.org/928313002

Cr-Commit-Position: refs/heads/master@{#316529}

BUG=458913

Review URL: https://codereview.chromium.org/931043002

Cr-Commit-Position: refs/heads/master@{#316528}