GitLab

This introduces the concept of invocation type, which decides if
a reporter run should start immediately (if started by the user),
and if logs are allowed or disallowed by the user.

This also deprecates behaviour BEHAVIOUR_ALLOW_SEND_REPORTER_LOGS,
which should no longer be enabled by the reporter component
manifest.

To be sent in follow-up CLs:
 - cleaner logs from the scanner process based on user selection;
 - UMA histograms for the new flow;
 - UI changes to enable the new invocation type.

Bug: 776538
Change-Id: I0093826b450dd29625ac22ae5939d932bb04bb86
Reviewed-on: https://chromium-review.googlesource.com/770050Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519700}

MockOverscrollControllerImpl in browser_tests inherits from
OverscrollController in content/browser, but the class was
not exported, causing a build failure with is_component_build.

Change-Id: I9e3b893a23243e292fa94cc4441821631dafcca2
Reviewed-on: https://chromium-review.googlesource.com/788213Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#519699}

This class is responsible for cross-platform logic for exporting
passwords.

Bug: 785237
Change-Id: Idc3f77f66ba6211324d82415bb9d42328823b7e5
Reviewed-on: https://chromium-review.googlesource.com/782722
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519698}

This CL adds ShouldReconcileAccount() function on the
DiceAccountReconcilor delegate, that is used to revoke the tokens when
cookies are empty.

As a cleanup, the chrome_account_ member is changed to a local variable,
to reduce the amount of state in the AccountReconcilor, making it
hopefully more readable.

Bug: 788315
Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
Reviewed-on: https://chromium-review.googlesource.com/789032
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519697}

This CL uses the constrained sign-in screen when required to switch to a
full tab from the embedded dialog view. This ensures that programmatic
auth endpoint is not used when the user attempts to sign in with a SAML
account.

Bug: 789143
Change-Id: I6f72ae72d395f6de42e7267fc6edb538007a92c6
Reviewed-on: https://chromium-review.googlesource.com/793391Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519696}

This concludes the refactoring. The tests now have a MUCH clearer
control flow, and test success is no longer handled behind the scenes.

I found that it's better to keep promise chains as long as possible,
since we can then append a single .catch(failTest) at the end. This
isn't strictly necessary - the test will time out since an error
will break the promise chain and not call reportTestSuccess, but
it's much nicer if the test fails right away on exceptions, rather
than timing out after 45 seconds.

Bug: chromium:777857
Change-Id: I46c110782488bb20cdf7101690ca6966601506f2
Reviewed-on: https://chromium-review.googlesource.com/793153
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519695}

Autofill relies on the identity
__gCrWeb.common.getFormElementFromIdentifier(
    __gCrWeb.common.getFormIdentifier(form)) === form.

This is not the case if multiple forms have the same name.
Do not use the name if it does not allow to access the form.

Bug: 788093
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I95e602a46736fdfd86aa3a4708eb0b062a470009
Reviewed-on: https://chromium-review.googlesource.com/786017
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519694}

Network Service: filter external/wpt/service-workers/service-worker/registration-updateviacache.https.html

Started failing likely after the FF change:
https://chromium.googlesource.com/chromium/src/+/2898d2a95064276f84a6803253f15b0ea018f82a

(haven't looked into details)

TBR=falken@chromium.org
NOTRY=true

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If294b03a252124ab41048271eccc491918bd113e
Reviewed-on: https://chromium-review.googlesource.com/793651
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519693}

Bug: 625126
Change-Id: I94fc678a84b91e7242859d31775e3fb6b2daf1d2
Reviewed-on: https://chromium-review.googlesource.com/779723
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519692}

The previous implementation was racy and sometimes missed the 'loaded'
message from the iframe, causing tests to timeout.

Bug: 788372
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0052aa03f451ba295475b7460565e4e3f88bf3b2
Reviewed-on: https://chromium-review.googlesource.com/788954Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519691}

Bug: 
Change-Id: I8f3a40807f4694661f007c3d00818049caad5fd3
Reviewed-on: https://chromium-review.googlesource.com/792174
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519690}

Moving these to be function-local static variables is a better pattern,
less likely to cause trouble for jumbo builds.

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/792691
and https://chromium-review.googlesource.com/792942

Change-Id: I1c85a04f5023d6e48b82758d108cb10fda09b53c
Reviewed-on: https://chromium-review.googlesource.com/792939
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#519689}

The mouse moves the reticle, so that's all we should see.  This CL hides
the system pointer cursor by supplying an empty cursor in its place.

BUG=
R=vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib6365f14bb30fc2f7235e65a08321f11236fac65
Reviewed-on: https://chromium-review.googlesource.com/791670Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519688}

https://webrtc.googlesource.com/src.git/+log/fb09eeb8f1b7..2492984441a3

$ git log fb09eeb8f..249298444 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I51c87fdc2cf3085a9317e8782187ab6cbdadc8c2
Reviewed-on: https://chromium-review.googlesource.com/793290Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519687}

The state keys can't be empty on a device. If the device is enrolled
and we receive empty state keys, retry to fetch them.

Bug: chromium:778757
Change-Id: I06efd3402218c825b86eb8037d73fc937150da2a
Reviewed-on: https://chromium-review.googlesource.com/743721
Commit-Queue: Igor <igorcov@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519686}

1) For general efficiency and to avoid the leak mentioned in the linked
bug, compare share services via the previously exposed |name| method.
2) Now that |name| is available, restrict the temporary activity spawned
while sharing to the Reminders service, since that's the only one that
needs it.

Bug: 787955
Change-Id: I6d2a38f8b1cba3b3a3a4e1edb9c06408ae9f1c41
Reviewed-on: https://chromium-review.googlesource.com/791333Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519685}

https://skia.googlesource.com/skia.git/+log/37b501d2c9d2..7f1b4f8cc39c

$ git log 37b501d2c..7f1b4f8cc --date=short --no-merges --format='%ad %ae %s'
2017-11-28 robertphillips Fix issues related to backend texture/rendertarget creation

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: If7a84a9bbbaf6c3a458c41e10132ff1b1c65feb6
Reviewed-on: https://chromium-review.googlesource.com/793052Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519684}

It's not enough to check that the current window has access, if other
security checks failed and the entered window shouldn't have access to
the current window.

BUG=788453
R=haraken@chromium.org,mkwst@chromium.org

Change-Id: Iea10c52f20bdc49f00eba067cab69dab06f79f01
Reviewed-on: https://chromium-review.googlesource.com/792934
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519683}

Checking site isolation only in a few Dice scenarios was actually
hard to do, and since we expect site isolation to be enabled by default
soon, this CL goes with a simpler approach:
completely disable account consistency (including Mirror and fixing
auth errors) on Dice platforms when site isolation is disabled.

Note that this change does not apply to mobile, where Mirror is still
always enabled, regardless of site isolation.

The signin component does not have access to the site isolation
feature, and thus it is injected from Chrome. The ChromeSigninClient
factory does the injection, for two reasons:
- configuring the component should be done by "client" code
- it should be done only once, and thus is done by the client
  factory rather than the client itself (because there can be multiple
  instances of ChromeSigninClient).

Bug: 781761
Change-Id: Ia897bead9ab1fcc6915933eeed168d5ece3dda4a
Reviewed-on: https://chromium-review.googlesource.com/768871
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519682}

Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I049759ea52faf56d7ee7cfbff5e523fb00adf003
Reviewed-on: https://chromium-review.googlesource.com/793156Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519681}

This reverts commit 07edac9e.

Reason for revert: Speculative revert for sync_integration_tests /
TwoClientPasswordsSyncTest.SetPassphraseAndThenSetupSync failure on
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/47531

Original change's description:
> Migrate away from deprecated RunLoop API
> 
> Instead, we keep around an instance of base::RunLoop and pass it
> explicitly for Quit(), which makes sure the code quits the intended loop
> and not a nested one.
> 
> Bug: 783774
> Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a
> Reviewed-on: https://chromium-review.googlesource.com/784790
> Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519664}

TBR=pavely@chromium.org,mastiz@chromium.org

Change-Id: I25ed5a61f5b9e13159af82c4ef6d6f652170d4a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783774
Reviewed-on: https://chromium-review.googlesource.com/793630Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519680}

The new interface was added in https://webrtc-review.googlesource.com/c/src/+/17942
It uses optionals and allows passing some needed information to APM, which will prevent stats from getting stuck.

TBR=haraken@chromium.org

Bug: b/67926135
Change-Id: I816395515a5501158398838bfaee92bda3a67ee1
Reviewed-on: https://chromium-review.googlesource.com/785570
Commit-Queue: Ivo Creusen <ivoc@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519679}

Moved Checking Uppercase in header from SpdyStream::SaveResponseHeaders() to HeaderCoalescer::AddHeader()

Bug: 695495
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie277eaec092ee1d7541c278a7501d48902473a0d
Reviewed-on: https://chromium-review.googlesource.com/775551Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519678}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4aadee5620c5520787106260cf516d5a1dc824dc
Reviewed-on: https://chromium-review.googlesource.com/788211Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519677}

This adds the wiring needed by https://crrev.com/c/753728 to actually
disable com init check hooks for the WebRTC bots.

Bug: chromium:737090
Change-Id: I7ea209345475e2fd34de969e277ba523483506a9
Reviewed-on: https://chromium-review.googlesource.com/788411Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519676}

https://chromium.googlesource.com/catapult.git/+log/b9d9a104ca83..230a61040fc8

$ git log b9d9a104c..230a61040 --date=short --no-merges --format='%ad %ae %s'
2017-11-28 perezju [Telemetry] Add AndroidReverseForwarder

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I040a40de6b467f1c70ca9867a48a4185fb96af71
Reviewed-on: https://chromium-review.googlesource.com/793051
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519675}

TBR=eseckler@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789139
Change-Id: Ia2d504b3c5a26bcbf5468db6e1f0d06c99c38aef
Reviewed-on: https://chromium-review.googlesource.com/793511Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519674}

We must treat any 'auto' margin as 0px during the tracks sizing
algorithm, as the CSS Grid spec states:

- https://drafts.csswg.org/css-grid/#auto-margins

Additionally, we have an utility function to compute the grid item's
margins when the item still needs to layout. We used the function
CommputedStyle::hasMarings to decide whether such margin computation
worths. However, we need that function to operate on a specific
axis, hence I added a new function adding such logic.

Bug: 788471
Change-Id: I5d4e4fc435aa1ffea0003a9a88cfd7a3c1bca114
Reviewed-on: https://chromium-review.googlesource.com/789830
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#519673}

ExtractForms currently extracts forms from same origin iframe.
This is useless as:
- form activity observer is not installed in iframes
- __gCrWeb.common.getFormElementFromIdentifier does not check iframe so
  fields in iframes cannot be filled.

It can also break form extraction (e.g. on the expedia.com web site).

Full support of iframe will be implemented once cross origin iframe
injection is available.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I16f7a208edfdf6bf2aa5b65ae31e152f1bd370b8
Reviewed-on: https://chromium-review.googlesource.com/785814
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519672}

AutofillInteractiveTest::PopulateForm has flaky timeouts on CrOS.

BUG=516052
TBR=estade@chromium.org

Change-Id: I3a010aad9723a50f9affafdd46a931458093c8a8
Reviewed-on: https://chromium-review.googlesource.com/793210Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519671}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5a92b85d..e1591d9c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2538b3185a5ccd19feb99c6e8a9e88ec6c5eb83b
Reviewed-on: https://chromium-review.googlesource.com/793091Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519670}

SigninManager calls its observers with GoogleSigninSucceeded only the first time the user
signs in to Chrome (not in case of a reauth). The logic in the ProfileSyncService was added
initially to avoid enabling sync using an old refresh token during a reauth.

This CL removes this check as it is now obsolete.

Bug: 777774
Change-Id: I78fe5da8d270b099d9bba5fc962d810c00bba409
Reviewed-on: https://chromium-review.googlesource.com/787977Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519669}

TBR=kbr@chromium.org,pavely@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789129
Change-Id: I46ac7f186e52770b09a39be276ee5959ed56a1c5
Reviewed-on: https://chromium-review.googlesource.com/793318Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519668}

https://webrtc.googlesource.com/src.git/+log/80adac053cab..fb09eeb8f1b7

$ git log 80adac053..fb09eeb8f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=689520


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8f6c9cc0f0e78f9c96dedc53b2477e5749660ae9
Reviewed-on: https://chromium-review.googlesource.com/793070Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519667}

GetClientSourceInfo() returns the information about what the
TextInputClient is. For example, RWHVA::GetClientSourceInfo() returns
the URL of the shown page.
This method will be used for collecting IME usage UKM.

Bug: 752657
Change-Id: I4ff050e7203ed78f6d78971a79c3420616922453
Reviewed-on: https://chromium-review.googlesource.com/774818
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519666}

This CL adds the Bookmarks and VoiceSearch buttons to the clean toolbar.

Bug: 788436, 787861
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9d12e52c3bc1ed269921f68d1ef4261a38cfec50
Reviewed-on: https://chromium-review.googlesource.com/789859
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519665}

Instead, we keep around an instance of base::RunLoop and pass it
explicitly for Quit(), which makes sure the code quits the intended loop
and not a nested one.

Bug: 783774
Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a
Reviewed-on: https://chromium-review.googlesource.com/784790Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519664}

This adds UI side support of notification inline reply to
NotificationViewMD, which is a View framework notification
implementation used in Chrome OS.

Several features are missing from this implementation.
- Animation
- Submit icon on the right side

TEST=manual
BUG=773586

Change-Id: I65108a5cf6d4cf654972e260ca93f2712bf9fc68
Reviewed-on: https://chromium-review.googlesource.com/776176
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519663}

Bug introduced in 55b3fe20 where, for
the first time, bookmark observers can get notified with an empty
favicon (i.e. the bookmark does not have a favicon). In this case, the
UIs that want to fall back to the default icon need to handle it
specifically.

BookmarkMenuDelegate seems to be the only UI that cares are this
particular event. To fix it, we mimic the logic implemented in the
very same class, in BookmarkMenuDelegate::BuildMenu(), and treat the
null image just like the default icon.

Bug: 787363
Change-Id: Idf8fc5d2f2937ab16780a43320dd6689876244fa
Reviewed-on: https://chromium-review.googlesource.com/782320Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519662}

There's a lot of search/instant code which isn't used on Android, but
was still built and shipped. This CL moves most of it to the
non-Android sections of the build files (and #ifdef's out access points
where necessary), for the following classes:
- InstantService
- NTPUserDataLogger
- NewTabPageInterceptorService
- SearchIPCRouter
- SearchTabHelper
- [MostVisited]IframeSource
- SearchBouncer
- SearchEngineBaseURLTracker

This saves almost 50kB of binary size on Android:
tools/binary_size/diagnose_bloat.py --reference-rev=master HEAD -v
MonochromePublic.apk_Breakdown (-49,152 bytes)
   -23,820 bytes Native resources (no l10n) size
      -328 bytes Zip Overhead
      -422 bytes Native resources (l10n) size
   -24,576 bytes Native code size
        -6 bytes Package metadata size
MonochromePublic.apk_Specifics
   -49,502 bytes normalized apk size
   -24,576 bytes main lib size

Bug: 787830
Change-Id: I1cf914863e0bd75cc2fa15356fe072beb961368c
Reviewed-on: https://chromium-review.googlesource.com/790511Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519661}