- 08 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eacaa9a164a4..87d384c09451 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: caseq@google.com,tluk@google.com Change-Id: Ida1be4f33eef49eaf46f64195b0467d82848b2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815254}
-
Anders Hartvoll Ruud authored
This CL aligns the parsing behavior for :is() and :where() with <forgiving-selector-list> [1]. Parsing as a forgiving selector list means that individual selectors that are invalid will just be dropped; they won't invalidate the entire pseudo. This also adds support for empty :is()/:where() pseudos, which are valid, but do not match anything [2]. [1] https://drafts.csswg.org/selectors/#typedef-forgiving-selector-list [2] https://drafts.csswg.org/selectors/#matches Bug: 568705 Change-Id: I1b8f7d34e28d10927b1199ae2ed6ef8c2936e828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450012Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#815253}
-
Alexander Cooper authored
Adds a warning that ApplicationStatus may not work properly in WebView or WebLayer, and that it is intended to be moved out of //base. While this is enforced by DEPS (at least in //components), that isn't as discoverable until the end of prepping a patch. This adds a class-level comment to provide better visibility to warning users off of using this if they are trying to break other //chrome dependencies. Bug: 470582 Change-Id: I3593a44b1075b51ab99a114074b8a54c80e916f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461333 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815252}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31b44b3a70ed..823a6df243c3 2020-10-08 treehugger-gerrit@google.com Merge "hprof converter skeleton" 2020-10-08 primiano@google.com Merge "gn: Apply visibility rules to gn:default_{deps,config}" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If3a79ed9f674302981c40933785324049e8e05ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461969Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815251}
-
Wenbin Zhang authored
[benchmarking] disabled animometer_webgl_indexed, animometer_webgl_indexed_multi_draw_base_vertex_base_instance, animometer_webgl_indexed_multi_draw on rendering.mobile Archives are missing for these three stories and thus all other rendering.mobile stories on the same shard stopped running since late August. Disabling them if no quick fix. Bug: chromium:1136227 Change-Id: Iacd35a8fbda20e51341e86e7b55fd1d4d0b4e3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459799Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#815250}
-
Andrew Grieve authored
Rather than .apk Bug: 1091256 Change-Id: I92d1b140f17b30779d15ff2137d4ebf847e88ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459939 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#815249}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7a1d8e7. With Chromium commits locally applied on WPT: ae057949 "Add infrastructure/testdriver/actions/penPointerEventProperties.html" 85d36168 "wake lock: Make |type| optional in WakeLock.request()." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I73bf5cf8da192b418ca1ff33f062a711d697b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461568Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815248}
-
Harvey Yang authored
This commit adds an interface class AccelerometerProviderInterface for AccelerometerFileReader, to allow another mojo implementation in the future. It also moves AccelerometerFileReader into separate source files. BUG=b:168434557 TEST=builds and run on kohaku Change-Id: I6ee6e2253764a69cfe1693f792b64fa275b34a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409672 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#815247}
-
Fredrik Söderqvist authored
This moves the determination of the mouse cursor to a separate method, dropping the associated state in the process. Drop the ShouldShrinkToFit() check in ImageLoaded(). This will have no direct effect at the moment, but will aid a future CL. Bug: 844743 Change-Id: Iae464e999668f7f77b13e03018e801c3885fb6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461268 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815246}
-
Lei Zhang authored
Change-Id: I26139f111e000f07310485b283ba0d01442a4be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458882Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#815245}
-
Tibor Goldschwendt authored
The new NewTabPage.Modules.Visible lets us track the ratio of NTP loads with modules visible. Bug: 1135393 Change-Id: I15a9fd064b7e189420e2eac2e9cecc72587f8fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454733 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815244}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/66377ce9be54..fc5c5ab60b22 2020-10-08 dsinclair@chromium.org [hlsl-writer] Emit specialization variables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: Icc63accd00e3c9f76fbf6b1083862aefa616461b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461967Reviewed-by:
-
Dominic Mazzoni authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: I5aad36bf020733721649db6f7308e32bef1ade50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450612Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#815242}
-
Klaus Weidner authored
Using wallclock time for render completion can overestimate GPU usage if the fence client wait is called on an already-completed fence. Use the fence status change time instead to get a more accurate measurement. It's technically best-effort, with fallback to wallclock time, but in practice seems to be reliably available. Bug: 1136276 Change-Id: I29c2830220de1dbac053cfeec8e4494f6d2eb42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461959 Auto-Submit: Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815241}
-
Xianzhu Wang authored
This reverts commit 1745f190. Reason for revert: Rebaseline the failing test. Original change's description: > Revert "Limit minimum scale of PaintedScrollbarLayer to 1" > > This reverts commit 6860e109. > > Reason for revert: Speculative revert to fix fast/frames/iframe-scaling-with-scroll.html. https://crbug.com/1136335 > > Original change's description: > > Limit minimum scale of PaintedScrollbarLayer to 1 > > > > This is to avoid too low scale when animating scale above the > > scrollbar layer. > > > > This is not ideal. In the future we should move rasterization of > > scrollbar layers to impl-side to better handle scales > > (crbug.com/1009291). > > > > Bug: 1133997 > > Change-Id: I3364754f530914816fe8526c627e6cf12e7942ec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453436 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814681} > > TBR=wangxianzhu@chromium.org,bokan@chromium.org > > Change-Id: I4554c428bcc5a3d5fef9033e6772f53932d0e256 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1133997, 1136335 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459087 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814987} TBR=wangxianzhu@chromium.org,bokan@chromium.org,shimazu@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1133997 Bug: 1136335 Change-Id: I7719f62f9b23f31f9c35094ac3c1de2a73dfdef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459137Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815240}
-
Robert Ogden authored
Adds a experiment param to require the user to have Lite Mode enabled, default true for the time being. Also removes the integration with the Data Saver config to get the proxy tunnel hosts and chrome-proxy header. Now, the tunnel host will be given through experiment param or cmd line and uses a tunnel header with the Google API key. Also fixes some flakiness in the new probing tests. Bug: 1135213 Change-Id: I23802a5c9787abe669759be0f782b3d586afd7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449912 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815239}
-
Michael Hansen authored
This extracts the creation of request objects for WebRTC into a separate file containing free functions. This better isolates this responsibility and improves testability. Fixed: 1134210 Change-Id: I817147d5c49dc0e461d4b54d07492e5a02f20ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456867Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#815238}
-
Lei Zhang authored
Convert callers to use non-deprecated base::Value APIs. Bug: 646113 Change-Id: I0dee0b8d466de1e3f7518aa087446885a08e3754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445051Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#815237}
-
Philip Rogers authored
This patch updates GraphicsLayer::ShouldCreateLayersAfterPaint during the CompositedLayerMapping update based on LayoutSVGRoot::HasDescendantWithCompositingReason, rather than doing this after paint based on the painted output. This is both simpler and avoids unnecessary compositing. Bug: 1132598 Change-Id: I11b6d2a32b7dc3b7f9a1b068a4806382d2cd6443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461429Reviewed-by:
-
Scott Violet authored
AFAICT LayoutView is always a scroll container. So, the TODOs for dealing with infinite width/height because of overflow:visible mixed with overflow:clip can never happen. This converts them to DCHECKs. BUG=1087667 Change-Id: I079be338a55067d6f5b1a62e72feb58709dfbc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441953Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815235}
-
David Bertoni authored
This CL implements a simple test for chrome.management.get. Bug: 1093066 Change-Id: I536b6eee36bd623d9bc772d1b5a357be69542181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441930 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815234}
-
Joey Arhar authored
You can tell that the origin trial is enabled and CSS.supports() isn't working as expected because of the document.body.onbeforematch check in the first assert. Bug: 1134237 Change-Id: I992e05dcf3cb0a3d07fcc1aedb1efb67630b9b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447051Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815233}
-
Ievgen Rysai authored
Aside from patching the guard returning nil for anything except static text this change also fixes a few issues that get in a way: - incorrect coordinate space handling (-[BrowserAccessibilityCocoa rectInScreen:] expects its input to be in root frame coordinate space) - redundant (and seemingly wrong) code in `GetInnerTextRangeBoundsRectInSubtree()` that causes incorrect results for text fields. Bug: 1131376 AX-Relnotes: VoiceOver and Zoom now correctly highlight the text in a text field. Change-Id: Ie14be2b0d36c420735397496da78cb1f53e7c26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424090 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815232}
-
Justin Cohen authored
Bug: 1127434 Change-Id: I63c5db473c2987eebc3605206eff64aeb4db3490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461976 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815231}
-
Shakti Sahu authored
Bug: 1117157 Change-Id: Ia7108a2e62dd2b97b4ddd9d806f7dcdc6b1097d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447251 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815230}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c267a5583028..acad80a97dc5 2020-10-08 ddoman@chromium.org [resultdb] move cipd pin of rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135892 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I18e4ca3de56f465bbbbea32530d4cd65f8442af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461962Reviewed-by:
-
Owen Min authored
This reverts commit 4d2dee85. Reason for revert: Create the reland to debug Original change's description: > Revert "Resolve the issue by moving PolicyMapAndroid instances in the test so that they can live until the end of tests." > > This reverts commit 6b3c4bdb. > > Reason for revert: Broke PolicyServiceAndroidTest.PolicyUpdateEvent on Android ASAN > https://ci.chromium.org/p/chromium/builders/ci/android-asan/8133 > > Original change's description: > > Add onPolicyUpdate notification in Java. > > > > Support PolicyService::onPolicyUpdate event in Java. Same as other > > functions, only Chrome policies are supported. > > > > Other changes: > > 1) Implement PolicyMap.equals() > > 2) Use ObserverList instead of Set to manage PolicyService's observers. > > > > Bug: 1127469 > > Change-Id: I40c6958e87c746aa40afec306ee632bba52183f6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446639 > > Commit-Queue: Owen Min <zmin@chromium.org> > > Reviewed-by: Sky Malice <skym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814310} > > TBR=zmin@chromium.org,skym@chromium.org > > Change-Id: Ibde93e22e01f4d3eb8d9eb2a8d4d9c42166ed191 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127469 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454653 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814628} TBR=vasilii@chromium.org,zmin@chromium.org,skym@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1127469 Change-Id: I778a68262809758d9dd5e43bc3ad5accbc1d823c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458767Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815228}
-
Sylvain Defresne authored
Since https://crrev.com/c/2289856, TabModel stopped observing WebState and _webStateObserver is no longer used. Remove the ivar. Bug: none Change-Id: I1b3b73b69d3bcde06e598ce70a3074f095350869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461117 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#815227}
-
Robbie Gibson authored
When the thumb strip is in hidden or peeked state, the tab switcher button will transition the thumb strip to revealed state. This CL also adds a public method to ViewRevealingVerticalPanHandler to set the state externally. Finally, the CL does not support tapping on the tab switcher button when the thumb strip is in revealed state. This is because the design has the BVC covered in a shim in this state. This hasn't been implemented yet, but the tab switcher button should be inaccessible. Change-Id: Ic44ddd8dc676fbdeb787bc75c422f332a9405574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455648 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Darin Fisher authored
Replicates logic from browser/media/webrtc/desktop_media_list_ash.cc Bug: 1094460 Change-Id: I249b401ff0b6b0fdace0502c27d81b2d2b3ae1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457467Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815225}
-
Shakti Sahu authored
This CL adds : 1 - Summary card IPH, that is shown after all other tutorial IPHs have been tapped by the user. Summary card is treated as a synthetic tutorial available only on NTP. It isn't addded to the actual list of tutorials which shows up elsewhere, e.g. tutorial list page. Tapping on summary card opens up the tutorial list page. 2 - Added remaining IPHs : chrome intro IPH, voice search IPH and their corresponding tutorials/proto at the backend. 3 - Renamed IPH features to be NTP specific since we will have the same tutorial shown on other surfaces as well. The click/dismiss events are kept generic so that they can be shared across NTP and non-NTP IPHs. Bug: 1117186, 1130255 Change-Id: I101b3a69cfa41bfcdbc45264c9f800fa3a0d2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438778 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#815224}
-
Rahul Singh authored
non-default orientation Problem: When Windows tablet devices are locked in a non-default orientation, the video capture stream is incorrectly rotated. Cause: We always return a camera rotation of 0 when auto-rotation is turned off. For devices locked in non-default orientations this leads to incorrect camera rotation. Fix: This change removes the IsAutoRotationEnabled() check inside GetCameraRotation(). It also adds a new base::Optional<int> member camera_rotation_ in video_capture_device_mf_win.cc and video_capture_device_win.cc. When a frame is received, if camera_rotation_ doesn't have a value OR auto rotation is enabled, we call GetCameraRotation() and cache the non-negative returned value in camera_rotation_. This enables us to calculate and save the correct camera rotation when the first frame is received. Further, if auto rotation is turned off during the capture session, we'll be able to use the cached value to keep the camera correctly rotated. Testing: I added a test in video_capture_device_mf_win_unittest.cc to verify that GetCameraRotation() is called and |camera_rotation_| is populated when MFVideoCallback::OnSample() is invoked. I also tested this change with both a naturally landscape and a naturally portrait Windows tablet device locked in all possible orientations. In each case the camera was correctly rotated. Bug: 1134801 Change-Id: Ib1b6f1a4bb388b1390e5a257686c3b8a417a2a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447036Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815223}
-
Herb Derby authored
Change-Id: Idb2dcad48973cabe7ea8ac34ed57dc2fca176f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462037Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Commit-Queue: Herb Derby <herb@google.com> Cr-Commit-Position: refs/heads/master@{#815222}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: Ic4d2f59b00c371db343bb1b698cb787d70871b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443513Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815221}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I66e357a12e290fa4717db6cb27ef746791d4a167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460889Reviewed-by:
-
Morten Stenshorne authored
When compiling with -Wshadow some of their values conflicted with those of FindOptionFlag in core/editing/finder/find_options.h Bug: 294205 Change-Id: I33f3e451f163841ebfce823bdefa3902e7ea0c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460821Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: If049d3c91d14c023d1363e27a33f0881c7e1646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460892Reviewed-by:
-
Darin Fisher authored
This type is binary compatible with skia.mojom.Bitmap and only serves to specify a difference in the generated bindings. Instead of copying the pixels out of shared memory into a heap allocated buffer retained by the SkBitmap, the bindings will allow the SkBitmap to simply retain the given shared memory buffer. This avoids a potentially large copy. This change leverages SkBitmap's support for having its pixel backing managed externally via SkPixelRef. The BigBuffer received over IPC is stored in a new SkPixelRef subclass. The outcome of this is that if the BigBuffer was using shared memory then the SkBitmap will be able to reference that memory directly, thus avoiding a copy of the pixels. Finally, the Lacros code for screen capture is updated to use this new type to eliminate a large buffer copy. Bug: 1094460 Change-Id: I9249ad40ced16c8cbe42bbbe5d11d9820cc75d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450838Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815217}
-
Jamie Walch authored
Bug: 1122155 Change-Id: I6653288c9d4d175d8f2e077c67470464f4194829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458807 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#815216}
-
Sébastien Séguin-Gagnon authored
Max value was not set to the right value. Also changed to enum class, which would cause the previous situation to not compile. Change-Id: I0476ae21eaac5c3ef52de5bb70af073548333564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459691Reviewed-by:
-
