- 14 Feb, 2018 40 commits
-
-
Maks Orlovich authored
disk_cache users should only need to go through disk_cache.h; the individual _impl.h files aren't public API. Change-Id: Ie2e7f696ec81e03ff00dbfcfc5535fd7929acf83 Reviewed-on: https://chromium-review.googlesource.com/916742Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#536713}
-
Tim Dresser authored
This is a reland of fe64540e. Original change's description: > Report First Input Delay across OOPIFs, report First Input Timestamp. > > Previously we only reported for documents in the same process. > > Adds InteractiveTiming.FirstInputTimestamp UKM, > PageLoad.InteractiveTiming.FirstInputTimestamp UMA. > > Bug: 803935, 808089 > Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32 > Reviewed-on: https://chromium-review.googlesource.com/901802 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536358} Accidentally skipped CQ. Then reverted. TBRing original reviews: TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org Bug: 803935, 808089 Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb Reviewed-on: https://chromium-review.googlesource.com/916007 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#536712}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15403669..8c345b4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I31d648a71d1d97a21d0388c802840a1dfeda6d3a Reviewed-on: https://chromium-review.googlesource.com/918743Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#536711}
-
https://webrtc.googlesource.com/src.git/+log/5dbb58602f24..d377f041944f $ git log 5dbb58602..d377f0419 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb8138e36a04d68786e54a3debd6705a2e43100d Reviewed-on: https://chromium-review.googlesource.com/918961 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536710}
-
Chandan Padhi authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78 Bug: 293292 Change-Id: Ib1869d4e940cffb3012572451268dec1ffb55a0e Reviewed-on: https://chromium-review.googlesource.com/899402 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#536709}
-
Rohit Rao authored
These serve as common model classes that can back either UICollectionView or UITableView. CollectionViewModel is updated to be a subclass of ListModel with added restrictions on permitted item types but no functional changes. CollectionViewController and its subclasses are largely unchanged. BUG=805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibcfbab5bae62c5c8a37f764508294421d3d1c307 Reviewed-on: https://chromium-review.googlesource.com/916365 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#536708}
-
Justin Cohen authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I913bc2bbe5d6ef5a2434d44c020c34bf5299343e Reviewed-on: https://chromium-review.googlesource.com/916712Reviewed-by:
-
Amirhossein Simjour authored
This CL moves AnchoredPopupWindow, RectProvider, and ViewRectProvider to ui/android/widget. This is needed to avoid circular dependency between DropdownPopupWindow and AnchoredPopupWindow. BUG=809758 Change-Id: If019ede28561a36b3f079806334bf85acc49c219 Reviewed-on: https://chromium-review.googlesource.com/909553 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536706}
-
https://skia.googlesource.com/skia.git/+log/6ce969472e2e..fc711a2b0143 $ git log 6ce969472..fc711a2b0 --date=short --no-merges --format='%ad %ae %s' 2018-02-13 robertphillips Add SkCharacterization creation helper to GrContextThreadSafeProxy (take 2) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ia3d2464b6a513f9a49f89de19630f072302e828d Reviewed-on: https://chromium-review.googlesource.com/918921 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536705}
-
Finnur Thorarinsson authored
- Ensure Settings and Close are visible always (for non-Chrome OS). - Add "from this site" to the "block all notifications" string. Bug: 810873,768300 Change-Id: I85eb7753614e8cd678343d06de6160b9dac5d50d Reviewed-on: https://chromium-review.googlesource.com/913271 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536704}
-
François Beaufort authored
This CL prepares the PictureInPictureWindow interface by adding the |resize| event handler to PictureInPictureWindow. We currently don't receive resize events from the backend. Triggering |resize| event will come in a future CL. Bug: 806249 Change-Id: Ib10eabc0e35af782dcdb36862535063d2dab0a2c Reviewed-on: https://chromium-review.googlesource.com/908562Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#536703}
-
Mugdha Lakhani authored
Bug: 799483 Change-Id: I9411d141492ae3db3f6baf413b31c7daa099b3a0 Reviewed-on: https://chromium-review.googlesource.com/918801Reviewed-by:
-
Friedrich Horschig authored
The title of the (only displayed) category causes confusion with Talkback because it was counted as search result entry. As it also doesn't need to be shown according to the latest mocks, removing it should be just fine. Bug: 808260 Change-Id: I870bb02f9f936dbf4f41ad3edb9cf1b9f0617dec Reviewed-on: https://chromium-review.googlesource.com/918621Reviewed-by:
-
Finnur Thorarinsson authored
Font metrics are calculated in two different ways on Windows, (Chrome uses DirectWrite, unit_tests GDI), so there is a slight offset that needs to be accounted for. Bug: 768300 Change-Id: Ia43e95df199b9e81ca37fae64bca76a4b9cc1d3c Reviewed-on: https://chromium-review.googlesource.com/915943 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#536700}
-
arthursonzogni authored
This revert commit fbeba561. Reason for revert: I suspect it breaks: GetAllPagesV1HandlerTest.testMultiplePages in chrome_test_apk downstream (crbug.com/811221). Original change's description: > Everything is the same as the original land, except for changes > to offline_page_test_archiver.cc and .h. > I've added a new test override of the new function that was added > in the original changelist, so the test override will be called > in unit tests. This was causing unit test failures in the internal > clank builds, even though it passed all the unit tests in the commit > queue. > > Original changelist: > https://chromium-review.googlesource.com/c/chromium/src/+/896555/12 > > Bug: 758690 > > Publish the Offline Page to a public directory > > This change will move the offline page to a public directory and inform > the system download manager if any (for instance, on Android) of the > location and type of the file. If both steps succeed, the > offline page item will be written to the offline page model database. TBR=petewil@chromium.org,dimich@chromium.org,jianli@chromium.org,carlosk@chromium.org Bug: 758690,811221 Change-Id: Ic055aeaf7369fd0696ccbb10c72be177e75ee693 Reviewed-on: https://chromium-review.googlesource.com/918541 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#536699}
-
Naina Raisinghani authored
We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - position - padding-{top,bottom,left,right} - text-align - text-decoration-style Bug: 774887 Change-Id: I9fc9d6d425b1a5ce0c71f8d918bc5893c74c4e89 Reviewed-on: https://chromium-review.googlesource.com/917927 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536698}
-
François Beaufort authored
According to UI review deck, the Picture-in-Picture icon should live at the very bottom of the list in the overflow menu. Test page: https://beaufortfrancois.github.io/sandbox/media/overflow-video.html Screenshots: https://imgur.com/a/lnH1e Bug: 726621 Change-Id: Id0075ec3524842200eacc315539233a494edc484 Reviewed-on: https://chromium-review.googlesource.com/916381Reviewed-by:
-
Tim Schumann authored
CrossSiteDocumentBlockingServiceWorkerTest.NoNetwork and CrossSiteDocumentBlockingServiceWorkerTest.NetworkAndOpaqueResponse They were already marked as flaky for Android and fail with the same error on Linux CSI. Bug: 809735 Change-Id: I62d8f8d152af287fd3c983806d430c5bd4e1d93e Tbr: creis@chromium.org,lukasza@chromium.org Reviewed-on: https://chromium-review.googlesource.com/918581 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#536696}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: I271421221cad33a61ec1b4e329fb7e5cc53289cd Reviewed-on: https://chromium-review.googlesource.com/911268 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536695}
-
Victor Costan authored
First, Chrome currently requires iOS 10.0 or above. Second, as of today, Chrome for iOS will use our patched version of SQLite, removing an unnecessary point of divergence between platforms. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-device Change-Id: I365713588d079658d5be9c1282d40f591aba05f7 Reviewed-on: https://chromium-review.googlesource.com/907497Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#536694}
-
Thomas Tangl authored
This CL implements the storage mechanism for the images in AccountTrackerService. Images are save to and loaded from disk. Bug: 794522 Change-Id: I6e54b5467e11d8f32a8518ab042218e74914ca3c Reviewed-on: https://chromium-review.googlesource.com/913575Reviewed-by:
-
Kush Sinha authored
Mirror is now available on Chrome OS via a preference. Use of truth for checking whether Mirror is enabled in the Settings page. AccountConsistencyModeManager: :IsMirrorEnabledForProfile as the source Change-Id: I4a8c2ddd4242953bd13fdb06ace2ef9d715850b3 Reviewed-on: https://chromium-review.googlesource.com/913608Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#536692}
-
Friedrich Horschig authored
Recently, a misnamed study (see deleted test config) caused the feature to fall back to the default popular sites. This isn't a big problem but when it was finally named correctly, the names of the groups disabled all popular sites. Popular sites should not be so easy to disable. Therefore, remove the group name condition. Aforced cmd line flag should cover all possible cases and make the intention very clear. This is already in place and remains untouched. This change removes the deprecated and unused function for Demo users on the Java side. This is necessary as the JNI calls would break the tests otherwise (see linked bug 808260). Bug: 794329, 808260 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I92b9d7426095b4aba1c81450b052090afe69307d Reviewed-on: https://chromium-review.googlesource.com/913574Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#536691}
-
James Forshaw authored
This CL adds the necessary support to the GPU process launcher to enable the AppContainer sandbox as well as UMA metrics and a new entry in chrome://flags. Bug: 807249 Change-Id: I92d1f5ef224e09952b8615a79da639edc83692e7 Reviewed-on: https://chromium-review.googlesource.com/912868 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#536690}
-
Patrik Höglund authored
This target is only needed by the GCC bot anyway. I hope this will green up the clang ToT bots. TBR=dpranke@chromium.org Bug: chromium:811764 Change-Id: Icd1d12f52387adc9b1b81d50f4cb75dc3f3b8694 Reviewed-on: https://chromium-review.googlesource.com/918441Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#536689}
-
Naoki Fukino authored
Bug: None Test: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0985fa3b5678159d51b5e88342abf570bbe7818a Reviewed-on: https://chromium-review.googlesource.com/917926Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#536688}
-
Christopher Cameron authored
Change-Id: Iba981ff6af26161e2ce4318a66527b0f458e23e4 Reviewed-on: https://chromium-review.googlesource.com/918403Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#536687}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3a9efb2712ef013269ebcaac5266e903e1ca1ea3 Reviewed-on: https://chromium-review.googlesource.com/918303 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536686}
-
Fredrik Söderquist authored
When setting a track .src to "", we would resolve the URL to a null URL, which matched the default initialized HTMLTrackElement::url_, meaning that readyState was not advanced and no 'error' event fired in this case. Extend the "url == url_" check with a check for readyState differing from 'none'. Also rewrite HTMLTrackElement::getReadyState to avoid using EnsureTrack(). Bug: 811713 Change-Id: Icd190492639c53e09a7e018202b69ac6e919a94c Reviewed-on: https://chromium-review.googlesource.com/916004 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#536685}
-
Yuta Kitamura authored
SingleThreadTaskRunner() is deprecated, and should be moved to TaskRunner(). This patch renames all the existing use sites and remove the function. Bug: 794845 Change-Id: Id8f8fb48f37262054845cbd5c91f73bc680ab31b Reviewed-on: https://chromium-review.googlesource.com/918201Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces test cases for |TextIterator::RangeLength()| to record current behavior as a preparation of fixing ::first-letter bug[1]. [1] http://crbug.com/810623 TextIterator::RangeLength() returns wrong value for ::first-letter Bug: 810623 Change-Id: I59b80f4f0a2b260bbcb7a02915ead354f796d3fb Reviewed-on: https://chromium-review.googlesource.com/908271Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536683}
-
Yuzu Saijo authored
This CL changes the leak detection with cluster telemetry in order to catch TimeoutException, which are caused by continuous resource loading. Change-Id: Ia91b3a1293b4b6838f1dcdba0e813a90429ba597 Reviewed-on: https://chromium-review.googlesource.com/915746Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#536682}
-
Jan Wilken Dörrie authored
This change makes BluetoothAdapterAndroid::SetPowered() wait for ACTION_STATE_CHANGED before running its success and error callbacks. The same async behavior is introduced to the FakeAdapter for tests, allowing more unit tests on Android to be enabled. Bug: 803105 Change-Id: I3e0f00e2b54583a0d715527939ceee4ad9dd5004 Reviewed-on: https://chromium-review.googlesource.com/875922 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#536681}
-
Ramin Halavati authored
Network traffic annotation is added to the QuicChromiumClientStream::QuicChromiumClientStream(). Bug: 656607 Change-Id: Ic425332ec2219595d0de49a5921c72333eef5e21 Reviewed-on: https://chromium-review.googlesource.com/911029Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#536680}
-
Matt Falkenhagen authored
This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/907013 Tests only; the code seems to work. R=horo, kinuko Bug: 808825 Change-Id: I6b86a4dac159b754cfe5e6b92ac390c07de89ab3 Reviewed-on: https://chromium-review.googlesource.com/918261Reviewed-by:
-
Mohamad Ahmadi authored
autofill::AutofillManager passes FormData.main_frame_origin to the autofill::AutofillMetrics::FormInteractionsUkmLogger. This property was not being set in autofill_agent.mm, therefore no metrics were being logged. Bug: 812070 Change-Id: I1e337ae6af575fc6182e5b360e44f12427d3d5be Reviewed-on: https://chromium-review.googlesource.com/917534Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536678}
-
Ramin Halavati authored
Serialize function for text output of annotations is added to traffic_annotation_auditor for debugging purposes. Also two small updates in output and documentation are done. Bug: 690323 Change-Id: I35ab3381a116dde685f283982b378c6549ce8a90 Reviewed-on: https://chromium-review.googlesource.com/916196 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536677}
-
Matt Falkenhagen authored
Probably the leak detector runs before the worker is fully shut down and all related memory is freed. The tests were recently re-enabled with some suppressions in r520900, but they are still reported as leaks in bug 808922. R=dcheng, glider, kinuko Bug: 586897,808922 Change-Id: I9c8a01303f38c39dcd3334ccb3c138bdac7d53db Reviewed-on: https://chromium-review.googlesource.com/917844Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#536676}
-
Dominick Ng authored
This CL removes the dependence of AddToHomescreenDialog on AddToHomescreenManager. A delegate interface on AddToHomescreenDialog is introduced to allow the dialog to communicate with its host on when the user accepts or dismisses the add to home screen prompt. This means that other hosts can embed the dialog, not just the AddToHomescreenManager (which is updated in this CL to implement the interface). This CL should have no functional changes. This work is a precursor to using the AddToHomescreenDialog as a surface for modal app install banners. BUG=811578 Change-Id: I0fe176e8f6853af180591b9a94b2e89898be89bd Reviewed-on: https://chromium-review.googlesource.com/915243 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#536675}
-
Ramin Halavati authored
Network traffic annotation is added to the handle read request of HttpServer. Bug: 656607 Change-Id: Ideecf50bcbb740efcb0a75b449c042d9c17e16e4 Reviewed-on: https://chromium-review.googlesource.com/910888 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536674}
-
