- 11 Sep, 2018 40 commits
-
-
Fady Samuel authored
Currently some invariants violation checks are in LayerTreeHost for mac but not for other platforms. This CL enables the check on other platforms. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iade0eee8322f9126a5ee7409b2e79aa00593b2d1 Reviewed-on: https://chromium-review.googlesource.com/1217598Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590175}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Iadd9cef6cec3357c3e3e66440fbcc10f31e7dd5a Reviewed-on: https://chromium-review.googlesource.com/1217746Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#590174}
-
David Bokan authored
The double-tap gesture on Aura (which causes zoom) does not respect the touch-action filter as it should. i.e., double-tapping over a region with touch-action: none should prevent zooming. This is caused by IsGestureEvent() returning false for the TAP_UNCONFIRMED event. IsGestureEvent is used in EventHandler::OnEvent to determine whether to pass the event to OnGestureEvent and meant that the TAP_UNCONFIRMED gesture would get dropped at this point. The reason this was working on Android was that Android's GestureProivderClient is RenderWidgetHostViewAndroid. When FilteredGestureProvider forwards the gesture it passes it straight back to the RWHVA which doesn't go through the IsGestureEvent check mentioned above. On Aura, the GestureProviderClient is GestureProviderAura which passes the forwarded gesture back through WindowEventDispatch before finding the RenderWidgetHostViewAura. The WindowEventDispatch call chain is where we accidentally filtered the TAP_UNCONFIRMED gesture because of !IsGestureEvent. This means the TouchActionFilter never saw this gesture, which it needs to determine whether to filter the subsequent double-tap gesture. Bug: 865090 Change-Id: I5f8932dcf8b33ec132fa946864a462610cc8413b Reviewed-on: https://chromium-review.googlesource.com/1213881Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590173}
-
Jared Saul authored
Usage was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1188587 but the actual feature flag was missed. This is final cleanup. Change-Id: I84537c6112eea803a991eefff9c997c7f0dce758 Reviewed-on: https://chromium-review.googlesource.com/1213923 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#590172}
-
dpapad authored
Removes /deep/ usage, which no longer works in Shadow DOM v1. Also fixes some test timing that caused part of the failures. Bug: 875505,860069 Change-Id: I5642105a6df148bdea2d02b8e1af8889f400c89d Reviewed-on: https://chromium-review.googlesource.com/1217026Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590171}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4d533d8ebd..5518e65d90d7 git log 3c4d533d8ebd..5518e65d90d7 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 480edb8c1d7d..63aa0e5b7001 (2 commits) Created with: gclient setdep -r src/third_party/skia@5518e65d90d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I0fe248380451033bd1a22c14682e3cc7f9bc0a6e Reviewed-on: https://chromium-review.googlesource.com/1217813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590170}
-
Jordy Greenblatt authored
Some initial formatting to get closer to the mocks: https://drive.google.com/open?id=0B1-cJJPK-cu6UGQ1Yk9uQzhReVlEc0J1N2ZZU0FaLTlvaFZB Bug: 878644 Change-Id: Ib985d48cd91014ae82c1f7d6c57df86be38f0a67 Reviewed-on: https://chromium-review.googlesource.com/1212353Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#590169}
-
Yue Cen authored
Please see b/114134918 for more details. Bug: 835029 Change-Id: Iefeffe6c9d0335aa61c24097b190092a3a657fbd Reviewed-on: https://chromium-review.googlesource.com/1213521 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#590168}
-
Yue Cen authored
Bug: 881488 Change-Id: Icd1464af653037ea59c20d4b5aa91dd315f9dba8 Reviewed-on: https://chromium-review.googlesource.com/1211962Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#590167}
-
Katie D authored
This reduces duplication of strings. Change-Id: I8c075f81282f63d151273e7704458afbe666b36f Reviewed-on: https://chromium-review.googlesource.com/1185896Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#590166}
-
Hector Carmona authored
CL also includes a few minor UI fixes to match mocks and a11y. Bug: 832933 Change-Id: Ibb9fd594b80d79692593e65f00636fbd7115eb3e Reviewed-on: https://chromium-review.googlesource.com/1212265 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590165}
-
Xida Chen authored
This CL records touch action rects for TableRowPainter. A layout test case is added to ensure the correctness. Bug: 851674 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3280aaf9c72dda6a75eed5d5ad85b60045c377f7 Reviewed-on: https://chromium-review.googlesource.com/1216706 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590164}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9b825ec0c30..f182b1fc9a95 git log b9b825ec0c30..f182b1fc9a95 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 simonhatch@chromium.org Dashboard - Combine yield on multiple futures Created with: gclient setdep -r src/third_party/catapult@f182b1fc9a95 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I96d379242e01181b1eaea846d97c2719e289ce6b Reviewed-on: https://chromium-review.googlesource.com/1217811Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590163}
-
Devlin Cronin authored
There's some churn going on with extension bindings (to native bindings) and user gestures (to UAv2). Add two end-to-end bindings tests to expand our coverage: - Test that extension messages "pass" the user gesture to the receiver; that is, if a user gesture is active when a message is created, it should be active on the receiving end as well. - Test that extension API callbacks are invoked with an active user gesture iff the API is invoked when a gesture is active. Bug: None Change-Id: I7d4036356bd20fd00c0774210b2019287413e30c Reviewed-on: https://chromium-review.googlesource.com/1217166Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590162}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf64a04acdf3..f2582da04e4d git log cf64a04acdf3..f2582da04e4d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 mbonadei@webrtc.org Revert "Partial revert of: 'Bump xcode versions for WebRTC bots.'" 2018-09-10 perkj@webrtc.org Decrease complexity of RtpPacketHistory::GetBestFittingPacket. Created with: gclient setdep -r src/third_party/webrtc@f2582da04e4d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0718a5951cdc2e98717b1079f39f30ed26f5e1fe Reviewed-on: https://chromium-review.googlesource.com/1217803Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590161}
-
Byoungkown authored
arraysize is deprecated, we should use base::size() instead. This cl clears a presubmit warnings. Bug: 837308 Change-Id: I5479c0f16e6df0b43b617c0e15c6c28527c41cbd Reviewed-on: https://chromium-review.googlesource.com/1213622Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#590160}
-
Klaus Weidner authored
This helps provide an estimate how old the poses are when polled by the gamepad API and when read from JavaScript. BUG=878181 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I623b876cff559709ff858d9df0ee1df33b736481 Reviewed-on: https://chromium-review.googlesource.com/1200569Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#590159}
-
Zhiqiang Zhang authored
Previously, we remove the SessionManagerListener upon session ending/ended. This is to stop listening to session changes after we are no longer interested in casting, while not being affected by MediaFling. However there's some tricky SDK behavior, such that session ending could be notified during a session relaunch. Then we never get onSessionStarted() signal. This CL checks for pending launch request before removing the listener, so that sessions can be relaunched. Bug: 711860 Change-Id: I582ae8bb6f038956c256ea88ae6115ed289fdfff Reviewed-on: https://chromium-review.googlesource.com/1217749Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#590158}
-
Yutaka Hirano authored
Bug: 882689 Change-Id: Ib80ccf82e70ddf242ecab87a0ed8d2b9f2937c8e Tbr: battre@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1218122 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590157}
-
Yutaka Hirano authored
This reverts commit 34b81f99. Reason for revert: Due to failures on the Leak bot. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/24067 Original change's description: > Make AXObjectCache garbage-collected > > This is a follow-up to http://crrev.com/c/1150824 - instead of having > Document keep track of its AXContexts, let the garbage collector do the > work for us. Each AXContext owns a Persistent<AXObjectCache>, and > the associated Document has a WeakPersistent<AXObjectCache>. That way > when the last AXContext goes out of scope, the AXObjectCache will be > cleaned up automatically. > > This requires a few changes due to assumptions that AXObjectCache couldn't > outlive its corresponding document. > > Bug: 867324 > Change-Id: Id0479f59c9a9652b2cb321ed14369e8996748d8a > Reviewed-on: https://chromium-review.googlesource.com/1162743 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590104} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,haraken@chromium.org Change-Id: Ic63c70078865bf5fdc8a7743bd07484eb95068e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867324 Reviewed-on: https://chromium-review.googlesource.com/1217646Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590156}
-
Stefan Zager authored
Re-landing after revert: https://chromium-review.googlesource.com/c/chromium/src/+/1200388 ... but leave the flaky tests disabled. R=chrishtr@chromium.org BUG=879798 Change-Id: Ia588f9d82665a533b4e1bd2f77809692ded0cb41 Reviewed-on: https://chromium-review.googlesource.com/1215370 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#590155}
-
Lei Zhang authored
It currently takes an OmniboxFocusState, but only two states are ever used. Change it to a bool to remove the possibility of the renderer sending an invalid state. Change-Id: Ib1bc4bb5bd3415bbaf4de96d63b81fd8cfa89907 Reviewed-on: https://chromium-review.googlesource.com/1217168Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590154}
-
Jia authored
This is almost the same cl as https://chromium-review.googlesource.com/c/chromium/src/+/1209000 The previous cl was reverted because it broke linux-chromeos-dbg due to missing constexpr declaration in the .cc file. It's added in this cl. This is the only change from the previous cl. Bug: 881215 Change-Id: I11ba819be664f1e13583b7543578f6d3b03efcef Reviewed-on: https://chromium-review.googlesource.com/1214907Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590153}
-
Stuart Langley authored
Part of the ongoing work to cleanup the filesystem callbacks to be OnceCallback where possible. No logic changes. Bug: 875700 Change-Id: I69c5518eaee657e0ce42d8bde3687696fa9047b9 Reviewed-on: https://chromium-review.googlesource.com/1217644Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#590152}
-
Tetsui Ohkubo authored
In order to show audio settings button on headphone connectivity change, we should relayout the slider view when visibility is changed. TEST=manual BUG=880237 Change-Id: I966ee7082987ddbefb83a434657c5b733570ca94 Reviewed-on: https://chromium-review.googlesource.com/1215509Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590151}
-
Jian Li authored
Also do not associate the top snackbar view with bottom container view in order to make it also work with Duet mode enabled. Bug: 882596 Change-Id: I34ed55cc6bc90ff705e488914773d7be116087df Reviewed-on: https://chromium-review.googlesource.com/1217590Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#590150}
-
Yutaka Hirano authored
This reverts commit 31f68667. Reason for revert: Due to fast/forms/text/input-appearance-readonly.html failures on Mac10.13 Tests (dbg). https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.13%20Tests%20%28dbg%29/builds/5205 Original change's description: > Show a focus ring when a readonly text field is focused. > > The previous behavior was deliberate but dates back to this 2006 > WebKit bug without any clear rationale: > https://bugs.webkit.org/show_bug.cgi?id=8705 > > In the absence of a strong argument in favor of this behavior, > we should do what's better for users and show the focus ring. > > Bug: 870062 > Change-Id: I6c1c427d05270a69d4ded74f68704d78b78c3095 > Reviewed-on: https://chromium-review.googlesource.com/1213311 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590043} TBR=dmazzoni@chromium.org,alancutter@chromium.org Change-Id: I4e4270d3d62350bf037b1103ebffd578e819474e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870062 Reviewed-on: https://chromium-review.googlesource.com/1217645Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590149}
-
Tetsui Ohkubo authored
The change is requested by UX. TEST=manual BUG=879794 Change-Id: Ibea68c353d20aa81cabe4e2ee5d8fe14d48a72c4 Reviewed-on: https://chromium-review.googlesource.com/1215429Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590148}
-
Shimi Zhang authored
The intermediate multiplication result was too large to store in float precisely, therefore there was a rounding error. To mitigate this, we apply a rounding for the integer conversion. We only need this for scale up since the granularity is finer. Bug: 881458 Change-Id: I9c07fdfb71fcbc59f36f5094bf813053cac8d8e8 Reviewed-on: https://chromium-review.googlesource.com/1214686 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590147}
-
Scott Wu authored
Enable basic password autofill functionality for ios web view - Save password after login and autofill password form when going back to the login page. Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4f6e3f40500bb667959110d5f0eb3f07c85bca94 Reviewed-on: https://chromium-review.googlesource.com/1198672Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590146}
-
Xi Cheng authored
Bug: 851163 Change-Id: I25fa3661d755118987dc8de8bc5496874d4578a1 Reviewed-on: https://chromium-review.googlesource.com/1217851Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#590145}
-
Kenichi Ishibashi authored
Before this CL, ServiceWorkerControlleeRequestHandler used the pointer of |url_job_| as an id of PrepareForMainResource trace event. However, |url_job_| can be cleared and the pointer could be nullptr so it's not unique. To avoid using nullptr as an id, use |this| of ServiceWorkerControlleeRequestHandler. Bug: 881826 Change-Id: I89e7f25194518a73de6adef98546e3069c711f5d Reviewed-on: https://chromium-review.googlesource.com/1215461Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590144}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I160f27ba8849d61766f3790721cb04c50b9b8726 Reviewed-on: https://chromium-review.googlesource.com/1214977Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590143}
-
Xiaocheng Hu authored
There is no guarantee that LocalCaretRectOfPosition() never returns a non-null LayoutObject. Instead, callers should handle the null result to avoid crashing. This patch adds handling to CaretDisplayItemClient::ComputeCaretRect(). Bug: 881613 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1845b29a0cd43fb189a13561ee83c3641320df3c Reviewed-on: https://chromium-review.googlesource.com/1217072Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590142}
-
Lei Zhang authored
TBR=jkarlin@chromium.org,mxnguyen@chromium.org,piman@chromium.org,posciak@chromium.org,sadrul@chromium.org,sdefresne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4737224f0e262005a25d87797f1ef69f18be420a Reviewed-on: https://chromium-review.googlesource.com/1215046 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#590141}
-
Will Harris authored
Needed to enable -Wshorten-64-to-32 on 64-bit builds. In file included from ../../printing/metafile_skia_unittest.cc:7: In file included from ../..\cc/paint/paint_record.h:9: ../..\cc/paint/paint_op_buffer.h(939,16): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] op->skip = skip; ~ ^~~~ ../../printing/metafile_skia_unittest.cc(28,11): note: in instantiation of function template specialization 'cc::PaintOpBuffer::push<cc::DrawRectOp, const SkRect &, cc::PaintFlags &>' requested here record->push<cc::DrawRectOp>(page_rect, flags); ^ In file included from ../../printing/metafile_skia_unittest.cc:7: In file included from ../..\cc/paint/paint_record.h:9: ../..\cc/paint/paint_op_buffer.h(939,16): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] op->skip = skip; ~ ^~~~ ../../printing/metafile_skia_unittest.cc(30,11): note: in instantiation of function template specialization 'cc::PaintOpBuffer::push<cc::CustomDataOp, const unsigned int &>' requested here record->push<cc::CustomDataOp>(content_id); ^ BUG=879657 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I272f2eb17e5ebb348e6960226949f3f18e4696f2 Reviewed-on: https://chromium-review.googlesource.com/1217903Reviewed-by:enne <enne@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590140}
-
Eugene But authored
Bug: 881876 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id32427383dc90c986bb6ddf3cf07b0e1fc3f5282 Reviewed-on: https://chromium-review.googlesource.com/1214756Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590139}
-
Koji Ishii authored
When the scrollbar is on left and the box is narrower than the scrollbar, the scrollbar overflows to left. LayoutBox::AddLayoutOverflow() expects the overflow adjusted by the amount the scrollbar overflows. This affects a jQuery plugin that detects RTL scroll type[1]. [1] https://github.com/othree/jquery.rtl-scroll-type Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I70e7b1ecc20857ff10687afd7d5e3b7d70afb2dc Reviewed-on: https://chromium-review.googlesource.com/1215365Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#590138}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/cb6ec4b1f91a..385a05c3d606 git log cb6ec4b1f91a..385a05c3d606 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 hinoka@chromium.org Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""" Created with: gclient setdep -r src/native_client@385a05c3d606 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ie08297a4b5f3a345d2d06b43149694096174f5e1 Reviewed-on: https://chromium-review.googlesource.com/1217804Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590137}
-
Yuki Awano authored
- Update window properties and detach ax child tree when user switches back to TalkBack. ]. Confirm that TalkBack works well. Bug: 881695 Test: Open any android app with spoken feedback and press Search+A then Change-Id: I2b5db2d77e49e674e98c1b3cfbb18b2567d69388 Reviewed-on: https://chromium-review.googlesource.com/1212210Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590136}
-