- 21 Jan, 2021 40 commits
-
-
Scott Violet authored
I suspect I'm going to need some tuning of exit. Unfortunately chrome shutdown path is pretty hard to observe outside of the code itself. BUG=1167296 TEST=SessionServiceLogTest* Change-Id: Iae2647695be8f6e6932406bbb88df2dd2ab76504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845789}
-
Sky Malice authored
Previous attempt to fix this https://crrev.com/c/2605393 was flawed in that it used the wrong suffix string. Also not sure how IPH_NewTabTip appeared in my previous CL, but removing it here. Sorry for the churn. Bug: 1162103 Change-Id: I1584d6cfeaa43d23d76a4fc31b0f1f47acc4676b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641564Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#845788}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611230296-a0d70aa7451b9c0a65b3b69ada45b93ac77ab251.profdata to chrome-linux-master-1611251835-492ad3518ecdcc200059acbff6fa6ac0a2007e2f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee71048315dcd7f7dfe2381d78dbb9c6fd25e549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845787}
-
danakj authored
OnRenderFrameCreated will send to frames when they are created in the renderer process - avoid sending the model to frames that do not exist. Previously this was silently dropped, and in this case the code handles things by sending the message later. R=drubery@chromium.org Bug: 1169066, 1158869 Change-Id: I7daffcce74c568f1c09f18288ab3e7cde3bc6b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#845786}
-
Yuanyao Zhong authored
Make sure a set the semantic's role as kList only when it has actionable children. Otherwise it is just a GenericContainer. Bug: b/178063833 Test: test on assistant device. Change-Id: Ie309e7bd3b87907fea19dbd1896f886965c7752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643478Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#845785}
-
Ben Wagner authored
Pull latest from https://github.com/webrtc/samples. In particular, this includes https://github.com/webrtc/samples/commit/583fc1a6efacd19d9485be381a8698d12748b671 which is a followup to https://chromium.googlesource.com/chromium/src/+/4eab15e1d4e2c0c9e4a6369c9d65ac2f543d489a to resolve the perf regressions in bug 1167426. PS1 has all manual changes. PS3 is the result of: $ ./tools/perf/page_sets/update_webrtc_cases $ git restore tools/perf/page_sets/webrtc_cases/datatransfer.js (Necessary because https://chromium-review.googlesource.com/c/chromium/src/+/2579968 is not present in the upstream yet.) Tested locally on Mac with: ./tools/perf/run_benchmark run webrtc --browser=system ./tools/perf/run_benchmark run webrtc --browser=canary ./tools/perf/run_benchmark run webrtc --browser=exact --browser-executable=/Applications/Google\ Chrome\ Beta.app/Contents/MacOS/Google\ Chrome\ Beta Bug: 1167426 Change-Id: I9d4605e8149dc5dafcfcee13cbfd3a7cd6d7b92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642360 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#845784}
-
Christian Biesinger authored
R=masonfreed@chromium.org Change-Id: I885b95fb269e2f9f239233fedc825739b674b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642858 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#845783}
-
Nektarios Paisios authored
This is required before merging BrowserAccessibilityPosition and AXNodePosition. In UI Automation, we expose an "embedded object replacement character" \xFFFC in the text representation of all empty controls, so that they will be treated by AXPosition as word, character and line boundaries. This patch moves some of the logic for determining which node is an empty control to AXNode in the form of the AXNode::IsEmptyLeaf method. Note that the definition of a control is quite loose and it encompasses all leaf nodes that expose no inner text or hypertext. This is in order to cover all possible future additions to our rendering engine and in order to extend this behavior to possibly other elements which meet the same criteria. This behavior is not new, but it has been moved from AXPosition::IsEmptyLeaf. This patch also fixes AXNode::IsLeaf to properly mark ignored nodes that have children as not leaves. A leaf node should be, either a node with no children (including ignored and unignored), or any unignored node whose entire subtree is not exposed to platform APIs. Ignored nodes that are already in an ignored subtree, should not be marked as leaves too, otherwise AXPosition::AsLeafTextPosition() might stop unexpectedly while traversing the AX tree to find a leaf node: ++kTextField "Some Text" (leaf node) ++++kGenericContainer ignored (should not be marked as a leaf node) ++++++kStaticText "Some text" ++++++++kInlineTextBox "Some text" (leaf node) For optimal performance AXNode::GetInnerTextLength() is introduced and is used by AXNode::IsEmptyLeaf(). Concadenating strings is much slower than adding up their lengths. Finally, AXNode::GetHypertext() is fixed so that descendants of leaf nodes have the correct hypertext per the existing IA2 and ATK behavior. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Bug: 1049261 Change-Id: I4ea5b578dded79920f07bf6a66df208dd4a88fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637515Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845782}
-
Xianzhu Wang authored
It fails in pre-CompositeAfterPaint and succeeds in CompositeAfterPaint. Bug: 148499 Change-Id: I8c755bb3c12d01a7187bd175aa5b871e83e16766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643045 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#845781}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I803b68b1341ee0faa382b9d37d2decaa7d6899e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626180 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845780}
-
Ella Ge authored
This goes through the RenderFrameHost to get to the Impl under content, similar to the HeavyAdIssue. Then build up the message and send to devtools protocol. This CL also adds passing the package name and signature to jni when violation type is DIGITAL_ASSET_LINK, so that they can be use for displaying the issue. Design doc https://docs.google.com/document/d/1Dsw4bYttTODZJ7QbRlS4-iN7nBFnJJ1-JGmUY6gdMiE/ Issue string https://docs.google.com/document/d/1nlYeWlwCOva7M9EoT6YKQZ4s-Ug8aXbQIp4Oc1cL8WE/ Bug: 1147479 Change-Id: I57b5fb9b415889efc998cf88223ef0a87b77ade8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568749Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#845779}
-
Lily Chen authored
Change-Id: Ife6e67c51e755f38dad7c1795fd2c0979943e67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642829Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#845778}
-
Tomasz Wiszkowski authored
This change adds TILE_NAVSUGGEST suggestion to the list of special match types that are excluded from GroupBySearchVsUrl. Bug: 1165941 Change-Id: I36791175c81289d752b69b01bfddf5844dd12d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641144Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#845777}
-
Austin Sullivan authored
Bug: N/A Change-Id: I3d0b3b83c35b322b650bba7bd636f71f2364275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630009 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#845776}
-
Evan Stade authored
Bug: 1147268 Change-Id: I7b67ba260d5b2f818ee52308a25cec8d496dac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638218Reviewed-by:
-
Ajit Narayanan authored
Records how the Select-to-speak actions of sentence/paragraph navigation and exit were triggered (i.e. through button click or keyboard shortcuts). Bug: 1143814 Change-Id: I17b524d9683f1298ce3cfb4d5fa97fbdc3bc4415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602854Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#845774}
-
Austin Eng authored
This follows the deprecation of the old vertex_idx identifier in the WGSL spec. Bug: none Change-Id: If3cf3d3b985b79b85b9807b17e5458bacd0805dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643238 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845773}
-
Michael Lippautz authored
A past refactoring translated `unique_ptr<TaskRunnerTimer>` to `Member<DisallowNewWrapper<HeapTaskRunnerTimer>>` to preserve semantics. Inline HeapTaskRunnerTimer which avoids a dynamic allocation. Change-Id: Id3c788c3dedab1dbf3022e0d8ebe5dfca47235b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640373 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845772}
-
Jan Wilken Dörrie authored
This change extends expiring PasswordManager and PasswordGeneration histograms and marks "PasswordManager.OtherPossibleUsernamesUsage" as obsolete. R=chromium-metrics-reviews@google.com Fixed: 1165103, 1165104, 1165114, 1165115, 1165116, 1165118, 1165119 Change-Id: Ib2bd28896c05ddb9c24fe7f191299a7e58e39321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632651 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Michael Crouse authored
This is a reland of 3f534050 This resolves the builder issue for neon performance warnings. Original change's description: > Reland "[TFLite] Enable tflite in build for android and desktop." > > This is a reland of a4df03d0 > > This addresses the revert by removing neon from the TFLite build > for chromeos. > > > Original change's description: > > [TFLite] Enable tflite in build for android and desktop. > > > > Bug: 1165517 > > Binary-Size: Expected increase due to inclusion of TFLite in binary. > > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845026} > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > TBR: Andrew Grieve <agrieve@chromium.org> > TBR: Tarun Bansal <tbansal@chromium.org> > Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845478} Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. Change-Id: I6f3b3a4a8b4bfda89eae49f9c24b684ff8ec8dab Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642742 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845770}
-
Yuwei Huang authored
This CL makes the host uninstaller delete the settings file. Change-Id: If03663338817dba6b15f15ae4493e6edfce9290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640652 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#845769}
-
Felipe Andrade authored
Extend the expiration date of AuthPolicy and Kerberos histograms. The milestone of expiry is synchronized, to make maintenance of these histograms easier. Justification for AuthPolicy: the feature doesn't send enough data to DM Server to provide data about it's usage. Justification for Kerberos: the feature was launched recently. Bug: 1165074, 1165051, 1165019 Change-Id: Iaa2851945f39b6b34ffa6a9a33e8b43a33cfa3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626287Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Haiyang Pan authored
It consistently fails on android-pie-arm64-rel Bug: 1169250, 1147581 Change-Id: I7923d166f42cef1ef65ebb22adbc3409cdeb2206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643259 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845767}
-
Fredrik Söderqvist authored
If the pattern resource is marked for layout via a mechanism that does not invalidate its attributes - for example by changing a style property that only requires paint invalidation - a call to LayoutSVGResourceContainer::InvalidateCacheAndMarkForLayout() will fail to properly invalidate attributes, which leaves the pattern in an inconsistent state. Drop the early-out check for SelfNeedsLayout() in said method so that RemoveAllClientsFromCache() is called in the above case as well. Bug: 1167563 Change-Id: Ib5896da9e52a103b86dc6eb7ad08e30a572b6d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642777Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..79b1b0af2eb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I86c4579f227c264c132c1fe7f041508b40b89114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642941Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idd52f07051df27d6df91d5e4f4188efa73d04f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643137Reviewed-by:
-
Tommy Nyquist authored
This reverts commit 305cf78b. Reason for revert: Crashing many browser tests, in particular BackgroundTracingManagerBrowserTest.* Original change's description: > tracing: make PosixSystemProducer work in child processes on Posix. > > The security sandbox forbids making socket connections directly from > within most child processes (except the network utility process). Trace > data for renderers are missing from a tracing session with Chrome data > sources on non-Android Posix platforms. > > This change introduces a new Mojo interface, SystemTracingService, that > is shared between the browser and child processes for making a socket > connection to the system tracing service daemon. A child process > receives a Mojo remote interface and then invokes the OpenProducerSocket > method to open the socket connection in the browser process. The browser > process then passes the socket connection to the child in the response. > The child process then adopts the connected socket in initializing the > connection in PosixSystemProducer. > > Full design doc: go/crosetto-chrome-producer-dd > > SystemPerfettoTest.SandboxedOpenProducerSocket > > Bug: b/147789115 > Test: services_unittests: SystemTracingServiceTest.*, > Change-Id: Id698dc656b7b9ede723e3a887532c33544914edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435129 > Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844743} TBR=kinuko@chromium.org,primiano@chromium.org,skyostil@chromium.org,eseckler@chromium.org,chinglinyu@chromium.org,nuskos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/147789115, 1169185 Change-Id: Ibe932297b317fdee6cbd9ef5b09ad1aeffd2f1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643258Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#845763}
-
Peter Wen authored
Recursive resource deps is meant for an android_library target to directly depend on all of its transitive resource deps. A target that does this also needs to rebuild its build config file when its transitive java library deps change, since otherwise, if a transitive resource dep is removed from the build by being removed from the java target that used to depend on it, the recursive resource target's build config would be stale and the removed resource would be included in the final apk/bundle. Example: A: Resource dep that turns on recursive_resource_deps. B: Java library C: Java library D: Resource dep A depends on B depends on C depends on D. Previously, A's depfile would only contain D.build_config. But if C removes D as a dependency, and the removal doesn't result in a change for B.build_config, A.build_config would not be rebuilt, since it only depends on B.build_config (via direct dep) and D.build_config (via recursive_resources_deps). Thus entirely missing the change to C.build_config. Bug: 1168655 Fixed: 1168655 Change-Id: I500d307802d64ef81099540ebd6fb54f4953c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639227Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79b1b0af2eb9..dc8ef8034344 2021-01-21 fmayer@google.com Merge "Add ELOG to truncation path in UnixSocket." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I136ed8a0493cd4120750bcda93104e78c4eb1fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642815Reviewed-by:
-
Ben Mason authored
Change-Id: I75471776f45dd2d6cc7ee562f90c5690d2a23025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642958 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845760}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f28a06ba7281..203154b52a46 2021-01-21 syoussefi@chromium.org Vulkan: Remove swiftshader workaround for missing gl_Position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5b6dcf3cd35704ee71cd771e0c1ea2bc9809692e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643097Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a reland of the CL reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2628949. Bug: 1166369 Change-Id: I86c177e525a8e330f2b135106488febb0e2d5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637954Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#845758}
-
Yuchen Liu authored
Bug: 177786478 Test: QA test shows the av sync is improved after disabling it. Change-Id: Ic9257ece4169b54b8b9126717657fb2abe80dcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643402 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#845757}
-
minch authored
Bug: 1166374 Change-Id: I9e513de723c7d27cd12ac0bb7604c4ebbe5200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628254Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#845756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1890f38f2471..8d1dafc6c231 2021-01-21 vidorteg@microsoft.com [Loc] Migrate heap_snapshot_worker to Localization V2 2021-01-21 tvanderlippe@chromium.org Disable Karma coverage preprocessing for component_docs 2021-01-21 andoli@chromium.org [module.json extensions] persistence views 2021-01-21 soxia@microsoft.com Service Workers Test Runner filters date information 2021-01-21 andoli@chromium.org [module.json extensions] Adds documentation on extension registrations. 2021-01-21 andoli@chromium.org [module.json extensions] protocol_monitor 2021-01-21 wolfi@chromium.org Fix: show OpenedWindowDetailsView when clicking on respective item in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1136655,chromium:1153091,chromium:1159502 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ec61b1d059fc8d54e4f1c402f9661688e25230c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642886Reviewed-by:
-
Henrique Nakashima authored
The getowners.py script periodically reads OWNERS files and git history and generates per-module data to be surfaced in go/clank- OWNERS files do not contain Monorail component, Team and OS information anymore, DIR_METADATA files have replaced them and broken the script since then. Bug: 1135347 Change-Id: Ib88e9d576d94ad5484b6a3dbbfff156639275dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634833Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845754}
-
Eugene But authored
Bug: None Change-Id: I8959d5ef64a2242bf7002cb826a40087d96ef292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638418Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d023562bd9..230cd50238f2 2021-01-21 mtklein@google.com close out simple assembler TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ie33af84899b2882904cc92d804eb775c56165ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643236Reviewed-by:
-
Shengfa Lin authored
This reverts commit 28c5a54b. Reason for revert: The test failure cases mostly are real failures. Original change's description: > Disable __main__.ChromeDriverTest.testCanSwitchToPrintPreviewDialog > > It's flaky. > > I can't figure out how to mark it as flaky using this test harness, so disabling instead. > > BUG=1166314 > > Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#843395} TBR=mpearson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shengfa@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1166314 Change-Id: Ia8c5f9f0bef64a21f2b0066ba1f218b5aed0874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641099Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#845751}
-
Matt Reynolds authored
This CL adds a histogram to record the reason why the HID device chooser was closed. Bug: 964041 Change-Id: I1fbe006314b0d2faab57771f07ccf57c5ed01c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600218Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845750}
-
