- 25 Jun, 2019 40 commits
-
-
Sophie Chang authored
This UKM should only be recorded once per page load. Marking this event as singular makes it easier to query in logs. Change-Id: I72acf796d084d0fe97df8932067a30ce95dc7537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669573Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672121}
-
Peter Kasting authored
We did this by default and for flattenhtml=true, but not when setting preprocess=true. This seems like an oversight. Bug: 564112 Change-Id: Id3d6907e79be51ea2ce905e563f350fd0f882164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670353 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#672120}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e899321b0bf7..a25f5438fa27 git log e899321b0bf7..a25f5438fa27 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 chrisforbes@google.com Use correct alignment for input attachment loads Created with: gclient setdep -r src/third_party/swiftshader@a25f5438fa27 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135954761 TBR=swiftshader-team+autoroll@google.com Change-Id: I5493b76f7d8f16aea2303001ea435282d10ffdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672119}
-
Lucas Furukawa Gadani authored
Bug: 973925 Change-Id: I7eae9ca730babc823341c766e49d242496d2c315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672204 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#672118}
-
Gustavo Avena authored
BUG=973822 Change-Id: I71f6494eae094646068382444eb985626efd0bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658168 Commit-Queue: Gustavo Avena <gustavoavena@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#672117}
-
Thomas Tangl authored
The method GetAvatarImageURLWithOptions() is updated to support image URLs coming in the FIFE Avatar URL format. This should resolve issues related to color-inverted account images on the Chrome surface. Bug: 911332 Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#672116}
-
edchin authored
A previous fix did not fully fix the crash. https://crrev.com/c/1645479 The crash with the signature AddSameConstraints still occur so an additional check is added directly before AddSameConstraints() is called. Bug: 970876 Change-Id: I9adb9437eea159896d089ce415c33688fb1dc46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670149 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672115}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/16f6e6ab932f..b9a1021d5b7d git log 16f6e6ab932f..b9a1021d5b7d --date=short --no-merges --format='%ad %ae %s' 2019-06-25 dneto@google.com Remove Appveyor artifacts link. (#739) Created with: gclient setdep -r src/third_party/shaderc/src@b9a1021d5b7d The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I4d1bd3021c4f0923eab1fe99cbde22804fc5571f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675743Reviewed-by:
-
Tommy Steimel authored
This CL removes all uses of the word 'modern' from the media controls resources. Bug: 884215 Change-Id: Ib6e28c953dd478bbc73a28697fa45a1562eb9641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674330Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#672113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f99e2caaf7..70ec83098831 Created with: gclient setdep -r src-internal@70ec83098831 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I2dbd047b07b5d5bd505733bcd85fe8bb258c8fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676011Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672112}
-
Fredrik Söderquist authored
Bug: 978436 Change-Id: Ief76cb6af4ad65fe433eb2d6d66282be313e4d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676168 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#672111}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e198ec2f..0d7d36e8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c54705e1d2f3ec537d46a9c94f190a5159b0542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672110}
-
Scott Sheehan authored
midl.py currently does some path munging that is better handled by midl.gni. It has knowledge of 'third_party' and 'win_build_output' and these should be an argument to the script provided by the build system instead of knowledge intrinsic to midl.py. This changes moves that logic to midl.gni. midl.gni produces the same default path that midl.py previously generated (so net result is a no-op). browser_switcher/bho is the only consumer that had custom logic that needed to explicitly specify the output location. Additionally, this enables other IDL producers to specify a non-standard place to persist the IDLs if they so desire. Details: midl.py/gni facilitate IDL compilation. Nominally, one would run midl as part of the build process and be done with it. However, to support cross-platform compilation, IDL generation is done on Windows clients and persisted in the source tree. This way platforms that can't run midl directly can still produce a Windows build. For a given IDL, in the source tree |somewhere|, the standard location for the checked in midl outputs is third_party\win_build_output\midl\|somewhere|. midl.py knew how to get from the IDL built outputs (in |gen|) to the standard location. Now midl.gni has that knowledge, additionally some other location, other than the standard location may be used, if necessary. Bug: 976936 Change-Id: Ibd448c8d59cc59e19c26beb8235c6f581182061e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666483Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Scott Sheehan <ssheehan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#672109}
-
Vadym Doroshenko authored
Bug: 969989, 975774 Change-Id: I10ea2dc24835b3da9d36d2045aef523ab11d10f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675672 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#672108}
-
Geoff Lang authored
The passthrough command decoder does not implement the state restoration functions because it does not track state. When a GLStateRestorer exists, it is used for the scoped binders in ui/gl/scoped_binders.h and leads to incorrect state being applied. BUG=88258 Change-Id: I18937597fc02562dfaf01d67a9d4a1b8b84290a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670949Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672107}
-
Matthew Jones authored
Bug: 971868 Change-Id: Icdfba2d851058b961cec6e7546d3c6fb0123fed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674615Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#672106}
-
Olivier Yiptong authored
This CL moves write-related operations to NFSFileWriter. This makes the backend and interface closer to the current shape of the spec. Bug: 968550 Change-Id: Ia2ccd97416b478eddf210118132519eef2b16040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672026Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#672105}
-
Istiaque Ahmed authored
The two metrics are meant to monitor extension content verification related stats: ExtensionContentHashFetcher.CreateHashesTime Extensions.CorruptExtensionTotalDisables Mark these as never-expiring. Bug: 976038, 976013 Test: None Change-Id: I915898f9533a1e40a3576ce4924453ef9374cee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674206Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL adds a |flip_y| param to said method next to |clockwise_rotation|. This is necessary to deprecate the PIXEL_FORMAT_RGB32 (see next CL in the relation list): Win video capture (and only that) uses RGB32 ISO the approved synonym ARGB to signify the vertical flip. Default arguments in virtual functions are banned, https://google.github.io/styleguide/cppguide.html#Default_Arguments so I left a couple of TODO()s to remove the ones currently there. Bug: 953128 Change-Id: I8651ad13c6457ac3209a286299469c3689ab24ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658689Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#672103}
-
Ben Pastene authored
Got green runs on the three desktop bots: https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel/5659 https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/5994 https://ci.chromium.org/p/chrome/builders/ci/mac-google-rel/2935 And trybot mirrors are not polluting the perf dashboard's streams for the CI bots since they upload to a different namespace based on master: https://codesearch.chromium.org/chromium/src/tools/perf/core/perf_dashboard_machine_group_mapping.json Bug: 961548 Change-Id: I9aae3c16eda8b2758e47a80f31a717c8c69f8772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656017Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#672102}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/adf18ce45a3c..d628747dfb54 git log adf18ce45a3c..d628747dfb54 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 bsalomon@google.com Make GrColorSpaceInfo store GrColorType. 2019-06-25 halcanary@google.com SkQP: fix Filterable.filter 2019-06-25 jvanverth@google.com Use asynchronous routines to build Metal shaders and pipelines for MacOS. 2019-06-25 mtklein@google.com baby steps for aarch64 support 2019-06-25 herb@google.com Introduce mergeGlyphAndImage to SkStrike Created with: gclient setdep -r src/third_party/skia@d628747dfb54 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:974219 TBR=djsollen@google.com Change-Id: Ia2924532f22e09279bb232374319f569fd1914ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675742Reviewed-by:
-
Sean Gilhuly authored
Move RendererType value instantiation into arrays, and use ValuesIn to remove the linting error for having a comma on a new line. Bug: 963446 Change-Id: I40095576d14b51e1515d7900b7a30703fa467cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674643 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#672100}
-
Aaron Leventhal authored
HTML labelable elements can cause extreme slowness while loading in some cases. We should only call html_element->labels() if the current element is known to have labels (we can check our relationship cache). Bug: 976849 Change-Id: Ia5e0e312b3a5e1d2d2d4cfdc5249f6a58b38147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669911 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#672099}
-
Kevin Babbitt authored
We already tolerate \r characters that exist in accessibility tree dump files, but some PDFs have been observed to produce \r characters in the generated "actual" tree dump, which can throw off the diff. This change normalizes line endings when generating a tree dump. Bug: 974397 Change-Id: I40f3f78398d890ef2f3536bfb0f807c455a96dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673840Reviewed-by:
-
Ian Vollick authored
FILTER_TOUCH_FOR_SECURITY is not used by the touchless modal dialog presenter and need not be included in touchless modal dialog properties. Bug: None Change-Id: I6bb9faea0b095dc5fef36f85c7c6b0b09b11e838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672097}
-
Ryan Hansberry authored
Also only Initialize the EasyUnlockService in the test once the test Profile object is ready. This change is high-priority because without it, the fix for crbug.com/953027 causes this test to fail (the incomplete Profile caused DCHECKs in known_user.h to fail). Bug: 857494, 953027 Change-Id: I5a389b3017e6428136295ccd6899ffc05c6c354b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669762 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672096}
-
Bruno Santos authored
This unblocks deleting related code in chrome/ in parallel with ash/ Bug: 977019 Change-Id: I3578898a501b337829703cf474146f1219eabad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672586Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#672095}
-
Michael Thiessen authored
We want shortcuts to feel more app-like as there are no tabs in touchless mode and shortcuts clobbering your tab is confusing amongst other things. See bug for additional details. Bug: 977198 Change-Id: I47c58ce218ffe6d0a146228fcd28c6c2e9b3abf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669235 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#672094}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3fc161c169d..5767fb8cbd2a git log d3fc161c169d..5767fb8cbd2a --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Stop passing deprecated flags to frame analyzer. Created with: gclient setdep -r src/third_party/webrtc@5767fb8cbd2a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0d196c364ec9264d21afcc97f04b19a97852cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676012Reviewed-by:
-
Harsh Patel authored
Changed proguard_utils to allow for non java executables to be run. Change-Id: I193288fbc857573a64a54926aa066d2a03e06698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672196Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Harsh Patel <harshpa@google.com> Cr-Commit-Position: refs/heads/master@{#672092}
-
Min Qin authored
Currently download use webcontents::GeURL() to check content settings. But the download can actually be triggered by javascript from another origin. This CL fixes the issue by passing the request initiator to check the content settings. Here is what included in this CL: 1. removed originating_web_contents param from TabDownloadState ctor, this param is never used. 2. Adding an origin param to DownloadRequestLimiter::CanDownload() call, and it will be used to check the content settings. 3. In DownloadRequestLimiter::CanDownloadImpl(), always do content setting check first. This fixes a bug that any site can always trigger a download first even if its automatic download setting is blocked 4. For restricted origins, record their download status. So that we can differentiate origins that are blocked and origins that require prompt. BUG=970378 Change-Id: I6f7efc8b5c6b27ff3eaec1bb436c5ffbb8c8b26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657031Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672091}
-
Tibor Goldschwendt authored
Bug: 891996 Change-Id: I5904066ca893c536cbed87b3e6fa55b1210f5f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675323 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#672090}
-
Andrew Grieve authored
The bot is now the same as is used by other perf tests, so if it is broken, it will not go unnoticed / will be covered by tree sheriffs. Change-Id: If63c11f92c43d0ecc45953b63301d95a31510f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676346 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Allen Robinson authored
Change-Id: I859b6c87050b5c2eb7f43eb55b052a5bb125603a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669648 Auto-Submit: Allen Robinson <arobins@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#672088}
-
Eric Orth authored
Essentially a thread-safe notifier wrapping around DnsConfigService, intended (but not yet used) for NetworkChangeNotifier and HostResolverManager(s) to listen to a shared object for system DNS config changes. In subsequent CLs, this will allow us to divorce HostResolverManager from listening to NetworkChangeNotifier and be able to apply Chrome-internal config changes on top of the system-only changes currently triggerring change notifications. In non-test, will generally be expected to be broadly shared and leaked on shutdown. Sequence-safe destruction is still implemented (using an internal Core class with an OnTaskRunnerDeleter) for any special cases and for tests. Note that some of the internal workings of the new class work similarly to base::ObserverListThreadSafe, but it was too difficult to make that work with the requirement that we always be able to get an initial config once ready, whether read before or after adding observers. Bug: 971411 Change-Id: Iac79dba9f74018ae6b9559c27df60174bf4edc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654881Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#672087}
-
Ian Kilpatrick authored
This moves NGLayoutAlgorithm onto the heap using partition alloc. This (in mac-64bit) reduces the stack space from 1392 -> 864 bytes which is the same as legacy. From pinpoint data, this only seems to have a slight performance regression. A follow up patch will be sent so which performs a refactoring, so that this patch can be a simple cherry pick with the beta branch. Bug: 977387 Change-Id: I75a5b995b26c60e69976f41876cea192bc761486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669917Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672086}
-
Ryan authored
iOS 13 causes weak signature algorithms and key sizes to be rejected as ERR_CERT_STATUS_INVALID, as documented in https://support.apple.com/en-us/HT210176 BUG=977163 Change-Id: If65bb570155db479e70b940de27f2b76b7d93223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670397 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#672085}
-
Jacques Chen authored
-Profile avatar images not used on Android -Removed all except one placeholder avatar icon -Last avatar not removed due to having large part of profiles code still being dependent on avatar icon code -Configured some profile tests not to run on Android -Removed profile_avatar_icon_util unit tests on Android Bug: 799078 Change-Id: Ic7b726c3ac58f8f1f6b24c48d95ac81d08aa9eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652193Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Jacques Chen <jacqueschen@google.com> Cr-Commit-Position: refs/heads/master@{#672084}
-
Sam Maier authored
This is a reland of eec7c07a Original change's description: > Using R8 in place of Proguard for creating main dex list > > Bug: 908988 > Change-Id: I9cfe718d3754b92022c9045f860dee36c7e049bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635949 > Commit-Queue: Sam Maier <smaier@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665957} Bug: 908988 Change-Id: I9d535df1e642f59a639865388b90fdd066a09802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650373 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f67ee5f..e198ec2f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57f2746d43103b9912b2235b6d590efd4e6fb010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675886Reviewed-by:
-
