- 18 Sep, 2020 40 commits
-
-
Eric Orth authored
Fixed: 1081186 Change-Id: I4a6a68b2368abf9a959c1a856536170958d9a694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416883Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#808367}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1539502. With Chromium commits locally applied on WPT: c2ab413e "CSS: Retire expansion-based implementation of :is and :where" aaab8ee4 "CSS: Rename new WPTs for uniqueness" e24e2d64 "Custom layout needs to force NG layout for the subtree." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Idaca15ca711c93e6a5104e27e781095b07f257ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418613Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808366}
-
James Cook authored
The API contract for ui::SelectFileDialog::SelectFile() allows a null owning_window, which should result in a modeless dialog not associated with a particular browser window. The lacros code used to assume owning_window was always non-null. This works for the common cases of open/save dialogs, but there's a code path for downloads that passes null. Add support for modeless dialogs by passing an empty owning shell window id for the SelectFile crosapi call. This is a non-breaking change. If a new lacros passes an empty window id to an older ash then the old code in ash will try to look up a shell surface window, fail, and bail out. Bug: 1129176 Change-Id: I6c71a573a411c1c5f4a6777dd7f102476201b102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417402Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#808365}
-
James Cook authored
Lacros is currently deploying trunk lacros-chrome to users running ash-chrome canary/dev/beta. This can make it hard to reason about which features are expected to work modulo the user's ash version. Add comments about the milestone each major new interface was added. We're hoping this helps a little with reasoning about compatbility, at least at a very high level. Bug: none Change-Id: I9bd79ffed130ebf85712145e31485d13080b22db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417510 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Steven Valdez authored
Change-Id: I968cf53ce3bee336eb478404ab34175fa6755f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416809 Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#808363}
-
Justin Cohen authored
TBR = alfonsogarza@google.com Bug: 1108809 Change-Id: I94e5332ad2832f25671848ecfda233a6b45dc655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418913Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808362}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors since OnSecurityEventEnterpriseConnector replaces this policy. Removing this policy completely is safe since it was marked as future and it has only been delivered as a cloud policy. Bug: 1103390 Change-Id: Ie886239acd53e28c5a9104812738b7627d082a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414550Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#808361}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d480934..ad83951e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29af5847d59ce06d42348c87d1b28a1ca29e0b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418614Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808360}
-
Victor Hugo Vianna Silva authored
After crrev.com/c/2415150, the class is no longer used from a background thread. This allows for a number of simplifications. - Removing all the synchronization code (synchronized blocks and lock). - updateSyncability() is now synchronous, so no need to expose the artificial callback parameter in ctor/updateAccount(). The associated code in the test file (CallbackHelper and updateAccountAndWait()) can also be removed. This also requires some adaptations: - Every call to the public API is guarded by assertOnUiThread(). - Tests that called the API from the test thread now use the methods in AndroidSyncSettingsTestUtil on runOnUIThreadBlocking(). Non-related to all this, the CL also takes care of the quick cleanup post crrev.com/c/2415150: AndroidSyncSettingsObserver implementations don't have to post a task anymore, since they are now notified directly in the UI thread. Fixed: 1028568 Change-Id: I8526cf67b26c97b3303510fbf0f4f0fc737617f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414194 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808359}
-
Christian Dullweber authored
Create "fade-through" animation to switch between main page and subpage. Remove animation for page-info rows. Video: https://crbug.com/1077766#c42 Bug: 1077766 Change-Id: I330b57b79a0e6dbd421b1d10ac897f16246f2f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418373Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#808358}
-
Viktor Semeniuk authored
Test was flaky because objects in the test scope weren't deallocated properly. Changing to BlockCleanupTest is fixing it. Bug: 1126660 Change-Id: If301a7c27a6170b2a12831ea06c78e7f1e204a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414230 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808357}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68c424fe4240..97813ea40eea 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 399f7fd741f7 to a148cdd49041 (1 revision) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 46fc663a1cb3 to d6935becabad (6 revisions) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 34ef0c3fdc8e to 50ae4c5f4427 (3 revisions) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from b045bf7d3b6a to 6ccc0d9ba0ff (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I5407ab46da1b7247acc87f959c5b363a5bca6b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808356}
-
Peter Boström authored
These arguments are essentially mandatory and call sites set both of them. Bug: 1106422 Change-Id: I85483306b70509e3b5cd0db5559179c88bc97b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417062 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808355}
-
Vasiliy Telezhnikov authored
Creation of eglImage can fail if context is lost. This CLs adds check that |source_texture_holder_| is not nullptr to avoid crash. Bug: 1129798 Change-Id: I91c351fa7932bda9074182090e6ede62cfc05ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418892Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#808354}
-
Joshua Pawlicki authored
- guidance is that owners should be committers, so removed mila for now. - linked Android and iOS Omaha clients to updater ownership. - salute to cpu@, but probably it is time to remove. Change-Id: I8beda0126d99a31b141c0f86bae6716e0c46446f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419031Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#808353}
-
Xi Han authored
In this CL, we make the following changes for MVP: 1) Hide the incognito switch on MVP start surface home page. 2) "Open a new incognito tab" will open a regular incognito tab without the home button. 3) Don't hide the incognito switch on Grid tab switcher. The Grid tab switcher can be reached from either "view all" button or the "tab switcher" button on a tab. Mock: https://docs.google.com/presentation/d/1ejI8l08SHOHF81rBXNWLMIJlNeMWHOTdnrU4VBq1UPE/edit?ts=5f4edb29#slide=id.g948759a467_0_0 Bug: 1108993 Change-Id: I01b4f6a569cfd663cc10f98e3b1be9a6e1dc1601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392736 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#808352}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600192792-f4ca908cacd319b04516240c34a315b960a046b2.profdata to chrome-win64-master-1600408689-3295f79c407879ba1d63e0363bb7fc826852b30c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7202874fb9f979d5aa261acf505712f5867eca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418016Reviewed-by:
-
Peng Huang authored
We found some Mali GPU, Android surface control cannot present AHB correctly if the AHB Vulkan image's layout is not VK_IMAGE_LAYOUT_PRESENT_SRC_KHR. Fix the problem by setting the layoout after each accessing. Bug: 1127432 Change-Id: Id1efcde8824936dad5536b5f75a233d8ea968bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414677 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808350}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d875587d515..70026f9d14f0 2020-09-18 kwiberg@webrtc.org Put UntypedFunction in untyped_function.h, not function.h 2020-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9cee95fc..86ce521c (808139:808263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0da03f6637642f5ca5637205bf60364f46f39922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418831Reviewed-by:
-
Friedrich Horschig authored
Instead of just telling users what a chip fills, highlight that a chip is an *autofill suggestion* provided by *Chrome*. IDS_IPH_KEYBOARD_ACCESSORY_FILL_WITH_CHROME screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/1b93b6afc656909bacdf8f62712a21b5990c7ac4 Bug: 1124711 Change-Id: Iefb80ccd3f59a865da661cf51d1308095c58fcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418312Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808348}
-
Michael Thiessen authored
Introduces JUnitTestGURLs, which returns GURLs generated from serialized GURLs for use in junit tests where the native library cannot be loaded. This allows junit tests to do simple operations with GURLs and allow unit testing of classes that use GURL without caring too much about more complex things like formatting or comparing origins, etc. The alternative to this is migrating the junit tests to instrumentation tests, but this isn't always feasible. For example, QualityEnforcerUnitTest is really difficult to re-write as an instrumentation test because of how it mocks out Activity behaviour and tests toasts. Bug: 783819 Change-Id: I37cf3a869958bd30e7ae86d2b212fd19961c1d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417063Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808347}
-
Jesse Schettler authored
When scanning is disabled, the scan SWA is disabled and chrome://scanning is forwarded to chrome://app-disabled. Bug: b:167569193 Change-Id: Ib9b3eb83f501470f6711a954abb68f12b479cead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406180 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#808346}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eaa69c21c45..4dcc12d1a441 2020-09-18 rex.xu@amd.com SPIRV: Add more utility functions to build some opcodes (#2398) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: If6d867a6904166d92a14b06aea3b50dfab8d682b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418871Reviewed-by:
-
Clark DuVall authored
I forgot to fix this earlier, this makes it so manifest paths don't need to be fully qualified. Bug: 1126301 Change-Id: I586e9830d61b0a1c76f5f357657b1d6e78e1b742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417541Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808344}
-
Benoit Lize authored
PartitionAlloc's main lock is the per-PartitionRoot lock. It has to be fast on the common uncontended path, and better than a simple spinlock when it's contended. Past attempts to replace it with base::Lock regressed low and high-level benchmarks. This commit introduces SpinningFutex, a futex()-based lock which spins in userspace like SpinLock before calling into the kernel, like base::Lock does. It is intended to be as fast as SpinLock, but better for contended cases. Since it relies on the linux-specific futex() system call, this is only available on Linux-based kernels, for now. Bug: 1125866, 1125999, 1061437 Change-Id: I1e0cf23beb48c32518d0ffc293d1a9326bc2d7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409902 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808343}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/076fddf19f32..913c13b2757b 2020-09-18 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityAttributesView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I462987aa0d7567fdc3ca74b9d28270ccb3ee9eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418365Reviewed-by:
-
Titouan Rigoudy authored
The is_web_secure_context bit for a document should take into account the bit set on its parent, if any. This is not the case for now, so this test demonstrates the bug. Bug: chromium:1126856 Change-Id: I45ebe97f0eb50034f933048b37f3c68eb778dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414248 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808341}
-
Francois Doray authored
crbug.com/1121339 indicates that there can be a null-pointer access in ContentToVisibleTimeReporter::RecordHistogramsAndTraceEvents() on Mac since 87.0.4241.0. The accessed variable is likely |tab_switch_start_state_|. Since |tab_switch_start_state_| is set before issuing RecordHistogramsAndTraceEvents() callback and reset at the end of that callback, a null-pointer access suggests that TabWasShown() was invoked twice, without a call to RecordHistogramsAndTraceEvents() or TabWasHidden() in-between. To mitigate the crash, this CL invalidates previously issued callbacks when TabWasShown() is invoked. This mitigation is useful to avoid crashes in branch M87. In a separate CL, we will add a DumpWithoutCrashing() to diagnose cases where TabWasShown() is invoked twice, without a call to RecordHistogramsAndTraceEvents() or TabWasHidden() in-between. Bug: 1121339 Change-Id: I6526cf3a001e9647c5f8ec1081f4747f94a160f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414408 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec598d5b00eb..feb4d10f7b2d 2020-09-18 mtklein@google.com tweak gathers in skvm interpreter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I7a91fb3ece1337c5c5cdf859e6086b11d465d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418364Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cf89f57dc90..236701a9c910 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andruud@google.com Change-Id: I13b28e3ed35bd7c02d74ecf473b4acbd3b379dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808338}
-
Benoit Lize authored
ThreadCache::Purge() is called from PartitionRoot::PurgeMemory(), which holds the lock, whereas freeing the thread cache memory in ThreadCache::Purge() calls PartitionRoot::RawFreeStatic(), which also acquires the lock. This deadlocks the allocator. Bug: 998048 Change-Id: Ifd61b3c463ed2372adf6a1b479ace1c9eab86da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418311 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Dave Tapuska authored
In order to use this definition in blink we need to move it outside of content. Since the definition of the header file is in cc, it makes sense to move this into cc as well. BUG=1097816 Change-Id: Ifce47e0cc3f4ff4d2460cc274cadc1377fd24252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411941Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#808336}
-
Charlie Hu authored
This CL updates comments and fuzzer seeds content according to current document policy syntax and document policy feature names. Bug: 1113375 Change-Id: Ia751abcaeb970436b73e0af8dd1f7031a96dfe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416876Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#808335}
-
Morten Stenshorne authored
And vice versa: Treat legacy objects as monolithic inside NG block fragmentation. The two block fragmentation implementations (NG and legacy) cannot cooperate, so once we switch engine somewhere inside a fragmentation context, we need to treat that subtree as monolithic. This requires us to specify which fragmentation engine is being in use when calling GetPaginationBreakability(), at least when possible at all. This required some work in LayoutFlowThread and LayoutMultiColumnFlowThread. Bug: 1127112 Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#808334}
-
Luke Zielinski authored
results-viewer For any test that is run we attempt to lookup its associated metadata ini files in the source tree. If it exists, it gets copied to the results viewer directory and renamed to <test>-expected.txt Bug: 1127360 Change-Id: Ie2f68e9f07c468918b69be041d247a1033ce500c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412622Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#808333}
-
Victor Vasiliev authored
This switches all QUICHE container aliases to the appropriate type of hash map, switches optional to absl::optional, and also changes some of the macros. Bug: 1128392 Change-Id: I47384d899c509170cd8d46208ee6a7eeac78d59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416945Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808332}
-
Takashi Sakamoto authored
Change-Id: Ibbc7228faedc039a679864e11dd17763ebed97c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415754 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2cf9523..1d480934 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a79cdd31561ded4b07a3e49edd75f966548530b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418611Reviewed-by:
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves content::UniqueNameHelper to blink, and a unit test file will be moved with a followup CL for moving {page_state_serialization.cc, h} by the dependency. Bug: 1110246 Change-Id: Iaae877403e27eeda2146191854e1a6f2b29f2e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415912Reviewed-by: -
Henrique Ferreiro authored
This allows to remove explicit typedefs from cursor.h. Bug: 796644 Change-Id: I91a8faf3a2a478a2d834795a4701114d17f9ea64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416592Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#808328}
-
