GitLab

The WebView swaps container views when transitioning
from/to fullscreen. This change ensures that
anchor views are transferred across container views too.

We also remove the PowerSaveBlocker attached to the
ContentVideoView because as a result it is not longer
needed. We now reuse the PowerSaveBlocker attached to
the WebContents which is implemented as an anchor
view. This has a number of advantages:
1. The PowerSaveBlocker now works correctly between
   transitions from/to fullscreen.
2. A PowerSaveBlocker is now also created for video
   elements contained inside a div (for these a
   ContentVideoView is not created when going
   fullscreen).

This change depends on:
https://codereview.chromium.org/639923003/

This change also adds comprehensive tests to verify the
new behaviour. For this we need a longer video, so we
replace the old one-frame test video. We also refactor
the tests to remove flakiness and unnecessary complexity.

BUG=398485

Review URL: https://codereview.chromium.org/639413002

Cr-Commit-Position: refs/heads/master@{#302094}

Revert of Disable WebRTC benchmark due to flakiness. (patchset #1 id:1 of https://codereview.chromium.org/684023002/)

Reason for revert:
Committed fix for flakiness: https://codereview.chromium.org/688163003/

Original issue's description:
> Disable WebRTC benchmark due to flakiness.
>
> TBR=tonyg@chromium.org, phoglund@chromium.org
> BUG=428157
>
> Committed: https://crrev.com/64709a0055eb91ceb5d29b4d6bfdaefa8380143d
> Cr-Commit-Position: refs/heads/master@{#301753}

TBR=phoglund@chromium.org,tonyg@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=428157

Review URL: https://codereview.chromium.org/688343002

Cr-Commit-Position: refs/heads/master@{#302093}

BUG=425996

Review URL: https://codereview.chromium.org/686503002

Cr-Commit-Position: refs/heads/master@{#302092}

This makes it easier to interpret log messages that contain enum values.

BUG=none

Review URL: https://codereview.chromium.org/689903002

Cr-Commit-Position: refs/heads/master@{#302091}

The code for importing/exporting pkcs8/spki is not specific to RSA. Extracting it so it can be shared by the EC implementation.

BUG=399094

Review URL: https://codereview.chromium.org/685213004

Cr-Commit-Position: refs/heads/master@{#302090}

This state should be decided according to aria-expanded attribute.

BUG=98982

Review URL: https://codereview.chromium.org/665843002

Cr-Commit-Position: refs/heads/master@{#302089}

Layout tests were previously running with visible_viewport_size uninitialized,
causing layout tests to fail when running with virtual-viewport mode enabled.

BUG=

Review URL: https://codereview.chromium.org/649673005

Cr-Commit-Position: refs/heads/master@{#302088}

There's a guess that the browser may be launching extremely slowly on
some bots and that when the browser main process is killed it's
leaking sub-processes that are in the middle of being spawned.
Increase the timeout to try to confirm this hypothesis.

BUG=424024
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/691683002

Cr-Commit-Position: refs/heads/master@{#302087}

This CL fixes the documentation of CrosSettings::PrepareTrustedValues()
which had gotten out of sync with the method's actual return value.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/690753002

Cr-Commit-Position: refs/heads/master@{#302086}

BM devices are enumerated and manipulated via DeckLink SDK.
Intermingling use of DeckLink SDK and AVFoundation seems to
produce bad results. This CL avoids adding these devices to the
AVFoundation enumeration.

BUG=426398, 408493

TEST=After running Chrome, plug in a thunderbolt Blackmagic
device, for instance an UltraStudio Mini. Wait 4 seconds or so,
then enumerate devices, e.g. using http://goo.gl/r0lnFQ. There
should be a number of UltraStudio Mini entries (or similar,
depending on which actual BM device is plugged in) but no
generic "Blackmagic" camera (those are the removed ones).

Review URL: https://codereview.chromium.org/690653002

Cr-Commit-Position: refs/heads/master@{#302085}

We decompose matrix, containing scale.
So we lose precision and get rotation due to
multiplication on 1.0/x instead of divide on x.

R=vollick@chromium.org

TEST=XFormTest.DecomposeTransform

Review URL: https://codereview.chromium.org/692593003

Cr-Commit-Position: refs/heads/master@{#302084}

As you indicated - this one is a simple re-ordering and can be TBR.

BUG=424679
TBR=sky@chromium.org
TEST=Covered by existing unit tests

Review URL: https://codereview.chromium.org/692883002

Cr-Commit-Position: refs/heads/master@{#302083}

Also updated presubmit script to not complain about default_for_enterprise_users
key in policy.

BUG=424190

Review URL: https://codereview.chromium.org/689953002

Cr-Commit-Position: refs/heads/master@{#302082}

Roll src/third_party/WebKit d4f55f9ea99bccd3b0fb321affca5c8e8ec96d7b:3c0b008b9a93ea227fb57d0d23b93e8affc3af08 (svn 184632:184648)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/694503002

Cr-Commit-Position: refs/heads/master@{#302081}

The migration is in support of Athena. InputAPI renamed VirtualKeyboardAPI to be more explicit as part of the migration. The Ash specific implementation details have been updated to depend only on Aura.

BUG=425702

Review URL: https://codereview.chromium.org/670003002

Cr-Commit-Position: refs/heads/master@{#302080}

R=jam@chromium.org, oshima@chromium.org
TBR=jam@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/692863002

Cr-Commit-Position: refs/heads/master@{#302079}

R=sadrul@chromium.org,mfomitchev@chromium.org,ananta@chromium.org
TBR=sadrul@chromium.org,mfomitchev@chromium.org,ananta@chromium.org

Review URL: https://codereview.chromium.org/687363005

Cr-Commit-Position: refs/heads/master@{#302078}

Roll src/third_party/WebKit 5d4e6a45858acb9904edad8ec8ff267713c2bc4f:d4f55f9ea99bccd3b0fb321affca5c8e8ec96d7b (svn 184626:184632)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/685383002

Cr-Commit-Position: refs/heads/master@{#302077}

Now that https://codereview.chromium.org/651063002/ has landed it's time to reenable cache tests on Windows.

BUG=425541

Review URL: https://codereview.chromium.org/664283006

Cr-Commit-Position: refs/heads/master@{#302076}

Cr-Commit-Position: refs/heads/master@{#302075}

BUG=424469
NOTRY=true

Review URL: https://codereview.chromium.org/674053002

Cr-Commit-Position: refs/heads/master@{#302074}

This patch improves performance of CheckValidity() by removing calls to
leveldb::DB::Get() from loops.

As a result the performance improved by 1.92x on Yoshi, for a testing account
with a lot of files.

Note, that base::hash_map is used, as its much faster in this case. Using
std::map gave only 1.39x performance gain over the former solution.

TEST=unit_tests: *ResourceMetadataStorageTest*, also tested manually.
BUG=418873

Review URL: https://codereview.chromium.org/638543002

Cr-Commit-Position: refs/heads/master@{#302073}

Put now calls Delete before CreateEntry, this requires a new callback PutDidDeleteEntry.

BUG=426562

Review URL: https://codereview.chromium.org/649203005

Cr-Commit-Position: refs/heads/master@{#302072}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/671913008

Cr-Commit-Position: refs/heads/master@{#302071}

Remove the constraint that tab.url has to match the tab's URL, because
this limitation prevents extension authors from using the media stream
in a frame whose origin differs from the top-level frame.

Updated the documentation to document this new behavior, and also added
a note about the validity (lifetime) of streamId because this important
piece of information was not documented. The expiry time is documented
to be "a few seconds" instead of the actual ten seconds, to encourage
extension authors to only call chooseDesktopMedia when they are prepared
to immediately handle the stream when it becomes available.

BUG=425344

Review URL: https://codereview.chromium.org/669623007

Cr-Commit-Position: refs/heads/master@{#302070}

We have a crash bug related to redirection, but I couln't understand the
mechanism so far. This CL adds some functions to see the actual path from the
crash dump.

BUG=399535

Review URL: https://codereview.chromium.org/683923003

Cr-Commit-Position: refs/heads/master@{#302069}

To prepare TSCS for componentising, this CL removes the knowledge about MSDS out of TSCS, by pulling out MSDS-specific processing from TSCS to MSDS.
Some tests had to be changed in a non-trivial way to preserve the coverage, in particular, some TSCS unit-tests needed to become MSDS browsertests (as wiring up everything needed for MSDS would be too messy in a unit test).

BUG=387075,395060

Review URL: https://codereview.chromium.org/678023002

Cr-Commit-Position: refs/heads/master@{#302068}

Clean up redundant PRESUBMIT files.

linux_redux has been 100% red since at least August 2014,
and is presumably not useful.

BUG=380709
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/685363002

Cr-Commit-Position: refs/heads/master@{#302067}

Revert of Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444 (patchset #6 id:120001 of https://codereview.chromium.org/683583002/)

Reason for revert:
Suspected to cause android bot failures:
New warnings.
Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface_Internal$ImportedInterfaceDoSomethingParams.equals(Object)  At ImportedInterface_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.math.Calculator_Internal$CalculatorClearParams.equals(Object)  At Calculator_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.mojo.IntegrationTestInterface2_Internal$IntegrationTestInterface2Method0Params.equals(Object)  At IntegrationTestInterface2_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithParameterAndEmptyResponseResponseParams.equals(Object)  At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseParams.equals(Object)  At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseResponseParams.equals(Object)  At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.EmptyStruct.equals(Object)  At EmptyStruct.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.sample.NamedObject_Internal$NamedObjectGetNameParams.equals(Object)  At NamedObject_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.test_structs.EmptyStruct.equals(Object)  At EmptyStruct.java
--------------------------------------------------------------------------------

*** 9 FindBugs warnings! ***
*** 9: new ***

Original issue's description:
> Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444
>
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/37273cab357d03ad9d2bcfa4ae467567ce93e2c4
> Cr-Commit-Position: refs/heads/master@{#302038}

TBR=jamesr@chromium.org,aa@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/694463002

Cr-Commit-Position: refs/heads/master@{#302066}

This CL is a part of https://codereview.chromium.org/665023002/ ("Post-commit
fixes for "stale-while-revalidate..."") that has been separated into a separate
CL because it depends on https://codereview.chromium.org/669083002/ ("Add
logging support for base::Time* types.").

BUG=348877

Review URL: https://codereview.chromium.org/670303003

Cr-Commit-Position: refs/heads/master@{#302065}

BUG=427526

Review URL: https://codereview.chromium.org/680923002

Cr-Commit-Position: refs/heads/master@{#302064}

Previously if drive sync over cellular network is disabled, pinning a drive file
is pending without notificaiton.

This CL lets Files.app show the notifiction.

BUG=279476
TEST=DriveSpecific/FileManagerBrowserTest.Test/4

Review URL: https://codereview.chromium.org/676653002

Cr-Commit-Position: refs/heads/master@{#302063}

Revert of Adds ozone support for ime keyboard. (patchset #7 id:120001 of https://codereview.chromium.org/683773002/)

Reason for revert:
Change doesn't compile on Linux ChromiumOS Ozone Builder

http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Builder&number=6030

Original issue's description:
> Adds ozone support for ime keyboard.
>
> BUG=342336
>
> Committed: https://crrev.com/8be55caf3d38bba7645de143f7e6b8b655fdd36c
> Cr-Commit-Position: refs/heads/master@{#302057}

TBR=shuchen@chromium.org,fengyuan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=342336

Review URL: https://codereview.chromium.org/689873004

Cr-Commit-Position: refs/heads/master@{#302062}

Roll src/third_party/WebKit b4fcaad1f8a5c9f7e22f699f41a98dbb954cc4f2:5d4e6a45858acb9904edad8ec8ff267713c2bc4f (svn 184589:184626)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/688243002

Cr-Commit-Position: refs/heads/master@{#302061}

Review URL: https://codereview.chromium.org/686193002

Cr-Commit-Position: refs/heads/master@{#302060}

BUG=424785
TEST=manually. athena_unittests passes.

Review URL: https://codereview.chromium.org/633403003

Cr-Commit-Position: refs/heads/master@{#302059}

This CL adds the canonical cookie that changed and a boolean indicating
if it was removed or added to the cookie changed callback.

It also sets a clear contract when the cookie changed notification callback
is called and documents it in |cookie_store.h|

BUG=NONE

Review URL: https://codereview.chromium.org/673633003

Cr-Commit-Position: refs/heads/master@{#302058}

BUG=342336

Review URL: https://codereview.chromium.org/683773002

Cr-Commit-Position: refs/heads/master@{#302057}

I accidentally committed http://crrev.com/455623003 before getting LGTM from
mmenke@. This CL is for additional fixes that he requested.

BUG=348877
TEST=net_unittests

Review URL: https://codereview.chromium.org/665023002

Cr-Commit-Position: refs/heads/master@{#302056}

Revert of Enable ChannelMojo on Linux (patchset #1 id:1 of https://codereview.chromium.org/684323002/)

Reason for revert:
Caused multiple layout test crashes on Linux

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Feffect-reference-subregion-hidpi-hw.html%2Ccss3%2Ffilters%2Feffect-reference-subregion-hidpi.html%2Ccss3%2Fimages%2Fpixelated-hidpi.html%2Cfast%2Fhidpi%2Fimage-set-as-background.html%2Cfast%2Fhidpi%2Fimage-set-background-dynamic.html%2Cfast%2Fhidpi%2Fimage-set-background-repeat-without-size.html%2Cfast%2Fhidpi%2Fimage-set-background-repeat.html%2Cfast%2Fhidpi%2Fimage-set-border-image-comparison.html%2Cfast%2Fhidpi%2Fimage-set-border-image-dynamic.html%2Cfast%2Fhidpi%2Fimage-set-border-image-simple.html%2Cfast%2Fhidpi%2Fimage-set-in-content-dynamic.html%2Cfast%2Fhidpi%2Fimage-set-out-of-order.html%2Cfast%2Fhidpi%2Fimage-set-simple.html%2Cfast%2Fhidpi%2Fimage-set-without-specified-width.html%2Cfast%2Fhistory%2Freplacestate-nocrash.html%2Chttp%2Ftests%2Finspector%2Fnetwork%2Flong-script-content.html%2Chttp%2Ftests%2Fxmlhttprequest%2Fsimple-cross-origin-progress-events.html%2Csvg%2Fas-image%2Fsvg-as-image-canvas.html%2Csvg%2Fcss%2Fsvg-resource-fragment-identifier-img-src.html

Regressions: Unexpected crashes (19)
  css3/filters/effect-reference-subregion-hidpi-hw.html [ Crash ]
  css3/filters/effect-reference-subregion-hidpi.html [ Crash ]
  css3/images/pixelated-hidpi.html [ Crash ]
  fast/hidpi/image-set-as-background.html [ Crash ]
  fast/hidpi/image-set-background-dynamic.html [ Crash ]
  fast/hidpi/image-set-background-repeat-without-size.html [ Crash ]
  fast/hidpi/image-set-background-repeat.html [ Crash ]
  fast/hidpi/image-set-border-image-comparison.html [ Crash ]
  fast/hidpi/image-set-border-image-dynamic.html [ Crash ]
  fast/hidpi/image-set-border-image-simple.html [ Crash ]
  fast/hidpi/image-set-in-content-dynamic.html [ Crash ]
  fast/hidpi/image-set-out-of-order.html [ Crash ]
  fast/hidpi/image-set-simple.html [ Crash ]
  fast/hidpi/image-set-without-specified-width.html [ Crash ]
  fast/history/replacestate-nocrash.html [ Crash ]
  http/tests/inspector/network/long-script-content.html [ Crash ]
  http/tests/xmlhttprequest/simple-cross-origin-progress-events.html [ Crash ]
  svg/as-image/svg-as-image-canvas.html [ Crash ]
  svg/css/svg-resource-fragment-identifier-img-src.html [ Crash ]

Original issue's description:
> Enable ChannelMojo on Linux
>
> This change enables ChannelMojo on Linux.
> There could possibly be a perf slowdown, especially
> on latency metrics.
>
> If you're looking for the cause of some perf bot redness,
> probably this is that one. Please feel free to revert and
> let me know which benchmark was hit.
>
> BUG=664413003
> R=viettrungluu@chromium.org
>
> Committed: https://crrev.com/d4d85c640375ea7f9692e53860f4de058a7f0ea1
> Cr-Commit-Position: refs/heads/master@{#301992}

TBR=viettrungluu@chromium.org,morrita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=664413003

Review URL: https://codereview.chromium.org/673903005

Cr-Commit-Position: refs/heads/master@{#302055}