GitLab

We can use a WebContent to open a new tab instead of a Browser.

TEST=unit_tests --gtest_filter=TranslateBubbleViewTest.*

Review URL: https://codereview.chromium.org/106793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242077 0039d316-1c4b-4281-b951-d872f2087c98

Previously the animation of progress items is broken and sometimes we cannot
detect the end of animation. This causes to remain the completed progress item.

The root cause is the progress track's width becomes 100% before the animation
starts. The ProgressCenterPanel is passed the reference of ProgressItem, and
refers it in a callback function, where the item value can be updated.

This CL make the ProgressCenterPanel save the item value in a local variable and
refer the variable in a callback function.

BUG=329400
TEST=Create 5 file and 5 directory, delete them in debug build.

Review URL: https://codereview.chromium.org/93633009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242076 0039d316-1c4b-4281-b951-d872f2087c98

ChangeInputMethodInternal called by EnableLayouts checks if component_extension_ime_manager_ is initialized or not.  When it is not initialized, active_input_method is not updated even if the new input method is a keyboard layout.

This patch checks if the new input method is a keyboard layout or not too.

BUG=329061

Review URL: https://codereview.chromium.org/118273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329832

Review URL: https://codereview.chromium.org/113673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242074 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
BUG=324225

Review URL: https://codereview.chromium.org/107083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242073 0039d316-1c4b-4281-b951-d872f2087c98

This renames *OnFileThread methods to *OnFileTaskRunner because now they run
not on FILE thread but on file_task_runner. And also adds some DCHECK for
checking valid task_runner into SandboxFileSystemBackendDelegate.


BUG=n/a
TEST=n/a
TBR=michaeln@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/101393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242072 0039d316-1c4b-4281-b951-d872f2087c98

DevTools window: split width and height are gone, and instead
contents insets are introduced. These insets are used for layout
in browser window. Having insets instead of rect allows for faster
regular-case resize occuring immediately in layout:
we keep DevTools of the same size and resize the page contents.

Views: removed SplitView and ContentsContainer, but instead added
ContentsLayoutManager which layouts DevTools and page contents taking
insets into account. It also supports active top margin, moved from
ContentsContainer.

Mac: removed NSSplitView, but instead added DevToolsContainerView
which resizes subviews manually taking page insets into account.

Gtk: removed both contents_vsplit and contents_hsplit, but instead
added devtools_floating_container which positions page contents
taking insets into account.

Next step will remove dock side knowledge from the browser, and leave it
on frontend only.

BUG=318751

Review URL: https://codereview.chromium.org/63173016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242071 0039d316-1c4b-4281-b951-d872f2087c98

Plugin windows are redrawn after EndDeferWindowPos call anyway.
Redrawing in SetWindowRgn causes plugin windows to be drawn on browser chrome.

BUG=

Review URL: https://codereview.chromium.org/118163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242070 0039d316-1c4b-4281-b951-d872f2087c98

This is the first part of the CL that will enable re-sending feedback reports that were sent when the user was offline, across sessions.

R=jcivelli@chromium.org, zork@chromium.org
BUG=249853

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241962

Review URL: https://codereview.chromium.org/116863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242069 0039d316-1c4b-4281-b951-d872f2087c98

Fix some tests that fail when it is enabled.

BUG=326832

Review URL: https://codereview.chromium.org/110913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242068 0039d316-1c4b-4281-b951-d872f2087c98

Update CRAS unittests to pass the new audio log factory argument introduced
to AudioManager's constructor to make media_unittests compile again.

BUG=None
TEST=Build media_unittests for CrOS, run CRAS tests.

Review URL: https://codereview.chromium.org/116653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329978
TEST=none
R=aedla@chromium.org,palmer@chromium.org

Review URL: https://codereview.chromium.org/115733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242066 0039d316-1c4b-4281-b951-d872f2087c98

We use a custom state machine to handle animations during drag and drop. The
state machine expects continuous callbacks from the NSDraggingDestination, even
if the mouse isn't moving. We were not providing continuous callbacks.

BUG=132850
TEST=manual

Review URL: https://codereview.chromium.org/109693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329756
TEST=Verified in sandbox.

Review URL: https://codereview.chromium.org/103163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242064 0039d316-1c4b-4281-b951-d872f2087c98

HttpByteRange by its nature represents ranges in inclusive format.
We should avoid using it during computation that might involve
empty ranges. In the old code, [0-*].ComputeBounds(0) was failing.

BUG=329328

Review URL: https://codereview.chromium.org/93883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242063 0039d316-1c4b-4281-b951-d872f2087c98

This is an attempt to fix flaky page scroll unittests in win aura.

BUG=328970
BUG=323249
BUG=297960

Review URL: https://codereview.chromium.org/117333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242062 0039d316-1c4b-4281-b951-d872f2087c98

Activity in Native Client plugins results in IPC messages 
sent to the BrowserPpapiHostImpl and routed to call 
extensions::ProcessManager::KeepaliveImpulse. 

Testing patch, builds on implementation. See: 
https://codereview.chromium.org/61063003/ Implementation.
https://codereview.chromium.org/105873003/ Cumulative patch. 

Design doc: 
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# 

BUG=298339

Review URL: https://codereview.chromium.org/111563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242061 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new GYP target for building Java unittests for Chromoting,
including a simple unittest example.

BUG=322095

Review URL: https://codereview.chromium.org/115953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242060 0039d316-1c4b-4281-b951-d872f2087c98

Without this fix demoted changes are not correctly promoted

BUG=330116, 240165
TEST=manual with logging (update - delete conflict)
R=nhiroki@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/119793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242059 0039d316-1c4b-4281-b951-d872f2087c98

I left these deletions out of my reviewed CL when I recreated it because Rietveld kept getting confused about whether I was deleting/renaming a file.

Since the deletions were already reviewed on the original CL I'm TBR-ing this change.

TBR=kalman
BUG=328441

Review URL: https://codereview.chromium.org/119303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242058 0039d316-1c4b-4281-b951-d872f2087c98

Possibly be a bot issue, but it's piling up tons of jobs in CQ,
so let me tentatively disable this to make things saner.

(Feel free to revert this change if this should just succeed)

BUG=330146
TBR=sadrul

Review URL: https://codereview.chromium.org/110633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242056 0039d316-1c4b-4281-b951-d872f2087c98

* Remove an obsolete code path (Blink side is in a separate patch).
* Re-wrap some IPC handler lines to 80-col

BUG=330077
TEST=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/119683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242054 0039d316-1c4b-4281-b951-d872f2087c98

After this was landed almost all tests in ash_unittests are crashing.
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20Aura&number=13804
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/13804/steps/ash_unittests/logs/stdio

> Get Windows 8 ASH to work again. 
> 
> This broke in revision 236017 which creates the compositor in the ctor of the RemoteRootWindowHostWin class.
> This in turn uses the GetAcceleratedWidget function which returns the desktop window as the metro viewer is not yet
> connected to the browser.
> 
> Moving the CreateCompositor call to the RemoteRootWindowHostWin::Connected function fixes this.
> 
> BUG=none
> TBR=ben
> 
> Review URL: https://codereview.chromium.org/64363004

TBR=ananta@chromium.org

Review URL: https://codereview.chromium.org/119863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242053 0039d316-1c4b-4281-b951-d872f2087c98

TBR=joi@chromium.org
BUG=329295
NOTRY=true

Review URL: https://codereview.chromium.org/119763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242052 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/118953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242051 0039d316-1c4b-4281-b951-d872f2087c98

R=tsepez@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/108793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330047

Review URL: https://codereview.chromium.org/113233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242049 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/94013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242048 0039d316-1c4b-4281-b951-d872f2087c98

My previous change to simplify actually made the matching incorrect.

BUG=321439

Review URL: https://codereview.chromium.org/117213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242047 0039d316-1c4b-4281-b951-d872f2087c98

(these are the licenses used by libc++ and libc++abi)

BUG=329819
R=phajdan.jr@chromium.org, phajdan@chromium.org

Review URL: https://codereview.chromium.org/103493008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242046 0039d316-1c4b-4281-b951-d872f2087c98

To reduce the IPC overhead, repeated IDBCursor.continue()
calls trigger pre-fetching where multiple values are
fetched at once. As long as only simple continue() calls
are made, the pre-fetch cache can be used to service them.
Other calls invalidate the cache.

IDBCursor.advance() is like a continue() call that skips
over values; it is safe to use the cache as long as it is skipping within the pre-fetched range, so do so.

(TBR for a unittest 'friend' change)

TBR=jam

Review URL: https://codereview.chromium.org/104663007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242045 0039d316-1c4b-4281-b951-d872f2087c98

Also:
- Code changes to avoid race between enable and disable dump. (This is extremely unlikely in practice due to the file picker dialog when enabling, but may happen in tests.)
- Allow enable dump after PeerConnectionFactory creation. This avoids race in tests and also has the benefit of letting a user enable the dump during an ongoing call.

R=jochen@chromium.org, phoglund@chromium.org

Review URL: https://codereview.chromium.org/101063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242042 0039d316-1c4b-4281-b951-d872f2087c98

This code isn't needed anymore.

BUG=none
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/111633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242039 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to cause use-after-free on ChromeOS/Linux bot.
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%282%29/builds/15076/steps/browser_tests/logs/GetSyncCategoriesWithoutPassphraseSynchronous

Might be test-only, but reverting this as u-a-f doesn't sound good

> Add hook for extension to check sync status.
> 
> Adds a new function to preferencesPrivate that returns a list of
> unencrypted sync categories. Also changes preferencesPrivate to use a
> whitelist instead of being restricted to component extensions.
> 
> BUG=326678
> 
> Review URL: https://codereview.chromium.org/118413003

TBR=rfevang@chromium.org

Review URL: https://codereview.chromium.org/105533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242038 0039d316-1c4b-4281-b951-d872f2087c98

Rename ContentBrowserClient::RenderProcessHostCreated to RenderProcessWillLaunch. It is called each time a render process will be launched, and possibly several times during the lifetime of a RenderProcessHost.

BUG=none
TEST=no change
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/119463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242037 0039d316-1c4b-4281-b951-d872f2087c98

There will be new files added for the sticky keys UI in the future, and this
refactor improves organization for sticky keys code and is more inline with how
the other accessibility features are organized.

TEST=StickyKeysTests pass

Review URL: https://codereview.chromium.org/118543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=218643

Review URL: https://codereview.chromium.org/117303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242035 0039d316-1c4b-4281-b951-d872f2087c98

Test will land on the blink side.

BUG=329971
R=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/116363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=oshima
TBR=jamescook

Review URL: https://codereview.chromium.org/115683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242033 0039d316-1c4b-4281-b951-d872f2087c98