- 19 Jul, 2019 40 commits
-
-
Caleb Rouleau authored
This will allow us to move somve of these devices to the Pinpoint pool. Looks like we actually had some shards that were completely unused, so this fixes that as well. Bug: 985456 Change-Id: Iac536a90d4e36ae25fd90461f66c026fb22e23b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709161 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#678963}
-
Hirokazu Honda authored
histograms: Make RTCVideoDecoderError, RTCVideoEncoderProfile and Cast.Sender.VideoEncodeAcceleratorInitializeSuccess permanent RTCVideoDecoderError is an important histogram that we can be informed something wrong happens with HW accelerated video decoder in webrtc usecase. RTCVideoEncoderProfile is useful to know how often each codec is used and encoded with HW accelerated video encoder in webrtc usecase. Cast.Sender.VideoEncodeAcceleratorInitializeSuccess is an importat histogram that we can be informed initialization failure rate of HW ccelerated video encoder in cast use case. They should be permanent metrics. Bug: 975264, 975567 Test: None Change-Id: Ic603ac806672f6e9831b72d36ca733c12a105ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703323Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#678962}
-
Lukasz Anforowicz authored
Bug: 983981 Change-Id: Ib7cab712e7f42a6ccd194eec261b623ad7a1ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707101 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678961}
-
Khushal authored
CanvasResourceSharedImage::OnBitmapImageDestroyed can be triggered when the shared context stored in thread local storage is desroyed. The function uses Thread::Current() for checking which thread it is invoked on. Since Thread is also stored in TLS and there is no clear order in which TLS objects are destroyed, this can result in UAF if Thread is destroyed before the context. Avoid the above by using PlatformThreadId which uses low level platform APIs to get a unique thread id. R=kbr@chromium.org Bug: 984788 Change-Id: Ifb73fdf5fa07d9de8afbbf0aea876d3b30cbcea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709891 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678960}
-
Matt Menke authored
Version 5 was added over 3 years ago, so it seems past time to remove support for old formats. At worst, with old formats, server metadata will be lost, and server properties will need to be rediscovered. 3-year-old server properties are likely to be outdated, anyways. Also, we need to double-key data stored in this table, which will likely mean a new data format, and it's simplest to remove legacy format support before doing that. Bug: 969890 Change-Id: I3cd847a0a06a439969f05efe17224bf9d2be8d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704682 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678959}
-
arun manickam authored
Adding Fuchsia specific SysInfo APIs and removing OS_FUCHSIA conditions from POXIS SysInfo Implementation (Code Clean-up) Bug: b/136176387 Test: base_unittests Change-Id: I90a431bae3fe814d1aa7f14071a0ac68a1dce8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693741 Commit-Queue: Arun Manickam <arunmanickam@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e371cbd597d8..c0f06fa3e27e git log e371cbd597d8..c0f06fa3e27e --date=short --no-merges --format='%ad %ae %s' 2019-07-18 ahassani@chromium.org cros_flash: Use the new paygen library instead of devserver 2019-07-18 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c0f06fa3e27e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9e94b8c4c381cebec33a561992f2a4ba738844dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678957}
-
David Bokan authored
A long-standing behavior on the web is that scrolls chaining up from a position: fixed subtree should chain to the layout viewport. This allows scrolling a page by mouse wheeling over a position fixed banner. In BlinkGenPropertyTrees, the scroll tree changed the parenting behavior for nodes in a fixed subtree. These nodes used to be parented to the outer/layout viewport but BGPT made them parented to the inner/visual viewport. This breaks the above chaining behavior since we now try to scroll the visual viewport when chaining up from a fixed element, rather than the layout viewport. This CL changes behavior back to chaining scrolls from fixed content to the layout viewport. Note that we intentionally don't use the root scroller since this would mean that an element can chain scrolling to its sibling as in bug 977954. Also note that this breaks a small optimization. All descendant scrollers in a frame (including the frame) that has an element with a background-attachment:fixed require scrolling on the main thread due to the fact that we don't implement background-attachment fixed on the compositor; the background must be repainted on each scroll change. One exception to this *was* position: fixed scrollers since their position will never change when an ancestor is scrolled and so we don't have to repaint the fixed background. Previously this was done by setting the BackgroundAttachmentFixed reason on the layout viewport and propagating it down to child scroll nodes. Before scrolling on the compositor, we check all ancestor scroll nodes' MainThreadScrollingReasons. Parenting the fixed nodes to the inner viewport means they would miss having this MTSR set on them. With this CL they now get the MTSR. We assume this is a really obscure edge-case and would prefer to avoid the complexity of keeping this working. If this turns out to regress any of our metrics, there are some ideas in https://crbug.com/985127. Bug: 981749,985127 Change-Id: I27a5b42fff257ea7ff86deb5df0fc519a558235c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707062 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678956}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/91ec571d17df..49aae0f3bde2 git log 91ec571d17df..49aae0f3bde2 --date=short --no-merges --format='%ad %ae %s' 2019-07-19 jiawei.shao@intel.com Double the size of the ring buffer only when it is not big enough Created with: gclient setdep -r src/third_party/dawn@49aae0f3bde2 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I6a00c54d742192dfd25930901388359b178ee8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709969Reviewed-by:
-
rbpotter authored
This test was passing accidentally due to an issue with autofocus. The print-preview-user-manager should be necessary to make the test pass. Add it to the test. Bug: 979603 Change-Id: I44065fdfcd28ad69b46373805f67f37c6a16799c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704734 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#678954}
-
dpapad authored
Only used there. Bug: None Change-Id: I3b5d8772cb811ca7745959dae69738ac13280146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709882 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#678953}
-
Eric Roman authored
The callers can instead use NetLogEntry directly. Change-Id: I93f2b8885fffc065ce768f7cadf14cf44989f4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706773 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#678952}
-
chrome://flagsAndrii Sagaidak authored
When tab is clicked it's 'aria-selected' attribute should be set to true, and 'false' for other tabs. Bug: 983373 Change-Id: Iee49632cd3b517e5c8f8bbe383ea2d7c59a44f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699545Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678951}
-
Sunny Sachanandani authored
Chrome doesn't update SDR white level unless something causes us to update all displays e.g. startup, resolution change, etc. There's no notification for SDR white level change for win32 apps, but sushraja@ from MS suggested we can listen to WM_ACTIVATEAPP as a workaround to update displays when switching back to Chrome from the display settings app, and this seems to work great. Bug: 929030 Change-Id: If1d4875f8657303e1cef121505bca3fec24f61b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708995Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678950}
-
Juan Antonio Navarro Perez authored
No longer need to import benchmark_runner module for this. Depends on catapult CL landing first: https://chromium-review.googlesource.com/c/catapult/+/1704194 Bug: 981349 Change-Id: Idec7329dad65533efd155cde10f4c5205acf0593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702318Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#678949}
-
Wei-Cheng Xiao authored
Also replace cros-hwsec@ with cros-hwsec+uma so that it's easier to set up email filters. Change-Id: I247222815d5ab32369cf247504682ddbff1ef29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707837Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Cheng Xiao <garryxiao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678948}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: If662b31d052ea7ae2b775cd6d19635b98d3fbec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709788 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#678947}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ab53d93e90c..f4e0cc69eed3 git log 6ab53d93e90c..f4e0cc69eed3 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 ehmaldonado@chromium.org depot_tools: Remove rietvelt code. Created with: gclient setdep -r src/third_party/depot_tools@f4e0cc69eed3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:984182 TBR=agable@chromium.org Change-Id: I2b4299f648d4e845ee77be8d27db5b391a7e18c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709828Reviewed-by:
-
Sadrul Habib Chowdhury authored
To track the state of a BeginMainFrame, SENT and STARTED serve the same purpose: they indicate that a BeginMainFrame has been issued to the main-thread, and the main-thread has not responded to that yet. So remove STARTED state, and use only SENT instead. Document these states, and also ForcedRedrawOnTimeoutState. BUG=none Change-Id: I200337cfe0a8ec7544961b01abf22fbc56eea5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709153 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678945}
-
Zhenyao Mo authored
There is no clean way to shut down GLX, so it's best to fail GPU process launch. In GpuProcessHost::DidFailInitialize(), we will fallback to the next mode, which is SwiftShader, right away. BUG=971169 TEST=manual R=piman@chromium.org Change-Id: I615c2a9a956b081f48dbbfa1d7ba4768dd363f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707986 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Matt Reynolds authored
When a gamepad that supports vibration effects is removed and a vibration effect is still playing, Chrome tries to issue a command to stop vibration. If the device is already disconnected, the stop vibration command will fail. On Mac, Chrome implements an internal XInput driver for Xbox controller support. This driver detects when an I/O operation fails and signals the data fetcher to remove the gamepad. This can cause a loop where Chrome tries to repeatedly issue the stop vibration command. To fix this, the XInput driver will suppress I/O errors when the device is already shutting down. This CL also adds DCHECKs to ensure the gamepad's Shutdown method is called exactly once. BUG=982902 Change-Id: I960066f9b6da9e5135903cbd88d1447720eec9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709006Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#678943}
-
Abhishek Bhardwaj authored
This change uses ICU time library to handle time calculations. This is done because it handles rollovers, DST calculations and other tricky edge cases. Each time calculation now also uses the time zone of the device instead of relying on base::Time::LocalExplode and base::Time::FromLocalExploded. BUG=924762 TEST=Unit tests. Change-Id: I6fd8a17cd9f96994516cbaea06158d17abb467fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684642 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678942}
-
Min Qin authored
these UMAs are no longer monitored BUG=975247 Change-Id: I959e878a4f2b12391e9bf7bd59571e72c278a066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702941Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Kyle Milka authored
- Show the logo as white on the 'No background' tile. - Add dark mode box shadow to the selected state. - Fix the background color of the preview for 'No background'. Bug: 937570 Change-Id: I0f4a757dd5b1230b9a3c082fb92fc57f9c4dd276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708041 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678940}
-
Sunny Sachanandani authored
Before this change ui::Compositor would scale the output color space according to the SDR brightness slider in Windows. This has the side effect of also scaling HDR content which can cause it to be easily washed out. With this change the SDR scaling factor is propagated to viz where GLRenderer applies it selectively to SDR content only. This change also removes the plumbing for blending color space since it can always be derived from the output color space. It also adds tests for verifying that the color transform in GLRenderer's shaders match what we expect, and enables the shader compile tests on Windows which were disabled in 2015 due to timeouts. Bug: 926173 Change-Id: I0932fbc7b66b24b7ea4d28157d084f4e2ef2762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694150Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678939}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d4dfa671d07..6a02f06dfd4e git log 3d4dfa671d07..6a02f06dfd4e --date=short --no-merges --format='%ad %ae %s' 2019-07-18 geofflang@chromium.org Implement EGL_ANGLE_create_context_backwards_compatible Created with: gclient setdep -r src/third_party/angle@6a02f06dfd4e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I9b00f6a3e987507555c2bc9df193c0972999b2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709829Reviewed-by:
-
Luciano Pacheco authored
Division line got lost when we enabled MyFilesVolume flag which made MyFiles to have the default section. The division line is displayed when a new section starts in the directory tree. Change the test that checks for section to run with the flag enabled, code used when flag is disabled will be removed soon after M77 branch. Bug: 985415 Change-Id: I50957703426579b4203c47b88ac57f6b6c16dacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709313 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#678937}
-
Shakti Sahu authored
If chrome is killed right away after user pauses a download, the download DB doesn't commit. So next time the download is resolved to a failed state and hence it doesnot show up on download home. A possible solution is to treat paused as immediate commit to the DB. Bug: 985464 Change-Id: I21487266e0ff24c329c850a33549c105e639b87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709334Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678936}
-
Rose Garcia authored
Merged the basic text selection functionality from the text_input_manager.js to text_navigation_manager.js. Also added variables to keep track of the start and end node for the selection and and added functionality to hide the set selection end button is the start of the selection is not set and show it as soon as the start is set. Bug: 982004 Change-Id: I94b1e1dd3bf3636034276d0ee7db8c95a5711df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707036Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Rose Garcia <rosalindag@google.com> Cr-Commit-Position: refs/heads/master@{#678935}
-
Miyoung Shin authored
This CL renames interfaces to mojom in //components/services/pdf_compositor. components/services/pdf_compositor/public/interfaces => components/services/pdf_compositor/public/mojom Bug: 806965 Change-Id: I23eb351c36d6b90cb9cffdb1a8c360ca83a76215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706455Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
David Bokan authored
Since https://crrev.com/863d211743b2d3e510b786f9aafceb111c4661cb all tests have been running with fractional scroll offsets enabled so these suites are now redundant. Bug: 414283 Change-Id: Iaa820923a94daae080fd60ee7f22a65b735dd2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709548Reviewed-by:
-
Vlad Tsyrklevich authored
On Android, there are 3 ways that crashpad can be invoked: libcrashpad_handler.so, CrashpadHandlerMain, or by JNI invocation. This change introduces a custom CrashpadHandlerMain symbol instead of using crashpad's default and also routes JNI invocation to use our custom CrashpadHandlerMain. This allows Chrome to specify custom user stream data sources. A follow-up change will refactor libcrashpad_handler.so so that it also uses CrashpadHandlerMain. CQ-DEPEND=CL:1708759 Bug: 973167 Change-Id: I08a8bbf7bc668589810bbcb216d1c1033df10225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707405 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678932}
-
Miyoung Shin authored
This CL renames interfaces to mojom in //components/services/patch. components/services/patch/public/interfaces => components/services/patch/public/mojom Bug: 806965 Change-Id: I68a85abdf754de184f2b0c189e3fde8e02ea0ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708090Reviewed-by:
-
Aleks Totic authored
My initial attempt to enforce kLayoutClean instead of kAfterPerformLayout triggered 9 test failures. They all pass with kAfterPerformLayout. external/wpt/content-security-policy/navigate-to/anchor-navigation-always-allowed.html fast/block/positioning/absolute-layout-after-image-load.html fast/block/positioning/positioned-float-layout-after-image-load.html fast/dom/anchor-without-content.html fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html fast/dynamic/anchor-lock.html fast/events/node-event-anchor-lock.html fast/events/scroll-to-anchor-in-overflow-hidden.html fast/events/sequential-focus-navigation-starting-point.html Bug: 957026 Change-Id: I08dd91ff1ede07fb8671cba1649563b27d1a4495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593403 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678930}
-
Lei Zhang authored
https://chromium.googlesource.com/external/github.com/googlefonts/sfntly.git/+log/e24c73130c66..48312c98332a Created with: roll-dep src/third_party/sfntly/src TBR=drott@chromium.org BUG=960354 Change-Id: I7c7d982ba9648d04b05c6fe1407bf31920b08329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709003 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Pavel Yatsuk authored
Width of location bar depends on mTabSwitcherState (ToolbarPhone.updateUnfocusedLocationBarLayoutParams). After toolbar transitions from TAB_SWITCHER to STATIC_TAB state, location bar width should be updated. Because toolbar view doesn't request layout at the end of transition, location bar is displayed incorrectly. This CL introduces requestLayout() at the end of tab switcher state transition. BUG=974745 R=twellington@chromium.org Change-Id: I884cc1bd3d2a04b4d2ec4c667b38dc40acace559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698941 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678928}
-
Julian Watson authored
BUG=chromium:985398 Change-Id: I8e0820451df8b782451a1ea3986dab16e760ee18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709569 Auto-Submit: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#678927}
-
Nigel Tao authored
There's no behavior change, other than removing a DVLOG(2) message. But calling AppListModelBuilder's (the superclass') RemoveApp makes the ExtensionAppModelBuilder consistent with the other AppListModelBuilder sub-classes' methods (which all call AppListModelBuilder::RemoveApp): - AppServiceAppModelBuilder::OnAppUpdate - ArcAppModelBuilder::RemoveApp - CrostiniAppModelBuilder::OnRegistryUpdated Change-Id: Ic77e49f3e30125031796d40b629550326275da92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705480Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678926}
-
chrome://testrbpotter authored
- Add a test data source that serves files from chrome://test - Autogenerate HTML responses containing a single <script type="module"> with src set to a requested JS file at runtime. Request these responses by preloading chrome://test?module=JS_TEST_FILE.js - Remaining dependencies, other than mocha and mocha adapter, can be imported via the JS test module, instead of using |extraLibraries|. - Map requests for chrome://test URLs to the appropriate Web UI controller using a new webuiHost parameter for tests. Bug: 968804 Change-Id: I5b409bb54da5611be68fe590176edec3c7b668e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700294 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
This is only called in SingleThreadProxy, whose override of this function always returns true. So the function is removed, and instead |SchedulerSettings::commit_to_active_tree| is directly turned on. Change-Id: Iad171ac199e7f2e0f63526b3f6ffe45325b1bdff Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708049 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#678924}
-
