- 24 Aug, 2018 40 commits
-
-
Oksana Zhuravlova authored
This change also adds the deserializing logic to Entry, but the options are not used anywhere yet. Bug: 866967 Change-Id: Ibb66000a627ea8b4413e41bd2010a71f60db1dd4 Reviewed-on: https://chromium-review.googlesource.com/1180079Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#585908}
-
Jeremy Roman authored
This removes the last remaining use of WTF::Mutex::Locked, in favour of the most base-like AssertAcquired. Bug: 856641 Change-Id: I59e3a90ada3d6c27b2a958240e6863bc15cf1e0c Reviewed-on: https://chromium-review.googlesource.com/1185636Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585907}
-
Mugdha Lakhani authored
This is the second part, the plumbing on the blink side. Bug: 876691, 869918 Change-Id: I62fe4aaf37f41b5ebd341ce4731f7fda1d486feb Reviewed-on: https://chromium-review.googlesource.com/1185015 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585906}
-
bsheedy authored
Fixes an issue with instrumentation tests that contained annotations that returned arrays of primitives not being listed. This was being caused by an unconditional cast to an Object array, which is not allowed with arrays of primitives. The fix is to detect when we receive an array of primitives and manually copy it over to an array of primitive wrappers. This seems to only have been hit for ints with the recent switch to using IntDef for enums, but the fix works for any primitive type. Bug: 875909 Change-Id: I465b1b7bd8c8ec67229e18be13e6da6295de3baa Reviewed-on: https://chromium-review.googlesource.com/1185461 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585905}
-
Etienne Pierre-doray authored
AddressTrackerLinux::ReadMessage is invoked from the main thread. It should not be possible to instantiate ScopedBlockingCall in that case (adding AssertBlockingAllowed breaks browser_tests). pauljensen@ pointed out that blocking does not happen when |tracking_| is false. This CL is a short-term fix for bug 817151, instantiating ScopedAllowBlocking only when |tracking_| is true. Bug: 817151 Change-Id: Ic5970b4e1c4fefb5231a2d666948b8cc2b7cdf35 Reviewed-on: https://chromium-review.googlesource.com/1187388 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585904}
-
Anna Offenwanger authored
Removing TODO as it's not worth refactoring WebVR 1.1 specific files as they are being replaced with the WebXR concepts. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52e9f14e54c05e13d530cf952e1a9d7b573ff981 Reviewed-on: https://chromium-review.googlesource.com/1185221 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#585903}
-
Joe Downing authored
I'm making duplicates of the existing LocalInputMonitor classes and checking them in prior to the refactoring. This is make future CLs easier to review as I've found that the way Git handles branching of files isn't deterministic enough and so it is easy to lose history and diff bases if too much of the files are changed. Thus this CL. My plan is to introduce specific listener classes for Mouse, Keyboard, Touch, and 'Disconnect Hotkey'which will be passed to the LocalInputMonitor which will then create the appropriate input monitor for that input type. BUG=877176 Change-Id: I8b259e416a15b4b4c6f082481800066d97317040 Reviewed-on: https://chromium-review.googlesource.com/1184250Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#585902}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/367ed462b517..284c5139836c git log 367ed462b517..284c5139836c --date=short --no-merges --format='%ad %ae %s' 2018-08-24 thestig@chromium.org Fix a bug in make_expected.sh. Created with: gclient setdep -r src/third_party/pdfium@284c5139836c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id50214a8ca68ca030399d3455acceef7f2b89b7a Reviewed-on: https://chromium-review.googlesource.com/1188505Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585901}
-
Josh Karlin authored
Bug: 877148 Change-Id: I757fa7363dd11f4c2db534fc7dbc3b46174a623f Reviewed-on: https://chromium-review.googlesource.com/1188602Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585900}
-
Steven Valdez authored
Bug: boringssl:226 Change-Id: I335ff85b59021603ccbce63fa9b826cda0fbfaac Reviewed-on: https://chromium-review.googlesource.com/1185207 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585899}
-
Christian Fremerey authored
Change log level for logs that appear to be normal/expected behavior for certain webcams in order to reduce log spam. Bug: 743093 Change-Id: I4c0b4c05a84a9d17a9777b1310a1a741f729daf4 Reviewed-on: https://chromium-review.googlesource.com/1188435Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585898}
-
Robert Sesek authored
The builder is now on LUCI rather than the legacy buildbot master. Change-Id: I5ccaaa9dc317211daee8348f61b9eda068018314 Reviewed-on: https://chromium-review.googlesource.com/1188616Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#585897}
-
Takumi Fujimoto authored
Subtract margin width from the preferred widths of the media remoting and cloud services dialogs, so that they have the intended width. Bug: 875102 Change-Id: I362dd2bbae7f533df3f9f51d851c7f7b5d136908 Reviewed-on: https://chromium-review.googlesource.com/1187577Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#585896}
-
bsheedy authored
Adds support for running the existing VR instrumentation tests on standalone VR devices, specifically the Lenovo Mirage Solo. Main changes include: 1. Adding new restrictions to differentiate smartphone VR from standalone devices and only enable tests on standalone when they make sense to do so. 2. Work around tests starting in VR. 3. Fix various issues with running on standalone devices such as controller recentering behavior being slightly different. Bug: 876946 Change-Id: Ibb357e765768c0db9d08a8c7504ee8d14e0d31f3 Reviewed-on: https://chromium-review.googlesource.com/1186114Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585895}
-
Clark DuVall authored
This test uses an OSDD URL that gives a 404, so allow http errors for the SimpleURLLoader. It looks like this could flake if there was a delay between OnReceiveResponse and OnComplete. Bug: 870588 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I101894bba7c31fcc7a686ab79b6e6bb936c4c26c Reviewed-on: https://chromium-review.googlesource.com/1187667Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585894}
-
Mathieu Guay-Paquet authored
Change-Id: Ie5bdc719778c41ef473ce977c8698966e9b47001 Reviewed-on: https://chromium-review.googlesource.com/1161181 Commit-Queue: Mathieu Guay-Paquet <mguaypaq@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585893}
-
Kevin Marshall authored
The underlying cause of the flakes should be fixed in crrev.com/98f6ea73. TBR=wez@chromium.org Bug: 876894 Change-Id: Ic3549ff80afc6e8041a1195ab71d39b300789e78 Reviewed-on: https://chromium-review.googlesource.com/1187897Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585892}
-
Scott Violet authored
EasyResizeWindowTargeter only works if a targeter is not installed on the children of the container. This makes EasyResizeWindowTargeter work by explicitly checking the parent's WindowTargeter for SubtreeShouldBeExploredForEvent(). BUG=877099 TEST=covered by test Change-Id: If5de972623bfbffb87986958010f7c8c51d8b448 Reviewed-on: https://chromium-review.googlesource.com/1187625Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585891}
-
Justin Cohen authored
Adds highlight state to articles and most visited cells. Bug: 865834, 865836 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b299b99767136cc6b0517d29f3c6e2aebc3bb05 Reviewed-on: https://chromium-review.googlesource.com/1183627Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585890}
-
Troy Hildebrandt authored
Introduces some performance tests for ProtoDatabase, for writing individual entries, writing in batches, and writing/reading a single database containing all entries vs. separate databases. Reports time taken and memory used where appropriate. Bug:870813 Change-Id: I9c916f296afed63be4d414f4a2fe70541863d510 Reviewed-on: https://chromium-review.googlesource.com/1148889 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585889}
-
Clark DuVall authored
Add a flush because of http://crrev.com/c/1139048. Bug: 347159 Change-Id: Ia134666ecbf82ae99d429522178f605b009b40eb Reviewed-on: https://chromium-review.googlesource.com/1187375Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585888}
-
Andrew Grieve authored
The existing version was found to infinite loop at times. Also moves the jars to CIPD NOTRY=true # windows bot failing Bug: 876539 Change-Id: If822837f4958434372ef0cb40799aec32ec7cd37 Reviewed-on: https://chromium-review.googlesource.com/1187003 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585887}
-
Matthew Cary authored
Create an UnsafeSharedMemoryRegion from a SharedMemoryHandle. This creation method is only needed while transitioning to the new shared memory API. This enables in particular the media code to not add a dependency on mojo, via WritableUnalignedMapping. This dependency has caused problems, eg crbug.com/874074 and crbug.com/871429. Bug: 795291 Change-Id: Ie0603e55afac9d853d371548a99475d763034fa5 Reviewed-on: https://chromium-review.googlesource.com/1183910 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#585886}
-
Yi Fan authored
clock_gettime() doesn't call syscall SYS_clock_gettime when VDSO is enabled. some unittests would fail. This is happening on aarch64 kernel w/ CL "arm64: Add support for CLOCK_MONOTONIC_RAW in clock_gettime() vDSO". enforce to use syscall to SYS_clock_gettime to get around the failure Bug: internal b/110172084 Test: local test Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: Idc824403faaba7b8504bf89ba10f0ba50422c3f5 Reviewed-on: https://chromium-review.googlesource.com/1187586 Commit-Queue: Yi Fan <yfa@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#585885}
-
Francois Doray authored
NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks is a test that verifies that the first paint in a tab can happen when TaskPriority::BEST_EFFORT tasks don't run. Before this CL, the test's body ran a RunLoop until WebContentsObserver::DidFirstVisuallyNonEmptyPaint() was invoked. A timeout occured if the first paint occured before the test's body was entered. Having the first paint before the test's body is possible, because InProcessBrowserTest::PreRunTestOnMainThread() runs tasks before jumping to the test's body (see https://cs.chromium.org/chromium/src/chrome/test/base/in_process_browser_test.cc?l=486&rcl=8edfdb37ebe40b1ba4dae27a23d8edaeac09a0ee). This CL fixes the issue by skipping running the RunLoop if WebContents::CompletedFirstVisuallyNonEmptyPaint() is already true at the beginning of the test's body. This is one of multiple fixes that will allow us to enable the test on ChromeOS. Bug: 833989 Change-Id: I0ce024bda351059c4e0ba8648e1f0f0459eb19ac Reviewed-on: https://chromium-review.googlesource.com/1187131Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#585884}
-
nednguyen authored
Bug: 828468, 828443 Change-Id: Id790c23f48fda5d8f6444c5cf175e930f153c3ba Reviewed-on: https://chromium-review.googlesource.com/1188583Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585883}
-
Manu Cornet authored
This fixes a bug whereby when pinning or un-pinning an app in a way that didn't require a reorder (e.g. pinning the leftmost running app) did not cause the separator to appear. Bug: 877348 Change-Id: I2f509a32f69f4779806430b4c08a96268171edef Reviewed-on: https://chromium-review.googlesource.com/1187962Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585882}
-
Manu Cornet authored
This reverts commit 64679b34. Reason for revert: I need this functionality at another level of the stack (directly in Skia), reverting this not to add unnecessary complication. Original change's description: > Support rounded rects that don't have the same radius on all 4 corners > > Bug: 805612 > Change-Id: I86af86a62fe2e46691db6bfb2b24da404c93ec1d > Reviewed-on: https://chromium-review.googlesource.com/1130059 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573528} TBR=xdai@chromium.org,manucornet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805612 Change-Id: I6011952531594bba81c565e1a4bc004654399ece Reviewed-on: https://chromium-review.googlesource.com/1188702Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585881}
-
Sammie Quon authored
Suspected cl is hurting performance test in the bug. This was requested by a couple people, we can see if this fixes it and then discuss with ux a workaround. Test: manual Bug: 863304 Change-Id: I0dfdcc87cdfe99e80021cd8a94168bb976fbc02d Reviewed-on: https://chromium-review.googlesource.com/1188438Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#585880}
-
David Benjamin authored
This is leftover from https://codereview.chromium.org/2715513004. This will remove HttpAuthController's vtable and hopefully decrease code size. Change-Id: I61dbc388f006234a64cb0a87d6475c12ba6b724e Reviewed-on: https://chromium-review.googlesource.com/1187731Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585879}
-
Xiaohan Wang authored
- Add TriStateSiteSettingsPreference, a Preference that has three RadioButtonWithDescription, corresponding to Allowed, Ask and Blocked state respectively to be used for site settings. - The title of the 3 radio buttons are fixed: "Allowed", "Ask first", and "Blocked". - The descriptions of the 3 radio buttons are declared in ContentSettingsResources. - SingleCategoryPreferences is updated to support both the toggle and a new tri-state setting, only one of which will be shown. When the tri-state setting is shown: * Hide the read_write_toggle. * Initialize the TriStateSiteSettingsPreference * Listen to setting change in the TriStateSiteSettingsPreference - Update PrefServiceBridge to be able get/set the ContentSetting, instead of getting/setting a boolean. Screenshots of the new UI at https://photos.app.goo.gl/rgkh53VNkesAGXKa7 TBR=raymes@chromium.org Bug: 854737 Test: Manually tested. Change-Id: I1a19474960bec9b5677ec1dc8408ec487248787b Reviewed-on: https://chromium-review.googlesource.com/1179461 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585878}
-
Evan Stade authored
The wrong version of this DCHECK slipped by in b2270914 Bug: 640365 Change-Id: I9e1922c537851be269f483e98878bb2d200e9260 Reviewed-on: https://chromium-review.googlesource.com/1187712Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#585877}
-
Eliot Courtney authored
free resize it. Bug: b/113151342 Test: unit test + opened a PIP window in tablet mode and was able to Change-Id: Ic72478a35c5726e7ffa2e89fd61243b87f4bf4d7 Reviewed-on: https://chromium-review.googlesource.com/1188404Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#585876}
-
Jacob Dufault authored
Bug: 877047 Change-Id: If77842d8f90cfc0a09420c82745d82a1b0a2030d Reviewed-on: https://chromium-review.googlesource.com/1187407Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#585875}
-
Jonathan Metzman authored
Allow fuzzers to opt out of using AFL's forkserver. Also opt v8 fuzzers out of using it. v8 fuzzers start threads when LLVMFuzzerInitialize is called. This breaks AFL's forkserver because one cannot fork after a thread has started. This is a speculative fix for crbug.com/875199 Bug: 797798, 875199, 796680 Change-Id: I12e8408afaba9c9ca435d031e4263fcc2f80c67f Reviewed-on: https://chromium-review.googlesource.com/1187835Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585874}
-
Eliot Courtney authored
overview. It was visible but not included in the overview. Bug: b/112668590 Test: Added unittests + put a window into PIP mode then started the Change-Id: I245c6a9eb05fb08fca68619b35261967d1becea2 Reviewed-on: https://chromium-review.googlesource.com/1177207Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#585873}
-
Dominik Röttsches authored
HarfBuzzShaper asks FontFallbackIterator whether a full hint list will be required. A full hint list is only required when determining which parts of a segmented font need to be downloaded. A segmented font face is a face that is composed out of multiple @font-face rules with different unicode-range: descriptors. The fallback characters need to be compared against the unicode-range: values. In other cases, only the first character that has a definite script is useful for fallback. A segmented font is a set of @font-face declarations with the same family name, but different unicode-range: descriptors. The order of performing font fallback with segmented fonts in the stack looks as follows: * We're going through the font stack font family by font family. * When selecting one family, we have to check whether it is a segmented font or not. * If it is segmented, we go sequentially through the different @font-face declarations, with differing unicode-range descriptors in reverse order of declaration. * Once we have determined that there is nothing more to shape with this segmented font family, we continue to the next family. The important situation regarding hint chars is as follows, in an example: 1) The first character of the remaining text to be shaped does not need the first segment of a @font-face, but only uses the second. 2) The second character needs the first segment of the @font-face, but since we go through them in order, we are not going to go back and find it anymore and will shape this character with the wrong font. If, at step 1 hint chars are collected, all @font-face's from a segmented font are selected, as all characters are compared against all unicode-ranges. fast/css/font-face-unicode-range.html was transformed into a inspector-protocol/layout style test and one case was added to check that the above mechanism works after falling back from a primary font. Bug: 848295 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38ddc196c02d92bb4608928772edee07203f98e7 Reviewed-on: https://chromium-review.googlesource.com/1172662 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#585872}
-
David Bokan authored
These tests: virtual/threaded/fast/events/pinch/pinch-zoom-into-center.html virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html pinch-zoom-pan-within-zoomed-viewport.html were breaking because Mac doesn't support touch events and the pinch was being done using touch. I've changed to use a touchpad source as this doesn't affect the meaning of the tests as well as some minor cleanups. While here, I also rewrote a number of tests to use gesture-util.js and the async/await style which is more readable and easier to produce non-flaky tests. TBR=nasko@chromium.org Bug: 854199,873435,877494,877361 Change-Id: I19f6e199fea694013d3dceaeb32c881059301f1d Reviewed-on: https://chromium-review.googlesource.com/1185238 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585871}
-
Tanja Gornak authored
Having the deprecated version of the InvalidationServiceProviderFactory will allow to migrate every sub-project which depends on invalidations individually. Follow-up CL introduces new factory, which internally will create the invalidation service based on FCM: https://chromium-review.googlesource.com/c/chromium/src/+/1185093 Bug: 801985 TBR=skuhne@chromium.org, emaxx@chromium.org, fukino@chromium.org, msarda@chromium.org, xiyuan@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I84c64366017de58bdfe060e59b8d54e8d2153a8d Reviewed-on: https://chromium-review.googlesource.com/1185014 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#585870}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/195b9510dbe5..8dabf7bda37f git log 195b9510dbe5..8dabf7bda37f --date=short --no-merges --format='%ad %ae %s' 2018-08-24 bmgordon@chromium.org lib/constants: Change ndk_translation ACLs Created with: gclient setdep -r src/third_party/chromite@8dabf7bda37f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I69ef6979718ca0c1209cff3623af4755d5a34d3c Reviewed-on: https://chromium-review.googlesource.com/1188503Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585869}
-