- 14 Jan, 2015 40 commits
-
-
Jason Kersey authored
This reverts commit a63c0394. BUG=448829 R=knn@chromium.org Review URL: https://codereview.chromium.org/841443005 Cr-Commit-Position: refs/heads/master@{#311532}
-
garykac authored
This cl updates the checker.py script in /third_party/closure_compiler to add an option to process a set of JS files at once rather than one at a time (the current default). It also adds a flag to enable additional compiler checks (since Chromoting wants all checks enabled). It also updates the Chromoting .gyp files to make use of the new compiler. The remaining changes were motivated by the errors reported by the new closure compiler. BUG= Review URL: https://codereview.chromium.org/803653004 Cr-Commit-Position: refs/heads/master@{#311531}
-
newt authored
Test code that's used downstream needs to live in chrome/test/android/javatests (which is included in the chrome_java_test_support target), not chrome/android/javatests (which is included only in the chrome_shell_test_apk target). BUG=444675 Review URL: https://codereview.chromium.org/788163006 Cr-Commit-Position: refs/heads/master@{#311530}
-
dtseng authored
Wikipedia now assigns a fallback classname to its 'tex' img nodes. ChromeVox, reading the className directly, needs to split the space delimited string. BUG=448544 TEST=math now reads on wikipedia Review URL: https://codereview.chromium.org/828373007 Cr-Commit-Position: refs/heads/master@{#311529}
-
tapted authored
Strict virtual annotation checks were enabled on Mac in r311365. This gets toolkit_views for Mac on board. BUG=417463 Review URL: https://codereview.chromium.org/850843003 Cr-Commit-Position: refs/heads/master@{#311528}
-
dnicoara authored
BUG=none NOTRY=true Review URL: https://codereview.chromium.org/854643002 Cr-Commit-Position: refs/heads/master@{#311527}
-
rmcilroy authored
BUG=421063,439661 Review URL: https://codereview.chromium.org/826083004 Cr-Commit-Position: refs/heads/master@{#311526}
-
watk authored
BUG=447732 TEST=Manually inspect chrome:histograms. Review URL: https://codereview.chromium.org/847223002 Cr-Commit-Position: refs/heads/master@{#311525}
-
vmpstr authored
Since map<Key, Value>::value_type is std::pair<const Key, Value>, we need to ensure that we use this type to avoid an extra copy/temporary creation. This patch does this by explicitly using value_type where it is clear what the type is, and adding const to the key where it's not. Review URL: https://codereview.chromium.org/853533002 Cr-Commit-Position: refs/heads/master@{#311524}
-
robert.bradford authored
In r311421 a test was modified that called into XkbKeyboardLayoutEngine::ParseLayoutName but this function was not exposed in the header file. This change exposes this method in the header file and fixes the build. Original CL that introduced issue: https://codereview.chromium.org/848833002 BUG=None TEST=Compile of events_unittests completes Review URL: https://codereview.chromium.org/812613004 Cr-Commit-Position: refs/heads/master@{#311523}
-
hubbe authored
Review URL: https://codereview.chromium.org/842113004 Cr-Commit-Position: refs/heads/master@{#311522}
-
stevenjb authored
BUG=448768 Review URL: https://codereview.chromium.org/852803002 Cr-Commit-Position: refs/heads/master@{#311521}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/b47bba7..7c348a8 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=djsollen@google.com Review URL: https://codereview.chromium.org/854663002 Cr-Commit-Position: refs/heads/master@{#311520}
-
mlamouri authored
It makes MultiResolutionImageResourceFetcher uses FRAME_ASSOCIATED_LOADER instead of PLATFORM_LOADER and set the loader options to allow cross origin fetching and passes credentials. Amongst other things, using the Blink loader will show the load in the developer tools. For example, it does expose a bug while trying to fetch the favicon in https://www.gmail.com/intl/en/mail/help/about.html The load allows cross origin because many websites uses CDN for favicon and it allows credentials because the last attempt to not pass cookies to the favicon request failed, see bug 114082. This CL is not changing any credential/cross-origin behaviour but makes it explicit. Furthermore, this CL changes some special favicon requests handling in resource_dispatcher_host_impl.cc and instead explicitly bypass service workers when setting up the request. BUG=110449 Review URL: https://codereview.chromium.org/840553003 Cr-Commit-Position: refs/heads/master@{#311519}
-
thakis authored
Include fixes: https://code.google.com/p/googletest/source/detail?r=701 MinGW specific: https://code.google.com/p/googletest/source/detail?r=702 The reason I want this: Fixing compiling the gmock header in .mm files with new clang revisions that have clang r220714: https://code.google.com/p/googletest/source/detail?r=703 https://code.google.com/p/googletest/source/detail?r=704 BUG=444089 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/838933003 Cr-Commit-Position: refs/heads/master@{#311518}
-
mstrum authored
chrome_shell.gypi is only included if OS=="android" so there is no reason to test it again. BUG=none Review URL: https://codereview.chromium.org/810193006 Cr-Commit-Position: refs/heads/master@{#311517}
-
kenobi authored
Add a cancellation callback so that the active import task is cancelled when the user clicks on the cancel button in the progress notification. BUG=420680 TEST=browser_test: FileManagerJsTest.MediaImportHandlerTest Review URL: https://codereview.chromium.org/846903004 Cr-Commit-Position: refs/heads/master@{#311516}
-
petrcermak authored
This patch is part of an ongoing process to unbundle memory_inspector and make it a chrome app. It replaces multiprocessing, which is currently not supported by naclports/python, with threading. BUG=448399 Review URL: https://codereview.chromium.org/836933004 Cr-Commit-Position: refs/heads/master@{#311515}
-
davidben authored
This removes the additions in chrome/, but not the underlying content/ dom_storage changes. BUG=440539 Review URL: https://codereview.chromium.org/797443002 Cr-Commit-Position: refs/heads/master@{#311514}
-
sdefresne authored
Move files from chrome/browser/history that have no dependency on chrome or content to components/history. BUG=370850 Review URL: https://codereview.chromium.org/813503003 Cr-Commit-Position: refs/heads/master@{#311513}
-
hubbe authored
These tests iterate over 10000 frames, and with debug mode being 13+ times slower than release mode, this ends up taking too long. Hopefully we won't loose much coverage by reducing the number of iterations in debug mode. BUG=448035, 448511 Review URL: https://codereview.chromium.org/832293003 Cr-Commit-Position: refs/heads/master@{#311512}
-
fdegans authored
This test is taking too long to run on the bot and preventing other tests to be run. BUG=427529 Review URL: https://codereview.chromium.org/850083002 Cr-Commit-Position: refs/heads/master@{#311511}
-
dnicoara authored
When probing for new displays we create new snapshots. We need to make sure that existing ones will contain the same state as the old ones otherwise the state between the Browser and GPU process will be out of sync. BUG=434115 NOTRY=true Review URL: https://codereview.chromium.org/845383002 Cr-Commit-Position: refs/heads/master@{#311510}
-
bartfab authored
Clarify that packets originating on Chrome OS are intercepted by the API, not packets reaching the device from outside. BUG=407541 Review URL: https://codereview.chromium.org/804363002 Cr-Commit-Position: refs/heads/master@{#311509}
-
bnc authored
BUG=448147 Review URL: https://codereview.chromium.org/849933002 Cr-Commit-Position: refs/heads/master@{#311508}
-
petrcermak authored
This patch is part of an ongoing process to unbundle memory_inspector and make it a chrome app. It removes the dependency of www_server.py on the dateutil module, which is not part of the Python Standard Library. BUG=448399 Review URL: https://codereview.chromium.org/850033002 Cr-Commit-Position: refs/heads/master@{#311507}
-
dmichael authored
This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 TBR=qinmin@chromium.org Review URL: https://codereview.chromium.org/841453006 Cr-Commit-Position: refs/heads/master@{#311506}
-
pkotwicz authored
BUG=401598 TEST=Manual, see bug Review URL: https://codereview.chromium.org/806693009 Cr-Commit-Position: refs/heads/master@{#311505}
-
hshi authored
Set max_num_reorder_frames to allow the decoder to output pictures early. BUG=446627 TEST=video_encode_accelerator_unittest Review URL: https://codereview.chromium.org/794433005 Cr-Commit-Position: refs/heads/master@{#311504}
-
dgozman authored
This will allow to re-create gesture provider with different configs, as requested by the user. BUG=425586 Review URL: https://codereview.chromium.org/820053002 Cr-Commit-Position: refs/heads/master@{#311503}
-
rvargas authored
BUG=137652, 146944 R=jschuh@chromium.org Review URL: https://codereview.chromium.org/854503002 Cr-Commit-Position: refs/heads/master@{#311502}
-
robertshield authored
BUG=447695 TEST=NONE Review URL: https://codereview.chromium.org/846663003 Cr-Commit-Position: refs/heads/master@{#311501}
-
haraldh authored
This to prevent click-jacking using an option popup list that becomes persistent. BUG=448008 Review URL: https://codereview.chromium.org/839573002 Cr-Commit-Position: refs/heads/master@{#311500}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/8018e68..b47bba7 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=djsollen@google.com Review URL: https://codereview.chromium.org/852773002 Cr-Commit-Position: refs/heads/master@{#311499}
-
kenobi authored
The ImportTask appears to be firing a final progress event after the success event has been fired; this is causing the UI to pop up a zombie import-related progress notification that never goes away. Fix by preventing the task from emitting further notifications once it's successfully completed. BUG=420680 Review URL: https://codereview.chromium.org/839473006 Cr-Commit-Position: refs/heads/master@{#311498}
-
alexst authored
Some initial messages may get routed to main thread. Once we get our first message on io, send it to main to ensure all prior main thread operations are finished before we continue on io. BUG=446184 Review URL: https://codereview.chromium.org/801233003 Cr-Commit-Position: refs/heads/master@{#311497}
-
lizeb authored
BUG= Review URL: https://codereview.chromium.org/834173006 Cr-Commit-Position: refs/heads/master@{#311496}
-
mseaborn authored
Revert of NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case (patchset #4 id:60001 of https://codereview.chromium.org/849523002/) Reason for revert: The change appears to cause NaClBrowserTestNewlib.Bad to become flaky. The flakiness was reported in: BUG=448596 Original change description: > NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case > > We can remove Plugin::NexeFileDidOpenContinuation(), which gets called > via the "init_done" SRPC call (which calls > StartupInitializationComplete() in plugin/service_runtime.cc). > > Its work gets done by the newer > ManifestServiceProxy::StartupInitializationComplete() in > components/nacl/renderer/ppb_nacl_private_impl.cc, which gets called > via Chrome IPC (by the "PpapiHostMsg_StartupInitializationComplete" > message). > > ppapi_dispatcher.cc: In order to keep the error handling tests in > NaClBrowserTestNewlib.Bad passing, send the > StartupInitializationComplete message earlier, before we call > PPP_InitializeModule(). This ensures that crashes in > PPP_InitializeModule() are reported properly. > > Note that PNaCl still relies on "init_done" for now. > > BUG=428030 > BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 > > Committed: https://crrev.com/4c03d4d0964b0b69f5741aac6c78557b415617e1 > Cr-Commit-Position: refs/heads/master@{#311298} BUG=428030 BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 Review URL: https://codereview.chromium.org/793723006 Cr-Commit-Position: refs/heads/master@{#311495}
-
noms authored
http://www.reactiongifs.com/r/kerm.gif BUG=NONE Review URL: https://codereview.chromium.org/810453005 Cr-Commit-Position: refs/heads/master@{#311494}
-
Nico Weber authored
In preparation of moving the clang/win bots to recipes. This list is intended to match win_clang_tests in masters/master.chromium.fyi/master.cfg BUG=446368 R=jochen@chromium.org Review URL: https://codereview.chromium.org/854523002 Cr-Commit-Position: refs/heads/master@{#311493}
-