- 19 Aug, 2019 40 commits
-
-
Tarun Bansal authored
Bug: 960961 Change-Id: I9cb66d13461cae042ec5626bd27b7b3633abcd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759231 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#688231}
-
Karan Bhatia authored
This CL enforces a secure extension page CSP for any extension using the "content_security_policy" dictionary key and for all manifest V3 extensions. The restrictions placed are same as those for secure isolated world CSPs. This should facilitate preventing these extensions from loading remote scripts. BUG=993530 Change-Id: I66191e7688a772eb0cf8321f09370d6dba4b0cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753470 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688230}
-
Tommy Steimel authored
This CL updates the scrollbar of the global media controls dialog to be an overlay scrollbar instead of the standard scrollbar. Bug: 991370 Change-Id: I21e78636749e2429b731c5bb4aa5b2edddc498ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758334Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688229}
-
Mohamed Amir Yosef authored
This CL reports the time spent in BookmarkModelTypeProcessor::ModelReadyToSync(). This is a critical step that runs on every startup on the UI thread. It caused recent UI jank issues due to inefficient implementation. Change-Id: I0aa9e64e964e0fa49d2ca8ec0e121414859d3196 Bug: 950869,516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760914 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688228}
-
Dominic Battre authored
This is an attempt at fixing the flakiness of a number of autofill interactive ui tests by changing the pattern from action(); wait_for_result(); to setup_waiting(); action(); wait_for_result(); The former pattern might lose some events in case action() happens to complete before wait_for_result() is called. Bug: 967588 Change-Id: I66800ed03fd27d9e6cf4be6ee53cc0f29200f21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757019Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#688227}
-
Becca Hughes authored
The close button is not accessible by ChromeVox since it is not drawn. Therefore, we should switch between a blank image and the icon. BUG=994838 Change-Id: I008b08b8620c20504806958eedeb8e26a112c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758718 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688226}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aad8cfca57fd..fd72dd0a439f git log aad8cfca57fd..fd72dd0a439f --date=short --no-merges --format='%ad %ae %s' 2019-08-19 chrisforbes@google.com Order timestamp writes correctly wrt renderer work 2019-08-19 chrisforbes@google.com Add newlines to SPIRV optimizer messages 2019-08-19 chrisforbes@google.com Add feature support check for VkPhysicalDeviceShaderDrawParametersFeatures Created with: gclient setdep -r src/third_party/swiftshader@fd72dd0a439f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:139469122,chromium:b/139528538 Change-Id: Id652973b29cd85ab5d9da970978f7ec33a50bf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688225}
-
Ken MacKay authored
https://chromium-review.googlesource.com/c/chromium/src/+/1752925 introduced an issue on mono devices without dynamic channel count enabled, where the check for valid number of postprocessor outputs would fail. Change-Id: I3d66144c50ca11cc6e90c79b318737a19c10dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761053 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688224}
-
Clark DuVall authored
I forgot to assign the ScopedCrashKeyStrings to a variable (oops). Also adds one more crash key. Bug: 934317 Change-Id: I773ff3d65b175e9619a5fe5746a86bf952cb1cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761059 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688223}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05137a76..0803a22a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id49355153f7eab01c11dd49bd943e2d6662ff0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760416Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688222}
-
Xinghui Lu authored
Previously, Timeout task never gets scheduled if OnGetDomFeatures() doesn't get called. Move Timeout task schedule into OnWhitelistCheckDone() to make sure it always gets called. Bug: 977719 Change-Id: I9cf5cd390f68e6f9275cf79cb8f19a9bd046001a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736517Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688221}
-
Findit authored
This reverts commit 9e12e07d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 688212 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzllMTJlMDdkMzQwZjJkZDNiY2IyYjdhMWU3MTJhYTAzMGVmODNlNWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-ozone-rel/89256 Sample Failed Step: compile Original change's description: > Refactor dependency on memory_instrumentation.mojom out of process.mojom > > Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct > in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump > instead. > > manager for Android memory footprint > > Bug: b:139190852 > Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task > Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456 > Commit-Queue: Willie Koomson <wvk@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688212} Change-Id: I642591284693919f312d8e1af3d3713a5a5e0874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:139190852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761229 Cr-Commit-Position: refs/heads/master@{#688220}
-
siyua authored
In SaveCardIconView, the controller should not be created every time GetController() is called with new web_content. Add a Get function. Bug:991110 Change-Id: I43817889d4f9c9b52d6a630b08813fa3309298e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754786Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#688219}
-
Alexander Hendrich authored
Temporarily whitelist Imprivata extensions until a WebUSB solution is ready to go (target M79/M80). Bug: 995294 Change-Id: I13266d0ead964155f19924bbab098c9529e137ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760741 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Chris Palmer authored
This enables us to re-use it for other probabilistic purposes, such as probabilistically scribbling memory on free. Bug: 984742 Change-Id: I09267647e22a0644b2aa25464f2ec135c872c89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757734Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688217}
-
Siye Liu authored
We need to reject out-of-bound ranges. Currently setting range that is outside the bounds of the text buffer in views::Textfield crashes, as Textfield uses RenderText to store the text buffer and RenderText will crash if the range is outside of the cached text buffer. Hence, we change views::Textfield::SetCompositionFromExistingText to clear the composition when the provided range is out-of-bound. Bug: 966484 Change-Id: I770457a1290ca4466b21779264e967789cbb80f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754498 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688216}
-
Tiancong Wang authored
We have been setting up orderfiles for Chrome OS for a while. We have an automatic pipeline to generate orderfiles, and an autoroller to update the version of orderfiles to the latest. Experiments show that using orderfile can bring us performance improvements by 1-3% on different Chrome OS boards. BUG=chromium:950627 TEST=The orderfile is tested on toolchain nightly tests. Change-Id: I3a6b5edf853250987168b758019de6fd2be39326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759894Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#688215}
-
Jenna Himawan authored
Bug: 814417 Change-Id: I9b9083cbbb10e8735579e64ee4a594c0afe69547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726636 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#688214}
-
Eric Roman authored
Bug: 994326 Change-Id: I199a53fa3325b7cd9d0629ccb7f0d987592f0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756941 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
-
Willie Koomson authored
Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump instead. manager for Android memory footprint Bug: b:139190852 Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#688212}
-
Sven Zheng authored
With this change, all DialogBrowserTest should be abled to verify pixel correctness. To use them as pixel test, add flag --browser-ui-tests-verify-pixels. TEST: browser_tests.exe --gtest_filter=PermissionDialogTest.* --browser-ui-tests-verify-pixels --enable-pixel-output-in-tests --build-revision=b6aaf42b --no-luci-auth I've approved the following images so these tests can pass now. https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_PermissionDialogTest_InvokeUi_protocol_handlers&digest=877f6df6101e926f24c5b9bc3cf111b3 https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_PermissionDialogTest_InvokeUi_camera&digest=cf09792802b243e0a33bf4d45e2e8047 I didn't start with test_browser_ui because most of the tests are inherited from test_browser_dialog. Next step: 1 Add some tests to fyi bots to monitor the stability. 2 Fix some tests that don't have stable UI. Eg disable animation for https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_AuthenticatorDialogViewTest_InvokeUi_default&digest=2442c011949e9f98f4442f066bb90e55 Bug: 958242 Change-Id: I7bc048b792a5e303e8ee948fda228fa664395ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756604 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#688211}
-
Adrienne Walker authored
Layers start at the origin and not in negative space and we should never need these values. This prevents rtree complexity and bounds overflow. Bug: 988590 Change-Id: I4fa77c11fc5f0411997e2697291b9e554958c9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749703Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688210}
-
Scott Violet authored
Adds logic to switch between LayoutFlexibleBox and LayoutDeprecatedFlexibleBox when clamping changes. This is necessary as LayoutDeprecatedFlexibleBox is the only place that currently provides support for clamping. BUG=993813 TEST=none Change-Id: I88dc4ce0195faf08870afeb9e8e5fce338a29476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754922 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#688209}
-
Manu Cornet authored
This is not expected to result in any user-visible changes. Bug: 973482, 973446 Change-Id: I8cddfbaaff421db8e8824dcf25ee817b3f7ee894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730960 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Presubmit warnings found as part of touching many files in https://chromium-review.googlesource.com/c/chromium/src/+/1756247 R=hansberry@chromium.org, msw@chromium.org Bug: 992483 Change-Id: I76ceb6ded41b61a27ea0fd0b0cd7d7ee7d66596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757507 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Michael Thiessen authored
No functionality changes intended, this is simply cleanup. getModelAt was only exposed for testing, and the API contract was confusing (SingleTabModelSelector always just returned the index 0 model). Change-Id: I7f18ad407e14540de180c7f5b8d624e3148266af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749845Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#688206}
-
Garrett Beaty authored
named-cache-clobber.py can be used to clobber any named cache on machines in any pool. The existing clobber.py was replaced with builder-cache-clobber.py, which renames the pool flag to bucket to more accurately indicate the expected value and removes the restriction on project. Change-Id: I7614330213c8e20a0c0e9ee4bb0498d3b2fbbb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757888 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688205}
-
Natalie Chouinard authored
In the Support Library Preference's onBindViewHolder, visibility toggling is handled for both title and summary empty TextViews, so removing some now redundant logic. There are no TextMessagePreferences which contain links in the title, and the LinkMovementMethod was breaking DPad navigation on screens where it was set, so removing that as well. See https://crbug.com/993368. Bug: 993368 Change-Id: I702fc08e563e544e9ad774c2b05dcdd070a74678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757390Reviewed-by:
-
Xiaocheng Hu authored
Bug: 978682 Change-Id: I65c38a7b5978034c4c477e68d29edaa2852d09af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758299Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688203}
-
Tibor Goldschwendt authored
Change-Id: I5de49029ca6904d034ecfaa01d780351f5ce22ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761189 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#688202}
-
Francois Doray authored
The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1679434 was reverted because of failures on test end on Mac OS 10.11. This CL simply disables that check on Mac, so we can benefit from process priority check on other platforms ASAP. See diff: https://chromium-review.googlesource.com/c/chromium/src/+/1760873/2..3/base/test/test_suite.cc This CL verifies that a test process is not backgrounded when it is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931721). Bug: 931721 Change-Id: Ib60d728c960f84026c84f24395d38847c1941573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760873Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688201}
-
Yaron Friedman authored
Bo knows this code and the only client is content/renderer/input. Input folks ought to be better reviewers Change-Id: Ie5b0042378eb38cb08e7f29a6ec4c20f2f4cc3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758657 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688200}
-
Anna Malova authored
Bug: 994758 Change-Id: Ic4d82f03ec8b0cb7cc19b4e5981f154d19c37334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758082Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#688199}
-
Xi Han authored
This is a follow up CL for https://crrev.com/c/1758500. In this CL, caching the native flags is called when native is loaded in ServiceManager only mode, including: - ServiceManagerForDownload - ServiceManagerForBackgroundPrefetch Bug: 984559,995355 Change-Id: I51b00b3be048dc6ec377eeef0f81bbc0ce4e9023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759682 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8133374cb7fe..4935770daa8e git log 8133374cb7fe..4935770daa8e --date=short --no-merges --format='%ad %ae %s' 2019-08-19 tsepez@chromium.org Initialize widget handlers from topmost fpdfsdk. 2019-08-19 tsepez@chromium.org Avoid casting to CPDFXFA_Context just to get form type. Created with: gclient setdep -r src/third_party/pdfium@4935770daa8e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I8bd5c37c009f066f76e1d50c714f56964372c6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761000Reviewed-by:
-
Ben Mason authored
This reverts commit 2b751bd7. Reason for revert: Crash on launch Original change's description: > JNI refactor: @NativeMethods conversion (//chrome/android/features). > > To create this change: > * cd chrome/android/features > * base/android/jni_generator/jni_refactorer.py -R --nonstatic > * base/android/jni_generator/jni_refactorer.py -R > * Change the native side of VrShellDelegateJni#recordVrStartAction > to not pass the Java object > > Bug: 929661 > Change-Id: I1d2c57e0f7a30a8b7e50e9e3ce905172cbb761cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749737 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687674} TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 929661 Change-Id: I60ffe465a69470b20d5785b291a13a0819bb2a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759892 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#688196}
-
Alex Keng authored
This CL enables <input type=radio/checkbox> to render high contrast colors when high contrast mode is enabled. A test is added in fast/forms/controls-new-ui-high-contrast. Note the test is verifying if we are correctly using system colors in high contrast mode and since we don't really change system setting for HC in webtests, the results colors are still black/grey/white (in higher contrast) instead of black/white/green. Bug: 994219 Change-Id: Ia798503ff040ce6b479a2845797118f7869c7ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756209 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688195}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=dtrainor@chromium.org, jshin@chromium.org, pmonette@chromium.org NOTRY=true Bug: 977050 Change-Id: I1bf790cf0957c912382787dec1b100651ff6b0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699950Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688194}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3f7932e73316..8566dda51b42 git log 3f7932e73316..8566dda51b42 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 958fec279ed5..d931999c3afd (1 commits) 2019-08-19 egdaniel@google.com Remove some unused GrPixelConfig functions. Created with: gclient setdep -r src/third_party/skia@8566dda51b42 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None Change-Id: I63baa0d8436797a464ad063b4d4288d01aaed70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761001Reviewed-by:
-
Gabriel Charette authored
Per https://chromium-review.googlesource.com/c/chromium/src/+/1756247/2/chrome/browser/metrics/perf/heap_collector_unittest.cc#695 this is migrated on its own because of the non-trivial requirement to avoid formatting away intentional trailing whitespaces. Edit: Turns out trailing whitespace formatting was my editor's fault not git cl format. Simple one-line migration in latest patch set. R=gmx@chromium.org Bug: 992483 Change-Id: I8f6331ce2c187b41f1f541fbe03884a9138cfff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759145 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688192}
-
