GitLab

The ui flag is always true on ChromeOS and off elsewhere. The other is
never on and we're not planning to turn it on.

R=piman@chromium.org, piman
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538

Review URL: https://codereview.chromium.org/164183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252069 0039d316-1c4b-4281-b951-d872f2087c98

Changes
r251855: Fix compilation of NSPR and NSPR for aarch64

BUG=314720
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/172143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252068 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=344693

Review URL: https://codereview.chromium.org/171783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252067 0039d316-1c4b-4281-b951-d872f2087c98

Unifies the Path Service's base::DIR_HOME on Posix and base::DIR_PROFILE on Windows to just be base::DIR_HOME everywhere, and DIR_HOME will now work on Mac.

This removes the AssertIOAllowed check in the Posix implementation because that was only executed in a fallback case that no developer is likely to ever hit. In addition, the we do call this type of function on the UI thread, so either we need to promote the assertion to be at the top of the function or delete it. It seemed unreasonable to disallow using this one key of the path service on the UI thread (the other ones are OK) so I just went for deleting the assertion.

R=benwells@chromium.org

Review URL: https://codereview.chromium.org/159833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252066 0039d316-1c4b-4281-b951-d872f2087c98

Updates all rebase_path calls to use the new parameter ordering.

Use the new getenv function and delete the Python script we had to get the home directory.

Takes advantage of the new ability to have the default value of declare_args blocks be dependent on other values. This simplifies some code.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/164773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252065 0039d316-1c4b-4281-b951-d872f2087c98

This resubmission fixes a memory leak that was causing ASAN bots to fail.

Original code review: https://codereview.chromium.org/163953007

BUG=227247
R=jennyz@chromium.org
TBR=jamescook, jennyz

Review URL: https://codereview.chromium.org/165393013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252064 0039d316-1c4b-4281-b951-d872f2087c98

The IPC in question was in
PasswordGenerationManager::SendAccountCreationFormsToRenderer. This is now done
through PasswordManagerDriver.

Most of this patch was developed by vabr@chromium.org.

BUG=335028

Review URL: https://codereview.chromium.org/156173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252063 0039d316-1c4b-4281-b951-d872f2087c98

It is ok for SafeGetImageInfo to fails to get the image info, so catch
exceptions instead of dying.

BUG=343925

Review URL: https://codereview.chromium.org/171153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=325685
R=bulach@chromium.org, pliard@chromium.org

Review URL: https://codereview.chromium.org/172193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252061 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of the flag clean up effort.
The flags is enabled by default for a while and working pretty well. We won't
go back any more.

BUG=344738

Review URL: https://codereview.chromium.org/166273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252060 0039d316-1c4b-4281-b951-d872f2087c98

All tests listed in chromium_swarm_tests are going to be run on the CI
infrastructure. Sadly, sync_integration_tests_run is currently failing on all
OSes, so commenting it out in the meantime until we focus on adding back more
tests.

R=csharp@chromium.org
BUG=157234
NOTRY=true

Review URL: https://codereview.chromium.org/170283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252057 0039d316-1c4b-4281-b951-d872f2087c98

UNPROXIED_API() no longer does anything. This change removes that macro, since
it serves no purpose.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/167943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344808

Review URL: https://codereview.chromium.org/172113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252055 0039d316-1c4b-4281-b951-d872f2087c98

ImageView.setImageAlpha is available only since JB. Use setAlpha preJB.

NOTRY=true

Review URL: https://codereview.chromium.org/165953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252054 0039d316-1c4b-4281-b951-d872f2087c98

Removing the autofill enum from blink side and moving it to
browser side in components/autofill/core/common/autofill_enums.h.
This patch is only adding of enum in browser side. Removing of
enum from blink side is done in another patch.

BUG=302489
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/159853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252053 0039d316-1c4b-4281-b951-d872f2087c98

When recording a page, we identify it by its "display name" (name if it has one,
otherwise URL unless it's a file). When replaying a page, however, we always use
its URL to look up the correct WPR file. So pages with names cannot be found.

R=tonyg@chromium.org
BUG=344380

Review URL: https://codereview.chromium.org/169873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252052 0039d316-1c4b-4281-b951-d872f2087c98

This will allow changing, adding, and removing tests without two-sided
patches.

The list format can be extended in the future, for now keeping it as simple
and static as possible.

BUG=332239
R=darin@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/166663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252050 0039d316-1c4b-4281-b951-d872f2087c98

Do not call InsertText() if there is no focused text input client or the text input type is TEXT_INPUT_TYPE_NONE.

BUG=343875

Review URL: https://codereview.chromium.org/166823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252049 0039d316-1c4b-4281-b951-d872f2087c98

Currently browser dialogs are centered relatively to the main
webcontents. If one has docked devtools which occupy 90% of the browser
window, the dialog is hardly seen.

This patch makes dialogs to be centered with respect to open devtools,
which means centering to the container of both inspected webcontents
and and devtools.

BUG=

Review URL: https://codereview.chromium.org/169403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252048 0039d316-1c4b-4281-b951-d872f2087c98

The test passes now, but with the IsFullScreenMode implementation warning (harmless to
this test).

BUG=163931

Review URL: https://codereview.chromium.org/167773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252047 0039d316-1c4b-4281-b951-d872f2087c98

This test is now passing, though with console warnings about IsFullScreenMode
not implemented yet for linux and a RENDER WARNING (already noted in
http://crbug.com/333003).

BUG=163931

Review URL: https://codereview.chromium.org/164333010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344938
R=waffles@chromium.org

Review URL: https://codereview.chromium.org/169033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252045 0039d316-1c4b-4281-b951-d872f2087c98

Previously, during typing a search query on the drive, Files.app uses
DirectoryContents#createForDirectory method. It does not handle FakeEntries so
it causes an exception if a user typing a search query in the drive special
folders. This CL replace the method with createDirectoryContents_, which is
a caller of the createForDirectory method and can handle FakeEntries.

BUG=344459
TEST=manually

Review URL: https://codereview.chromium.org/166443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252044 0039d316-1c4b-4281-b951-d872f2087c98

This platform also supports PopupsAllowedForUrls and PopupsBlockedForUrls.
If these policies are enabled on the template then they'll be loaded by the
cloud policy provider.

BUG=341493

Review URL: https://codereview.chromium.org/169443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252043 0039d316-1c4b-4281-b951-d872f2087c98

R=jeremy@chromium.org,tonyg@chromium.org

Review URL: https://codereview.chromium.org/164133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252042 0039d316-1c4b-4281-b951-d872f2087c98

There are tests for each operation and each sync performer.
But, no test verifies operation classes and performer classes working together.

Add tests for FileSystem::Copy(), Move(), Remove(), CreateDirectory(), CreateFile(), TouchFile() and TruncateFile().

BUG=340210
TEST=unit_tests --gtest_filter="FileSystemTest.*"

Review URL: https://codereview.chromium.org/158723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252041 0039d316-1c4b-4281-b951-d872f2087c98

This removes the default "gen" command so that "gn" by itself does nothing (it prints a short help message).

The "gen" command now takes as an argument the output directory to use, and I removed the --output flag except for the "gyp" command (which will be needed until we update gyp_chromium).

Updates the base build file to keep in sync with recent changes.

True relative directories are now supported, so that the directories given to the gen command can be relative to the current one. It also supports relative directories for the desc and refs command. This allows you to be in the base directory and say "gn desc :base" and it will resolve the ":base" label relative to the current directory in the source tree.

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/165823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342064
R=darin@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/172643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252039 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Should have only enabled this on ChromeOS. Enabled elsewhere by mistake.

Original issue's description:
> cc: Remove the --enable-partial-swap flag.
> 
> R=piman
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251898

TBR=piman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/172763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341493
NOTRY=True
NOTREECHECKS=true
R=benm@chromium.org

Review URL: https://codereview.chromium.org/168283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252037 0039d316-1c4b-4281-b951-d872f2087c98

See details in issue.

BUG=344931

> Add GetDeviceSupportedFormats to Win DirectShow.
> 
> Extracted pixel format translation logic to 
> TranslateMediaSubtypeToPixelFormat().
> 
> BUG=309554, 314161
> 
> Review URL: https://codereview.chromium.org/156583004

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/163023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252036 0039d316-1c4b-4281-b951-d872f2087c98

Most people don't use this parameter and get arm binaries. This is
still the default, so this change shouldn't affect most people.

Folks should instead pass -Dtarget_arch to gyp. (Or, soon, envsetup will stop
clobbering GYP_DEFINES, then you can just add target_arch to your GYP_DEFINES.)
Note that in gyp land, 'mips' is called 'mipsel' and 'x86' is called 'ia32'.
'arm' stays 'arm'.

So for example, instead of running

  . build/android/envsetup.sh --target-arch=mips
  android_gyp

you'd run

  . build/android/envsetup.sh
  android_gyp -Dtarget_arch=mipsel

I updated the bots I was able to find to pass the -D flag in addition to
--target-arch. After this CL here is in, I'll update the bots to stop passing
--target-arch, and then I'll make --target-arch a hard error in this script for
a while, to make sure nobody still uses it.

BUG=330631,34476
R=torne@chromium.org
TBR=yfriedman

Review URL: https://codereview.chromium.org/171903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252034 0039d316-1c4b-4281-b951-d872f2087c98

The bots tells this CL broke most of the webrtc browser tests on Mac.
http://chromegw/i/internal.chromium.webrtc/builders/Mac%20Tester


BUG=344912
TEST=webrtc bots.

> Do not send a frame swap ack from the browser until the frame is drawn
> 
> Code to do this was recently removed because it was no longer being
> used in r241225 (https://codereview.chromium.org/116103002). This is
> now necessary again to throttle renderers when using CoreAnimation.
> 
> Frames are acked only when they are drawn. Both the CoreAnimation and
> the non-CoreAnimation paths are changed to behave this way. By virtue
> of the fact that the non-CoreAnimation path draws immediately, this
> should have no functional effect on that path.
> 
> This differs from the mechanism deleted in the aforementioned patch in
> two ways.
> 
> First, it uses a scoped_ptr of a struct instead of a vector of pairs to
> store the information about the swap being returned. This should improve
> readability in that the ack has struct names instead of just first and
> second in the pair, and in that the scoped_ptr does not suggest support
> for multiple pending swaps (which does not exist).
> 
> Second, it does makes RWHVMac ack frames more aggressively when
> inside a draw call, rather than adding a call from RWHImpl to the view,
> to effect the ack (which is what the old way does).
> 
> BUG=340133
> 
> Review URL: https://codereview.chromium.org/165703002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/172633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252031 0039d316-1c4b-4281-b951-d872f2087c98

It corrects a mistake which does not assign the output device id to the member of the dispatcher.

NOTRY=true

BUG=344818
TEST=http://localhost:8080/hangout_services_test.html works with device selection.
R=joi@chromium.org

Review URL: https://codereview.chromium.org/172243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252025 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252022 0039d316-1c4b-4281-b951-d872f2087c98

> Roll to r13493
> 
> R=rmistry@google.com
> 
> Review URL: https://codereview.chromium.org/167973005

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/171603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/166273013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252018 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/167973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252017 0039d316-1c4b-4281-b951-d872f2087c98