- 19 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008190800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/eyckbIodGqr8VaH2vd3VtVYswZKSsa-4D4LDP_V5v3IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/141204984,b/157380285,b/157694064,b/160105783,b/163422302,b/163432652,b/164613918,b/165154829 Tbr: media-app@grotations.appspotmail.com Change-Id: I2621bb37f14940f50db70df4bb2d850c664abc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364281Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799694}
-
Marc Treib authored
This CL adds a default FeatureConfig for kIPHPasswordsAccountStorageFeature. It also adds an about:flags entry to enable the feature. This will make manual testing much easier. Bug: 1115476 Change-Id: I30efa2fc4d3177fb47b363a8076a484d7eca630e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352935 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#799693}
-
arthursonzogni authored
Add support for CrossOriginOpenerPolicyReporting experiment for OriginTrial. This is put behind the flag CrossOriginOpenerPolicyReportingOriginTrial. The flag is disabled for now. Once approuved it will be switched to enabled and will be used as a kill-switch. Bug: 1116413 Change-Id: I48abfee8e9b9369926a94d03a4c1f4c2afec5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362122Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#799692}
-
Stephen McGruer authored
Test was fixed upstream and the fix imported into Chromium by a recent wpt import. Bug: 1116954 Change-Id: I4653fe2878c46f1b408fd16e801bfa70d8366410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359166 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#799691}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I88dc82e3b48bd1d63189d3e57ed0f3fe3351279b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352024 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#799690}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I2d8b5a172bb679cfc51bd1a6fd8a1d4eb97dec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351282 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799689}
-
Stephen McGruer authored
Previously the code would default to always passing --enable-logging (no parameter) to Chrome. This only logs to stderr on Debug Chrome builds or when running in headless mode[0], so in other configurations the user would also be required to set '--enable-logging=stderr' as an args capability. Instead, use the new '--enable-chrome-logs' flag as a signal that the user wants browser logs sent to stderr, and set either '--enable-logging' or '--enable-logging=stderr' accordingly. [0]: https://docs.google.com/document/d/1DsvGXPri3exlQupj3d5IbOvI1tzIw2ePWbePDZVp1Cc/edit Bug: 1109233 Change-Id: Ife69170e67746b5ba6cd8dbd0ddb8041827d76c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341891Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799688}
-
Alex Moshchuk authored
This hack was introduced for https://crbug.com/791796, but it is no longer needed after r789285, where we've started indexing SiteInstances with SiteInfo, which includes both site and lock URLs. Various test expectations are updated accordingly. In addition to removing the hack from GetSiteForURLInternal, this CL also fixes the DoesSiteForURLMatch() in ConvertToSiteInstance() to consider the full SiteInfo struct, rather than only the site URL. This is needed to maintain old behavior, where we implicitly compared lock URLs (in the hash) even if the scheme+host parts of site URLs were the same. This matters for hosted apps which cover multiple origins in their web extent, which results in multiple lock URLs mapping to the same site URL. Bug: 1105994, 1015882 Change-Id: I2fedac25cc6739edb532da4e39f3d75cd568801f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304537Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799687}
-
Mark Schillaci authored
DumpAccessibilityTreeTests This CL addresses issues with flaky tests and failing tests after this change was landed: https://chromium-review.googlesource.com/c/chromium/src/+/2341826 This CL updates the expected output for Android DumpAccessibilityTreeTests to match actual results of tests. Bug: 1117594 AX-Relnotes: N/A Change-Id: Ibc8de678e3302d77943d315d5fdc72a15104c6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363549Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#799686}
-
Alexandre Courbot authored
Reported by clang-tidy. Bug: None Test: video_decode_accelerator_tests --use_vd passes on Hana. Change-Id: I43bf640830297ef3daeaf3c938585ce36167939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364340 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799685}
-
Trent Begin authored
This default case ensures that CrosHealthd can add additional routines without modifying the DiagnosticsService. Routines will have to be explicitly added to the conversion list if they want to be used. Bug: b:158658869 Change-Id: I9a12db071e59b71e12bb6ce91a6b116c1d9ed52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363315 Commit-Queue: Trent Begin <tbegin@chromium.org> Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#799684}
-
Daniel Murphy authored
This change also cleans up the logic a bit to correctly use the optional type. R=alancutter@chromium.org, phillis@chromium.org Bug: 1116059d Change-Id: Ie467ce69f8fbf4900ca89be49f4de83d32db3f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354453Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#799683}
-
Daniel Libby authored
We should not be using the original root window segments when none are passed to the emulator, since these are based off of the DIPs the widget is occupying, which doesn't take into account the emulator scale (zoom drop down menu). Instead, just emulate a single segment that is the same as the emulated widget size, which takes the scale into account when emulated width/height are not specified. Bug: 1119306 Change-Id: Ic6ab80517989309f697036da873af3448981ad16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350763Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799682}
-
Youkichi Hosoi authored
This CL lets ArcVmClientAdapter start and stop new upstart jobs arcvm-mount-myfiles and arcvm-mount-removable-media. They mount the media directories (/media/removable and /home/chronos/user/MyFiles) under /run/arcvm/media when a user signs in. The directory /run/arcvm/media is supposed to have been exported to ARCVM, and these jobs will make the media directories visible for ARCVM. BUG=b:123377807 BUG=b:123641356 TEST=$ components_unittests --gtest_filter="ArcVmClientAdapterTest.*" TEST=Start ARCVM from various states (using e.g. `pkill crosvm`, TEST=`adb reboot`), then check the log /var/log/chrome/chrome and the TEST=directory /run/arcvm/media. Confirm that the jobs always start TEST=without errors, and the media directories are successfully mounted. Change-Id: Ife673620b41f9b4e4cf72df29ce3ab59d4bbac7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266053 Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799681}
-
Renato Silva authored
Reverted due to a merge conflict with another CL. Original change's description: > CrOS - Login Screen - Minor cleanup > > Rename AnimationState to UiState and use it to determine the > visibility of elements. Remove multiple variables in favor of > UiState. > > Bug: 1075994 > Change-Id: I0d7413fb173dadbff22cde0eb3af6f43586bdee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352883 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798780} Bug: 1075994 Change-Id: I0e2c05b692ddb807930455fca6b5a2216c0a16e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362183Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#799680}
-
Christian Dullweber authored
RenderFrameHostImplBrowserTest.CheckIsCurrentBeforeAndAfterUnload is flaking frequently. Tbr: acolwell@chromium.org Bug: 1114149 Change-Id: If6f3066dc64196a39e9da9da62750f019c453a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362801Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#799679}
-
edchin authored
Create SnapshotBrowserAgent, whose lifetime is tied to the Browser. Remove SnapshotCacheFactory, whose lifetime is tied to the BrowserState (profile). This allows separate windows to have their own folder so that session data can be purged. To achieve this: 1) Add a uniqueIdentifier to the SnapshotCache, which is used in the filepath where snapshots are stored on disk. 2) Set the UISceneSession's persistentIdentifier as the SnapshotCache's uniqueIdentifier. 3) Plumb the SnapshotCache associated with a Browser to all the SnapshotTabHelpers and SnapshotGenerators that are associated with WebStates in the WebStateList in the Browser. 4) Replace all uses of SnapshotCacheFactory with SnapshotBrowserAgent. Bug: 1110958, 1087843 Change-Id: I1aba5f3b61ae7835658887807b329866bf08ce20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348293 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799678}
-
Lukasz Anforowicz authored
The CL tweaks 1 remaining test that relied on the legacy/deprecated behavior that allowed CORS-exempt cross-origin requests from content scripts. The CL changes the test request to same-origin. This change should be okay - the cross-origin aspect of the request was not essential to the test, which mostly wanted to verify that the XHR results in the "blinkRequestResource XMLHttpRequest" |domExpectedActivity|. Bug: 920638 Change-Id: I9d9f765b91c7524586ac1b3280ba063274dba0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359392Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#799677}
-
Friedrich Horschig authored
This CL ensures that credentials who are compromised in two ways display both reasons in the list. Translation screenshot for https://storage.cloud.google.com/chromium-translation-screenshots/cf6c7eaf298250e9e14f7c244dacb7e11f07dd47 Bug: 1117489, 1092444 Change-Id: I214e5e2211d1732cb5fa745a582cc64a37890293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362616 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#799676}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5e15fd87. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7129bd03c2e980e29ffe30e08aa7d893f6fca437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362633Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799675}
-
Mark Mentovai authored
Change-Id: Id0c9619dc31cd2e2bcb510d03baebe6f27e6c03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364013 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799674}
-
Xianzhu Wang authored
This improves performance of RasterInvalidator when some paint chunks are moved from cached subsequences. No functional behavior change. Change-Id: I8cc492200c033ee2759c63f908571722c0a09df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363649Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799673}
-
Morten Stenshorne authored
Line and block fragmentation should cause leading / trailing borders to be painted only in the first / last fragments, as long as 'box-decoration-break' is 'slice' (i.e. the initial value). This hasn't been implemented for NG block fragmentation yet (only line fragmentation), but this CL will make that job easier. There were a bunch of methods and classes on the painting side that took two bool flags, typically named include_logical_left_edge and include_logical_right_edge. Rather than adding another two for "logical top" and "logical bottom", use a struct for all four sides. Also, use physical values, rather than logical ones. It made marginally more sense to use logical values in the legacy engine, but with NG it makes no sense at all. They are stored as physical values in NGPhysicalBoxFragment, and all painting cares about is physical coordinates. Not having to convert them to logical and back to physical makes things simpler (note, however, that on the legacy inline side, they are actually stored as logical values in the InlineBox tree, but we're not optimizing for that case, and adding a converter is easy enough). Remove NGBorderEdges (which dealt with logical sides, with converters to and from physical sides), and replaced it with LogicalBoxSide, and use it mainly on the layout side. Add PhysicalBoxSide, which is what we'll use on the painting side. Went for "side" rather than "edge", since there's already an existing class named BorderEdge, and, according to https://www.w3.org/TR/CSS22/box.html , "side" is a more suitable name than "edge". The writing-mode converter in PhysicalBoxSide is based on what we had in NGBorderEdges. There are some problems here, but currently they aren't exposable, since we haven't implemented border handling for NG block fragmentation yet. Added a TODO. Also remove border inclusion logic from FloatRoundedRect, and let RoundedBorderGeometry deal with it instead. No behavior changes intended. Note that AdjustOutsetsForEdgeInclusion() had a bug, where we converted directly from logical left/rigtht to physical left/right (which was hard for me not to fix). This code has no test coverage, though. But I think it will be needed by block fragmentation. Change-Id: If427f202e49cfcf21234170fdd6b10e3e7c8eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362908Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#799672}
-
Orin Jaworski authored
This CL resolves the occasional case of disappearing Pedals. If a pedal is attached to a match that then becomes a duplicate, the remaining surface match will not have a pedal because only one is allowed in the whole set. In such cases, moving the pedal from the duplicate to the main surface match will preserve the pedal for presentation. Bug: 1118126 Change-Id: Ie25d6634f4face69e102521510d983ea5a723b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363872 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799671}
-
Charlie Hu authored
Bug: 1113375 Change-Id: I140619605e1262bf2f9a3b23972a932da84b4fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333498Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#799670}
-
Nate Fischer authored
No change to logic. This adds a histogram for the flag UI's new search bar, to determine if the search bar was used each time a user toggles a flag. Fixed: 1114247 Test: manually verify we log the correct value Change-Id: I57ce73641146b95ce31e44497f561c9a7aca852f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364003Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799669}
-
Gavin Williams authored
These boolean histograms capture the printer status of the selected printer and whether the user chose to print or cancel in Print Preview on Chrome OS. This set of histogram is useful for understanding how the new Printer Availability icons change users' behavior and confidence when it comes to printing on Chrome OS. Bug: 1059607 Change-Id: Ib69b4679d23695c420307e007d468f25c0b4a5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361024Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#799668}
-
Xiaohui Chen authored
Bug: None Change-Id: I310776c953be841c1aa48f25e48704f21ed74ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363657Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799667}
-
Yao Xiao authored
Use a cached swaa/nac/account_type status to avoid querying the server too often. This is to prepare for an upcoming CL that computes the floc (which will go through all the checks) on history-deletion. Bug: 1062736 Change-Id: I6d48e102f664c3dd1e673f63f5afaf4d7eadef05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363006 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799666}
-
OlivierLi authored
The IO thread param was used twice instead of the UI thread one. Bug: 1034046 Change-Id: I06abd5f50760cd5b02ac53125a5f35b722ce2a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363805 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#799665}
-
Lukasz Anforowicz authored
This CL removes all studies in fieldtrial_testing_config.json where neither the study name nor any of enabled or disabled feature names appear as a string literal elsewhere in the codebase. This CL has been generated semi-automatically: 1. Download cleanup.py attached to https://crbug.com/1053702#c3 2. Generate cleaned-up list of studies: $ python3 ~/Downloads/cleanup.py \ testing/variations/fieldtrial_testing_config.json \ ~/scratch/out.txt 3. Copy the output: $ cp ~/scratch/out.txt \ testing/variations/fieldtrial_testing_config.json 4. Format the output: $ python testing/variations/PRESUBMIT.py \ testing/variations/fieldtrial_testing_config.json Bug: 1053702 Change-Id: If7a17f06786bfa8dbda312401d291bf120251aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363717 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799664}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I11ca61ff56f98115ba70cdc0445876af6bb7d529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799663}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6177a5ec5b8b..9c907b44dac7 2020-08-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12f74d97f2302cc89626310ad8665fd704b606fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799662}
-
Luke Zielinski authored
This also includes a generated set of metadata for the payments API. Bug: 1116091 Change-Id: Ie73e27eb79c3dbd7b9512418f2f3661ae5fe73dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327138 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799661}
-
Patrick Brosset authored
Right now, the grid overlay does not support vertical writing modes. The grid information collected by the backend (track and gap breadth, etc.) is collected "logically", as if the grid was in its default horizontal-tb mode. The approach here is to add the writing-mode value to the grid info object sent to the grid overlay frontend so it can apply the right transformation, as a whole, to the overlay. I decided not to convert coordinates on the backend as I thought the code would become quickly difficult to read and maintain as opposed to applying a transform on the frontend canvas which would achieve the same thing. In both cases anyway, displaying grid labels so they point to the right place has to be done on the frontend, so doing the writing-mode transformation on the front-end means we do everything there, making it easier to follow. Corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364455/ Bug: 1096971 Change-Id: I27fc7b24d73581439cd1fb9c5dd6e4c19d4846d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363050 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799660}
-
Nohemi Fernandez authored
Migrates MDCSnackbarManager dismissAndCallCompletionBlocksWithCategory to MDCSnackbarManager.defaultManager. TBR=yuweih@chromium.org Bug: 1117399 Change-Id: Iabfebf3086e2909a0dee1a4aedc47d8b19d2956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363758 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799659}
-
Oleh Lamzin authored
NOTREACHED() after switch across all union variants does not really make sense. For example if cros_healthd will have more variants for some union and Chrome Mojo interface copy will be outdated (i.e. without union changes), then Mojo library will crash and our converter method will not be called. So there is no way for us to handle out-of-band values for Mojo unions. Bug: b:158658869 Change-Id: Id72fff0ffe847408153ad2ecd8596ea8d2e89c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364495Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#799658}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bcdfc8975ea2..7ad1011a1965 2020-08-19 zhaoliang.ma@intel.com Support AVX2/FMA intrinsics in audio FIR filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f62bf45a9dcf4d5a4f02af646957a3896ae3df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799657}
-
Mitsuru Oshima authored
There are multiple classes with this name for the same purpose. I'll consolidate them into single class in a separate CL later. Bug: None AX-Relnotes: n/a. Change-Id: I5c1ab39f4e3559a2e2fe9f4cd3f6f47c397860f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363880Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799656}
-
Roberto Moura authored
Addition of the thumb strip coordinator, pan gesture handler and animatee classes. The handler handles user pan gestures that reveal/hide the thumb strip and calls methods on other UI elements to be animated during thumb strip transitions. The view revealing animatee is a protocol to be implemented by UI objects that are animated in these transitions. Bug: 1094335 Change-Id: Iad91af43ea4956b47f6784ea138fe4d81a482489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313877Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#799655}
-