- 20 Dec, 2019 7 commits
-
-
Nate Fischer authored
The WebViewClientTest#testOnSafeBrowsingHit() is flaky due to a subtle timing change when we switched to Network Service. This disables the test for now, while we look for a fix. This test was added in OMR1 (which we don't run CTS tests for in chromium waterfall), so we don't need to do anything for earlier API levels. The flaky part of the test was split out into testOnSafeBrowsingHitBackToSafety in Q, which we're already skipping in the JSON config. Bug: 1006953 Test: android_webview/tools/run_cts.py (on P device) Change-Id: I2c3e197484b1678722573ee052aed83150148417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975156 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726610}
-
Sajjad Mirza authored
Add definitions for tester machines for Windows coverage. Add buildbot definitions so the tryjob can run tests. Bug: 1033753 Change-Id: I3d933b1beaedd24ad206c9e5d2528ed5e4496b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972753Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#726609}
-
Xiaoqian Dai authored
To be consistent with the name of other WindowResizers. Bug: None Change-Id: I557b3beb6840fe60bd960490e1cf324bc910eeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977184Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726608}
-
Emily Stark authored
Currently, all cert error decisions (i.e., when a user clicks through a certificate error) are stored in ContentSettings, associated with a Profile. This means that if a user clicks through a certificate error in a <webview> in a Chrome App, that decisions propagates to normal browsing. Persisting decisions within a <webview> is undesirable on its own (because there's no UI to remind the user that they've done so and to allow them to revoke the decision), and it's especially undesirable for that decision to affect normal browsing. Therefore, this CL isolates cert error decisions by storage partition. Decisions made for the default storage partition are remembered in the normal way (ContentSettings for the Profile); decisions for other storage partitions are remembered in memory only. Bug: 639173 Change-Id: If1cca181c80f8d07f5411fbb0d3707cf3755c5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974698Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ba8de1a..7f890a8e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I334028b5c8bab641c3dd635e429006b3c3bec86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726606}
-
Darwin Huang authored
Bug: 1035371, 1034695 Change-Id: Ia845e059d69417bcccf3f9ad6982d4df94fe5b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975290Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726605}
-
sczs authored
- Adds verifyFolderExists to BookmarkEarlGrey and its AppInterface. - Adds ScrollToTop to ChromeActions to be used on Bookmark Folder test. - Deletes BookmarkEarlGreyUtils since its no longer used. Change-Id: Ia1eeb07bcfa80f03e263c49d4f89b2592c338903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976490 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726604}
-
- 19 Dec, 2019 33 commits
-
-
Miguel Casas authored
This CL adds 4K resolution to the Fake Video Capture Device, a.k.a. the rolling pacman. TEST= unittests and ./out/desktop/chrome --use-fake-device-for-media-stream https://codepen.io/miguelao/full/bGNgOYq Bug: 1010457 Change-Id: Ibcab5e83a8bb09dbf4f1e6866951f1ccb9e41f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974995 Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726603}
-
Kai Ninomiya authored
Using the "SafeEjectGPU" tool, we can see that when the "responsible" process (the browser process) has a GPUEjectPolicy of 'wait', any subordinates using the GPU (i.e. the GPU process) get the 'rwait' GPUEjectPolicy: "Eject actions apply to the responsible process, who in turn deals with subordinates to eliminate their ejecting eGPU references." [man 8 SafeEjectGPU] Empirically, the browser does not relaunch. Once the GPU process exits, it appears that the browser process is no longer considered to be using the GPU, so it "succeeds" the "wait". Documentation: https://developer.apple.com/documentation/metal/gpu_selection_in_macos/handling_external_gpu_additions_and_removals Change-Id: Ia44c2ed864d1bdbb52d82ad72e14cbfcb4e32108 Bug: 1035619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974856Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726602}
-
Manas Verma authored
Bug: 949269 Change-Id: I914b20bc5532a4df59120f6954235b1a5daa9013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977185Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#726601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5acad7aa14e2..330a8816909a Created with: gclient setdep -r src-internal@330a8816909a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029520,chromium:984162 Tbr: jbudorick@google.com Change-Id: I12e810a1d1e6fb72bf726936dc6ee9b9112b7e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726600}
-
Alexey Baskakov authored
Observe OnWebAppWillBeUninstalled instead of OnWebAppUninstalled. It's too late to obtain the app pointer from the registrar after a web app uninstall (deletion) happened. Bug: 1029221 Change-Id: I7794ed4fa7ed52ac396949eed88bd4514ed2154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975473Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#726599}
-
David Bokan authored
ScrollBy currently has some logic to check the |current_native_scrolling_element| and use that rather than the CurrentlyScrollingNode. This allows the currently scrolling node to be changed mid-gesture, even though this should never happen. The goal we're aiming for is that every scroll gesture should follow this sequence: ScrollBegin - select the scroller and "latch" it ScrollUpdate - * * * ScrollEnd - release the scroller i.e. "unlatch" it Between begin and end, there should be no modification of the latched scroller. This CL removes the mid-gesture uses of |current_native_scrolling_element|. After this CL, this member of the scroll state is only valid when passed into ScrollBegin where it can be used to specify the scroller that should be scrolled. A future CL will rename this member for clarity. Bug: 1016229 Change-Id: I7a8b24795990623dd27c471f05d06481ff05e147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953331 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#726598}
-
behdad authored
The experimental percentage of representative perf tests increased from 25% to 100% Bug: chromium:1000837 Change-Id: I9d86c3358bcfe8a05d29896453dd0e9154c2f45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976191 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726597}
-
Yuke Liao authored
Due to crbug.com/1034002, linux-code-coverage fails frequently with an infra failure at the step of collecting results for weblayer_browsertests, so this CL removes the offending target for now. Bug: 1016929, 1034002 Change-Id: I41fd82097ff55bf3a84ec9d139e1a3f22894fc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977021Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#726596}
-
Clark DuVall authored
Switches all test to ContentJUnit4ClassRunner since it already has the @CommandLine.Flags parsing bits set up. This also removes a sleep that was added because we couldn't pass command line args before. Change-Id: Ic7e63c31e24d540af0bbf1dda58e800319a1d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975075 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#726595}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6d31bd0894c..6e6b4dd7d3e2 git log e6d31bd0894c..6e6b4dd7d3e2 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-19 jvanverth@google.com Revert "Generate small path SDFs directly from path." 2019-12-19 jvanverth@google.com Generate small path SDFs directly from path. 2019-12-19 bsalomon@google.com Revert "Revert "Blend functions as SkSL built ins."" 2019-12-19 reed@google.com Revert "temporarily expose postIDiv" 2019-12-19 jvanverth@google.com Add wireframe support to Metal. Created with: gclient setdep -r src/third_party/skia@6e6b4dd7d3e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I1ab721b51199c34fb8fd762c1ea77ec936ef729d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726594}
-
Aga Wronska authored
Detailed app activity information are needed by Per-App Time Limits feature. Bug: 1015656 Change-Id: Ibb0a59067a9d9d01adc5b02a1e6fc59ca8fec681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970855Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726593}
-
Lu Huang authored
The pwa install icon should not be visible when the user is adding input to the omnibox. http://crrev.com/c/1933852 made this the default behavior for all page action icons. This change adds a specific test for the PwaInstallView icon view. Bug: 969902 Change-Id: I6cd4fa495f70fefaf228771a2d8fd706e88f88e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975155Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726592}
-
Mason Freed authored
In the (corner) case that the <iframe> src attribute is relative to a data URL, the previous behavior was to silently fail. With this CL, there is now a console message indicating what happened. Example: <iframe id="i"></iframe> <script> let html = `<iframe src="resource.html"></iframe>`; i.src = `data:text/html,${encodeURIComponent(html)}` </script> Bug: 1033313 Change-Id: Ie164edaacd2d92ea2bebc89419782e9204cdf410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972493 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#726591}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5217ad51c521..d28b578b6b09 git log 5217ad51c521..d28b578b6b09 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 yunchao.he@intel.com Disallow storage buffer binding in vertex shader 2019-12-19 enga@chromium.org fuzzing: Add Vulkan backend fuzzer Created with: gclient setdep -r src/third_party/dawn@d28b578b6b09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2d4e14e934b49523773b2d9ac8dd85c27eb6e365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726590}
-
Clark DuVall authored
This will allow testing WebView/WebLayer behavior when using a bundle, and will help investigate any issues that can happen. Bug: 1033098 Change-Id: Id88c128d5dd555ccb188a172d52dcb49ee373af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962899Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726589}
-
Brian Norris authored
<meme>Why do we even have that lever?</meme> (Maybe just a holdover of the Flimflam API?) Shill never has (and most likely never will do so) managed Bluetooth devices. I plan to drop this (unimplemented) definition from system_api and stop documenting it in the Shill docs (https://crrev.com/c/1976962), so Chrome should stop using it. Bug: none Change-Id: I6c868fb05add97da800e39e7c32add5b8e9a1c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977140Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#726588}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=ericorth@chromium.org Bug: 1023677 Change-Id: Ic527ff1a7cb4654e17df53ba36a3da314187de17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957495 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#726587}
-
Kramer Ge authored
OS API creates vulkan swapchain images as render targets. Estimate the allocated GPU resource with vkGetImageMemoryRequirements. Bug: 899905 Change-Id: I162ab641c3e13a10fa29e8e8860dee06b2598a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967552Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#726586}
-
Aran Gilman authored
ExecuteJsScript() is used only once in this CL but will be used in new tests added by https://crrev.com/c/1922788. This CL also runs clang-format on pinch_tester.js and modifies it to return a bool instead of a dict. The latter simplifies verification of script execution in the C++ portion of the test. Bug: 1016615 Change-Id: I2c847eb53556a30e991d988fb676c6a3fa5aee8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971702 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726585}
-
Michael Thiessen authored
Split off of https://chromium-review.googlesource.com/c/chromium/src/+/1901591 The motivation here is to make get rid of the memcpy and leaked ptr in DoAddSchemeWithType to make the code more readable. Also DCHECKs that schemes aren't locked when calling EnableNonStandardSchemesForAndroidWebView. Bug: 783819 Change-Id: I959d364fd0572a3c09c68ab75e48f46809f8dbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974759 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726584}
-
Ahmed Mehfooz authored
Bug: 1021133 Change-Id: Ic7cbf25c094006efd970c75dff2b733b31620bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974599 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726583}
-
Ella Ge authored
To support replay input events (crrev.com/c/1944333). This CL adds input event's detail information (coordinates, modifiers, button to trace data, when "devtools.timeline.inputs" category is enabled. Change-Id: I73cad86a9922e0a7b494ac0a01f8817e53cf7e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943179Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#726582}
-
Aaron Leventhal authored
Make sure even if painting returns early, that accessibility focus is still updated. Bug: 820351 Change-Id: I4d712742b9677095cdcf19d486945c892b73a11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976071 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#726581}
-
Oksana Zhuravlova authored
This change addresses the crash in TextSuggestionHostMojoImplAndroid::StartSuggestionMenuTimer() if text_suggestion_host_ is null. TextSuggestionHostMojoImplAndroid is now not created if a TextSuggestionHost has not been set for the corresponding RenderWidgetHostViewAndroid. Bug: 1034125 Change-Id: Ia21fba5e6d486637715743d33e65d2fcccc86c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976829Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726580}
-
Ben Pastene authored
All uses of Simple Chrome currently already do this: https://cs.chromium.org/chromium/src/third_party/chromite/cli/cros/cros_chrome_sdk.py?rcl=8b42807c6f1e5b2a046695f363227138f56db6cb&l=999 While the ebuild explicitly overwrites the host toolchain with the host toolchain in the chroot: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aeeb6096850b8fe779d87b83a5498160e25a3ffa/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild#907 So this should have no effect on ebuilds of chrome, while letting us delete parts of simeplchrome's chromite code. Bug: 937821 Change-Id: Ic589c948407c6dd34bd67e95520cc05ed84740b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976284Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#726579}
-
Nate Fischer authored
This adds an OWNERS file for the aw/nonembedded folder. I'm nominating myself and torne@ for initial owners since we've written/reviewed a number of CLs in the folder recently, but this still inherits the top-level AW owners. Test: N/A Change-Id: Ic4591f59e1a4e81088ea0de69136e1dcc39d4b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976882Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726578}
-
Sonny Sasaka authored
Bug: b:145163508 Change-Id: I93f832f958a13fd88c13fe2a74bdea66a69e584d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976497Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#726577}
-
nancy authored
BUG=1011235 Change-Id: Icb262a58b4464d7963acb0b22a9d30ce7b070060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972738 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#726576}
-
Devlin Cronin authored
There was a class, ConsoleWebContentsDelegate, in chrome/browser/ssl/security_state_tab_helper_browsertest.cc. However, it's never used, and is obsolete with content::WebContentsConsoleObserver. Remove it. Bug: None Change-Id: I1178fe62927b4d6bb5e8d8072a65814f3aaca525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974321Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726575}
-
Peter Kotwicz authored
This CL enables preconnecting and DNS prefetching for webapps BUG=1035752 Change-Id: If9856ecd6febc630d84da870a95ce2810458f3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976560 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726574}
-
John Budorick authored
instead of pool:Chrome-CrOS-VM. Bug: 1011474 Change-Id: I27b1be5840cc4f017eeb96cfc7560a87aab14d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976553Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726573}
-
Kelvin Jiang authored
This CL leverages crrev.com/c/1923611 by using the navigation ID within WebRequestInfo to correlate a main-frame navigation request originating from the previously active WebContents to the new WebContents loaded from that request. This is accomplished by adding the actions matched with a request to a pending set of actions for a given navigation ID if the request is associated main-frame navigation. Once the navigation completes, the actions matched for the navigation are added to the badge text and cleared from the pending set. Bug: 992251 Change-Id: Iac7b3502a3598c9d06ab3261ea33f30d2cb20ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956110 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726572}
-
Ian Kilpatrick authored
IsLogicalHeightTreatAsAuto -> IsLogicalHeightTreatedAsAuto There should be no behaviour change. Change-Id: I074dba0f468981f901869fa1bb96c098157c7ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977059Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726571}
-