- 10 Oct, 2019 40 commits
-
-
Hwanseung Lee authored
Use enum class instead of enum for ActivatedShape enum class is more type safety. Bug: 940736 Change-Id: I377b57af89eb29199f31496b310d7adea414e711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850677 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704509}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8374dec2..ef91f895 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I138bd6449eec23313f7438e783b19fb30ebe0e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851404Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704508}
-
Jay Harris authored
Bug: 860581 Change-Id: I3536dfbae57e9141a5f6fdbcb6c1722252a60d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850686Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#704507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71681bf1e84a..3481902904a9 git log 71681bf1e84a..3481902904a9 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 ehmaldonado@chromium.org depot_tools: Remove depot-tools-auth Created with: gclient setdep -r src/third_party/depot_tools@3481902904a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: Ifaa8e95da25f86900a46170c1664340a4216e0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704506}
-
Gyuyoung Kim authored
This is a reland of 43c06dab Include manifest.mojom-blink.h in push_messaing_client.cc Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 11 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I467c6ee86c44e581a6fee3cdcb8a5fdf6ed29aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847599 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704455} Bug: 1001360 Change-Id: I394b286c39adbb80356ed84e10ac466750d3164a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851368Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704505}
-
Ken MacKay authored
Merge-With: eureka-internal/323312 Bug: internal b/127963522 Change-Id: Ic5a57c0c673d167bb7c56f9c5f5f41a8c64cfa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848941 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704504}
-
Hiroshige Hayashizaki authored
Intent to deprecate and remove: https://groups.google.com/a/chromium.org/d/topic/blink-dev/KyB2mwOmjrk/discussion This CL also removes crash tests that require executing scripts moved between documents. Code paths related to scripts moved between documents will be covered by e.g. https://github.com/web-platform-tests/wpt/pull/5911 Bug: 721914 Change-Id: I6acb7182c4a62accd5e5285adb6a77a2cd891465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843508Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#704503}
-
Maggie Cai authored
This CL adds fields in IntentInfo to allow Chrome to send more flexible intent to ARC. This allows ARC to create the URI rather than Chrome. BUG=853604 Change-Id: Ib908039e079109e5d72c31d8c5822b8bcd2b10bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839751 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704502}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a9ec07ff393..fe23b1de9ed0 git log 0a9ec07ff393..fe23b1de9ed0 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 herb@google.com Revert "Draw perspective text as paths." Created with: gclient setdep -r src/third_party/skia@fe23b1de9ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I4e8f95f75266c9826ccd7fc590ab3148d5c640ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851151Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/05b285760e40..65adcb504d02 git log 05b285760e40..65adcb504d02 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 rharrison@google.com Add in shaderc_features.gni to support build time flags (#837) Created with: gclient setdep -r src/third_party/shaderc/src@65adcb504d02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ie3f59dd445730236da5d3a3ea30392f0417f4e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849636Reviewed-by:
-
Shuo-Peng Liao authored
ImageProcessor stores input and output's configuration with VideoFrameLayout object and VideoFrame::StorageType. However, VideoFrameLayout is unable to represent proprietary format, e.g. MT21, so it is not suitable to represent IP's input/output config. Instead of storing individual configuration properties (format, visible_size, color_plane_layout, storage_type), we modify an existing class, ImageProcessor::PortConfig, to store ImageProcessor's input/output configuration. BUG=1004727, 1005636 TEST=Run VDA test on elm and kukui Pass image_processor_test Change-Id: I720b8ba41db8c5d4e0d1c42ea41f3d4ba27d3ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817858Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Shuo-Peng Liao <deanliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704499}
-
BUG=762641 TBR=satorux@chromium.org Change-Id: I6e032bfdc68a841676c7ee19f2ac19470a031586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851388Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704498}
-
Peter Kotwicz authored
This CL renames ActivityTabTaskDescriptionHelper and ActivityTaskDescriptionIconGenerator to be CCT specific BUG=989912 R=pshmakov TBR=twellington (as files are being moved from chrome/browser) Change-Id: I8f07a043663178a26405d26e69ab7dfbf37104bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849943Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704497}
-
Alex Moshchuk authored
This CL fixes the undesirable behavior where manually enabling password site isolation from chrome://flags didn't take effect if the user's device was below the site isolation memory threshold. The same also affected strict origin isolation, which is also fixed. (Strict site isolation and IsolateOrigins are not affected because they map to cmdline switches rather than base::Features.) Bug: 1009828 Change-Id: Ibdfbca5ed1e2216e347e15a18c71ceaeafe2da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845667 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704496}
-
Kenichi Ishibashi authored
This CL is a preparation for passing outside fetch client settings object. This CL plumbs outside fetch client settings object from browser process to renderer process but its fields aren't set correctly yet. Follow-up CLs will fill them correctly. This CL does not have behavioral changes. Bug: 967265 Change-Id: I83b9bc6644c2bf33a0516f869166cc639fe61683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846220Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704495}
-
Bo Liu authored
Do a complicated dance to avoid visual artifacts during transition: 1) Allocate new SurfaceData, and insert it into view hierarchy below the existing SurfaceData, so it is not yet showing. 2) When Surface is allocated by new View, swap chromium compositor to the new Surface. |markForDestroy| is called on the previous SurfaceData, and the two SurfaceDatas are linked through these to variables. Note at this point the existing view should is still visible. 3) Wait until new SurfaceData decides that it has content is visible to be shown. * For TextureView, wait until TextureView.invalidate is called * For SurfaceView, wait for two swaps from the chromium compositor 4) New SurfaceData calls |destroy| on previous SurfaceData. * For TextureView, it is simply detached immediately from the view tree * For SurfaceView, to avoid flicker, move it to the back first before and wait two frames before detaching. 5) Previous SurfaceData runs callbacks on the new SurfaceData to signal the completion of the transition. Other related changes: * Update CompositorImpl::SetNeedsComposite to force a new frame to be produced. * Allow java to control caching and releasing the back buffer. * To complete the steps above, chain the two SurfaceDatas so new one calls destroy on old one, and old one calls runCallbacks on the new one. * Add TextureViewWithInvalidate to listen to when it is invalidated. * Implement moveChildToBackWithoutDetach with calls to bringChildToFront since android does not have a moveChildToBack method. * Send an artificial surfaceDestroyed signal in destroy to control back buffer caching. Change-Id: Ie43485304c1c08df5ae11cd7756767d29e84e112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836605 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704494}
-
Kenichi Ishibashi authored
Conversions between WebFetchClientSettingsObject and mojom::FetchClientSettingsObject will be needed for shared/service workers in addition to dedicated workers. Introduce a helper function to avoid duplication of these conversions. This CL does not have behavioral changes. Bug: 937177 Change-Id: I6cef87d510b41ae31087c71a90c6b704049bb20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846622 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Roger Tawa authored
Bug: 1012865 Change-Id: I83e03782d6975b1b5a7b53c994476f933f451536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849984 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704492}
-
tby authored
When a FilesTaskNotifier is not available (which happens sometimes in guest mode), the |files_ranker_| object in ZeroStateFileProvider never gets initialized, crashing Chrome the next time it is used. Bug: 1012911 Change-Id: Ic1d2231d4d3e9810fd16a7425a98faf94c65115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850672 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#704491}
-
Joel Hockey authored
Updated FileManagerDialogBase.shown to be set to false immediately when hide() is called. Previously, when one dialog spawns a second, the second fails to show since FileManagerDialogBase is setting its static 'shown' property to false async. The call to show the second dialog is ignored since the dialog believes it is still showing the first. Bug: 1010371 Change-Id: I96d5b9fad72c1c7a87520fdc92604494b5b7a9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849474 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#704490}
-
Mugdha Lakhani authored
We currently wake the browser up and call FireReadyEvents() to fire any ready sync events, and then call the passed |callback|. Before this change, we were invoking the callback once all sync events had been fired. This CL waits till all those sync events have completed before running the callback. This will have the effect of keeping the browser awake until all sync events complete, and will add a few minutes to how long we hold the wakelock. It will give the browser a chance to finish processing (Periodic) Background Sync registrations and reduce the number of times we need to wake the browser up. This CL adds a new parameter to BackgroundSyncParameters to enable this functionality, so that we can run experiments using the existing 'BackgroundSync' field trial before it's enabled everywhere. A unit test has also been added to verify the functionality. Bug: 933849, 932591 Change-Id: Ica68f6bdb262dea2365334296ae825d91126c65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807194 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#704489}
-
Manas Verma authored
Whenever card suggestions are shown, and the user has server cards and is eligible for FIDO authentication, a preflight call is made to retrieve authentication details. Logging the number of times this call is made. Also includes a bug fix, something that was caught by the metrics test. Bug: 949269 Change-Id: Ic1067de5a137598c0758f787a41d7a311f7d0a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783858Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#704488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9514a2a7642d..d65a3ffb5ea1 Created with: gclient setdep -r src-internal@d65a3ffb5ea1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3c8006113e04707aa93ea29744f2d41920f0c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851152Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704487}
-
Yu Han authored
Previous to this CL, hitting CTRL-A inside a TextArea containing text that ends with a newline would cause the selectionEnd property to be incorrect. selectionEnd returns a number that's 1 pass the end of text. This is because TextControl automatically inserts an BRElement at the end when the last child is a carriage return. And the inserted node is taken into consideration when calculating the selection range. The fix is to ignore this last child if it's a BRElement. Tested with carriage return inserted into the beginning, middle and end of text to make sure there's no regression. Bug: 882614 Change-Id: Idc7a1f098556fc74b89f3041e3f5f35e127eed78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838549Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This is a reland of bc1f6367 Original change's description: > [fuchsia] Add wildcard support for hosts filtering. > > Add wildcard-based filtering for hosts in UrlRequestRewriteRules. > > Bug: 1011156 > > Change-Id: I982b2241e622194dbf39ccd8519af8f92ee593c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838706 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704406} TBR=wez@chromium.org Bug: 1011156 Change-Id: Iee15c86f44a6f6a1d2496f79483add4ea12d2799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851324Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#704485}
-
Jay Harris authored
This CL is just the boilerplate of creating new classes and wiring them up to WebAppProvider. Eventually, the functionality from web_app_extension_shortcut should be migrated into this class. A WIP CL for beginning this is available here: https://crrev.com/c/1846422. The motivation for beginning this now is file handling on Linux, as registering and unregistering file handlers in the OS is tightly coupled to shortcut management. Bug: 860581 Change-Id: I3e28018d6fd6656fccd3c22ed62b9576db43f51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847708 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Navigation Sheet should be closed when its Tab is closed. In most cases the sheet is close prior to Tab, but the opposite can happen if incognito tabs are closed via Android notification. This CL ensures the sheet gets closed upon tab closure. Bug: 1011073 Change-Id: Id9729c2d8987bfe37ff81f47a8070d40a86e00e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842134Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704483}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. - Implement WebAppSyncBridge::MergeSyncData and ApplySyncChanges. - Implement "Local changes" propagation to change_processor. Unit tests and browser tests will be added later in a follow up CL. An MVP implementation of the bridge needed first. This CL follows Chrome Sync's Model API doc https://chromium.googlesource.com/chromium/src/+/HEAD/docs/sync/model_api.md In next CLs: Implement sync-initiated installs and uninstalls. TBR=alancutter@chromium.org Bug: 860583 Change-Id: I65d3cae6f47dd8fc8fdbe2c7cfb2ed13012f90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830494Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#704482}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I1f891f5d90d03a40c851f68067d9801305131e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851444Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704481}
-
Regan Hsu authored
The Arabic string for 'Refresh' changed, causing de-alignment issues. Space on the right side is reduced to account for a longer string. Initial - screenshot: https://screenshot.googleplex.com/YTso9OyFquU 2nd patch - screenshots: Normal Text: - https://screenshot.googleplex.com/auLs71d3Ops - https://screenshot.googleplex.com/YeMT1v0Wdgy Exaggerated long text: - https://screenshot.googleplex.com/BSJaTPBnGmb - https://screenshot.googleplex.com/Om5iuYQUfT1 Bug: 987195 Change-Id: Ib1de302b0eaab700270a5a1fd46abf9609fd7870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850412 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#704480}
-
Julie Jeongeun Kim authored
This CL migrates ImeServiceTest with new Mojo types using Remote. It replaces old Mojo types for InputChannel with new Mojo types. Bug: 955171 Change-Id: Ic9fb98c6342bd4d5338d731a7f08da099a5309a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849614Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2fa9d73469ff..d7323cf7f12d git log 2fa9d73469ff..d7323cf7f12d --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jmadill@chromium.org Fix a warning with VS2019. 2019-10-09 jmadill@chromium.org Roll Chromium DEPS (October 2019). 2019-10-09 jmadill@chromium.org Vulkan: Get rid of "TextureVkViews". Created with: gclient setdep -r src/third_party/angle@d7323cf7f12d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I7df99fda64309f5dc91a6ddd32e3ef8af63287f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851174Reviewed-by:
-
Dan Beam authored
FWIW: I tried using capturing (true as third arg to addEventListener) and stopPropagation()/e.defaultPrevented. Because keypress seems to be handled before click, it didn't make a difference. So I landed at target filtering. This has the benefit of never navigating for elements we don't add to this list, but with the detriment of needing to explicitly add any new UI elements. R=mahmadi@chromium.org Fixed: 1012996 Change-Id: Ie36a90210eee8238d05d026bf370a8bc95160a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851228Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704477}
-
Findit authored
This reverts commit 43c06dab. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 704455 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzYzA2ZGFiNGU2YWYwOWY4MGQ0YWVmMjMwOTI2YzJiNzdiMGY4ZGUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/55207 Sample Failed Step: compile Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 11 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I467c6ee86c44e581a6fee3cdcb8a5fdf6ed29aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847599 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704455} Change-Id: I9564a7f8a608f121f50ab53061160955f4ef9015 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851386 Cr-Commit-Position: refs/heads/master@{#704476}
-
Julie Jeongeun Kim authored
This CL converts MdnsResponder in mdns_responder.mojom using SharedRemote and PendingRemote. Bug: 955171,978694 Change-Id: Idd336a690d55e65817ec2a42bd173dc2b3dd59fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846217 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
siyua authored
The idea is to move autofill bubble showing logic out of browser window to keep it short and clean. Also this extracted class can be a observer for autofill data saving and notify avatar so that avatar itself does not need to be such observers. Also add avatar button accessor in the ToolbarButtonProvider. Bug: 964127 Change-Id: I46f85f01b1da9d8d85d9049a1acd95ebe9bb2c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845827 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Yusuke Sato authored
This allows us to inject failures to the StartJob and StopJob functions for better unit test coverage. BUG=b:142144019 TEST=try Change-Id: I17ebd3ddd74cd78bb7b123a7fda0a377d53963ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850572Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704473}
-
Nico Weber authored
This reverts commit 3a54e6fa. Reason for revert: Possibly no longer needed after #703693 disabled g2gtest()s in cross builds in a different way. Original change's description: > Don't build js2gtest()s in win/cross builds. > > Bug: 1010561 > Change-Id: Ic6b0d656af1944d9dbb16f5fb96d70fe1ad90f14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835157 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702156} TBR=thakis@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010561 Change-Id: I7b8fd3399786da5d51b827b846d2b03c72efb337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851085 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#704472}
-
Darren Shen authored
As of cl/258693469, our code no longer uses ProcessText API, which has been deprecated. We delete the unused code. Bug: 1009903 Change-Id: I4d920d6b147df086c01fb4d5e3c18f31b5ed2f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833018Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
-
Cathie Chen authored
Currently, the value of ScrollLeft / ScrollTop / ScrollTo for a box in Element is the offset to the origin of ScrollableArea(left-top corner). This behavior isn't consistent with Document-scroll or the behavior of other vendors either whose origin is ScrollOrigin. There're compatibility problems when the box has leftward or upwards scroll overflow direction. According to the Specification, the scroll x-coordinate of a leftward box is nonpositive, and the scroll y-coordinate of an upwards box is also nonpositive. With using the origin of ScrollableArea, the coordinate is always nonnegative. In order to fix it, this patch transforms the scroll coordinate of a box in Element interface to use ScrollOrigin as its origin. There are a few cases needed to recalculate the scroll coordinate to meet this change. Since the origin of scroll coordinate transforms from the ScrollableArea origin to ScrollOrigin(), current_coordinate is equal to old_coordinate - ScrollOrigin. E.g. current_scrollLeft = old_scrollLeft - ScrollOrigin().X(). This behavior is guarded by a feature flag. See intent to ship blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7X2CKPGeEa0 Bug: 721759 Change-Id: I0ceed62e6845c6e5cd976e59b36f292d60bb669c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700001Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: cathie chen <cathiechen@igalia.com> Cr-Commit-Position: refs/heads/master@{#704470}
-
