- 22 Jul, 2020 40 commits
-
-
Robbie McElrath authored
This CL defines WebContentsDelegate::ShouldPinTopControlsToContentTop(), which embedders can use to tell BrowserControlsOffsetManager to only show the top browser controls if the page is scrolled to the top. WebLayer's Browser#setTopView pinToContentTop parameter is hooked up to this new method. Bug: 1069498 Change-Id: I7a19656c0ee3219936c3279bfb89591b1f3abb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284138 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790985}
-
Sammie Quon authored
Makes use of the clipping api for ink drop highlights/ripples. ToggleButton: Ink-drop layers were always forwarded to the thumb view, so the InkDropMask was unnecessary before. FrameButton: InkDropMask relies a bit on the frame button internals, so create a custom highlight path generator. MediaButton: Used CircularMask which can be converted to a CircularPath. Test: manual Bug: 1056490 Change-Id: I16e4b853158136eee2ffba1a2de2b495437896f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310875Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790984}
-
Vasiliy Telezhnikov authored
This CL removes GLRendererCopier for SkiaRenderer, as we use skia for readback on all platforms. Bug: 1044594 Change-Id: I51ee6f36c87a0598a5aa7dd9d9dc1c9ca1417d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307651Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790983}
-
Alexander Cooper authored
Converts ModelAddedCallback and ModelRemovedCallback to base::Repeating Callbacks to match their usage. Removes the corresponding entry from PRESUBMIT.py Bug: 1007635 Change-Id: I10393eea74ff16ba86f5e7118765557fca770028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303877 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790982}
-
Fritz Koenig authored
ChromeOS devices are usually lower powered where making use of the hardware based video decoders helps a lot with battery life. ChromeOS SOC's are closer to those of Android, so choose the same cutoff point. Bug: 684792 Change-Id: I426e0dedaf210b0d7b7c387ddacebdaa78eb363b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303605Reviewed-by:
Will Cassella <cassew@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790981}
-
Sharon Yang authored
The node.fidl interface is expected to change over the next year, so add a default case to prevent against future SDK roll breakages. Test: AccessibilityBridgeTest and AXTreeConverterTest Bug: 1108467 Change-Id: I63612fcdd88f169279a2cad464be97b17a8e0369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314040Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790980}
-
Anders Hartvoll Ruud authored
I forgot to handle CascadeOrigin::kNone, which means the subsequent call to priority.GetPosition() would always return zero, and we would access the wrong value (and possibly crash). Handle that case, and add a more detailed test which verifies each origin. Fixed: 1108019 Change-Id: I298c12ed56231b27f3ce505911db5e3fe0c2a16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310535Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#790979}
-
Yuly Novikov authored
This reverts commit 539778cf. Reason for revert: not enough HW capacity for more tests Original change's description: > Explicitly name webgl/2 conformance tests on Windows > > These tests should be explicit about using ANGLE's d3d11 backend. > > Bug: chromium:850252 > Change-Id: I0f3d348edf38f845efeb5ba9d2a70f38b662efbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302413 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#790942} TBR=ynovikov@chromium.org,kbr@chromium.org,bsheedy@chromium.org,jonahr@google.com Change-Id: I0af5192a835a0094c468d000786ba6b5b3aec7f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:850252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314135Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790978}
-
rbpotter authored
Adding tests for zoom, fit, and rotate buttons. Also fixing a small bug, where forceFit() was setting the icon to the opposite of the desired type in the new toolbar (reproduce by opening a PDF with #view=fit appended to the URL, with the new and old UI). Bug: 1101146 Change-Id: I86b1e0b7cdb1e5a04cb10552c904e0d58cd6f20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310898 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#790977}
-
Anastasia Helfinstein authored
Add an EventHandler class to wrap calls to addEventListener and removeEventListener. This makes the code more readable, by describing semantically what is happening, and less complex, by automatically removing old event listeners when the nodes in question change. In addition, it eliminates the need to save bound pointers to functions to eventually remove a listener. AX-Relnotes: n/a. Bug: None Change-Id: I3994abbdd2f0da1ce06f0b51fbcf0634fa7eb2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303458 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790976}
-
Andrew authored
UpdateEngineAttemptResult does not match the AttemptResult enum in update_engine. Add two missing values. BUG=chromium:1108110 TEST=None Change-Id: I756358dcfb1e167359e8e350c6a75155fd6f9937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311076Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Andrew Lassalle <andrewlassalle@chromium.org> Cr-Commit-Position: refs/heads/master@{#790975}
-
Matt Mueller authored
Bug: 973650 Change-Id: I60375e858ac017b2b1ae96ad7bff8ce8aa6ffc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310830 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790974}
-
Yuke Liao authored
This CL implements function to run tests with ash-chrome Bug: 1104318 Change-Id: Ic53d72c5f6152ed114ca360405e7b459d6b71f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309804 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790973}
-
Prabir Pradhan authored
Previously, ClientControlledShellSurface always assumed that the client uses default_device_scale_factor, and that the client converts x/y values to DP before sending bounds information to the server. This means that each pixel in the client buffer corresponds to one pixel on the display only when the scale factor is set to the default_dsf. This CL allows a client using the remote_shell protocol to disable using default_dsf for scale cancellation. When it is disabled, remote_surfaces for that client will use the display_scale_factor of the display on which the surface is placed for scale cancellation. In this CL, if use_default_scale_cancellation is disabled: - ClientControlledShellSurface expects that clients will send all bounds and buffers in display pixels instead of DP; - When the device_scale_factor changes, the client will update the UI accordingly to account for the new scale factor; - When the device_scale_factor changes, the client will resize each of its windows that are not fullscreen or maximized so that the bounds change proportionally to the scale factor; - When the client sends the first buffer of a different size (after resizing the window), the newly added OnContentSizeChanged callback of the SurfaceObserver interface is called, and the server will commit the scale cancellation to use the new device_scale_factor. BUG=b:141715728 TEST=manual with client-side changes; change the scale using Ctrl-shift-(+/-) and expect scale cancellation to updated visually. Change-Id: I06b2c47828af4d1d1923fdc4b6a82e5c41cd9766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255141 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790972}
-
Yuwei Huang authored
This CL hooks UrlLoaderFactory into FtlSignalStrategy, as it will be needed by multiple components inside FtlSignalStrategy. This is split off from crrev.com/c/2293230, as that CL is blocked by server rollout. Bug: 1103416 Change-Id: I0efeb4468c066a8f7f2eb1dd35d1e20b2cca3366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310775 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#790971}
-
Saurabh Nijhara authored
This CL changes minimum version policy to work with Chrome OS version (platform version) instead of Chrome version. The policy updates Chrome OS and Chrome gets updated along with it, hence it makes sense to use Chrome OS version here. Also there are other policies that already work with Chrome OS version, like DeviceTargetVersionPrefix. Bug: 1106736 Change-Id: I84c19254d800638f412df99c0bed67457a33e888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302009Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#790970}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.25-1595237914-benchmark-86.0.4207.0-r1 to 86-4183.25-1595237914-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id92efd3a917fec2bd609068b28c70d0585d15c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790969}
-
Yuchen Liu authored
Use AudioManagerAndroid, instead of CastAudioManagerAndroid on ATV. The flag should only be used for dev and testing. Bug: internal b/160753974 Test: Turn on the flag and verify in the log Change-Id: Ie205d3f48d40d85b67272eeb143dbbc99d22bfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311677Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790968}
-
Che-Yu Wu authored
Bug: 1104858 Change-Id: I40e12d5922f33036953fcedad3a19faf42557c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313296 Commit-Queue: Che-yu Wu <cheyuw@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790967}
-
Koji Ishii authored
TBR=yosin@chromium.org Bug: 982194 Change-Id: Ibf53acb6ce258419128fe809bda63539eac42a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313057Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790966}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4181.3-1595240638-benchmark-86.0.4207.0-r1 to 86-4181.3-1595240638-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia092f2b2daaaa53bb4176ef38515cf783142de26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790965}
-
Adam Raine authored
Surfacing the composite failure reasons in the inspector trace will allow Lighthouse to identify animations which can cause jank during page load. Bug: 230229 Change-Id: I40031189b3bb47f7bfa48ab2a7c06e40cd8c36c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283289 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#790964}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76e4baebf3bd..deded62426ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1107843,chromium:1107847,chromium:937821 Tbr: kelvinjiang@google.com,wjmaclean@google.com Change-Id: Ic6222e0f92673d920ebcda1ed4be339687a80c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790963}
-
Ayu Ishii authored
This change adds CookieAccessSemantics to CookieAccessResult and CookieAccessResult to CookieChangeInfo so change events will have CookieAccessResult data. This change is part of a larger effort [1] so CookieStore will eventually be able to consistently return EffectiveSameSite for SameSite across all its endpoints. [1]https://crbug.com/1092695 Bug: 1092695 Change-Id: I498bd79c1bfa6d92e92414173a219fe4f3d2482e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288508 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#790962}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.25-1595242326-benchmark-86.0.4207.0-r1 to 86-4183.25-1595242326-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8cb9f0d6579616da5c537ba4eed40ec544cab373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790961}
-
Kramer Ge authored
Test expectation of conformance/misc/shader-precision-format.html on ChromeOS FYI Release (kevin) is set to Failure on Nexus 5. TBR=kbr@chromium.org Bug: 1108368 Change-Id: I59aa049b373fd38fa759d0f3246de33ee95fde9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313302Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#790960}
-
Sorin Jianu authored
Per-project coding style: ref counted types must be thread-safe and sequence affinity declared with sequence checkers in destructors if needed. The motivation for such change is that our types get aggregated in different ways, and mixing thread-safe and non thread-safe may result into puzzling asserts in ref-counting code when objects get shared between sequences. Bug: 1105922 Change-Id: I31c5f3c118b633d3a3eb5bf072d3872fba2d2054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314418Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790959}
-
Robert Ma authored
Note that this does not really fix the underlying issue, but is for verifying that these are indeed intermittent. Bug: 1108417 Change-Id: I9a17f72367c2acae19456493b05c89770bafc753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313698 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790958}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595418891-a8621ba8b81fb74c2c9632ebc3dbb1023038eccd.profdata to chrome-mac-master-1595437495-48d009be52961ba2cab16cb5f417b3b20b5e946c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I670b4c5b13e041a0c2fb58a73f59a0603f4418bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790957}
-
Adam Langley authored
This change plumbs policy-approved enterprise attestation requests into CTAP2. It also supports authenticator-approved requests but these are currently hard-coded to be denied. A future change will need to implement UI to complete support for this. This change alters behaviour too: requesting enterprise attestation and “missing” (i.e. not being listed in policy and not being approved by the authenticator) now results in no attestation. I.e. the fallback from “enterprise” is now “none”, not “direct”. Change-Id: Ia995ebe2143d2fba63f8953b953cdc7182b661ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296260Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#790956}
-
Salvador Guerrero authored
The following tests were disabled because they are flaky - StartSurfaceTest#testScroll_Top__NoInstant_Return - StartSurfaceTest#testScroll_Top__Instant_Return - StartSurfaceTest#testScroll_Quick__NoInstant_Return - StartSurfaceTest#testScroll_Quick__Instant_Return TBR=yusufo@chromium.org Bug: 1108459 Change-Id: I3ff0271d6775d3138dd9b7ab2e3eb8b92ba8d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314297Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#790955}
-
Mohamed Amir Yosef authored
This CL moves FillAutofillableLogins() and FillBlacklistLogins() APIs PasswordStoreSync to PasswordStore. After the removal of PasswordSyncableService those APIs aren't needed in PasswordStoreSync anymore. Bug: 925307 Change-Id: I4a92be1165e26c63cced1c9ff3344289d16df4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312820Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#790954}
-
Eric Orth authored
Record a ratio between success time and the base timeout. Will be used to help inform future timeout improvements, especially regarding SECURE mode transactions where fallback is not an option. Bug: 1105138 Change-Id: I252936f2840b7e4ead9803de12585445c9064adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308859Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#790953}
-
Jia Li authored
- Completes the launching and model loading code paths of the Chrome ML Service. - Adds a singleton ServiceConnection class to provide access to the unique service connection in the browser process. - Creates a copy of optimization_guide::PredictionModel to avoid pulling in unneeded dependencies. Bug: 1102425 Change-Id: Icddfc7dfe574c6810c52a1de0063ff2573b9a3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296067 Commit-Queue: Jia Li <jiakl@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790952}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3c72fdf8246..9faf0cdcd0c6 2020-07-22 jmadill@chromium.org Capture/Replay: Use custom GL header. 2020-07-22 geofflang@google.com Textures that have bound surfaces are always renderable. 2020-07-22 wander.lairson@gmail.com D3D: Make possible to build angle without D3D11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ie4abbec79d1a3cb55de038fd49ace72927d2df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790951}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6081b23b2980..e4e1fb30c836 2020-07-22 ehmaldonado@google.com bot_update: Map refs to remote refs and don't checkout after clone. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104182 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iae1b6b6df62cc954ecfca0988f4a4d2e8d1c18d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790950}
-
Garrett Beaty authored
Change-Id: Iaeb6b10ae9b2ff13fe4d1660ac562b243b1ab152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313045 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#790949}
-
John Z Wu authored
The check was there before, but I accidentally removed it as part of the refactoring in: https://chromium-review.googlesource.com/c/chromium/src/+/2254351 Change-Id: I4c57334ead28dd94fa624656b6fc21041bb10a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310845 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790948}
-
Sangwoo Ko authored
Avoid changing image when new ui::ImageModel equals to the old one or isn't for visible state. Bug: 1048901 Change-Id: I56d583818a0c85db8b15d78520dfa2a634e0f7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305809 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790947}
-
Brandon Goddard authored
This CL adds a new histogram to track devtools Grid Setting changes. The original histogram would fire multiple times per setting change due to it being bound to each target on the page. It is now marked obsolete. This new histogram is updated to fire on launch, listing all current settings. A follow up change will remove the logic for the old histogram from devtools_ui_bindings once the frontend CL has landed and deps are rolled. Frontend CL: https://crrev.com/c/2308256 Bug: 1106888 Change-Id: I8eec21c28550e19e026c1547af1c8f284e2cb2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304166Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790946}
-