- 07 Jul, 2020 40 commits
-
-
Will Cassella authored
By default, `media::DecoderSelector` uses a decoder prioritization function that tries to balance power and performance with a resolution -based hardware decoder cutoff. This CL adds a default-disabled feature to instead use a function that prioritizes nothing, which is useful for testing. Bug: 684792 Change-Id: Iac0dc0e12fd9f5a41f344eefcbe002b4a1e84724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278702 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#785868}
-
Steve Kobes authored
Bug: 1007815 Change-Id: I62c3b0bd99b685e7cea30244d88c8196d3646854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284141 Auto-Submit: Steve Kobes <skobes@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#785867}
-
Mugdha Lakhani authored
These are deleted either because they are already covered by tests elsewhere or are no longer useful. See this spreadsheet for more details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ie4548e0a8b3e27704b0342838364b29b1078a5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279790 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#785866}
-
Yuheng Huang authored
mojo js binding: mojo js template interface_definition should generate !Promise instead of Promise for annotation Bug: 1100700 Change-Id: I51a5b0babe4557baa070fde216fdbc2264f021a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276665Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#785865}
-
Miguel Casas authored
The new direct Vaapi VideoDecoder doesn't have tracing, this CL adds the first such meas, for the Decode() call, similar to https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/vaapi/vaapi_video_decode_accelerator.cc;l=446 Bug: 1040291 Change-Id: I25b70cecb48435cd5539cbf927c0f2547d584649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283249 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#785864}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. Also replace QueryInterface(foo.GetAddressOf()) with QueryInterface(IID_PPV_ARGS(&foo)). NOPRESUBMIT=true Bug: 914910 Change-Id: Ib574cb4d93ec9e6b1134d2916058fa792aaec862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271525Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785863}
-
Meera Srinivasan authored
email address is @google.com. Change-Id: I35a217fbec4995125afb42cce4332c507fdbd78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276811 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#785862}
-
Finnur Thorarinsson authored
- Sandbox the iframe and sanitize the input used. - Remove special 'synchronous' testing flag (not needed). - Multi-line quote requirement also no longer needed. - Change default reader list - (replace deprecated Bloglines service with Newsblur). - Deflake and re-enable the RSS extension tests. - Up the version by two (from 2.2.3 to 2.2.5, since 2.2.4 is live already). Bug: 340354, b/137075999 Change-Id: I6eac37fae9e2228aeabe68ccf1fd34b9b36ac6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264059 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#785861}
-
Robert Ma authored
WPT Import https://crrev.com/c/2252278 introduced a bunch of Mac10.10 timeout expectations. It appears the timeouts were caused by one-off bot slowness. Bug: 1096604 Change-Id: Ibcd38cd1e0c6435cf0231962e73e570e70b2d247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283414 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785860}
-
Tibor Goldschwendt authored
Bug: 688960 Change-Id: I8da036e642476b1eff6d0247f5bce3c2113c36e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268957Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#785859}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bf8ca6dc7f2..8c03d5d9bcc5 2020-07-07 sigurds@chromium.org Update heavy ads issue strings 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in networkPanel.css 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in media/playerPropertiesView.css 2020-07-07 aerotwist@chromium.org [CSS Overview] Adds checks for null / undefined 2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in network/networkLogView.css 2020-07-07 jacktfranklin@chromium.org Fix component _bridges generation for TypeScript 4 2020-07-07 petermarshall@chromium.org Revert "Add E2E tests for Breakpoint test cases" 2020-07-07 leese@chromium.org Add helpers for debugging and snippet tests 2020-07-07 jacktfranklin@chromium.org Fix test_helpers on Python 3 2020-07-07 pfaffe@chromium.org [wasm debugging] Add a js_type to evaluator results 2020-07-07 tvanderlippe@chromium.org Remove e2e-test build files from .gitignore 2020-07-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-07-07 tvanderlippe@chromium.org Fix stylelint reports in inline_editor/cssShadowEditor.css 2020-07-07 johanbay@gmail.com Fix stylelint-config-standard issues in color_picker/spectrum.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1083146,chromium:1088463,chromium:1094436,chromium:1095617,chromium:1102704 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id88b50084ed4c7ee17b34047eeb2fcc769afa10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785858}
-
Philip Rogers authored
This reverts commit e1b47a15. Reason for revert: crbug.com/1102888 Original change's description: > Enable RespectMacLCDTextSetting by default in M86 > > Bug: 1079418 > Change-Id: Ib48fbedd92a01f161b954c614f081f91a5ad89f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283246 > Auto-Submit: Philip Rogers <pdr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785697} TBR=creis@chromium.org,pdr@chromium.org,chrishtr@chromium.org Change-Id: Id373e62f49f0b4091d7516e6996eaffb4574a4b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285247Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785857}
-
James Cook authored
The old screenshot was taking on a linux-chromeos build, so it said "Personalize your Chrome device". This is confusing, since it isn't clear if "device" should be part of the translated string. Update screenshot so it shows "Personalize your Chromebook", which is a better example of how it would appear. (The string already contains a DEVICE_TYPE placeholder.) Bug: b/159155720 Change-Id: If041bafcec392cfd0b896b528208865ae9c80500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284965 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#785856}
-
Asanka Herath authored
`IdentifiabilityStudyState` was using a separate instance of `IdentifiabilityStudySettings` to access the externally supplied study parameters. Instead it now uses the global singleton. Why do this? There really should be only one settings object. Having the `IdentifiabilityStudyState` rely on the authoritative instance which is the same one that the renderer and the rest of the reporting infrastructure also relies on. In turn, this means that race conditions involving setting up the global instance are much more visible and are immediately caught by tests. Existing tests exercise the functionality being changed here. R=pauljensen@chromium.org Bug: 1100424 Bug: 973801 Change-Id: I102495c70faa03378a392aecf9ab6b8c36364ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275478 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785855}
-
Lahiru Ginnaliya Gamathige authored
Bug: 1102606 Change-Id: I1f26284306d832fa2fe1ad6578bca6c6eb193843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284005Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@google.com> Cr-Commit-Position: refs/heads/master@{#785854}
-
Fredrik Söderqvist authored
These have not been SVG-specific for quite some time, so keeping them separate from the "basic" (HTML) named colors does not offer any advantage. Bug: 1102816 Change-Id: Ia2fd62e150aa99054cc8110f2e4ede0706a238d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283354 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb40750b..22f9d885 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1278eec37b8d86f460c5440af40e8b5daf45ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785852}
-
Daniel Rubery authored
This CL adds metrics to monitor the performance of the CSD visual model. We measure the amount of time it takes to extract visual features, and how long is spent on the comparison of those features with the model. Bug: 1068613 Change-Id: I294b6cb2b217470c422f82ce388ec448f11e6375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276335 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#785851}
-
Doug Arnett authored
This is an attempt to avoid a race condition crash with the infobar going away while the page translated callback occurs. Bug: 1093320 Change-Id: I47025de0d8c23045e1a964d4cef0c732e903b8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283657Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#785850}
-
Henrique Nakashima authored
It is enough to pass in a WebContents. Bug: 1090048 Change-Id: Ib32c8fb80c58777409e3c7bba415013ce6351ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281306Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#785849}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ba17d8bcf0dc..e8c9fd602f11 2020-07-07 johnkslang@users.noreply.github.com Merge pull request #2326 from ben-clayton/always_pic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Iabe6540a7b0657101dda67261b6d50a1db6df6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284948Reviewed-by:
-
Toni Barzic authored
Notify shelf config observers that the shelf config has changed when tablet mode changes - some shelf dimensions depend on tablet mode state, so shelf may need relayout when tablet mode changes. This is generally done when hiding shelf buttons in tablet mode is enabled, but depending on user settings, that may not be the case. Also, stop observing tablet mode state in ShelfLayoutManager, as it's already observing both ShelfConfig, so now that shelf config is updated when tablet mode changes, it should be enough to observe shelf config only. BUG=None Change-Id: I3c9f84ec9fa4d03bcd2838ea43cd7ae5869f26a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283580Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785847}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. BUG=704136 R=guidou@chromium.org Change-Id: Ib14470ab7e8acbd911e059c12c8ddc0f983b3d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283392 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#785846}
-
ckitagawa authored
Capturing OOPIFs separately allows them to scroll for the purposes of paint previews. However, on pages where iframes may not be out-of-process it would be ideal if we recorded them as separate SkPictures if they are scrollable to allow them to scroll and not become clipped. This is especially important in cases like AMP on mobile where, without strict site-isolation, a same-process iframe is the majority of the content view. However this iframe is clipped and cannot scroll due to how printing works normally. This can be fixed by capturing these iframes using the same mechanism as OOPIFs when capturing a Paint Preview. Bug: 1098300 Change-Id: Ic57c59bd2d358d96334ad892387e7e785f3c9df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194381Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
danakj authored
Put the code there directly into content/shell/browser/web_test. R=avi@chromium.org Bug: 866140 Change-Id: I28024f4fbe56a6086819a15b874130a53bb25425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280387 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785844}
-
sauski authored
To support recording access for non-persistent cookies, the Access Context Audit service and databases are extended to store non- persistent cookies alongside persistent cookies. These records are cleared on startup unless restoring the previous session. Bug: 1101675 Change-Id: I7ee7a47530f8f0d6b05fc8890b94c605f839c2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273057Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#785843}
-
David Tseng authored
R=akihiroota@chromium.org Test: browser_tests --gtest_filter=ChromeVox*.*Unknown Change-Id: I918f738fc0e9fdee1db2bec579e43a8f3a0984e6 Fixed: 934968 AX-Relnotes: when a permission dialog pops up, ChromeVox places focus correctly. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283928 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#785842}
-
Colin Blundell authored
This CL follows up the componentization of infobar_android.* and confirm_infobar.* by putting these classes in the infobars namespace. Bug: 1099169 Change-Id: I6344cd990975f720f60be6eab05f97debb75892a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282806Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#785841}
-
Alexander Cooper authored
Fixed: 1099834 Change-Id: Ib434e634528e1ac56efecb3e8c97201558eafd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278307 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#785840}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I084e2f36ecd874fd893bfd14cbcd0fe133d16602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284632Reviewed-by:
-
Nate Chapin authored
Bug: 1101402 Change-Id: I8b1aee063f1f19c850346912b1d15c69dc70631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278234 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#785838}
-
Henrique Ferreiro authored
Change-Id: I6ee7fac30161ca131765d36d4283e202fad99ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283346Reviewed-by:
-
harrisonsean authored
The custom cell for password check is similar to the one needed for safety check. It is being renamed to settings_check_cell for more general use. The main difference is the whether or not an image is used on the leading side of the cell. This CL adds an optional image to the leading side of the cell for compatibility with both checks. Bug: 1078782 Change-Id: I825bdcb53f624ce2e567a68dc900bddc310dc270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273162 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#785836}
-
Shengfa Lin authored
Once/Repeating Change Bind and Callback to BindRepeating and RepeatingCallback for nacl broker listener and nacl debug exception handler win. Bug: 1007703 Change-Id: I1f9aac13d3478d2a121faedb47476d6455a427f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278855Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#785835}
-
Daniele Castagna authored
This patch renames/removes the GL reference since the flag is now used by SkiaRenderer too. Change-Id: I0ca3dd171b379af6a926e5622b9f9230f09f8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276807Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
dpapad authored
The change at r782918, which modified RunNode() to use shell=False, broke this script, and started returning incorrect output (JS comments were not stripped) Bug: 1096473 Change-Id: I9d767d0ec2d92612ddf73c37e8ab70c4aedc6573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284015 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#785833}
-
Mitsuru Oshima authored
so that CL like this (crrev.com/c/2214761) can use it. Bug: None Change-Id: I685819c89b87603a542324431ba0a6d9a80eb1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283504 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785832}
-
Shengfa Lin authored
Once/Repeating Modified coded_frame_provider and its subclass buffering_frame_provider and demuxer_stream_adapter to use OnceClosure and BindOnce. Modified mock_frame_consumer/provider to use OnceClosure and BindOnce. Bug: 1007649 Change-Id: I9f464c65065c8676be8ee793a9ba6d099eff9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278583Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#785831}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I802b82616789443420957e28d87a64bfdb1c93c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283738Reviewed-by:
-
Meredith Lane authored
https://crrev.com/c/2203775 introduced storing of theme and font family selections in a user preference. On page load, this was not taken into account with the radio buttons for the theme selector or the select drop down for the font family. This change ensures these UI elements are updated correctly on page load to display the currently active theme and font family to avoid confusion for users. This patch also introduces some front end testing for the settings dialog. Bug: 1016615, 1070724 Change-Id: I2e45334d012b6d88e813c4bfd4f395adfa309413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208871 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785829}
-
