- 30 Jun, 2020 40 commits
-
-
Yue Ru Sun authored
Change-Id: Ia282a1b720ec4cb5d6e376692b34dbd4c2aef891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274108Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#784176}
-
John Z Wu authored
This will be shared between ios/chrome and ios/web_view. Also deleted extra space in the string. Bug: 1097353 Change-Id: I3bef90ec663d1b092c6dd79e8b9131f4d97688a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259513 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784175}
-
inglorion authored
crrev.com/c/2271896 changed the ninja files that are generated by goma_link to build .o.stamp files for native object files, instead of .o files directly. The present change adds phony rules with the .o name, so that you can use ninja foo.o to build foo.o, instead of having to write ninja foo.o.stamp. Bug: 1072888 Change-Id: I14d5f33a1b1ccc6677e58fb6efa4c8a02981e9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274864 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#784174}
-
Avi Drissman authored
One last name that needs to be changed. I missed this one. Bug: 1100727 Change-Id: I1bd327b355cf4d040438e0b1a4baf11fc8914061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276655 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784173}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c858d7bd811e..d5b5215a888d 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2300 from KhronosGroup/generalize-precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC ianelliott@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: ianelliott@google.com,radial-bots+chrome-roll@google.com Change-Id: I0ae0f172ff8bc86cbc8e8026c290944ed8ac9610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784172}
-
Solomon Kinard authored
There are other identical typos. However, those can remain for other on-boarding. Bug: None Change-Id: Ie04e83346de7906af5c4ab5ce2b95ac56ce99ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276499Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#784171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9056401df001..d014422b2085 2020-06-30 yiwzhang@google.com Roll bb tool from @616b3dd to @165c851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093824 Tbr: agable@chromium.org Change-Id: I37ebc191790d46f08d3f4b013099b2b9c3ee785b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276545Reviewed-by:
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Idaa3876955681cf5ef5c5a83f970d0a23c1648a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276803 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#784169}
-
Becca Hughes authored
BUG=1099250 Change-Id: Ia73ff41012a1e4d9a7a524339ea30e0c327f1fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269510 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784168}
-
Istiaque Ahmed authored
This CL tidies up extension creation to improve readability in those tests. chrome_settings_override is available in all channels in OSX, this CL stops overriding channel in unit_tests related to this. Bug: None Change-Id: Ief5291e9121eeefaf0a4d425db632f51a62d9227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271884 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Francois Doray authored
On Youtube, some videos end with a few seconds of silence to recommend other content (e.g. www.youtube.com/watch?v=yUBPLtSUNCw&list=UU-V8lFk4Pk5i_DErHS_UNVQ). Also, after and ad plays, there is a countdown to let the user click on a button (e.g. https://drive.google.com/file/d/1zCeLJZW9ghdI0l8W0MIvBGVThXrk_6m_/view?usp=sharing). During this silence, the existing 5 seconds "recent audio delay" can expire and throttling starts, delaying the load of the next video. This is worse with intensive wake up throttling. This CL increases the recent audio delay to 30 seconds. This will ensure that sites can operate correctly if there is more than 5 seconds of silence between playing different audio/video clips. Since most pages don't play audio in background, this shouldn't affect performance significantly. Bug: 1075553 Change-Id: I0c12b3703c1436bbb7aad8507da950d8ab8d604f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275488 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784166}
-
Varun Varada authored
This commit adds the Oxford English Dictionary variant of the British English (en-GB) locale to allow for strict spellchecking when using the corresponding locale (en-GB-oxendict) as distinguished from the generic British English (en-GB) locale. Bug: chromium:1064659 Change-Id: Ia625a3566b7d89475c4853562ebbdb3afe7f9ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140610 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784165}
-
Etienne Bergeron authored
This CL is fixing the CFI detection that causes chromium bots failure. It caused that Angle roll back: https://chromium-review.googlesource.com/c/chromium/src/+/2273440 DevTools listening on ws://127.0.0.1:34485/devtools/browser/6b3d139b-d597-448f-bc99-b1a8ccf0ef57 [6573:6573:0630/045819.756406:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process. ../../ui/gl/angle_platform_impl.cc:134:13: runtime error: control flow integrity check for type 'void (void *)' failed during indirect function call (/b/s/w/ir/out/Release/libGLESv2.so+0x70e468): note: (unknown) defined here ../../ui/gl/angle_platform_impl.cc:134:13: note: check failed in /b/s/w/ir/out/Release/content_shell, destination function located in /b/s/w/ir/out/Release/libGLESv2.so #0 0x55a9dd09723f in angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0::operator()(void (*)(void*), void*) const ./../../ui/gl/angle_platform_impl.cc:134:13 #1 0x55a9dd0971a4 in void base::internal::FunctorTraits<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void>::Invoke<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, void (*&&)(void*), void*&&) ./../../base/bind_internal.h:379:12 #2 0x55a9dd097124 in void base::internal::InvokeHelper<false, void>::MakeItSo<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, void (*&&)(void*), void*&&) ./../../base/bind_internal.h:637:12 #3 0x55a9dd0970e4 in void base::internal::Invoker<base::internal::BindState<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, void (*)(void*), void*>, void ()>::RunImpl<angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0, std::__1::tuple<void (*)(void*), void*>, 0ul, 1ul>(angle::(anonymous namespace)::ANGLEPlatformImpl_postWorkerTask(angle::PlatformMethods*, void (*)(void*), void*)::$_0&&, std::__1::tuple<void (*)(void*), void*>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/bind_internal.h:710:12 #4 0x55a9dd097094 in _ZN4base8internal7InvokerINS0_9BindStateIZN5angle12_GLOBAL__N_132ANGLEPlatformImpl_postWorkerTaskEPNS3_15PlatformMethodsEPFvPvES7_E3$_0JS9_S7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE$e9746124236f50940159c137b2ecb700.cfi ./../../base/bind_internal.h:679:12 #5 0x55a9d7baab74 in base::OnceCallback<void ()>::Run() && ./../../base/callback.h:99:12 #6 0x55a9dbc25481 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33 #7 0x55a9dbc63df6 in base::internal::TaskTracker::RunSkipOnShutdown(base::internal::Task*) ./../../base/task/thread_pool/task_tracker.cc:768:19 #8 0x55a9dbc63353 in base::internal::TaskTracker::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&) ./../../base/task/thread_pool/task_tracker.cc:632:5 #9 0x55a9dbcc2c27 in base::internal::TaskTrackerPosix::RunTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&) ./../../base/task/thread_pool/task_tracker_posix.cc:22:16 #10 0x55a9dbc6298e in base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource) ./../../base/task/thread_pool/task_tracker.cc:505:5 #11 0x55a9dbc82f5a in base::internal::WorkerThread::RunWorker() ./../../base/task/thread_pool/worker_thread.cc:348:34 #12 0x55a9dbc82c0c in base::internal::WorkerThread::RunPooledWorker() ./../../base/task/thread_pool/worker_thread.cc:223:3 #13 0x55a9dbcc3749 in _ZN4base12_GLOBAL__N_110ThreadFuncEPv$02080084496f8c17dc927fff280e5fe6.cfi ./../../base/threading/platform_thread_posix.cc:81:13 #14 0x7f331ced16b9 in start_thread /build/glibc-LK5gWL/glibc-2.23/nptl/pthread_create.c:333:0 #15 0x7f33159d141c in clone /build/glibc-LK5gWL/glibc-2.23/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:109:0 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../ui/gl/angle_platform_impl.cc:134:13 Bug: 1091259 Change-Id: Ie6d4cf36ddc40fff2864ce27ba130b9bec069ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276245Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784164}
-
Xiaohan Wang authored
Update the example to match the new recommended style (use backticks). Change-Id: I635c1dc0fabf1581f04f11c4ac9a98fda6edebdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277079 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784163}
-
Haiyang Pan authored
Bug: 1098927 Change-Id: I1502ff5cea7f38686793695596397beaf3fc92f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274959 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784162}
-
Oksana Zhuravlova authored
This change exposes a Java method on WebContentsObserverProxy that allows it to observe render frame creation. Follow-up CLs will inject objects in the RenderFrameCreated handler as part of the mojofied Java Bridge browser integration. Bug: 794320 Change-Id: Ied51a88887e9d53744f253ce7d817d126557b608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274328Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#784161}
-
Aaron Leventhal authored
HandleLayoutComplete(LayoutObject*) is no longer used, but HandleLayoutComplete(Document*) is still important. AX-Relnotes: n/a Bug: None Change-Id: I64a3340a1a7def1491c913fe50b2b15a7b1b90ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276247 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784160}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1fd5ad0e949dd0488d4032e67eacf290c313b21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274838Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34eb401ba547..68e60a92ae92 2020-06-30 timvp@google.com Vulkan: Don't store transformed SPIR-V 2020-06-30 jmadill@chromium.org Tests: Add scripts/common.py to standalone data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Test: Test: CQ Change-Id: I61408bdd41c080bb8f1f43e870cade6acfe946ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276539Reviewed-by:
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: I8b0d4044403df50de63471aa38872f46f2225053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271014Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784157}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35c950b7e18e..4f894cfb70fd 2020-06-30 bsheedy@chromium.org Reland "[Telemetry] Fix CrOS remote screenshots" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098450,chromium:1098485 Tbr: wenbinzhang@google.com Change-Id: I54920c990d3346fe37ed4d5682024eef10e52bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276544Reviewed-by:
-
Xiaocheng Hu authored
This patch extends the expiry of the metrics since the finch experiment is still ongoing. Bug: 1084045,1092507 Change-Id: I762fb17c7df633bd15a77bc7b9f9498d64cd3a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270669Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I4dad0fc3aee9d09734b684d9d48f0210dfb024cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274490Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784154}
-
Livvie Lin authored
The methods that record to UKM and populate interstitial strings will also be used by iOS lookalike interstitials. Bug: 1058898 Change-Id: I8ecf1eff284181c27eb24942e4b92b726ba51d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269553Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784153}
-
Sam Sebree authored
This CL changes the default background color for pages with the <meta name="color-scheme" content="light dark"> tag. Bug: 1094649 Change-Id: I80afe70345a99daa4de47a54c704e46c267ebec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271520 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#784152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e50e757e3e5..6685f320c0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC parastoog@google.com,davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: parastoog@google.com,davidbienvenu@google.com Change-Id: I3a6cbcc175fe6f84dbab82bdfd32326a99ab2e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276546Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784151}
-
Nick Burris authored
The PaymentAppProviderImpl's web contents is not always closed via PaymentAppProviderImpl::CloseOpenedWindow, e.g. when the bottom sheet UI is closed the web contents is destroyed. If the PaymentAppProviderImpl instance then reopens a web contents, we hit the DCHECK in SetOpenedWindow. This patch properly resets the payment_handler_window_ pointer even if the web contents is already closed. Ideally the bottom sheet UI code should close the web contents via CloseOpenedWindow(), but we don't currently have any other logic in here so the issue is minimal. This temporary fix is worthwhile as we often hit this in manual testing. Bug: 1099270 Change-Id: I377406f385f2250073dacd6b750a948019cea3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269792Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#784150}
-
Shengfa Lin authored
Changed usage of Bind to BindOnce and Callback to OnceCallback where applicable Disable base::Bind/base::Callback for //chromecst/net Bug: 1007651 Change-Id: I08e009fd49effc8e4ef32463cdfa448dea50486b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274092Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#784149}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I0349ddcf227357da19936e5c6c5908b9229aaf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276230 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784148}
-
Etienne Pierre-doray authored
To re-use the same logic in ThreadProfiler and TracingSamplerProfiler. Bug: 1098119 Change-Id: I3ae23af070e8a9798a2cc771c8fc347bb4fc3570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269741 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#784147}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/608e0dbc1073..c9336155e045 2020-06-30 sque@google.com infra: Do not start/stop Goma for gcc builders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093641 Tbr: jophba@chromium.org Change-Id: Id2bfa95708e7966bb1988cc07f25d1337a0cc64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276541Reviewed-by:
-
Yue Ru Sun authored
This patch fixes the crash on debugging build when visiting chrome://ukm due to CheckFeatureIdentity(UkmSamplingRate) failure. COMPONENT_EXPORT makes the definition of the base::Feature UkmSamplingRate from ukm_recorder_impl.cc exported and shared by the libraries that reference it, ensuring there's only one copy of the base::Feature in memory. Bug-id: b/160004246 Change-Id: Icda0e0a403538a263f8132afc19dd0cb455395db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274240 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
We let all of the ImageAnnotationService.* histograms expire because we weren't using them post-launch, but two of these would be useful for an M85 launch because we expect it to affect the average number of queries sent by each user. Bug: 1091538 Change-Id: Ic03beccaff7b8c41d36c4db0c4f6f598f12eebb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271013 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I5f728078d3bf620b1f1707cabab912b9bff2d3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276405Reviewed-by:
-
Philip Rogers authored
This patch cleans up flakiness caused by video-overlay-scroll.html which had a fullscreenchange event handler that fired twice, but was only intended to fire once in the test. The test used waitForEventAndEnd which continued calling the event handler after the test ended. This patch updates this function to waitForEventOnceAndEnd which makes it clear that the event handler will be removed after firing once. The root-cause of this flakiness is being fixed in https://crrev.com/c/2275348 and this patch is just followup cleanup. Bug: 1048597 Change-Id: I4b7473879085e5a7f91875f4daa53a2891c9274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275350Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784142}
-
Leonid Baraz authored
Change-Id: I343e0cc357dc0f1d6d7e179af6183ed0e3a2d001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276229Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#784141}
-
Dominique Fauteux-Chapleau authored
This is a new field in that policy that allows a minimum size to avoid scanning small strings. This also adds a UMA metric to track data entry sizes. Bug: 1093348 Change-Id: I3f390563560c9e3ced1ecfe91ed95a74edb725f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268378Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784140}
-
Morten Stenshorne authored
Need to check if page breaks are applicable before applying them. Bug: 1100308, 1053768 Change-Id: I987bf4ce42f7d0f5128cb01c30824214d9c12ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276432Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#784139}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/769129fb29fc..de4aedaec33c $ git log 769129fb2..de4aedaec --date=short --no-merges --format='%ad %ae %s' 2020-06-26 marpan vp9-svc: Fix to setting frame size for dynamic resize 2020-06-23 marpan vp9-svc: Allow scale_references for single layer svc 2020-06-18 jzern tools/lint-hunks.py: skip third_party files 2020-06-17 jzern update googletest to v1.10.0 2020-06-18 jzern vp9_skip_loopfilter_test: make Init() return a bool Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: Ib7048b0c6d3445637799d1a73868d1d41f2cc880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276343Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#784138}
-
Ryan Daum authored
Follow-up after fixing the JNI classname; unfortunately previous CL was mistakenly thought to fix the issue but the bug remained. This CL fixes: * Classname signature (missing $) * Method signature (extraneous ';') * Calling method (Should be CallVoidMethod) Tested on physical Android things device. Bug: internal b/159235968 Test: manual on device Change-Id: I5907ab842740e697e80d757a2f96485ba63c7f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276242Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#784137}
-
