- 13 Jun, 2018 40 commits
-
-
Koji Ishii authored
This patch forces legacy fallback for -webkit-box and -webkit-inline-box. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I15c35df5e71c03a2df6b466e2ba2197f48d5e588 Reviewed-on: https://chromium-review.googlesource.com/1089591 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#566742}
-
Keishi Hattori authored
Add new IncrementalV8FollowupGC. It is a incremental marking enabled version of PreciseGC. Bug: 757440 Change-Id: I1b480eac30936a8ad9b56a88b2191b0d417a61e7 Reviewed-on: https://chromium-review.googlesource.com/1096798 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#566741}
-
Darren Shen authored
There are some keyboard settings that enable the virtual keyboard (e.g. SetTouchKeyboardEnabled, SetAccessibilityKeyboardEnabled). When changing these settings, the code must also Enable/Disable KeyboardController. This is done every time in the real code so that we maintain an invariant that KeyboardController is enabled iff one of those settings is on. In KeyboardControllerUnittest however, we Enable KeyboardController in SetUp, but we don't update the corresponding settings there. Instead we instantiate some helper classes that turns on those settings in each test case. This is weird, as we'll always need to instantiate that class to maintain the invariant, so we might as well do it in SetUp. We get rid of the scoped helper classes and just turn on the setting in SetUp. Bug: 849995 Change-Id: I7d7b1bd751cb8894ff2d7a2554b6ae1f8db77bf9 Reviewed-on: https://chromium-review.googlesource.com/1098647Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#566740}
-
Wez authored
Update RTCPeerConnectionHandler to check explicitly that the configured |task_runner_| is the sequence that is is invoked on, rather than using a separate ThreadChecker. Bug: 851378 Change-Id: Ib0e4a7f12e12c1e3b92a435244808d177f86cbf2 Reviewed-on: https://chromium-review.googlesource.com/1096277Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#566739}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11376cfc6fe9..c27a6612dbae git log 11376cfc6fe9..c27a6612dbae --date=short --no-merges --format='%ad %ae %s' 2018-06-13 ahassani@chromium.org paygen: Remove au-generator.zip Created with: gclient setdep -r src/third_party/chromite@c27a6612dbae The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I5cd621b2dcccf248570fdd215ec497a277003059 Reviewed-on: https://chromium-review.googlesource.com/1098238Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566738}
-
Hajime Hoshi authored
Now we're trying not to depend on event's target when dispatch an event asyncly in EventQueueImpl since event target is set also when actual dispatching, and setting the target before dispatching should be redundant. In the current situation, there is no consistent rule whether event target is set before dispatching or not. However, there is no other way to inform what is the target for the given event at EventQueueImpl::EnqueueEvent. In the usecase of EventQueue in ContentSecurityPolicy, there is no need to cancel events actively. Then, just posting tasks for events and dispatching them or canceling them when execution context is not present are enough. Instead of EventQueueImpl, this CL introduces EventTarget:: EnqueueAsyncEvent. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I33e67390762cba233ce31634238d4fd477b8d8da Reviewed-on: https://chromium-review.googlesource.com/1090591 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
edchin authored
This CL refactors duplicate logic into a helper method. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I83dcd77667a25821d8bac524be16647517bb83c4 Reviewed-on: https://chromium-review.googlesource.com/1094476 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566736}
-
Hajime Hoshi authored
This CL is a pure refactoring. There is no usage of IPCTaskRunner from non-main threads. Change-Id: I74063e7f8cdd4562262eebfea4f9d12d594bae8d Reviewed-on: https://chromium-review.googlesource.com/1096934Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566735}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9614a313b836..241d0c16c0d3 git log 9614a313b836..241d0c16c0d3 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 qingsi@google.com Remove ContinualGatheringPolicy::GATHER_CONTINUALLY_AND_RECOVER. 2018-06-13 shampson@webrtc.org Updated PeerConnection integration test to fix race condition. 2018-06-13 buildbot@webrtc.org Roll chromium_revision ef538e31..9df92afb (566490:566630) 2018-06-12 qingsi@google.com Refactor the regathering of candidates in P2PTransportChannel. 2018-06-12 zhihuang@webrtc.org Add a flag to actively reset the SRTP parameters 2018-06-12 danilchap@webrtc.org Reland "Use absl::optional instead or rtc::Optional" 2018-06-12 buildbot@webrtc.org Roll chromium_revision ffaf1e2b..ef538e31 (565764:566490) 2018-06-12 orphis@webrtc.org Add HeaderExtensions to RtpParameters 2018-06-12 alexnarest@webrtc.org Enable send side audio TWCC only if WebRTC-Audio-ForceNoTWCC is not enabled. 2018-06-12 mbonadei@webrtc.org Explicitly setting use_lld=false on MSVC bots. 2018-06-12 peterhanspers@webrtc.org Metal renderer does not handle i420 frames correctly. 2018-06-12 andersc@webrtc.org Make rtc_software_fallback_wrappers target visible. 2018-06-12 phensman@webrtc.org Release ADM after passing it to PCF in AppRTC 2018-06-12 kwiberg@webrtc.org LogMessage::UpdateMinLogSeverity: Don't ignore all but the last stream 2018-06-12 philipel@webrtc.org Don't update internal state of the FrameBuffer2 when an undecodable frame is inserted. 2018-06-12 jonasolsson@webrtc.org Remove stringstreams from p2p/ 2018-06-12 jonasolsson@webrtc.org remove unused UNSHIPPED trace macros 2018-06-12 sakal@webrtc.org Delay the creation of the platform thread in TestAudioDeviceModule. Created with: gclient setdep -r src/third_party/webrtc@241d0c16c0d3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:835958,chromium:None,chromium:None,chromium:844313,chromium:b/79961243 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b4bcb1330e3b4206e7a0d20aa3bb776e04949b2 Reviewed-on: https://chromium-review.googlesource.com/1098237Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566734}
-
edchin authored
A crash will occur when an scrolled offscreen cell is updated. This is because UICollectionView's |-cellForItemAtIndexPath:| returns nil if the cell is offscreen. This CL adds a unittest that fails without the fix, which is also in this CL. The fix is to skip cell configuration if the cell is nil. Bug: 851352 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccdb53e3a67b58f225a09ce32ac70f48d42431ef Reviewed-on: https://chromium-review.googlesource.com/1094210Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Joel Hockey authored
* Add Quick View test for downloads and crostini. * Update waitForElement to support searching elements within nested shadow roots. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b8f2ebd29eddfb3aa453aa5db0cd75aadec0650 Reviewed-on: https://chromium-review.googlesource.com/1090517 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566732}
-
Matt Falkenhagen authored
The linked bug is marked Fixed, and ServiceWorkerContainer is not exposed to workers. Bug: 413518 Change-Id: I435044364801a9cc02307f929d36a7fcbc87d9a8 Reviewed-on: https://chromium-review.googlesource.com/1098430 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566731}
-
Adam Rice authored
The M68 branch has a non-working implementation of the enable-websocket-auth-connection-reuse flag. In order to avoid the confusion of having a flag that works in some versions and not in others, temporarily remove the flag from about:flags. Once the flag has been disabled in the M68 branch it will be re-enabled for M69 by reverting this CL. BUG=423609 Change-Id: Id17ac18e13effcfd5bd946dc1fe0f1c70df96539 Reviewed-on: https://chromium-review.googlesource.com/1090700 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#566730}
-
Yoichi Osato authored
This patch converts the test to reftest since that test just confirms repaint after load. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: Iffc00614c617a64c5f185029014f1d43734fbbca Reviewed-on: https://chromium-review.googlesource.com/1092610 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566729}
-
Stuart Langley authored
Some cleanup work for components/drive/ briging it in line with recomended practices/c++ modernization. - clang tidy modernize-make-unique. - Fix up headers. This CL introduces NO logic changes. Bug: 841659 Change-Id: I9b8e1dfbacee96c4411abd304c8faf0feb24e118 Reviewed-on: https://chromium-review.googlesource.com/1093334 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566728}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e73d7d84d770..efd99cc92817 git log e73d7d84d770..efd99cc92817 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 caryclark@skia.org clean up SkPicture include Created with: gclient setdep -r src/third_party/skia@efd99cc92817 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I56c3ce7048b7b9456042030d73150345856f65db Reviewed-on: https://chromium-review.googlesource.com/1098236Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566727}
-
Matt Falkenhagen authored
The function had a public helper function that didn't add much value. We were duplicating checks like !provider_ and the flow of data was more complicated. It's hard to read the diff so the changes are: * Removed RegisterServiceWorkerImpl. * Removed duplicate if (!provider_) check. * Removed |raw_script_url|, it's unneeded indirection. * Unified the preparation of |script_url|, |pattern_url|, and |update_via_cache| to just before they are used. Change-Id: Icef9dd5b26f4009fbf69d62ad918066be2c0733c Reviewed-on: https://chromium-review.googlesource.com/1098425 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
Design doc: http://go/cros-qs-restyling TEST=ash_unittests,browser_tests BUG=842079 Change-Id: Ia9eaac6e494fc8ec1b35aaedd9ebf9814890ec57 Reviewed-on: https://chromium-review.googlesource.com/1088458 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566725}
-
Sadrul Habib Chowdhury authored
The presentation-time from gpu gives a more correct view of what the user experiences, rather than the swap-time in the renderer process. So switch to using the presentation-time to measure the various paint-time metrics. The various paint-time metrics in telemetry tests (loading benchmark) will go up after this change, but it is expected, and it is not a regression. Results on various platforms with this change: Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000 Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000 Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000 Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000 Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000 BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I70a86eb85e84670942fe3fe6341926b5bc6255b9 Reviewed-on: https://chromium-review.googlesource.com/1050693 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#566724}
-
Sunny authored
According to xhr spec[1], no CRLF normalize operation need to be performed when invoking FormData methods, so all normalization call is removed in this commit. But in form sepc[2], when appending data from form controls to FormData, both name and value should be normalized. New methods |FormData::AppendFromElement| will perform the normalize operation. [1] https://xhr.spec.whatwg.org/#dom-formdata-append [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#append-an-entry BUG=798030 Change-Id: If90a8e500705013c2935e5290624d4414dd32a72 Reviewed-on: https://chromium-review.googlesource.com/1091238Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#566723}
-
Hiroki Nakagawa authored
This CL mechanically renames SettingsObject to FetchClientSettingsObjectSnapshot, and revises the class level comments of the class. This change is a part of the Modulator cleanup project. See the design doc for details: https://docs.google.com/document/d/1R0VgKZtrBL9hAq8SgCVuDOv-2vzB15M9HDwzdad0J6k/edit#heading=h.5rwrtojwiu5c Bug: 845285 Change-Id: I0359d650e97a5972b2cdc5a39c223b50f2e42afc TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1090592 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#566722}
-
Ben Chan authored
CL:857742 and CL:857743 added the support for APN authentication method specified in the mobile operator database in shill. CL:1081764 updated shill to respect the authentication method in the user-specified APN property. This CL adds the ONC translation of the APN authentication property, so that a follow-up CL can update the settings UI to allow specifying the APN authentication for the user-specified APN. BUG=b:68680371 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e110a3a4841f8ec2ee725cdc799999b51a45746 Reviewed-on: https://chromium-review.googlesource.com/1096430 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by:
-
Patti authored
Site settings's All Sites back end was updated in r562730 to group sites by their eTLD+1. This patch updates the front end to match. Clicking on an eTLD+1 group will expand the list to show all relevant origins under it, and clicking one of those origins retains the previous behavior where it will navigate to Site Details. Similarly sites that have no eTLD+1 group will retain existing behavior. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I075a1befd49211d0a3b29820ea3aa71887f9dd0e Reviewed-on: https://chromium-review.googlesource.com/1088274 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#566720}
-
Joel Hockey authored
This makes them available in the save-as dialog. Bug: 845088 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37dbb73a8de6a115e70a3bc8549b0e4351086bb6 Reviewed-on: https://chromium-review.googlesource.com/1098421Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566719}
-
Tetsui Ohkubo authored
It fixes FirstRunUIBrowserTest when UnifiedSystemTray is enabled. The test is regressed by interactive_ui_tests fix https://crrev.com/c/1096718. We only have to set initial focus when system tray bubble is activated. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. TEST=FirstRunUIBrowserTest.EscapeCancelsTutorial BUG=847104 Change-Id: Iccb8ea92724fffc787a649e1a4fdac36507f3b71 Reviewed-on: https://chromium-review.googlesource.com/1098419 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566718}
-
tzik authored
MSVC's STL has aggressive [[nodiscard]] attribute, that traps subtle bugs. That is enabled by default in C++17, and can be opted in C++14. Change-Id: Ie30bad0ae0ebd81d15f2f50cbdf66c85050b5033 Reviewed-on: https://chromium-review.googlesource.com/1097044 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#566717}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fdacd1639e2a..459c4d0417df git log fdacd1639e2a..459c4d0417df --date=short --no-merges --format='%ad %ae %s' 2018-06-12 benjhayden@chromium.org Add an index for GetAlertsAroundRevision for non-internal users. 2018-06-12 achuith@chromium.org oobe: Also support gaiastaging. 2018-06-12 nednguyen@google.com Revert "[Sheriff] Disable telemetry.internal.browser.browser_unittest.BrowserTest.testForegroundTab" 2018-06-12 nednguyen@google.com Revert "Disable BrowserTest.testActivateTab on Mac" 2018-06-12 perezju@chromium.org [Telemetry] Remove measurement property from TimelineBasedPageTest Created with: gclient setdep -r src/third_party/catapult@459c4d0417df The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851463,chromium:851463,chromium:851948 TBR=sullivan@chromium.org Change-Id: Ib82446d7c3fe1aa9f915886dfdee5059fecd4bf1 Reviewed-on: https://chromium-review.googlesource.com/1097817Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566716}
-
Sebastien Marchand authored
Without this the observers who only care about the Loaded <=> Loading transitions don't know if a transition to Loading is coming from a Loaded state or not (some logic could be added in the observer directly but this seems cleaner). Change-Id: I077314c2afc800f14dfddd3b65fa4530feacb559 Reviewed-on: https://chromium-review.googlesource.com/1096306Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#566715}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51360dbda4aa..11376cfc6fe9 git log 51360dbda4aa..11376cfc6fe9 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 dgarrett@google.com chromeos_config: Mark assorted standalone builders important. 2018-06-12 dgarrett@google.com chromeos_config: Create a master-full builder. Created with: gclient setdep -r src/third_party/chromite@11376cfc6fe9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: Icad4a216ddef676124ce5ef2227e94d120c41c79 Reviewed-on: https://chromium-review.googlesource.com/1098435Reviewed-by:
-
Kent Tamura authored
Change-Id: Ibc19664d191f8bee18711170e5feeedc26fa0362 Reviewed-on: https://chromium-review.googlesource.com/1094820 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#566713}
-
Ben Pastene authored
Bug: 851996 Change-Id: Id1b01007c65fe417dc9f3beac1aac158e5c97bd0 Reviewed-on: https://chromium-review.googlesource.com/1097701Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566712}
-
Kyle Milka authored
When the browser is resized to be very, very narrow the picker should resize to one column. At this point the option dialog will also need to be resized and the text may now overflow. Bug: 850338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06d08f15b631f9810ead7e01180aacf2a4a66c18 Reviewed-on: https://chromium-review.googlesource.com/1097461Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#566711}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47fd204aa6c0..e73d7d84d770 git log 47fd204aa6c0..e73d7d84d770 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e73d7d84d770 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Id6ca5e7b17c5db0f8d9f0b094357929da73b63be Reviewed-on: https://chromium-review.googlesource.com/1098495Reviewed-by:
-
Matt Falkenhagen authored
Change-Id: I2437f4bae9bfd7384d42a586fd7ee6cfba54210d Reviewed-on: https://chromium-review.googlesource.com/1098418Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#566709}
-
cathiechen authored
LayoutNGMarker has pre white-space. If its parent changes color and PropagateStyle() without carry marker's white-space, this will cause extra layout passes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I388f1811baf45f31f1ce168b9c7b68d51c2dd1d2 Reviewed-on: https://chromium-review.googlesource.com/1096590Reviewed-by:
-
Yutaka Hirano authored
//services/network/public/mojom:websocket is split from //services/network/public/mojom:mojom due to an issue related with lazy serialization[1]. network_param.mojom is in the websocket_mojom target because websocket.mojom depends on the file, but network_ipc_param_traits.(cc|h), some of its typemap files, depend on services/network/public/cpp, and that results in a circular build dependency. This CL fixes that by splitting network_ipc_param_traits.(cc|h). 1: https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/UoDBRD3GhVE/nizRiiOEBgAJ Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I31ee8c8e56f4e5b7087fc991b4b0059a8a5e9beb Bug: 850869 Reviewed-on: https://chromium-review.googlesource.com/1094911Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#566707}
-
Oksana Zhuravlova authored
This changes prepares DeviceSensorEventPump and its subclasses for the move to blink by removing the inheritance of DeviceSensorEventPump from PlatformEventObserver and moving listener-related logic to DeviceSensorEventPump. Since Device*EventPump instances can no longer be stored in RendererBlinkPlatformImpl::platform_event_observers_, separate variables have been added temporarily that will be moved to appropriate Device*Dispatcher classes along with the logic when Device*EventPump classes are moved to blink. Bug: 850997 Change-Id: Iedf23e368adb9180091d094146306330987bcf9c Reviewed-on: https://chromium-review.googlesource.com/1091275 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566706}
-
sczs@chromium.org authored
When a new Folder is created, the folder cell is created on edit mode. If we try to delete the cell at this point (by swiping the cell to the left) a crash occurs (both on legacy and UIRefresh). This Cl prevent this crash by returning NO on canEditRowAtIndexPath for the editingFolderCell. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaca9d4d7001d89d795d2ce2c82db46a092086ec9 Reviewed-on: https://chromium-review.googlesource.com/1098230 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566705}
-
Bence Béky authored
Use CompletionOnceCallback in most places in //net/dns, except for dns_transaction.cc. Bug: 807724 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie2a8ad3ed9e5285761d7321ec337e888b55b9dd9 Reviewed-on: https://chromium-review.googlesource.com/1091596Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
The number of decoded frames should be equal to the number of frames of input video, if no Reset() is invoked before Flush(). Should check this condition in VDA unittest. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2eda613522b9a1e6259a9d72c4f86b616bc90996 Reviewed-on: https://chromium-review.googlesource.com/1063910 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#566703}
-
