- 26 Feb, 2019 40 commits
-
-
Katie D authored
Bug: 928592 Change-Id: I1506a77038113ae2b8c641575155d96d1621c06c Reviewed-on: https://chromium-review.googlesource.com/c/1488177 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#635715}
-
Ryan Sturm authored
This CL adds a handler for virtual URL re-write whenever the HTTPS Previews is on and data saver is on. This will act on the committed URL when it matches the lite page server URL. This CL also adds UMA for server response and when a host is blacklisted. Bug: 921757,929969 Change-Id: I458f9bfb9b9c292a3f3a96065a7c6a9073ec2c23 Reviewed-on: https://chromium-review.googlesource.com/c/1488015 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#635714}
-
Tarun Bansal authored
Approval doc here: http://shortn/_FVcQvJsxmu Change-Id: I1b79f2be75a7fceef5c596ceda8372c62ac9e4ec Bug: 893923 Reviewed-on: https://chromium-review.googlesource.com/c/1484739Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#635713}
-
Jordan Demeulenaere authored
Bug: 933070 Change-Id: Ie1d0bd119a7a301b044ef5c28f63a9de9e77593e Reviewed-on: https://chromium-review.googlesource.com/c/1475458 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635712}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cf48d6c7. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 32a115f8 "[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ica7006f7f28689005185087998c91e831fea7e93 Reviewed-on: https://chromium-review.googlesource.com/c/1488616Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635711}
-
Brandon Wylie authored
Change-Id: Id52bceaaa9ac8635192b7cb0cd7714aeff821615 Reviewed-on: https://chromium-review.googlesource.com/c/1487172Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635710}
-
Sammie Quon authored
Replaces null window targeter, I think its a better solution. Test: manual Bug: none Change-Id: I65b92e7fc259950802837517692c7898ed1628fd Reviewed-on: https://chromium-review.googlesource.com/c/1489477Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#635709}
-
John Abd-El-Malek authored
Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled. Bug: 933880 Change-Id: I3fbc8b037126ddefe75fa1400e89486cc22d214c Reviewed-on: https://chromium-review.googlesource.com/c/1488834 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#635708}
-
Josh Karlin authored
What: For each cache request, measures if the request has a top-frame-origin which is used for double-keying. Why: This gives us a sense of coverage for requests. It also tells us the fraction of requests that we'll wind up having to bypass the cache for (those that aren't double-keyed). Bug: 936048 Change-Id: I962f9dc03a31fe4e9c808e38065efb8dfe2abf69 Reviewed-on: https://chromium-review.googlesource.com/c/1489417Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635707}
-
Aga Wronska authored
Create an instance of ParentAccessService in ScreenTimeController. Unblock lock screen upon successful validation of access code. Bug: 911326 Change-Id: If304be20ad59fe1e9a108faa1f1c84e179a97c91 Reviewed-on: https://chromium-review.googlesource.com/c/1474544 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#635706}
-
Christopher Cameron authored
It has been observed that we are hitting the CHECK(parent_ns_view) in WebContentsNSViewBridge::SetParentNSView. Partially revert r625255, the culprit patch, by moving the functionality of WebContentsNSViewBridge::SetParentNSView in to the caller, NativeViewHostMac::AttachNativeView. This is not a reasonable long-term solution, but is the most reasonable merge candidate. Follow-on patches will move the CHECK up into NativeViewHostMac::AttachNativeView to see exactly why this is happening. Bug: 933679 Change-Id: I08b19f3123bbe96c49376a41f28a879a855bee62 Reviewed-on: https://chromium-review.googlesource.com/c/1487888 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635705}
-
Koji Ishii authored
NGBoxFragmentPainter::PaintBlockFlowContents creates DrawingRecorer before calling PaintMask, but PaintMask creates another DrawingRecorder. This patch removes the duplicated instantiation. The structure, to create DrawingRecorder inside of PaintMask, matches to BoxPainter. blink_perf.paint_layout_ng does't show much differences: https://pinpoint-dot-chromeperf.appspot.com/job/15d7ebcb340000 Change-Id: I68919799eb00083cb4e782c41ff7dfa6bbadd9b2 Bug: 936024 Reviewed-on: https://chromium-review.googlesource.com/c/1488490Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635704}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc2dec20be7e..33105789ee1e Created with: gclient setdep -r src-internal@33105789ee1e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:931336,chromium:916361 TBR=mmoss@chromium.org Change-Id: I92a9b104623d859b6381972f7f8284765eafae65 Reviewed-on: https://chromium-review.googlesource.com/c/1488961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635703}
-
sebsg authored
Change-Id: I1562934344130c9bf1e8748c745375bb9e2a41ad Reviewed-on: https://chromium-review.googlesource.com/c/1490051 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635702}
-
Etienne Bergeron authored
This CL is adding the FROM_HERE location of the call sites to each ScopedBlockingCall. This modification will provide the detailed location to the trace events and allow developpers do understand cause of janks of long tasks. This CL is adding manually the cases not caught by the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1483834 TBR=gab@chromium.org (skipping owners for side-effects after //base review) Bug: 934302 Change-Id: I04dc84ddc0b8824f91d7409bb06c74397ec7bf32 Reviewed-on: https://chromium-review.googlesource.com/c/1489110Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635701}
-
Jared Saul authored
This TODO was actioned in https://chromium-review.googlesource.com/c/chromium/src/+/1237615, but I apparently forgot to remove the actual TODO. Change-Id: I8298cb9a8c180fc86503df53b60e301b65101e3b Reviewed-on: https://chromium-review.googlesource.com/c/1489517 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635700}
-
Nate Fischer authored
This implements CookieManager#flush() for the network service code path. Now that this is implemented, we can easily test this functionality (and this renames HttpCacheTest -> OnDiskFileTest since the file is now more general). This removes a TODO to implement more CookieManager APIs, because this is the final API for AwCookieManagerWrapper. Bug: 902641, 933456, 933462 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f=OnDiskFileTest#* Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic99990719e87f8b1ed9bdc51aa7f1920c1ee5b88 Reviewed-on: https://chromium-review.googlesource.com/c/1481195 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635699}
-
Eyor Alemayehu authored
Currently, G-Suite users whose policy is enforced by the administrator are prompted to enable the Web and App activity when they launch Assistant. However, they are not authorized to enable the Web and App activity. Made changes to present an appropriate prompt as outlined in: go/gsuite-optin Bug: b:123638794 Change-Id: I883efed56948f0d22e577902eb489b37b894af94 Reviewed-on: https://chromium-review.googlesource.com/c/1480539 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#635698}
-
dalyk authored
To send DoH requests, LogDnsClient needs to set the URLRequestContext to be used for a transaction. The TreeStateTracker is configured with a URLRequestContext that is passed to the resulting LogDnsClient. Bug: 878582 Change-Id: Iea5be660ac1ac0db9a2338386201ff6a92796b0a Reviewed-on: https://chromium-review.googlesource.com/c/1486718 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#635697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f073572f..44fde444 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bda0800d015dfd33bfa6c21b830850191b8bd7d Reviewed-on: https://chromium-review.googlesource.com/c/1489411Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635696}
-
John Budorick authored
also alphabetize the console by builder name. Bug: 935764 Change-Id: I7c6951d264f97d184c22cddb4a3b8600a59e5e93 Reviewed-on: https://chromium-review.googlesource.com/c/1489893 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#635695}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a930646662a..793add9a8d60 git log 1a930646662a..793add9a8d60 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 dgarrett@google.com chromeos_config: Remove prototype-factorybranch. Created with: gclient setdep -r src/third_party/chromite@793add9a8d60 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I7be60339f73aa4d6a70d5c2743356af17c8b98d5 Reviewed-on: https://chromium-review.googlesource.com/c/1489691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635694}
-
David Jacobo authored
Smart text selection was originally implemented to be accessed via context menu and so the UMA description reflected that. After that it was decided the feature should also be accessible via touchscreen and so this CL reflects that update. Bug: None Change-Id: Ib4216e7e913d4a7aa2273b23f7e010ff6e883840 Reviewed-on: https://chromium-review.googlesource.com/c/1489792 Auto-Submit: David Jacobo <djacobo@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635693}
-
Joshua Pawlicki authored
This allows us to reuse the unzip / patch implementations of update_client. Bug: 926236 Change-Id: Iabdbe9f4017b69d3e38a2137e8905b6d274f4ed7 Reviewed-on: https://chromium-review.googlesource.com/c/1461079 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#635692}
-
Fabrice de Gans-Riberi authored
This is a reland of 7da3d9df This creates chromium.web.CreateContextParams2 and chromium.web.LoadUrlParams2 as extensible FIDL tables. All the Chromium-internal call sites have been updated to use the newer APIs. The original APIs will be removed in a future CL when all out-of-tree callers for them will have been updated. Bug: 931831 Change-Id: I8f324342f928c1217b8b88cf8db6797ecfc9aecc Reviewed-on: https://chromium-review.googlesource.com/c/1481080 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635691}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/024f271ae0c7..fe3d4978886b git log 024f271ae0c7..fe3d4978886b --date=short --no-merges --format='%ad %ae %s' 2019-02-26 chrisforbes@google.com Fix various issues in vertex fetch setup Created with: gclient setdep -r src/third_party/swiftshader@fe3d4978886b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib549139ede1a70db9e5b8f60d712fa7a8846f734 Reviewed-on: https://chromium-review.googlesource.com/c/1488960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635690}
-
Nico Weber authored
Requires suppressing the warning for a file generated by mc.exe, and for a system header (which is arguably a clang bug, see comment in the .h). Bug: 926235 Change-Id: Iee8ecd6eab476207c1507719ba5102403f381cae Reviewed-on: https://chromium-review.googlesource.com/c/1489102Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635689}
-
Manu Cornet authored
This should help with flaky tests reported in the linked bug. Bug: 934558 Change-Id: I78b09e596d7da42c3c483598f62e969fff017309 Reviewed-on: https://chromium-review.googlesource.com/c/1487145 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635688}
-
Nicolás Peña Moreno authored
This CL moves the input delay computations for UKM to further down the pipeline to where they are computed for EventTiming. After this CL, the same types of events are logged by both UMA/UKM and EventTiming. The WebViewTest is fixed so that the artificial events move further enough down the pipeline. The tests checking for pointerCancels are no longer applicable since these only applied to the UMA/UKM computations, per issue 924278. By unifying input delay computation, this CL also fixes frame attribution for the UMA/UKM input delays: PageWidgetDelegate does not know the target frame (before, it would tell the root that an event has occurred even if it occurred in an iframe. Bug: 897656, 925130 Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78 Reviewed-on: https://chromium-review.googlesource.com/c/1476070Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635687}
-
Céline O'Neil authored
Small bug fixes: browser UI CompositorFrame now has a valid frame_token, and validation logic for the fuzzed CompositorFrame ensures that the RenderPass output_rect contains the damage_rect, and that the DrawQuad's rect contains its visible_rect. R=kylechar@chromium.org Bug: 934656 Change-Id: If90756a4a608407952fde27e308db1d90a14f1fb Reviewed-on: https://chromium-review.googlesource.com/c/1489632Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#635686}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f53e1f6e2d49..5da3a7e01dc2 git log f53e1f6e2d49..5da3a7e01dc2 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 perezju@chromium.org [Telemetry] Implement TelemetryTracingAgent Created with: gclient setdep -r src/third_party/catapult@5da3a7e01dc2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I2b0cddded0cc3a6c15be5a779ac767f4b3c525e5 Reviewed-on: https://chromium-review.googlesource.com/c/1489453Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635685}
-
Collin Baker authored
The enable_features array was missing in my last CL. Bug: 887991 Change-Id: Ie69d9189a3255e93ee0fb41b24bc54db9b3d670a Reviewed-on: https://chromium-review.googlesource.com/c/1489108Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635684}
-
Yue Li authored
Bug: None Test: Local build Change-Id: I619f49394f25c072bfa714ac0648800b89f2c729 Reviewed-on: https://chromium-review.googlesource.com/c/1484586Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#635683}
-
David Tseng authored
Bug: 935963 Test: manual. Change-Id: I7db0bc37d8085ac3f812818542d1a9dd6f8465de Reviewed-on: https://chromium-review.googlesource.com/c/1489533 Auto-Submit: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635682}
-
Ehsan Karamad authored
The API MaybeCreateMimeHandlerView passes an int which is used as the element instance ID for the GuestView. The int is obtained from BrowserPluginManager::GetNextInstnaceID() which itself obtains it from RenderThread::GenerateRoutingID() (publicly accessible to outside of content/). This is unnecessary and can be generated inside MimeHandlerViewFrameContainer instead. This (mechanical) CL removes the argument from all the methods involved. TBR=avi@chromium.org,wjmaclean@chromium.org Bug: 659750 Change-Id: Ia20e2e2dd59f144ebaa646a4c022390398ea8e07 Reviewed-on: https://chromium-review.googlesource.com/c/1487209Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#635681}
-
Ehsan Karamad authored
This CL fixes a few types and mistakes in the original CL which implemented opener policies (CL: 1384992). Besides, this CL adds two WPTs to complement the test coverage for "FeaturePolicyForSandbox". The current tests verify correctness of propagation in the following cases: 1- "window.open" from an <iframe> that is not sandbox. 2- "window.open" from an <iframe> that is sandboxed but allows escaping. In case (1) the policies are expected to be inherited but in case (2) they should not be inherited from the <iframe>. Future tests add support for cross-origin frames/window as well as rel=noopener case if need be. TBR=mkwst@chromium.org Bug: 774620, 926293 Change-Id: I2da875a008584c7e2015a020fcad92e9528e748d Reviewed-on: https://chromium-review.googlesource.com/c/1483942 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635680}
-
Michael Thiessen authored
Bug: 933884 Change-Id: I596e3a3d59e93e8991a5740eb49b6355e5bbcd7a Reviewed-on: https://chromium-review.googlesource.com/c/1489514 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635679}
-
Xiaocheng Hu authored
Tbr: dgozman@chromium.org NoTry: True Bug: 934818 Change-Id: I302a1cd8252dd0a9401beea1b7762c379e7794c5 Reviewed-on: https://chromium-review.googlesource.com/c/1489853Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635678}
-
Andrew Grieve authored
This reverts commit d9d05e18. Reason for revert: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Integer.intValue()' on a null object reference at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.getPreviousPanelState (OverlayPanelBase.java: 620) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.updatePanelForHeight (OverlayPanelBase.java: 783) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.setPanelHeight (OverlayPanelBase.java: 758) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation.lambda$animatePanelTo$0$OverlayPanelAnimation (OverlayPanelAnimation.java: 354) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation$$Lambda$0.onAnimationUpdate (OverlayPanelAnimation.java) at org.chromium.chrome.browser.compositor.animation.CompositorAnimator.doAnimationFrame (CompositorAnimator.java: 207) at org.chromium.chrome.browser.compositor.animation.CompositorAnimationHandler.pushUpdate (CompositorAnimationHandler.java: 108) at org.chromium.chrome.browser.compositor.animation.CompositorAnimationHandler.pushUpdate (CompositorAnimationHandler.java: 91) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate (LayoutManager.java: 361) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate (LayoutManager.java: 344) at org.chromium.chrome.browser.compositor.CompositorViewHolder.onCompositorLayout (CompositorViewHolder.java: 738) at org.chromium.chrome.browser.compositor.CompositorView.onCompositorLayout (CompositorView.java: 316) Original change's description: > Migrate PanelState from enum to @IntDef + remove one Map > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: > > 1. with @IntDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries > 4. with comment about numbering from 0 without gaps > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > There is additionally removed one unnecessary Map. > > BUG=919666 > > Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1142764 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635196} TBR=dtrainor@chromium.org,donnd@chromium.org,agrieve@chromium.org,marcin@mwiacek.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919666, 936105 Change-Id: I58863b9ffe0dbdf311f0feb459729445b75af179 Reviewed-on: https://chromium-review.googlesource.com/c/1488575Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635677}
-
Jérôme Lebel authored
The sign-in cell opens to the account list view controller, it needs to have a disclosure indicator. Before: https://drive.google.com/open?id=1Opqj8IeHkqfeIbrb5ayizQxk3YFL4p6g After: https://drive.google.com/open?id=1VOoQgkNrnNaexALS-Dprvn6H4YjyDQrH Bug: 914059 Change-Id: I50616173dd5fb6eb457005518e096cc084bcd721 TBR: gambard Reviewed-on: https://chromium-review.googlesource.com/c/1489204Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635676}
-