GitLab

Review URL: https://chromiumcodereview.appspot.com/11746025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175699 0039d316-1c4b-4281-b951-d872f2087c98

Our bash scripts were getting complicated an unwieldy. In this
commit I port the test logic into python, as a precursor to
moving the rest of the file.

I also move the step selection logic into python which offers the following advantages:
- Less files to maintain, easier to change something globally.
- Paves way to moving most factory_properties into 'slave_properties' argument I added.  This will let us change parameters like buildtype (make vs. ninja) without a waterfall restart.  This also moves configuration into a single place.

Also:
- Refactor test runners to not require envsetup.
- Adding test report step

BUG=153707,163476, 168518

Review URL: https://codereview.chromium.org/11666023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175698 0039d316-1c4b-4281-b951-d872f2087c98

1) show hover effect on rows
2) add placeholder resources for menu buttons
3) make clicks on rows pop up the suggestion menu

BUG=157273

Review URL: https://codereview.chromium.org/11785035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175696 0039d316-1c4b-4281-b951-d872f2087c98

Move sandbox_linux_unittests away from the FYI bots and enable them
by default.

BUG=166704
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175695 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Implement DelegatingRender::drawFrame() method.
> 
> The method sends the render passes it is given to the parent compositor via
> the output surface. It should include a valid frame metadata with it.
> 
> Tests:
> DelegatingRendererTestDraw.runSingleThread
> DelegatingRendererTestDraw.runMultiThread
> DelegatingRendererTestResources.runSingleThread
> DelegatingRendererTestResources.runMultiThread
> 
> R=piman
> BUG=123444
> 
> Review URL: https://chromiumcodereview.appspot.com/11777025

TBR=danakj@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175694 0039d316-1c4b-4281-b951-d872f2087c98

This moves the GTK- and Views-specific code for alerting RenderWidgetHostView keypress listeners of keypress events into the shared method RenderWidgetHostImpl::ForwardKeyboardEvent() that all implementations bottleneck through.

Also updates RenderWidgetHostImpl::KeyPressListenersHandleEvent() to ignore events with the skip_in_browser flag set.

BUG=51644


Review URL: https://chromiumcodereview.appspot.com/11779035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175691 0039d316-1c4b-4281-b951-d872f2087c98

The method sends the render passes it is given to the parent compositor via
the output surface. It should include a valid frame metadata with it.

Tests:
DelegatingRendererTestDraw.runSingleThread
DelegatingRendererTestDraw.runMultiThread
DelegatingRendererTestResources.runSingleThread
DelegatingRendererTestResources.runMultiThread

R=piman
BUG=123444

Review URL: https://chromiumcodereview.appspot.com/11777025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175690 0039d316-1c4b-4281-b951-d872f2087c98

The script has to be aware of MIPS arch, so it can figure out that the libary
is for MIPS.

BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome


Review URL: https://chromiumcodereview.appspot.com/11819009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175689 0039d316-1c4b-4281-b951-d872f2087c98

cc: Map the clip_rect in the SharedQuadState to include the drawTransform of the hosting delegated renderer layer.

The clip rect is assuming that it draws to its old target space, but it will be
drawing to the target space of the delegated renderer layer, so adjust it
accordingly.

Tests:
cc_unittests:DelegatedRendererLayerImplTestSharedData.SharedData

BUG=123444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175688 0039d316-1c4b-4281-b951-d872f2087c98

This re-enables several tests that were disabled, and
adds new expectations where they were missing before.
It also cleans up some tests by suppressing unnecessary
attributes, and makes the Mac "subrole" attribute hidden
by default since it's rarely useful.

The correctness of the output was determined by these specs:

HTML: http://www.w3.org/TR/html-aapi/
ARIA: http://www.w3.org/WAI/PF/aria-implementation/

BUG=165838
TBR=dtseng


Review URL: https://chromiumcodereview.appspot.com/11785038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175687 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11830015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165783


Review URL: https://chromiumcodereview.appspot.com/11778051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175682 0039d316-1c4b-4281-b951-d872f2087c98

This change requires this WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=104404

This change enables access to the guest's window's name attribute from the embedder <webview>. It also enables changes to the window name attribute from the embedder WebContents.

BUG=140316
Test=BrowserPluginHostTest.ChangeWindowName

Review URL: https://codereview.chromium.org/11554030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175681 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11824008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175679 0039d316-1c4b-4281-b951-d872f2087c98

The core problem is that the key that controls the execution of a protocol
HKEY_CLASSES_ROOT\<protocol>\Shell\Open\Command

Has changed, we expect the Default value to be a valid command like foo.exe %1
but this is no longer the case. This value can be empty and other values will
control what happens, for instance DelegateExecute.

This CL also whitelists the protocol, alternatively we could hardcode a meaniful
string to present to the user but that presents localization issues. We take the
same approach as IE and just launch the windows store if we see this protocol.

BUG=159096
TEST=see bug
Review URL: https://codereview.chromium.org/11316038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175678 0039d316-1c4b-4281-b951-d872f2087c98

The goal is just to make sure this code has test coverage, not to test
correctness. There was an issue in the past where the code that computed
the histograms crashed in debug mode, this will help prevent something like
that from landing in the future.

BUG=99504


Review URL: https://chromiumcodereview.appspot.com/11778045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155221


Review URL: https://chromiumcodereview.appspot.com/11638053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175676 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11773048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175675 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
TEST=Repro steps in bug #168746.
BUG=166348

Review URL: https://chromiumcodereview.appspot.com/11784036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175674 0039d316-1c4b-4281-b951-d872f2087c98

This will track Shill Device info, including Wifi access point data.

BUG=167987


Review URL: https://chromiumcodereview.appspot.com/11743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168652


Review URL: https://chromiumcodereview.appspot.com/11788020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175672 0039d316-1c4b-4281-b951-d872f2087c98

Change the method to no longer write to both App GUIDs, just the one that matches the distribution of the caller. This means that GCAPI will only write to the Google Chrome product's client state key, and not to the Chrome Binaries.

Replace SetOmahaExperimentLabel in the GCAPI code with a more specific version, and have SetOmahaExperimentLabel perform the general clobber-write to the registry.

This is in preparation for future work in using the experiment_labels to transmit Chrome Variations.

BUG=160251


Review URL: https://chromiumcodereview.appspot.com/11280067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175671 0039d316-1c4b-4281-b951-d872f2087c98

Now it doesn't dismiss the item. When click happens in the toast, it will hide from the popup but remain in the center.

BUG=165576

Review URL: https://codereview.chromium.org/11778012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175669 0039d316-1c4b-4281-b951-d872f2087c98

> Omnibox: Make HistoryQuick provider not re-issue queries if |minimal_changes| is true
> 
> BUG=
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11722020

I'm reverting this because it causes problems with backspace, at least when
certain field trials are enabled.  See
https://code.google.com/p/chromium/issues/detail?id=168725

We'll probably chose a different strategy to fix this in a better way (in
terms of how the code should work), but at least this puts the behavior
back to what people are used to.

BUG=168725
TBR=mpearson@chromium.org
Review URL: https://codereview.chromium.org/11820015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175668 0039d316-1c4b-4281-b951-d872f2087c98

Context menu button isn't useful for editing item and it casuses
a problem when displaying context menu on editing item.

BUG=76189

Review URL: https://codereview.chromium.org/11777026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175667 0039d316-1c4b-4281-b951-d872f2087c98

Host and NaCl builds currently use different headers which can cause
build problems.  This change moves the headers out of the toolchains
and instead all toolchains share the same set as the host builds.

NOTRY=true
BUG=168718
R=binji@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11825003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175666 0039d316-1c4b-4281-b951-d872f2087c98

This change allows you to compile all .cc files for nacl-mounts. Previously you
need to include compile kernel_wrap.cc, but only copy (not compile) the other
kernel_wrap_*.cc files.

This is convenient for someone making a visual studio project -- they can just
drop all the .cc files into a project and everything "just works".

BUG=none
R=noelallen@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11744010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175665 0039d316-1c4b-4281-b951-d872f2087c98

This updates a few more classes to be observers of
PowerManagerClient in addition to RootPowerManagerClient.
After powerm is moved into powerd, all of the
RootPowerManagerClient code will be deleted.

BUG=chromium-os:36804


Review URL: https://chromiumcodereview.appspot.com/11824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175664 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
BUG=168882
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11825008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175663 0039d316-1c4b-4281-b951-d872f2087c98

Also allow InstantExtended field trial groups to override this behavior and set espv values as they see fit, to provide for flexibility for future experiments.

BUG=168298

Review URL: https://codereview.chromium.org/11743035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175660 0039d316-1c4b-4281-b951-d872f2087c98

There is a linux adb binary checked in to platform-tools. We use it if on linux
and the adb command isn't found.

BUG=None
TEST=tools/perf/run_multipage_benchmarks --browser=list -v

Review URL: https://codereview.chromium.org/11830011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175659 0039d316-1c4b-4281-b951-d872f2087c98

Over in related https://codereview.chromium.org/11649028/ , I had to add HISTOGRAM_BOOLEAN. It's not right that UMA_HISTOGRAM_* and HISTOGRAM_* are not the same. This CL doesn't fix that, but it does at least make things less bad.

R=isherman@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11794020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175658 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11788022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175657 0039d316-1c4b-4281-b951-d872f2087c98

Adds a mechanism to TemplateURL to optionally allow search term extraction only when a given key is present (for Google, this is "espv"). Uses this to ensure ToolbarModel no longer relies on the hardcoded "espv" parameter.

Depends on:
  https://codereview.chromium.org/11552020/

BUG=161602


Review URL: https://chromiumcodereview.appspot.com/11576044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168244
Owner:
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11766002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175655 0039d316-1c4b-4281-b951-d872f2087c98

Possibly the change of 
http://src.chromium.org/viewvc/chrome?view=rev&revision=175642

Broke the mac plist string generation

BUG=168890
TEST=mac bot not red
TBR=thakis
Review URL: https://codereview.chromium.org/11829014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175654 0039d316-1c4b-4281-b951-d872f2087c98

> ThreadedTest that a non-null OutputSurface that fails initialization immediately doesn't crash
> 
> Unit test to catch things like bug 168691
> 
> BUG=
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11782026

The new tests this change added fail on Mac and linux 

TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/11830013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11829005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175651 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't change over the lifetime of the prcoess, so we can
easily keep ahold of one instance.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11791010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175650 0039d316-1c4b-4281-b951-d872f2087c98

See the attachments of crbug.com/166786#c2 the bubble has border for focus.

BUG=166786
TEST=open the message center bubble when there're no notifications and confirmed no focus borders appear.

Review URL: https://codereview.chromium.org/11737029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175649 0039d316-1c4b-4281-b951-d872f2087c98