GitLab

BUG=140293
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150622 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150618 0039d316-1c4b-4281-b951-d872f2087c98

Fixes safe_browsing_tests failure on win from 110.

BUG=96459

Review URL: https://chromiumcodereview.appspot.com/10855035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150617 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10836149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150614 0039d316-1c4b-4281-b951-d872f2087c98

This script will convert static files from the old documentation
system to the new one.

To run from the server2/ directory try:
converter.py ../static/ ../../api templates/articles/ templates/intros/ templates/public/ static/images/ -r -s

This was moved from: http://codereview.chromium.org/10832042/

BUG=131095
Review URL: https://chromiumcodereview.appspot.com/10834130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141473

Review URL: https://chromiumcodereview.appspot.com/10830226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150611 0039d316-1c4b-4281-b951-d872f2087c98

skia expects to be initialized before it can be used. This must be done if serializing SkPicture, which we now do for benchmarking.
Review URL: https://chromiumcodereview.appspot.com/10823129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150609 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2813

Review URL: https://chromiumcodereview.appspot.com/10823220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150608 0039d316-1c4b-4281-b951-d872f2087c98

There were a few bugs, and some confusing UI. I made the following changes:
* Moved the ShouldShowIconInTray() logic into NetworkMenuIcon.
* Removed the unused function GetVpnImage()
* Made VPN icon code similar to other network types
* Changed network display order to:
** Active network
** Connected networks (VPN, Ethernet, Cellular, Wimax, Wifi)
** Unconnected networks (same order)

BUG=137941

Review URL: https://chromiumcodereview.appspot.com/10824208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150607 0039d316-1c4b-4281-b951-d872f2087c98

Base web accessibility decisions on page transition. We only need to perform the check if the transition is web triggerable.

BUG=137435
TEST=ExtensionResourceRequestPolicyTest.WebAccessibleResources
Review URL: https://chromiumcodereview.appspot.com/10827107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150606 0039d316-1c4b-4281-b951-d872f2087c98

This will go after 'Noto Sans UI' is checked into ChromeOS.

See https://gerrit.chromium.org/gerrit/#/c/29087/1 for the
corresponding CrOS change.

Bug=131515
Test=The UI (both 'native' and web ui) uses Noto Sans UI. For English UI, it's exactly the same as Chrome Droid Sans. If you try Vietnamese UI, there will be no more ransom note effect because Noto Sans UI covers all the Latin letters used in Vietnamese while Chrome Droid Sans does not and leads to a ransom note effect (some characters from Chrome Droid Sans while others coming from other fonts).
Review URL: https://chromiumcodereview.appspot.com/10836082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150605 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10837169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150604 0039d316-1c4b-4281-b951-d872f2087c98

Don't print the callstack in forked browser test processes. This may allocate memory or try to acquire OS locks which may already be locked from the parent process. This was happening because there's a race condition where the browser process forks a process and shuts it down very soon after, before it calls exec*.

BUG=141302,139209,36678
Review URL: https://chromiumcodereview.appspot.com/10836148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134159


Review URL: https://chromiumcodereview.appspot.com/10830217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150602 0039d316-1c4b-4281-b951-d872f2087c98

Localized_error contains code to generate error strings, and it isn't render-thread specific. Chrome for iOS uses this class for error messages, but because we don't use the render thread at all, we've had to go into contortions of DEPS and gyp files to include it. This CL pulls localized_error out of renderer into common, which will bring great sanity to the iOS build.


BUG=


Review URL: https://chromiumcodereview.appspot.com/10830218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150601 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10855041

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150599 0039d316-1c4b-4281-b951-d872f2087c98

Reviewed at: https://chromiumcodereview.appspot.com/10799014

Reverted for failure of mac_valgrind. Failure due (almost certainly) to
a bug in Apple's code. Added suppression and filed bug (http://crbug.com/141293).

BUG=123865


Review URL: https://chromiumcodereview.appspot.com/10830207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150598 0039d316-1c4b-4281-b951-d872f2087c98

Fire a notification in Windows 8 metro chrome which informs the user about a completed download. This is achieved
by a new class DownloadCompletionObserver which lives in the newly added file download_completion_observer_win.cc/.h
in chrome/browser/download. This class observes the DownloadManager and the DownloadItem to get information about
download items getting created and completing.

BUG=133109
R=cpu,asanka
Review URL: https://chromiumcodereview.appspot.com/10832174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150597 0039d316-1c4b-4281-b951-d872f2087c98

instead of GDataFileSystem::GetEntryInfoByPath(). The two are similar
but the latter initiates feed loading/fetching. Inside GDataFileSystem,
we don't need to use the latter.

BUG=150567
TEST= out/Release/unit_tests --gtest_filter='GData*'

Review URL: https://chromiumcodereview.appspot.com/10836154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141410
TEST=Ran on chrome-qa bot to witness failing steps identified in the bug.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10826206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150595 0039d316-1c4b-4281-b951-d872f2087c98

Broken by r150531

TBR=marja@chromium.org
BUG=141443

Review URL: https://chromiumcodereview.appspot.com/10825253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150594 0039d316-1c4b-4281-b951-d872f2087c98

After the requester calls EnumerateDevices, it should expect new device list as initial response and whenever devices are changed.
A new method StopEnumerateDevices is also added to allow the request to stop device enumeration.

It also includes corresponding change in Pepper since EnumerateDevices contract is changed (http://codereview.chromium.org/10837064/).
This patch keeps current Pepper API, while using the new API of EnumerateDevices from MediaStreamDispatcher. 
Pepper calls StopEnumerateDevices when it receives the first enumerated result. 

A new Pepper API will be created in a separate patch to make EnumerateDevices persistent. 

BUG=137799
Review URL: https://chromiumcodereview.appspot.com/10830063

BUG=141367

TBR=wjia@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150593 0039d316-1c4b-4281-b951-d872f2087c98

shouldn't. We need to invoke UpdateShelfVisibility after
BaseLayoutManager::ShowStateChanged since it ShowStateChanged() may
change the visiblity of the window, which effects what
UpdateShelfVisibility returns.

BUG=141391
TEST=covered by unit tests
R=skuhne@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150592 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10855041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150591 0039d316-1c4b-4281-b951-d872f2087c98

The method gives the illusion that Pipeline objects can be reset to the initial state. They can't.

Review URL: https://chromiumcodereview.appspot.com/10823222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150590 0039d316-1c4b-4281-b951-d872f2087c98

Reviewers:
aa: webstore_installer.*
Done:
sky: mock_download_item.h
achuith: gdata_download_observer.cc
rdsmith, asanka: *

Review URL: https://chromiumcodereview.appspot.com/10833058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150589 0039d316-1c4b-4281-b951-d872f2087c98

Remove myself from the reviewer section on chrome\OWNERS. I'm too overloaded with reviews for content as is.
Review URL: https://chromiumcodereview.appspot.com/10832181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150588 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10827145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10825249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150586 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150585 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org

BUG=


Review URL: https://chromiumcodereview.appspot.com/10829241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150584 0039d316-1c4b-4281-b951-d872f2087c98

We're apparently running into situations where an extension is attempting to
clear browsing data before either the browser or the profile is correctly set
up. This CL takes the simplest approach: if we can't grab the browser or the
profile, exit early (hopefully) without crashing.

BUG=139075


Review URL: https://chromiumcodereview.appspot.com/10855049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150583 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150580 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9392: (khim) Speedup the check-decoder test
r9393: (shcherbina) Validator_ragel: fix validator_test segfault on no input files
r9394: (bradchen) Restrict underdefined bit fields for lfence, mfence and sfence.
r9395: (mseaborn) Debug stub: Make HLT produce the same signal on Windows and Linux
r9396: (arbenson) Allocate zero-based memory if prereserved memory found on x86-64
r9397: (robertm) Make a function at a time translation the default for pnacl.
r9398: (bradchen) Minor clean to enuminst; fixes a base register analysis error.
r9399: (robertm) Increase test coverage on pnacl bot.
r9400: (bradchen) Fix ragel checking of unsandboxed uses of RSI/RDI and RBP/RSP.
r9401: (phosek) SConstruct fix for OS X 10.8 and newer which deprecated and removed older OS X SDKs.
r9402: (petarj) [MIPS] Toolchain scripts for MIPS architecture.
r9403: (arbenson) Pull out NaClVmmapAdd calls in NaClMprotectGuards.

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10837160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150579 0039d316-1c4b-4281-b951-d872f2087c98

This target has been renamed to ash_unittests.  We were
temporarily building ash_unittests and copying it to
aura_shell_unittests.  The buildbots have been reconfigured
and restarted, so they should look for the new name.  We
can now eliminate the copy step and the old target.

BUG=110107
TEST=green buildbots


Review URL: https://chromiumcodereview.appspot.com/10828075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10826205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150577 0039d316-1c4b-4281-b951-d872f2087c98

The contacts GData code was previously fetching the default
feed, which includes "Other Contacts" suggested by Gmail
(i.e. everyone you've ever emailed).

This change makes GDataContactsService first fetch the list
of contact groups so it can find the ID of the user-curated
"My Contacts" group, and then use it when requesting the
contacts themselves.

BUG=128805
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10834220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10827226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140870

Review URL: https://chromiumcodereview.appspot.com/10830190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150573 0039d316-1c4b-4281-b951-d872f2087c98