- 29 Aug, 2019 40 commits
-
-
Nicolás Peña Moreno authored
This CL adds a test for poster image of video. It also adds a helper script with a checkImage() helper which is used in the tests where LCP entry with image is expected. The last parameter is an options array which is used to specify different expected behaviors. Bug: 994414 Change-Id: If0d085aa4569d2ce2d116734819c18028700ad8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764416Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#691736}
-
Etienne Bergeron authored
Add arguments from ScopedThreadMayLoadLibraryOnBackgroundThread to the tracing whitelist. ScopedThreadMayLoadLibraryOnBackgroundThread:: ScopedThreadMayLoadLibraryOnBackgroundThread(const Location& from_here) { TRACE_EVENT_BEGIN2("base", "ScopedThreadMayLoadLibraryOnBackgroundThread", "file_name", from_here.file_name(), "function_name", from_here.function_name()); [...] } R=oysteine@chromium.org Bug: 973868 Change-Id: If6bfa7c224a4c69c9d004526c773ad0d69534ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773702Reviewed-by:oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691735}
-
Peter Boström authored
Makes sure BrowserActionsContainer isn't being used anymore. Note that there are layout problems and that the entire container doesn't render. The change is under a flag though so submitting it won't break users but debugging the layout problems can be done separately. Bug: chromium:995452, chromium:985834 Change-Id: I4c3c71f7afa7705bcc8da96631dccf3973c985b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740687 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691734}
-
chrome://local-staterbpotter authored
This is the first WebUI page leveraging native Javascript modules, used as a proof of concept for other WebUI pages to follow. Type-checking should also work ninja -C out/<out>/ chrome/browser/resources/local_state:closure_compile Bug: 915053 Change-Id: I274f02c5f95e395131318ece0172750c9d815139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1414153 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691733}
-
Erik Chen authored
Bug: 995981 Change-Id: I1737d9866fb616666e6984825e4a389c169a2a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775057 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691732}
-
vmpstr authored
This patch adds the CSS content-size property along with the parsing code. This does not add any behavior changes based on the existence of these properties. R=chrishtr@chromium.org, futhark@chromium.org Bug: 991096 Change-Id: I853caab577176abf8a566f2694091800c68b6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772285 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691731}
-
Monica Basta authored
Set the ids for the listed accounts retrieved from |prefs::kGaiaCookieLastListAccountsData| on startup as they are not set in |gaia::ParseListAccountsData| and are empty. Bug: 990286 Change-Id: I57d28ce8eff3f209c9b4fc82f0bf22e78545a7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760950 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#691730}
-
Erik Chen authored
The redirect through MainFrameWidget was incorrect -- size is a WebViewImpl property and should be directly set. Bug: 995981 Change-Id: Ic57d7f890fefc4220de02d06d5b883ab9bb64398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774017Reviewed-by:
-
Caroline Rising authored
Bug: 998642, 910739 Change-Id: I1754f1db6f56b04976eb4ae4e3bf08436db425f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774270Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#691728}
-
Mason Freed authored
With this CL, backdrop-filter is disabled for all of Android. It will be (first) enabled via Finch for Android non-Webview platforms and all other platforms just in case. This was suggested as a good course of action rather than relying only on the Finch system to disable the feature for Webview. See the discussion in crbug.com/997290. Bug: 997290 Change-Id: I7996cc674114701fb1a833f859a9a18e397327ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772280Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
When user loses past session tabs of regular mode after invoking a new window from the incognito mode. This was happening because the SessionStartUpPref type was being set to default, from last, for regular user mode. This was happening in the RestoreIfNecessary method where the restoration was taking place for users whose SessionStartUpPref type was set to last. The fix was to make the protocol of changing the pref type to default more explicit to incognito users and not regular users of pref type last. Bug: 481373 Change-Id: I96efb4cf196949312181c83c6dcd45986ddded13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774441Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691726}
-
Matt Mueller authored
GetMinimumRsaDsaKeySize needs to check which CertVerifyProc implementation is being tested since CertVerifyProcInternalTest is a parameterized test. Bug: 998845 Change-Id: I376263bf5bdfb1ca6dc7d23c025f9f23ba3e192c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776402Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#691725}
-
Anushruth authored
Enables informational tast tests on the said builder. See go/tast-attr for the distinction R=bpastene@google.com Bug: 988581 Change-Id: Ic259f5054a23a5e32cd8df4015de47930d83c971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754496Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#691724}
-
Nico Weber authored
Bug: 999160 Change-Id: Ifabc11bd62e2808135fbe1768206e7264fb48809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774791 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#691723}
-
Fredrik Söderquist authored
This reference should always be the same as the first child of the shadow root. Since we don't make heavy use of it though - and it shouldn't be too slow to access via the ShadowRoot, just get rid of it to have less state to keep up-to-date. Bug: 997176 Change-Id: I798bbc7ac64934d5eda1250b32150b50b4d2acdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771960Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#691722}
-
Yannic Bonenberger authored
To accommodate for cases where base::BindRepeating was used to satisfy the presubmit warning to not use base::Bind, this CL extends the base_bind_rewriter to also replaces base::BindRepeating with base::BindOnce where the resulting Callback is converted to OnceCallback immediately. E.g.: PostTask(FROM_HERE, base::BindRepeating([]{})); OnceCallback<void()> cb = base::BindRepeating([]{}); will be replaced to PostTask(FROM_HERE, base::BindOnce([]{})); OnceCallback<void()> cb = base::BindOnce([]{}); Change-Id: I99b6406fdce26ae53f332740699e5a66d709c61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1215942 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#691721}
-
Stefan Zager authored
This is in preparation for subsequent optimization work that computes RootGeometry once per IntersectionObserver, rather than once per IntersectionObservation. Also, add some const-correctness, because why not? No functional change. BUG=956071 Change-Id: I14cb0b698d0c2f6271bbb36143ded21a790435c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774240 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691720}
-
Elly Fong-Jones authored
This is required since the changed theme might have a different color or image for the toolbar. Bug: 996799 Change-Id: I057f16ccea3f9b9dfe6d530f8b728f6ae1fb5c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774786 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#691719}
-
Yasmin authored
Plus some refactoring to favor composition over inheritance for click_to_call_icon_view. Recording of the change:(check the omnibox icon and message on 0:12 sec) https://drive.google.com/file/d/18wxoxYDW6U8fKEmDcRnlYass5I_0sy7U/view Bug: 994704 Change-Id: I2124794f11e5060f5c233966aa49eedb9b6b97bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768349 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691718}
-
John Budorick authored
machines added in crrev.com/i/1722808 Bug: 994432 Change-Id: Iaa59bb6110924cf198d990ea10f07ac4132c95c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774307Reviewed-by:
-
Peter Kasting authored
Documentation on these is scarce; the intended behavior is not perfectly clear. Bug: 284015 Change-Id: I0ece5500f45071afe02b8457925872d3187943c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775602Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#691716}
-
Sven Zheng authored
This is needed for any new filter file. Bug: chromium:958242 Change-Id: Icd95e0d04d405ac3ace5b7caf9ccb6da5a178627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775444 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#691715}
-
Sophie Chang authored
It was wrong to begin with (or rather it did not fulfill the intent I wanted it to fulfill) and mcrouse's UMA around the fetched hints request proportion serves the same purpose. Change-Id: I657833f6bf8e0bc3ce6676459b8904f1e4b8b112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775373Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#691714}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44dc241ae8d6..022a7c8d4980 git log 44dc241ae8d6..022a7c8d4980 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 kkinnunen@nvidia.com Fix HexEncodeTest.TestZeroLengthNoDelimiter with enable_iterator_debugging=true 2019-08-29 sprang@webrtc.org Avoids race during VideoStreamEncoder unittest teardown 2019-08-29 mbonadei@webrtc.org Remove backwards compatibility names from api/uma_metrics.h. 2019-08-29 mbonadei@webrtc.org Remove stale TODO from rtc_base/checks.h. Created with: gclient setdep -r src/third_party/webrtc@022a7c8d4980 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I0cf07f47cb1791ef279de1acf20de0aa2c42f7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691713}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/938ce9fc5369..b1f411ac053d git log 938ce9fc5369..b1f411ac053d --date=short --no-merges --format='%ad %ae %s' 2019-08-29 halcanary@google.com tools/skui: put all enums in a common namespace 2019-08-29 brianosman@google.com Reland "Pin the GLSL version to be no larger than the GL version" Created with: gclient setdep -r src/third_party/skia@b1f411ac053d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I114bf2826c7654252511a01eb4a9fbe18f844c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775108Reviewed-by:
-
Matt Mueller authored
Presently, //net has CertStatus flags which are "errors, but minor", used to indicate when revocation checking failed or revocation information was absent. Callers can check IsCertStatusError and IsCertStatusMinorError to determine whether this is such a case, which is presently used to implement the soft-fail logic. However, this means that code has to deal with "errors that aren't errors" throughout, adding unnecessary complexity. This change moves the handling into //net. In the default configuration, revocation checking errors are soft-fail. The CertVerifier status will indicate OK, and will not include additional status bits about the failure in the CertStatus. However, if the caller has requested revocation checking be hard fail (e.g. in the case of local trust anchors), then any failure to check revocation information will be flagged as either ERR_CERT_NO_REVOCATION_MECHANISM or ERR_CERT_UNABLE_TO_CHECK_REVOCATION, with additional CertStatuses to map. These CertStatuses are now treated as hard errors, removing the concept of "errors that aren't errors" from //net. Harmonizes the per-implementation CertVerifyProc handling of revocation checking errors as much as possible. net::IsCertStatusMinorErrors will be removed in a follow-up CL. Bug: 964416 Change-Id: I81214a87377769de9e644371bac6906ea20d346f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766000 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
-
Joe Mason authored
Also fix repeated enum value in CustomErrors. R=jwd Bug: 969139 Change-Id: I070600e5a73de8481fc255680003f0f026e75555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767664 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#691710}
-
Bruce Dawson authored
When creating a .zip file in order to run browser tests on a non-dev laptop I hit an exception because the total (uncompressed) size of the files was too big. There seems to be no reason not to allow Zip64 and therefore arbitrarily large .zip files. I have successfully unzipped the Zip64 file created by this change using Explorer on Windows 7. Command line used was: python tools\mb\mb.py zip out/Debug browser_tests browser_tests.zip Change-Id: I93efd6e43f6af75e34f0c17aaa89b260bfa89bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775382Reviewed-by:Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#691709}
-
Xing Liu authored
This CL adds the metrics to track IHNR buttons clicks and show. Bug: 963298 Change-Id: I33ef62df25a9873b4ec814f5730c191289bc7691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772045Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691708}
-
Sebastien Marchand authored
Change-Id: I8f419ae17a02427b4d51a787d4a84b2724d6cf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773842 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#691707}
-
Kush Sinha authored
ARC's accounts' migrations to Chrome OS Account Manager can fail at the start of a user session if ARC fails to properly start up. Retry migrations after a successful ARC startup. Bug: 998111 Change-Id: I466ef4fa698228d1ef10b8018e485461529d8eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773137Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#691706}
-
Julian Watson authored
Bug: 998319 Change-Id: I46594add1dbec54e29ba2b2d6bd515ce180a6cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773003Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#691705}
-
Jan Wilken Dörrie authored
Similarly to r691214 this change implements logic to record metrics for interactions with the leak detecion dialog for Android. In order to get more detailed notificiations about the user's interaction it extends PasswordManagerDialogMediator's Callback result from a boolean to the more descriptive DialogDismissalCause enum. Bug: 986317 Change-Id: I923410c79198541964a779869d03387d7602896e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776036Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#691704}
-
Etienne Pierre-doray authored
This is a reland of 792309b6 ThreadGroupTest.JobTaskSourceConcurrencyIncrease was previously failing: The issue is caused by a race between EnsureEnoughWorkersLockRequired and DidProcessTask: - Worker 1 and worker 2 are running the job TaskSource. - Main: SetNumTasksToRun() sets |remaining_num_tasks_to_run_| to 4 and unblocks the callbacks running on worker 1 and worker 2. - Worker 1: The callback returns and |remaining_num_tasks_to_run_| is decremented by MockJobTask::Run(). The new value is 3. - Main: NotifyConcurrencyIncrease > PushTaskSourceAndWakeUpWorkers > EnsureEnoughWorkersLockRequired wakes up 1 worker instead of 2. From the point of view of EnsureEnoughWorkersLockRequired(), worker 1 is still running a task from the job TaskSource. 3 workers needed - 2 workers already running = 1 worker to wake up. - Worker 1: DidProcessTask() is called and tries to reenqueue the TaskSource, but it is already in the PriorityQueue (added by the main thread). It does not wake up any worker. - Worker 2: Finishes running the job callback. DidProcessTask() is called and tries to reenqueue the TaskSource, but it is already in the PriorityQueue (added by the main thread). It does not wake up any worker. - Worker 3: Wakes up, gets the job TaskSource from the PriorityQueue and runs it. - Worker 3: Finishes running the job callback. DidProcessTask() is called and tries to reenqueue the TaskSource, but it is already in the PriorityQueue (added by the main thread). It does not wake up any worker. No additional worker is woken up. On the native thread group, a worker runs only a single task so the 4th never runs and the test waits forever. This is fixed by calling EnsureEnoughWorkersLockRequired unconditionally in ThreadGroup::ReEnqueueTaskSource to avoid leaving a task source with no worker. Original change's description: > Reland "[ThreadPool]: Implement Job Delegate's ShouldYield and concurrency increase." > > This is a reland of 63fbbb92 > > Reason for reland: > - Fixed with ScopedAllowBaseSyncPrimitivesOutsideBlockingScope. > > Original change's description: > > [ThreadPool]: Implement Job Delegate's ShouldYield and concurrency increase. > > > > This CL partially implement job's delegate, as well as concurrency > > usage assertion: > > - ShouldYield must be called in worker task. > > - max concurrency is expected to decrease unless > > NotifyConcurrencyIncrease() is called. > > > > To implement ShouldYield, PooledTaskRunnerDelegate is used > > to communicate with ThreadPool and a racy priority is added to > > task source. > > > > Bug: 839091 > > Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#690127} > > Bug: 839091 > Change-Id: I6f36f27426351e4efbcbaf7e9356840c004e6630 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769502 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690437} Bug: 839091 Change-Id: I043e6c129e0ebf4f80483a70045866402db776f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773323 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#691703}
-
Jamie Madill authored
Capitialization was sensitive and did not match the spelling in DEPS. Bug: angleproject:3876 Tbr: thakis@chromium.org Change-Id: I7a0da1d415fd21ab9754354f8000dd4d7ddb8546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774789Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#691702}
-
Patrick Monette authored
Bug: 973497 Change-Id: I10d28adb82234040aa3ef5f36ceb29e3a82f81f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724606Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#691701}
-
Toni Barzic authored
For now, it doesn't add search box configs, and folder configuration is not yet wired up - that is to come in subsequent cls. Bug: 996808 Change-Id: Ie99860aff9537795d2eb6d0795c5cb7652883231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774887 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691700}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9af883e9787..8dd0eb227a3f git log a9af883e9787..8dd0eb227a3f --date=short --no-merges --format='%ad %ae %s' 2019-08-29 bclayton@google.com Regres: Adjust constants and include error messages Created with: gclient setdep -r src/third_party/swiftshader@8dd0eb227a3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I7b96769c3bea3bf10c6c0a11d30540b185d8e2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775106Reviewed-by:
-
Daniel Clark authored
Per https://w3c.github.io/html-aam/#el-time, set the LocalizedControlType of <time> to "time". Bug: 998221 Change-Id: Ib789f4a22308ac4f600b40abf3ae106799309e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769351Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691698}
-
Malay Keshav authored
Cleanup CL to make the code easier to modify and understand. Change-Id: I4e29b2f54b5598f3d11d519921ddb8442d769b4d Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774904 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#691697}
-
