- 03 Sep, 2020 40 commits
-
-
James Hawkins authored
Bug: 1045266 Test: NetworkComponentsNetworkConfigTest* Change-Id: Ic585489fae7711e483e1759d6dcda5473b43d418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353557 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804070}
-
Liquan (Max) Gu authored
After crrev.com/c/2372888, all cases of mMerchantSupportsAutofillCards are accessed after defined, we can limit that it's used only after it's not null. Bug: 1107039 Change-Id: Iea978142c9a9e7d755cb294d9acf3eff80f13d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388561 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804069}
-
Joe DeBlasio authored
Change-Id: Iff940839243bf27974860e1e32b5fe25d8a59b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391730 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#804068}
-
Eugene Zemtsov authored
Change-Id: I1a32006dc0d91102b24a16bc591284dc88ca7ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387415Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#804067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ef21edffb35..683beccf6776 2020-09-02 johnstiles@google.com Migrate inliner-related tests to a separate unit-test file. 2020-09-02 egdaniel@google.com Don't require secondary command buffers on mali vk. 2020-09-02 michaelludwig@google.com Revert "Add idea of DataType to SkYUVAPixmapInfo." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Replace RRect objects with TypedArrays." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Change SkRects to be arrays, not objects." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Add drawRect4f as example 'fast path' API" 2020-09-02 johnstiles@google.com Remove pipeline-stage workarounds from the GLSL code generator. 2020-09-02 mtklein@google.com update INHERITED style 2020-09-02 nifong@google.com Fix GL loading bug in wasm debugger. 2020-09-02 kjlubick@google.com [canvaskit] Add drawRect4f as example 'fast path' API 2020-09-02 kjlubick@google.com [canvaskit] Change SkRects to be arrays, not objects. 2020-09-02 kjlubick@google.com [canvaskit] Replace RRect objects with TypedArrays. 2020-09-02 johnstiles@google.com Replace empty Block with Nop statement. 2020-09-02 herb@google.com simplify fill vertex calculations 2020-09-02 brianosman@google.com Disallow some combinations of program element and program kind 2020-09-02 johnstiles@google.com Ensure that inlined if/else blocks are properly scoped. 2020-09-02 ethannicholas@google.com Disallow a bare ';' at the top level of SkSL files 2020-09-02 brianosman@google.com Remove some leftover double types from SkSLContext 2020-09-02 johnstiles@google.com Add unit tests for inlining if/else blocks. 2020-09-02 egdaniel@google.com Remove unused GrVkDescriptorSetManager factor. 2020-09-02 johnstiles@google.com Ensure that inlined statements are properly scoped. 2020-09-02 mtklein@google.com add missing clamp to SkColorFilter_Matrix 2020-09-02 mtklein@google.com update SkNx allTrue/anyTrue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Icdeb51709f2e37d30368b29f3aa912e66ddf3ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804066}
-
Sasha McIntosh authored
This is a reland of 08ad21a9 Original change's description: > blink: Enable JPEG YUV decoding on TOT > > The JPEG YUV decoding experiment has concluded and can now be enabled on > TOT. This change enables YUV decoding for JPEG images by default and > removes the field trial testing config. > > Bug: 919627 > Change-Id: Ic3742750af59fa3b4e6dedc2f55424d4a87afcad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216712 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772724} Bug: 919627 Change-Id: Ib162ea913ab0fdf588206d8ea0560cbbf259cb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386487Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804065}
-
Xianzhu Wang authored
When a caret is active, now we always paint it in either the desired color or the transparent color according to the blinking state. This prepares for composited caret which will use an opacity effect node to control the visibility during blinking. The always painted display item for the active caret won't cause performance issue because the paint opearation is trivial. It may actually make PaintController and RasterInvalidator more efficient when matching display items sequentially (without appearing/disappearing display items). Bug: 1123630 Change-Id: I507e1f5014040e8aecceb83346e5f28973f16c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391002Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804064}
-
Natalie Chouinard authored
Use ICU case folded full font names as keys for the font lookup table to be consistent with the local unique name matching done by Blink for firmware font files. Bug: 1111148 Change-Id: Ia94b11e10ffa53582c46020eeafb5524108e9914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389224 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804063}
-
Ben Pastene authored
Telemetry shouldn't touch ARC on the system, so these suites on this bot are unnecessary since we have them running on the normal eve bot. Bug: None Change-Id: I6ab0ec3de5d5bd9569858fb8ffa850e5c800fb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391659 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804062}
-
Daniel Cheng authored
Bug: 1122072 Change-Id: Ic89dc4c0ff343da1cc989f242070735a11811644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381066 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804061}
-
Daniil Lunev authored
Factored out from https://chromium-review.googlesource.com/c/chromium/src/+/2379383/ Bug: b:151176984 Change-Id: Ia089d35ab8c5597732af5b136b75db5a50d9ff97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379460 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804060}
-
Hui Yingst authored
setDocumentMetadata_() has 3 parameters, which all comes from the same structure MetadataMessageData. This CL makes setDocumentMetadata_() only takes one MetadataMessageData type parameter instead. Bug: 177188 Change-Id: I59c53252d91996ac13824c60ae1e7b276feb940e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386297 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804059}
-
Sahir Vellani authored
This change implements percent based scrolling for mousewheels on linux as part of the scrolling roadmap. If percent based scrolling is enabled, mousewheel scrolls will now be percent based scrolls. This is already implemented on Windows. Bug: 1101535 Change-Id: I91cf774a2dc3fe5e129939c64a0e5bc645b8fe9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354663Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804058}
-
Akihiro Ota authored
Text content was originally added to the tab order with the intention to make it more accessible. However, this goes against common practices on the web and could lead to confusion. Therefore, we are removing text content from the tab order. Bug: 1124064 Change-Id: I3e6ff0868b8d7c02ebc41a6a87b202602dfc5968 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390870 Auto-Submit: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#804057}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9bc506e0ab0..c35e2ba3798e 2020-09-02 rharrison@chromium.org Remove usages of SPVC 2020-09-02 enga@chromium.org Cleanup: always clear Vulkan textures with vkCmdClear*Image 2020-09-02 enga@chromium.org Cleanup: Make TexelBlockInfo a member of Format, not superclass 2020-09-02 cwallez@chromium.org Make ShaderModule reflection go through EntryPointMetadata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iacaf0959b87260b636fc1d6f08fbce7b2fb13ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391669Reviewed-by:
-
Tommy Li authored
No one is looking at these histograms anymore, and they are blocking removal of ZeroSuggestVariant. Also anything that simplifies ZeroSuggestProvider is a good thing. I checked with ender@ already, who originally added these histograms, and it's fine to remove these. Bug: 1123688 Change-Id: Idcb760d0969ad74577c0f3555d2020730a1dda1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388898 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804055}
-
Kyle Horimoto authored
This was missed when originally creating the class. Bug: 1106937 Change-Id: Iad47abb34673a5556518f03fe82ed4c04f74d729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391650 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804054}
-
Evan Stade authored
This relands commit 78a7ace4. The original change somehow passed the CQ, and was reported to be flaky, but I believe it was deterministically failing. The failure was on a new assert in SelectFileDialog. This CL fixes the issue by moving the onPhotoPickerDismissed call into PhotoPickerListener, so that the tests, which don't involve SelectFileDialog, won't call into it. This also has the nice effect of removing the direct dependency from photo_picker on SelectFileDialog. Original change's description: > Remove ApplicationStatus usage from PhotoPicker. > > ApplicationStatus only works in //chrome. See crbug.com/470582 > > Bug: 1110930 > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803247} TBR=dtrainor@chromium.org Bug: 1123848,1110930 Change-Id: Id5c0ae00b85d97cb5121acf1ece8d37ac8e2d021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387624Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804053}
-
Wei Li authored
Remove the last few uses of set_owned_by_client() in tests. After this change, the only one case left is testing the set_owned_by_client()'s behavior itself. Bug: 1044687 Change-Id: I29a5d3aa307040899dbfab10bed7f2bf834bc8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388990Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#804052}
-
mhasank authored
In order to better understand the feedback reports, adding logging in key events of arc provisioning process. BUG=b:162221783 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: I3f5cbfd0cb023c43982e15a5aba724901a4fe3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377229 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#804051}
-
Jon Mann authored
Fixed: 1123781 Change-Id: I45458f24df0c77f97f2997a7384618262b18af47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387309 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804050}
-
Amr Aboelkher authored
Executes PSM determination if its switch is enabled during the initial enrollment. Then, upon completion, it will execute hash dance. As the whole PSM functionality is being controlled by a switch, its possible to split its basic functionality and its tests in follow up CLs. Test: Will be added in a follow-up CL Bug: chromium:1119581 Binary-Size: Increase is temporary. Change-Id: I4473ef0617cc9f7e4594130bcefe57bab12ed7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365952Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#804049}
-
nancylingwang authored
When more than 200 Arc apps are installed, due to different icon size, scale, too many files are opened, causing the system crash. Add a limitation to control icon loading requests to be less than 250. If there are more icon loading requests, add them to the pending list, and when some icon requests finished, continue loading icons from the pending list. Modify ArcAppIcon to observer_->OnIconUpdated to notify the observer for all error cases, because the observer in AppService depends on the notification to update the pending list and the in-flight list. BUG=1123796 Change-Id: I00ab3be5326e21574c1757cedacd7701e8b66710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386688Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804048}
-
yilkal authored
This CL introduces EDUCoexistence ARC Migration UI. The UI is triggered only in the following scenario: 1. The supervised user has an EDU account on device. 2. The EDU account has not yet been added to ARC++. Regardless of the number of EDU accounts on the supervised user, the migration ui will be shown only once. Bug: 1115313 Change-Id: Ieded997c99be6708bef7d441aa5d07ce3b1cf95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360575Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804047}
-
Donn Denman authored
When we don't send page content for privacy reasons we also should not preload the SRP. We were doing this for performance reasons, and there were some other benefits, but solid privacy is more important. Also improve some test names. BUG=1122690 Change-Id: I6d459007e90ec94c87ebf35feb8810a87ce8cd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380746Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804046}
-
Kent Tamura authored
It sets fixed values depending on platforms. The values can be represented by UA stylesheets if we add a pseudo class to check |input->list()|. This CL introduces a UA-only pseudo class, :-internal-has-datalist, and converts LayoutSliderContainer::ComputeLogicalHeight() to CSS rulesets. This CL has no behavior changes. Bug: 1040826 Change-Id: I996bb887fa18856a32a9670b91e09ad3ec315562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387917Reviewed-by:
-
Alexander Hendrich authored
This CL: * Adds a new ExternalCacheDelegate::OnCachedExtensionFileDeleted() method, which is being called when the cached .crx file is removed from cache. * Adds SigninScreenExtensionsExternalLoader::OnCachedExtensionFileDeleted(), which reacts to the deleted file by removing the extension from the PendingExtensionManager, which allows a re-installation to occur. Bug: 1115905 Change-Id: Ie04986e08a8c3c67a5ef4d36e7eb1f8f42334046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366801 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
minch authored
Bug: 1106012 Change-Id: I56a91c30a9743570c0377a8e57e8b341c8698743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388707Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#804043}
-
Ahmed Mehfooz authored
Bug: 1124145 Change-Id: I620444d44648a2b1d408f12a1b9137c23012e72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388859 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804042}
-
Ryan Sturm authored
Bug: 1032153 Change-Id: I6202ac7ece548ba8a5f63ef36a2151fc9cd7e3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391584Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#804041}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7642c19404f..3ffd1d826be3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic7cbbe4bbb319608838aac900dd111803f983d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391046Reviewed-by:
-
Daniel Classon authored
Renames the Cups Printer tests to reflect that they work with the cups_printer.html page. This helps with deep linking by making room for a test for the actual os_printing_page. Bug: 1084154 Change-Id: Ia2884b16bf488f0079e781191452826b4d606fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391509Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Yuly Novikov authored
conformance/ogles/GL/acos/acos_001_to_006.html conformance/ogles/GL/asin/asin_001_to_006.html Flaky DCHECK on multiple configs - Intel, AMD, Metal, OpenGL TBR=bsheedy Bug: 1108676 Change-Id: I0e81ad898cca9e0f862511c8d732ed89372858d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391589Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This issue was caused because allow roaming is a device level property in Shill but it's represented at network level in ONC. Fixed this by adding a request for network properties after device state is updated. Also added a test case to cover this. Fixed: 1123143 Change-Id: Icf7babb11a4e27cd22b081bdc9abc19036f60666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389230 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804037}
-
Ahmed Fakhry authored
This CL implements the image capture part of this feature, from all the possible sources, and handles saving the image files and showing preview notifications as well as error notifications. Later CLs will implement logic to disable capture mode operations such as policy or Data Leak Prevention (DLP). BUG=1121699 Change-Id: I6dfba6f57adb0c48270b4d5ebb71e7d28fe489df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376476 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#804036}
-
Karandeep Bhatia authored
Make it explicit that these fields match the request initiator. BUG=1120739 Change-Id: I380def94e0a92a8aa6a523896f146d3b27579b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388775 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804035}
-
Alice Boxhall authored
This is a reland of b89144a4 Original change's description: > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > AX-Relnotes: n/a > > Bug: 1114959 > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803007} TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Bug: 1114959 Change-Id: I1997496df505691103568989a9cbfaa38e4e9b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388025Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#804034}
-
Daniel Classon authored
Adds deep links to the Files Page. Bug: 1084154 Change-Id: I29729a708f640d32bcb89e6fdd61bedfafe9d67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389161 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Himanshu Jaju authored
- Added bug for ice candidate cache - Removed shared clipboard TODOs with my name Change-Id: Ia9ae308c7af05a13bca299fd96310bb82bd2f76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390901Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#804032}
-
Marijn Kruisselbrink authored
Rather than extracting the origin a token is associated with from its FileSystemURL, store the URL separately. This lets us use FileSystemURLs that don't have an origin (or in the future move away from FileSystemURL entirely). Other classes that have a FileSystemURL and are associated with an origin (i.e. NFSHandleBase) already stored the origin separately, this just bring TransferToken in line with those. Bug: 1093653 Change-Id: I26aeabce7bf35ad74e6beb3ffcb49d50b33d034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391179 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#804031}
-
