GitLab

This reverts commit 6c9388f9.

Reason for revert: Broke compile on ios-device-xcode-clang bot: https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120239

Original change's description:
> Allow FROM_HERE to be backed by base::Location::Current().
> 
> This allows the functionality of base::Location::Current() to be
> verified in releases while still allowing a simple revert.
> 
> One minor difference from before is that the helper macro
> FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since
> cc::BeginFrameTracker is the only user of this macro and doesn't
> appear to need it, just revert it to use FROM_HERE directly.
> 
> Bug: 974061
> Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Auto-Submit: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731804}

TBR=danakj@chromium.org,dcheng@chromium.org,jbroman@chromium.org,altimin@chromium.org

Change-Id: I4d545b08f3e784cb9302ad1fb1541741296af726
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000439Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731812}

BUG=chromium:1014871

Change-Id: I25e48d51150e9d4291a98fb7e68fa7319e5de734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001722Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731811}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I91f14629f573a7ad95191a2b5b1c5c8f979cf48f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001858Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731810}

Update InstantTethering, SmartLock/EasyUnlock, CryptAuth, and AndroidSms
prefixed histograms to use the same expiration date and all use
better-together-dev@google.com as a secondary contact.

Also mark obsolete old EasyUnlock histograms which have not been
emitted to in nearly a year.

Fixed: 1036924,1037011,1037061,1037298,1039343
Change-Id: Ibff0384bfc3f0c7c60a1f23b7fc76dcb1823b42a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992801Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731809}

Bug: 1007788
Change-Id: I52a2b0a15d8962f312f41a9fb1e227c911d5f410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997425Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731808}

Fixes a regression where emoji fonts don't render on Ubuntu 19.04. The
regression was caused by [1] in the previous roll and is fixed by [2] in this
roll.

[1] https://gitlab.freedesktop.org/fontconfig/fontconfig/commit/c4324f54ee16e648ba91f3e9c66af13ab3b1754c
[2] https://gitlab.freedesktop.org/fontconfig/fontconfig/commit/c9862b6ea7c3234b29f6500c7d07359847e55ed7

https://chromium.googlesource.com/external/fontconfig.git/+log/cd51cb241aad..452be8125f0e

$ git log cd51cb241..452be8125 --date=short --no-merges --format='%ad %ae %s'
2019-12-09 akira Add proper fullname for named-instances
2019-12-05 akira Fix a test fail when no bwrap was available
2019-11-28 akira Don't add a value for FC_FULLNAME in meta face
2019-11-20 jtojnar Correct reset-dirs in DTD
2019-11-06 akira Fix gcc warnings with -Wpointer-sign
2019-11-02 akira Fix potential race condition in FcConfigSetCurrent and FcConfigReference
2019-11-01 akira Use FcConfigReference/Destroy appropriately instead of FcConfigGetCurrent
2019-10-31 akira Fix a memory leak caused by the previous commit
2019-10-28 akira Read latest cache in paths

Created with:
  roll-dep src/third_party/fontconfig/src

R=spang

Bug: 1039967
Change-Id: I48105b81d00be43d88ae8e8581f779f52eb08093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001839
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731807}

Bug: 1041031
Change-Id: I4e6f3c0d09633ca27513258d3c9d078168ccf908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993733Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731806}

These errors should only occur when the X server is buggy, which we can't do do
much about. Continuing running seems to be harmless (tested in an X11 forwarding
environment), so just remove the DCHECKs.

BUG=1029486,701023
R=sky

Change-Id: I751991f8a2c222679ecb690349beaafff8e2ba49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947188Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731805}

This allows the functionality of base::Location::Current() to be
verified in releases while still allowing a simple revert.

One minor difference from before is that the helper macro
FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since
cc::BeginFrameTracker is the only user of this macro and doesn't
appear to need it, just revert it to use FROM_HERE directly.

Bug: 974061
Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731804}

Bug: 1042015
Change-Id: Ic1ad4c0902725bc0a096b72f05f5fab92ef9d4d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001265
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731803}

Using wpt-import in Chromium 3ab2bcb8.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I765e541eef5251da1cfbc1898b2135086bb608fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001159Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731802}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69949ed05dcf..676a4d7d6cca


Created with:
  gclient setdep -r src-internal@676a4d7d6cca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1020004,chromium:1041140,chromium:790886
Tbr: jbudorick@google.com
Change-Id: I464791cb73ee70fb7a98032d646c995dfae1fdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001690Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731801}

Add render tests for RadioButtonWithDescription, RadioButtonWithEditText
and RadioButtonWithDescriptionLayout.

Bug: 1036470
Change-Id: I793aa1a17f65f6c0a2ced6a83b6216cc5df8c227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984752Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731800}

This CL updates the list of default search engines with rankings
determined by data collected in 2019.

Bug: 1025000
Change-Id: Ifb4412ae046639681a3f5c242e188615b5ab3d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918334
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731799}

The shelf_widget_ has its bounds set with an animation, which means the bounds
do not change immediately. With this CL the starting position of the
animating_background_ will then use the current bounds of the shelf_widget_,
instead of the target bounds for the animation. This will stop the
animating_background_ from jumping at the start of its animation.

Bug: 1040708
Change-Id: I0b187cffd4654c1d3a6082ebf928014a3698d4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994521Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731798}

Currently the referrer policy browsertests' JS files read
query params by dead-reckoning using a regex. This causes
browser blackscreens when you add additional query params.

This change fixes this problem by updating the tests to use
JS's URLSearchParams (which didn't exist when they were
originally written).

Change-Id: Iab72ae6b5e213d841f896294117662d23c4cca4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000963Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731797}

Missed this in the previous CL.

Bug: 1023483
Change-Id: I7b1876ef066f3278dd0eeec7f5a2cbe4d40f199c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001841
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731796}

Introduce a helper WebGLRenderingContextBase::GetContextTaskRunner()
and use it uniformly when posting tasks related to query objects, sync
objects, and timer query objects.

Tested with WebGL conformance tests being added in
https://github.com/KhronosGroup/WebGL/pull/3004 .

Bug: 1010877
Change-Id: I36128dca93fc7ff490abf503991b82992d9861d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999486Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731795}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ce09ca54f86e..2a04803267c6

git log ce09ca54f86e..2a04803267c6 --date=short --first-parent --format='%ad %ae %s'
2020-01-14 ehmaldonado@google.com my_activity: Make compatible with Python 3.
2020-01-14 ehmaldonado@google.com subcommand: Add tests.

Created with:
  gclient setdep -r src/third_party/depot_tools@2a04803267c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1009820
Tbr: agable@chromium.org
Change-Id: I270bf8c5b5cbccb7b17ff60cbfa27faa672d88e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731794}

This fixes a bug that CopyVideoFrame() copies by a visible size
only. The function should copy by coded size, otherwise a real
visible size is not copied when the visible area begins with
non-(0, 0) point.

Bug: None
Test: IPTest on atlas
Change-Id: I2412e6bcc72c7a5668e8dca15f126c2e16979976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000435Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731793}

BUG=1041909

Change-Id: Ib3a7729f3c37ceab0486638fbf0984401123f015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001840Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731792}

Bug: 1026712
Change-Id: I3de05d154bf0460c4876b9142dc3b6013927e167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999544
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731791}

Support WebXR input events while DOM Overlay is active, using a new
"beforexrselect" event to let applications deduplicate input. If that
event is preventDefaulted, i.e. on UI elements, XR input events
are suppressed. If the interaction is in a cross-origin iframe, suppress
XR select events and input updates.

See the draft spec https://immersive-web.github.io/dom-overlays/ for
background information.

Bug: 991747
Change-Id: I3c058454cfcee732a544863bbf6b807437513c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974820
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731790}

Generational barrier will require slot in the context. To make code
compatible the CL changes the signature of the common WriteBarrier
function to accept slot instead of value. Since the write barrier
function is always inlined this shouldn't affect performance.

Bug: 1029379
Change-Id: I430908bcc7a0eea4da91dc09bfbcd3f1899f18dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000918Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731789}

The lifetime of CrostiniExportImportNotificationController used to be
1to1 with the lifetime of the NotificationUI. This is unnecessary and
makes it harder to reuse this functionality more broadly (see
https://chromium-review.googlesource.com/c/chromium/src/+/1985621/3 for
an example which has very complicated lifetime management due to this).

This CL separates the Controller's lifetime from the UI's lifetime by
extracting the Controller's UI event handling logic (clicking/closing)
into a delegate which the controller creates, such that its lifetime
is 1to1 with the UI, thus allowing the Controller to be destroyed at
anytime without affecting the behaviour of the UI.

Bug: 1024693
Change-Id: I6c67016f862e80dcd1c92a12d507f484c28fe4de
tbr: stevenjb@chromium.org
tbr: tengs@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991060
Commit-Queue: Julian Watson <juwa@google.com>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#731788}

Change http://crrev.com/c/1881695 tried to set SuggestionSpans for
spelling errors, but some corner cases are resulting in us trying to
set something out of range. Add a check for that.

Bug: 1025723
Change-Id: If506df13049d5abfd89e15081109bc0682a07cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998467Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731787}

The chrome.loginState API was only exposed to Chrome Extensions.

This change exposes this API to the Smart Card Connector, which
is a Chrome App. The Connector app needs this API in order to
fix an issue related to user session states (details on the bug).

Bug: 1034927
Change-Id: I17a3d5fb7446ae65b9ef500011615a20b841c4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970311
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731786}

This patch only modifies the min-width: auto case for tables by skipping
the flex-specific behavior and just using the table's preferred minimum
width as calculated by legacy. We now match legacy when tables are flex
items.

But I think when the spec was updated in
https://github.com/w3c/csswg-drafts/commit/66241e4896d3e6300d8559080a0de4ee9a11fdcd,
legacy became incorrect in cases where min-width is specified. Compare
css/css-flexbox/table-as-item-fixed-min-width.html with
http://wpt.live/css/css-flexbox/table-as-item-auto-min-width.html . The
only difference is an additional min-width: 5px that should have no
effect but does, see https://i.imgur.com/yMxUdeI.png for how the new
test renders in legacy.

An older patchset (3) does what I think is the newly-correct behavior,
which also says that
http://wpt.live/css/css-flexbox/table-as-item-wide-content.html is
invalid -- the green square should be 500px wide.

Bug: 845235
Change-Id: Ica870fe3aa12fc1fbeb2388c0f2c69263c5e8860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995617
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731785}

This reverts commit ce400cdf.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Ash Tray: Fix quick settings not closing after clicking on a notification."
>
> This is a reland of b622130a
>
> Original change's description:
> > Ash Tray: Fix quick settings not closing after clicking on a notification.
> >
> > BUG=1024100
> >
> > Change-Id: Ib30e43689842069e4647f7f455a919c62a3c7844
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928042
> > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#717775}
>
> Bug: 1024100
> Change-Id: Ie4e4435f0b336b77e856705512a21911704a95b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962799
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#725204}

TBR=amehfooz@chromium.org,tengs@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1024100, 1041174
Change-Id: Ica74c49ad4de3123e15196ad8ce39a09d718cb1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001845
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731784}

Bug: 1029822
Change-Id: I87a379cde39641431a0099ffd8bb982128c51a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001738
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731783}

Prevent a user from clicking Start recording on multiple pages at the same
time by disabling all Start recording buttons when one has been pressed.
This prevents a crash which would occur when a user would click
Start recording on multiple pages without stopping the recording.

Bug: 1036755, 785493
Change-Id: I58cdd9be1595dac679f4bfa488599bc198863c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997946
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731782}

The first argument to AffectedFiles is include_deletes,
so current usage sets it to include deleted files and
ignores the filter, causing checks to run on unrelated
files.

Fix it so that the source filter is passed to the right
parameter.

Bug: 962619
Change-Id: I94f550a72f2773d5fedc5949848dcd2defd5757e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610541
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731781}

The current version of the EME spec
(https://w3c.github.io/encrypted-media/) has encryptionScheme as a
DOMString with an additional value allowed ("cbcs-1-9"). Updating
the code to match this.

This also moves the feature to stable now that it has been approved.

With this change the W3C test
(https://wpt.live/encrypted-media/clearkey-check-encryption-scheme.https.html)
passes.

Bug: 1035153
Test: Updated media_blink_unittests, browser_tests, and WPT tests pass
Change-Id: I00cb2ce8a4c4f52f95817471226b5e8129660247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972617Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731780}

This class is an optimized way to share an egl fence
among multiple consumers. Once the shared egl fence
has been waited upon by any of the consumer, all the
future waits to the same fence becomes no-op since we
don't need to wait again on the same fence any more.
This saves un-neccesary gl calls issued to do wait by
each consumer.

Change-Id: I5bf0c0f9a36d2d1a2709100343a141ec8b841dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989025
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731779}

This histogram is still useful to our team, so keep it alive.

Bug: 1036934
Change-Id: I241f785dfa501139fbe4a3cabe03065fa282dbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997643
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731778}

Adds support for specifying the VideoColorSpace and HDRMetadata fields
in the VideoDecoderConfig. This shouldn't change anything at present
unless someone sets the the HDRMetadata field for H264 or VP9 in MP4
on Windows. Otherwise we generally prefer the frame color space
information.
Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Bug: b/143382177
Change-Id: I39bfb06228f5f5f67b858551e9fe67a74c79d20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001248Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731777}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=wrong@chromium.org

Bug: 1041419
Change-Id: I6759f2f2d88ecab9c71e220d6be9093720ba4a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994079
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731776}

Change-Id: Ia1ff9063898cd033bf0c3ea5e09e9d6ebcaccbd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001587
Auto-Submit: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731775}

(1) Adds myself and zentaro@.
(2) Removes the settings_forked_os_settings list, which was temporary
    and only used during the split.
(3) Removes maybelle@/jordynass@/stevenjb@ who no longer work on
    settings.

Change-Id: If00ed188bf28e9628182e4f071f0d340530d2cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001801
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731774}

This commit fixes the BufferLimitConfig content unittest by accounting
for low memory devices.

When a device has 1 GB or less of RAM,
BackgroundTracingConfigImpl::GetMaximumTraceBufferSizeKb() returns the
low RAM buffer size instead of mobile network buffer size for Android.

This commit updates the BufferLimitConfig test expectations to handle
that code path properly.

TEST=out/Debug/bin/run_content_unittests --num_retries=0
       -f BackgroundTracingConfigTest.BufferLimitConfig

Bug: 1038539
Change-Id: I53622041b06c012b9b3b06dc9df49b8587f57b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983669Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731773}