GitLab

This reverts commit 7802af1d.

Reason for revert: crbug.com/936336#c20

TBR=jbudorick@chromium.org,benmason@chromium.org

Bug: 928422, 936336
Change-Id: Ia3864bd03f1284cd1daaac85929a082972c4dcc0
Reviewed-on: https://chromium-review.googlesource.com/c/1495037Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636454}

In an effort to reduce or even ban variable shadowing, this renames a
couple of variables. I'm interested in prohibiting shadowing because I
think it might prevent potential jumbo problems.

The exact error this avoids is:
third_party/blink/renderer/core/frame/frame_serializer.cc:301:12: error: declaration shadows a local variable [-Werror,-Wshadow]
      KURL url =
           ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/frame_serializer.cc:307:14: error: declaration shadows a local variable [-Werror,-Wshadow]
        KURL url = input->Src();
             ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/frame_serializer.cc:313:14: error: declaration shadows a local variable [-Werror,-Wshadow]
        KURL url =
             ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc:110:14: error: declaration shadows a local variable [-Werror,-Wshadow]
      String uma_name = uma_percentage_preamble;
             ^
third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc:94:10: note: previous declaration is here
    auto uma_name = uma_preamble;
         ^
third_party/blink/renderer/core/frame/rotation_viewport_anchor.cc:52:21: error: declaration shadows a local variable [-Werror,-Wshadow]
    HitTestLocation location(point + point_offset);
                    ^
third_party/blink/renderer/core/frame/rotation_viewport_anchor.cc:30:19: note: previous declaration is here
  HitTestLocation location(point);
                  ^

Bug: 923510
Change-Id: I9bd46559f31e6b3fdb412cf7787b764ae84c775b
Reviewed-on: https://chromium-review.googlesource.com/c/1494659
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636453}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ef04c3c7..21541ca9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I00019ec9aa11746cf419eeb616a5aef24967c3c0
Reviewed-on: https://chromium-review.googlesource.com/c/1494718Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636452}

BUG=890790

Change-Id: Ia0e9d5c2276676ecc5e4f551218ee1aecbb62d74
Reviewed-on: https://chromium-review.googlesource.com/c/1494515
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636451}

This reverts commit 68320b85.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Android: ensuring onDestroy called between each test
> 
> The previous onDestroy in tests change only blocked until onDestroy with certain
> subclasses of ChromeActivityTestRule which called launchActivity. This change
> blocks all tests on onDestroy.
> 
> Bug: 908174
> Change-Id: I074054c28d002e012d0f6ebc95a53aadf4175eaa
> Reviewed-on: https://chromium-review.googlesource.com/c/1473330
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Auto-Submit: Sam Maier <smaier@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636023}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: Idc5c2b186615b73cd4b6a49c29c29466cce30973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908174
Reviewed-on: https://chromium-review.googlesource.com/c/1494717
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636450}

Before this CL, SyncAuthManager's |last_auth_error_| member could be
populated either by an error from Chrome's identity/token system, or by
an error from the Sync server. This was confusing and inconsistent, since
these errors have different lifetimes: An error from the Sync server
should be cleared when Sync is shut down, but an error from the identity
system should only be cleared on signout (and optimally, we wouldn't need
to cache these errors at all).
As a first step, this CL makes it so |last_auth_error_| only refers to
errors from the identity system. Errors from the Sync server are instead
generated on-the-fly, from already-existing information.

Bug: 921553
Change-Id: I646ea21220e19849df96d771ed35f1b54e4fb0ec
Reviewed-on: https://chromium-review.googlesource.com/c/1489232
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636449}

This CL takes the newly split out InterfaceFactory::Create*Renderer
methods and exposes them directly in the MojoRendererFactory.

Classes that used to wrap the MojoRendererFactory and use its return
values opaquely now have direct knowledge of the Mojo layer.

FlingingRendererClientFactory is moved to content/ because it cannot
depend on media/mojo. It also no longer needs to provide a
|type_specific_id|.

Bug: 936116
Change-Id: I37509c8c68c52dc6e2cb3488e2f41bed9c7b8396
Reviewed-on: https://chromium-review.googlesource.com/c/1489904
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636448}

At the moment the Contained Shell launches any time its feature flag is
enabled. But since we want users to toggle the experience from settings,
we added a pref to control it. This change actually enforces this new
pref by aways checking it when we try to launch the experience.

Bug: 922687
Change-Id: Icf1ffa2422bbb68fda80e22f626d48bcbe8c8c18
Reviewed-on: https://chromium-review.googlesource.com/c/1477821
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636447}

mime_util does not take extensions with a leading dot, and if you
pass in an extension with a leading dot, you will not successfully
look up a mime type.

BUG=84003
TEST=as in bug

Change-Id: I37d9b0946df61a557b3423ae8a13ae447ed6c7c1
Reviewed-on: https://chromium-review.googlesource.com/c/1493473
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636446}

This CL is a part of OnionSoup effort. It moves
third_party/blink/public/mojom/color_chooser/color_chooser.mojom to
third_party/blink/public/mojom/choosers/ and port other dependent
files to refer to a new include path.

Bug: 935938
Change-Id: I9dc107b6842a5ccdf5b116624ee7266923e07f50
Reviewed-on: https://chromium-review.googlesource.com/c/1488410
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636445}

A unit test includes prefs_names.cc which in some builds
caused duplicate symbol errors in linking.

(I get a feeling we need a presubmit check for this because
it has happened several times recently)

TBR=gayane@chromium.org

Bug: 931806
Change-Id: I942ba67f7570feed59b32694a55402db169e109c
Reviewed-on: https://chromium-review.googlesource.com/c/1494884Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#636444}

Change-Id: Ia899557b839d7c0340f1d89dbd086adeee834e73
Reviewed-on: https://chromium-review.googlesource.com/c/1489234
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636443}

Speculative fix for leak_detection benchmark, which should not have
been overriding the CustomizeBrowserOptions method.

TBR=yuzus@chromium.org,keishi@chromium.org

Bug: 936805
Change-Id: If949793f605925de8754dd0fc02b8de2c2608404
Reviewed-on: https://chromium-review.googlesource.com/c/1494879Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636442}

When Perfetto is enabled but used by the legacy Coordinator/Agent
Mojo layer, tracing is enabled through a different set of message
pipes (the Perfetto Consumer/Producer interfaces). To fully ensure
that the legacy Coordinator only calls the BeginTracing callback
when tracing is enabled for all currently running sub-processes,
we add a new API call which explicitly waits for the TraceLog to
become enabled for that sub-process before calling the callback.

This should fix some flaky tests in the perfetto_content_browsertests
suite.

BUG=839084,935642
R=dcheng@chromium.org,eseckler@chromium.org

Change-Id: I0d72cf3f393c5e68d54a489e6c7a17699e02a4e7
Reviewed-on: https://chromium-review.googlesource.com/c/1490901Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636441}

Reland Note:
{
  Previously landed:
  https://crrev.com/258ed8d55e4f8b4d99fcde72c3569b9450198092
  Reverted:
  https://crrev.com/716496fe0909bc918c410a56f6566390b12adedc

  Revert was due to failing Leak Detector bot. Issue was that the
  browser still held a reference to the V8 function for the gesture
  completion callback which was never resolved. This CL resolves
  callback when the BlinkTestRunner is reset. Original CL uploaded in
  PS1.
}

This CL makes synthetic input - the kind used in web tests and
telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame
has been submitted by the renderer and displayed by the display
compositor before resolving the completion callback. This means client
code that wants to wait until any observable side-effects of this input
is visible to further input need only wait on the gesture's completion
callback.

To give a motivating example: suppose we wish to write a test that
scrolls an out-of-process iframe into view and clicks on a button in the
frame. The code might look something like this:

gpuBenchmarking.smoothScroll(1000, () => {
  gpuBenchmarking.tap(0, 0);
});

This code contains a race today. The callback for smoothScroll is
invoked as soon as the ScrollEnd is received in the renderer. However,
until a new compositor frame is submitted from the renderer, the tap
may occur against stale hit testing geometry. This is a major source of
flakiness in our tests.

This CL fixes the problem by forcing the renderer to perform a full
redraw at the end of each gesture. The redraw produces a compositor
frame and we invoke the callback once the compositor frame is displayed.
We do this by reusing the RequestPresentation mechanism in RenderWidget.
RequestPresentation required two modifications to work in web tests
which use a single thread proxy with no scheduler:

 - LayerTreeHost::Composite needs to check the forced redraw flag to
   determine whether we need to raster, otherwise it won't produce a
   frame
 - RequestPresentation must request a main frame since there's no
   scheduler to perform the commit, which is what SetNeedsForcedRedraw
   requests.

The timing change exposed an issue in the
overlay-play-button-tap-to-hide.html test so this CL also cleans that
test up to listen to the animation changes in media controls properly.

Finally, it's possible we may get input in a RenderWidget that's not
currently displayed. e.g. A click event sent via ChromeDriver causes a
TouchStart followed by a TouchEnd. The TouchStart causes a window.open
which opens and focuses a new tab. The TouchEnd then happens on the
background tab. In this case, we should resolve the callback rather than
waiting on a CompositorFrame that'll never come. See ChromeDriver test
testNetworkConnectionTypeIsAppliedToAllTabs for an example of this.


TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org

Bug: 902446
Change-Id: Ia2f0a5a6ae51216582bf4cc1d03cb5ba724ddffd
Reviewed-on: https://chromium-review.googlesource.com/c/1490757Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636440}

Rather than just using the basename of zip paths, use the full path to
generate the temporary name so the build does not depend on resource
and string targets having unique names.

Bug: 935576
Change-Id: I8aa2d1474e768659be444db2ba7c0e6dd7e5eb79
Reviewed-on: https://chromium-review.googlesource.com/c/1492835
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636439}

This change adds a std::unique_ptr overload to base::Owned and changes
base::internal::OwnedWrapper to use an std::unique_ptr as backing
storage, simplifying its implementation.

Bug: 554299
Change-Id: Ia3eb1bf3857c7be6593d77c59e495ed90932d24b
Reviewed-on: https://chromium-review.googlesource.com/c/1482890
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636438}

https://skia.googlesource.com/skia.git/+log/1179d5dfaf8d..b7b2da871e95


git log 1179d5dfaf8d..b7b2da871e95 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 mtklein@google.com set -fcolor-diagnostics when is_clang


Created with:
  gclient setdep -r src/third_party/skia@b7b2da871e95

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: If61244d414b764c9f31bd88f9f351a7a1360a5ed
Reviewed-on: https://chromium-review.googlesource.com/c/1494818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636437}

Start: if we fail to find a free display or Xvfb fails to start
otherwise, r_w_t now quits with a non-zero exit code instead of
continuing to run the tests without Xvfb.

Stop: we first try to send SIGTERM to Xvfb and give it some time to exit
gracefully (especially to clean up the lock file); SIGKILL is only used
as the last resort.

Add test cases to test the exit code and to cover the new behaviour
introduced in https://crrev.com/c/1480700 earlier.

Bug: 933523
Change-Id: Ide791f229e54b3f98db6eb698afa162e4f17e81f
Reviewed-on: https://chromium-review.googlesource.com/c/1493201Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636436}

No intended behavior change. (It implicitly adds the flag for is_nacl
I believe, but that seems to work.)

Bug: 935588,926235
Change-Id: I785d5b5a75092be1370be77559ec9fa5d0c795f7
Reviewed-on: https://chromium-review.googlesource.com/c/1489900Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636435}

This plumbs useful debug flag down.

Bug: 908957
Change-Id: I2f1777f850cc9f485698233a615b226c95502ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1492486
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636434}

Bug: 900613
Change-Id: Ic10b32dc913f250748b760feb5afd06ebd6b26a8
Reviewed-on: https://chromium-review.googlesource.com/c/1492753Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636433}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/87c513372ff3..ad9e9432731b


git log 87c513372ff3..ad9e9432731b --date=short --no-merges --format='%ad %ae %s'
2019-02-28 vapier@chromium.org image_test: allow /usr/share/portage in base images
2019-02-28 hcutts@chromium.org gerrit: sort actions and show arguments in usage
2019-02-28 vapier@chromium.org device: use `true` for online test
2019-02-28 ahassani@chromium.org build_dlc: Add functionality to copy all DLC images to their final location


Created with:
  gclient setdep -r src/third_party/chromite@ad9e9432731b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Icb255137af8baafa82b9da34a59e4e538fcbde0c
Reviewed-on: https://chromium-review.googlesource.com/c/1494821Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636432}

wherever apropriate.

Bug: 932591
Change-Id: Idc4378c1c6b4d70f0fcdbc4b98221e15cef9dba4
Reviewed-on: https://chromium-review.googlesource.com/c/1494067Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636431}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00be6aaa4a3e..73263e44dae6


Created with:
  gclient setdep -r src-internal@73263e44dae6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I768002350f2c9d337a2956fbe223bfcbbee83655
Reviewed-on: https://chromium-review.googlesource.com/c/1494819Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636430}

https://chromium.googlesource.com/angle/angle.git/+log/4b314eefc839..5de69e91bd93


git log 4b314eefc839..5de69e91bd93 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 jmadill@chromium.org Add watchlist file for ANGLE.


Created with:
  gclient setdep -r src/third_party/angle@5de69e91bd93

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:none
TBR=ynovikov@chromium.org

Change-Id: I46e3d604dd73d238539417dd668d3397509a31e8
Reviewed-on: https://chromium-review.googlesource.com/c/1494820Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636429}

https://dawn.googlesource.com/dawn.git/+log/31ac9850ad0f..2dfb3f01e77d


git log 31ac9850ad0f..2dfb3f01e77d --date=short --no-merges --format='%ad %ae %s'
2019-02-28 cwallez@chromium.org DawnTest: Allow checking for device errors.


Created with:
  gclient setdep -r src/third_party/dawn@2dfb3f01e77d

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I4501c136a97809d9fdd97db05bd88cc09f5bcfe3
Reviewed-on: https://chromium-review.googlesource.com/c/1493107
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636428}

This is a follow-up change of https://crrev.com/c/1483351/.
aura::Env::GetInstance() is Chrome's env but this code needs Ash's.

BUG=b:124258894
TEST=cheets_CTS_P.9.0_r6.arm.CtsViewTestCases autotest passes.

Change-Id: I45226e4bc44fa11f2a9a0597dc28f7c598dce7ba
Reviewed-on: https://chromium-review.googlesource.com/c/1493640
Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636427}

Change-Id: I785ec03fb47b6da59700fd2456c4796c51893315
Reviewed-on: https://chromium-review.googlesource.com/c/1491893
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636426}

Makes it easier porting new features over and editing BUILD.gn files.

Bug: None
Change-Id: I2012addc54df4ee62581d7fade7402e9e486b2e9
Reviewed-on: https://chromium-review.googlesource.com/c/1494934
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636425}

The scheduler processes multiple requests concurrently, and the
in-progress bytes were being overwritten by the latest request to
send an update.

This change also makes sure that the Response Size is available as soon
as the download is complete, rather than after the response blob is
created.

Bug: 919864
Change-Id: If81b0a11d664083bf16eceaca0c7b82d78f6e030
Reviewed-on: https://chromium-review.googlesource.com/c/1460933
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636424}

https://webrtc.googlesource.com/src.git/+log/2c7964832eac..25fb765367e1


git log 2c7964832eac..25fb765367e1 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ec3bf6e6..16b06806 (635450:636404)
2019-02-28 hbos@webrtc.org rtc::Thread::PostTask() added.
2019-02-28 tommi@webrtc.org Remove dependency on DECLARE_IUNKNOWN macro on Windows.
2019-02-28 titovartem@google.com Fix call setup: change way of adding media to the call.
2019-02-28 peah@webrtc.org Add flag for explicitly specifying that the legacy AEC2 should be used
2019-02-28 danilchap@webrtc.org Create conversions between webrtc::TaskQueueBase and rtc::TaskQueue
2019-02-28 hta@webrtc.org Add SCTP transport to the public API.
2019-02-28 danilchap@webrtc.org Migrate SequencedTaskChecker to rely on webrtc::TaskQueueBase interface
2019-02-28 ivoc@webrtc.org Move command line flags out of NetEqTestFactory
2019-02-28 titovartem@google.com Introduce test case name in peer connection e2e test framework.
2019-02-28 titovartem@google.com Reland "Improve example video analyzer for use in debugging"
2019-02-28 titovartem@webrtc.org Revert "Improve example video analyzer for use in debugging"
2019-02-27 titovartem@google.com Improve example video analyzer for use in debugging
2019-02-27 Peter) Slatala Pass the x-mt line from SDP to the media transport
2019-02-27 Peter) Slatala Add a parser for the x-mt line.
2019-02-27 benwright@webrtc.org Added underscore to dtls_transport_unittest.cc.


Created with:
  gclient setdep -r src/third_party/webrtc@25fb765367e1

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:818643
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib1aa3f7f503e2742aaf3f06787d3cf77c2d67206
Reviewed-on: https://chromium-review.googlesource.com/c/1494816Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636423}

Bug: None
Change-Id: I4c203819f8a18d4d7858eb36cdd8af81f37cfcdd
Reviewed-on: https://chromium-review.googlesource.com/c/1494795
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636422}

Using wpt-import in Chromium 72511a7e57f7353b83d96d35b603545efaf5fa6b.
With Chromium commits locally applied on WPT:
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"
a6d9cfda "[WPT] Changes to generated files by CL 1476144"
4665f96b "RestrictDeviceSensorEventsToSecureContexts by default."
03505df6 "[Origin Policy] Implement error reporting via Reporting API"
cdbd3b67 "Fix flakiness of external/wpt/css/css-position/z-index-blend-will-change-overlapping-layers.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
meade@chromium.org:
  external/wpt/web-animations
mlamouri@chromium.org:
  external/wpt/screen-orientation

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Ia74d65451add96d5707ae6d13839a4bcf3990a0e
Reviewed-on: https://chromium-review.googlesource.com/c/1494974Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636421}

Eliminates the internal null Module state in favor of nullptr.

This is a reland of e6314175.

Bug: 931418
Change-Id: Idd08d4029d9ee60ab8b132e4216a2104bdf865d9
Reviewed-on: https://chromium-review.googlesource.com/c/1490736Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636420}

https://chromium.googlesource.com/catapult.git/+log/afd6d361b5b7..3c7b056c0c8b


git log afd6d361b5b7..3c7b056c0c8b --date=short --no-merges --format='%ad %ae %s'
2019-02-28 perezju@chromium.org [Telemetry] Add TimelineModelIntegrationTests


Created with:
  gclient setdep -r src/third_party/catapult@3c7b056c0c8b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:933343
TBR=sullivan@chromium.org

Change-Id: I825e9dcdc7f97e9dafb0596f25ca108727c696ca
Reviewed-on: https://chromium-review.googlesource.com/c/1494435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636419}

https://android.googlesource.com/platform/external/perfetto.git/+log/1eac440c1718..160b5823ac4f


git log 1eac440c1718..160b5823ac4f --date=short --no-merges --format='%ad %ae %s'
2019-02-28 rsavitski@google.com Remove ability to force DLOG/DCHECK via cflags in gen_android_bp
2019-02-28 taylori@google.com Merge "perfetto-ui: Fix query for process summary"
2019-02-28 taylori@google.com Merge "perfetto-ui: Show time offset within the trace"
2019-02-28 taylori@google.com Merge "perfetto-ui: Add show/hide button to selection panel"
2019-02-28 hjd@google.com Merge "perfetto_cmd: Add flush_period_ms when using basic cmdline"
2019-02-28 lalitm@google.com Merge "trace_processor: don't print extra new line in print events"


Created with:
  gclient setdep -r src/third_party/perfetto@160b5823ac4f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iaba111b792fca431081be8874ae0742037253daf
Reviewed-on: https://chromium-review.googlesource.com/c/1494817Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636418}

The crash occurs since http://crrev.com/c/1478667. It is caused because
mRawLineItems is set to null but the third-party Android payment app
doesn't checkt whether displayItems is null or not. We should always
make the mRawLineItems non-null before passing it to third-party payment
app.

Bug: 936832
Change-Id: Ief0aed549f23e45691c60c00ec7ae605e55a0cb7
Reviewed-on: https://chromium-review.googlesource.com/c/1495154Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#636417}

This reverts commit 0df81bc2.

Reason for revert: iOS support was needed

Original change's description:
> OOR-CORS: Introduce ResourceRequest::cors_exempt_headers
>
> Now ResourceRequest has multiple special header entries that are aimed
> for escaping from CORS checks for internal uses. This patch introduces
> cors_exempt_headers to handle this kind of entries in an unified way.
>
> Also this patch removes {Get|Set}ClientDataHeader interfaces from
> WebURLRequest because these should not be used in Blink.
>
> Bug: 870173
> Change-Id: I5ae5a4a58df30e54064da5b7ab74abb69c9e42a7
> Reviewed-on: https://chromium-review.googlesource.com/c/1445178
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630268}

TBR=kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,yhirano@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Try: True
No-Presubmit: True
No-Tree-Checks: True
Bug: 870173
Change-Id: I8338f6a7ea44b74efb526026c29f79728757513b
Reviewed-on: https://chromium-review.googlesource.com/c/1495197
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636416}

This CL exposes more API like RegisterProfilePrefsForServices() in
SimpleDependencyFactory. These are required to create testing factories
in a follow up CL (https://crrev.com/c/1492422/).

Change-Id: I13f6d59472cb293f7b6d1d2967674fc44035ad5a
Reviewed-on: https://chromium-review.googlesource.com/c/1492711Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636415}