GitLab

The DumpAccessibilityTree tests generate an output text file and diff
the results against an expected file. Previously, the way that the
algorithm handled files of different lengths was by adding an
end-of-file sentinel to the end. This resulted in that sentinel
getting checked in, which was just confusing.

Fix this by modifying the DiffLines helper function to properly compare
files that don't have the same number of lines. Add full unit tests for
DiffLines so we can be confident it works.

Continue to LOG the end-of-file sentinel, because it's needed by
running rebase_dump_accessibility_tree_test.py to parse actual output
files from remote logs.

Bug: none
Change-Id: If1bcef063822fd5786acaeff9133c05d5fc5b065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109458Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751791}

It was inconsistent to not always  check for "ignored but included in
tree" changes in the same place as "ignored" changes.

Both are checked here, for example here:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/accessibility/ax_object.cc?q=ax_object.cc&sq=package:chromium&l=965

Bug: None
Change-Id: Id43b414eb7665866d0822bf95ee4b3e0605f6604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107605
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#751790}

These setters have only one caller (SVGResources::BuildResources), which
null-checks these already, so no need to do it again. Replace with
DCHECKs.

Change-Id: Ia61537ca39c792b00502b3e1e41823bf2fa87b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108736
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751789}

* Add real localized text.
* Make text grey via "secondary" text styling.
* Retitle "Turn on" and "Turn off" buttons per latest UX spec.

https://screenshot.googleplex.com/RzQAQfbvwqC

Bug: 1013466
Change-Id: Ibae11cf543479c2038252525282bf6c4511a11f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108098
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751788}

Also, remove the ExpirationDateFixFlow flag as it is enabled by default.

Bug: 1062629
Change-Id: Iaa44f743153fc4465a511a18ba98cc10624eb8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109475Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751787}

When Chrome apps, e.g. google photos, change the open method from
windows to tabs, the app_id could be changed, because extensions might
get the app_id from tab, and then get the app_id from URL.

If both the Chrome app and web app are installed, extensions might get
the web app app_id based on the URL, so when the tab is active or
inactive, check the instance for the window first. If there is an
app_id, reuse that app_id, otherwise, get the app_id from extensions.

BUG=1011235

Change-Id: Ia0a396b9d5ebe9eac713d867359d941276f83011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106991Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751786}

Make AppListController methods for getting app list visibility display
aware. They're used by shelf to determine shelf background properties
(e.g. background type) which may differ by display, so global app list
visibility does not work for that case.

Better handles display change in AppListPresenterImpl::ToggleAppList. It
tapping home button on the display where app list is not shown now
dismisses app list if visible on another display, and also show the app
list on the target screen (instead of requiring two taps, as is the case
today). Makes ToggleAppList dismiss the app list on another display
immediately, so the display visibility change happens before the new
app list visibility starts changing.

BUG=1060686

Change-Id: I1dfb2f7ce0c11c1fc166d9fc61794c48b4379ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109332
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751785}

Also changed CallOnGraphAndReplyWithResult to be static.

Bug: 1013127
Change-Id: I99e7b0d54714efb73181ba5cc6bcec015bb1058c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107901Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751784}

Move the code that used to be on the internal repository to the chromium
repository. The code is unchanged except for the following:

* There is no more need for Fido2ApiHandlerInternal, so that logic is
  moved to Fido2ApiHandler.
* We no longer use AppHooks to acquire the API handler. Embedders
  interested in implementing WebAuthn on android no longer have to
  implement those bits. I also added a TODO to remove the ApiHooks entry
  point. We can't remove it until we clean the downstream repository.
* IsUVPAA is unconditionally delegated to FIDO GMS Core.
* The minimum GMS Core APK version has been bumped to support the
  current FIDO GMS Core version (18.1), and the constant is now
  centralized to Fido2ApiHandler.
* Tests won't run if the bot has an old GMS core version instead of
  waiting to set up and then doing nothing.

This patch increases the chromium binary size by ~65kb and the method
count by ~530. After the downstream code is cleaned up, the chrome
binary size will decrease by ~55kb and method count by ~430. The ~10kb,
~100 method count difference is caused by the updated FIDO2 library
that is being used in this patch.


Fixed: 1059401
Change-Id: I940d80ccf1610545d6801cd9d337b2b14e973459
Binary-Size: 55kb temporary, 10kb unavoidable.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095414
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751783}

This patch removes back-end support for simulating the following
vision deficiencies:

- achromatomaly
- deuteranomaly
- protanomaly
- tritanomaly

As captured in our documentation ([1]), the abovementioned vision
deficiencies represent a broad spectrum, ranging from a slightly
reduced sensitivity to (for example) red light (in the case of
protanomaly) to a more severe lack of sensitivity to red light.
However, our built-in simulation presets can only represent a single
point on this spectrum. As Ian Hamilton points out [2], despite our
docs, this could give the false impression that most people with
protanomaly see in the way that our simulation indicates.

The most extreme form, i.e. the complete inability to perceive red
light, is protanopia instead of protanomaly. Being able to simulate
protanopia is sufficient; designing for protanopia means you’re
accessible to any severity of protanomaly anyway. The same goes for
the other vision deficiencies.

With this patch, the list of vision deficiencies DevTools can simulate
becomes:

- blurred vision
- achromatopsia
- deuteranopia
- protanopia
- tritanopia

Note that for blurred vision, the same logic applies: not everyone with
blurred vision sees in exactly the way DevTools indicates. However,
since blurred vision is a much more commonly-known vision deficiency,
the potential for confusion is lessened.

[1]: https://developers.google.com/web/updates/2020/03/devtools#vision-deficiencies
[2]: https://twitter.com/ianhamilton_/status/1237704178497130496

Related patches:

- DevTools UI CL:
  https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2109751
- Documentation patch:
  https://github.com/google/WebFundamentals/pull/8569

Bug: chromium:1003700
Change-Id: Ib3d753874830b9cea17c18c6ac0baa064bbd9c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109754Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751782}

On Chromium CI, this occasionally dips above 6s and times out. Looks
like its just a bit slow, not hanging entirely, so giving it more time
to finish seems ok.

Bug: 1062762
Change-Id: I8ff780462676a0aadaaa0d0193509dae7e36bf4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110672Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751781}

Histogram recorded to understand user's interactions with Quick Answers consent:
* QuickAnswers.Consent - How many times user has seens the consent before.
* QuickAnswers.Consent.Duration.[Interaction Type] - How long user has seens the consent before the interaction.
* QuickAnswers.Consent.Impression.[Interaction Type] - How many times user has seens the consent before the interaction.

The interaction type is one of the following:
* Accept - click on the "Got it" button.
* ManageSettings - click on the "Manage settings" button.
* Dismiss - the consent is dismissed.

Bug: b/151112171
Test: Manual

Change-Id: I29dedf999bc0f1560d5fce4707eba5229d4cde88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100937
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751780}

The idl tests were failing because the definition order was wrong.

Change-Id: Iac210d6c0b211c49a78749c8dfd2a94be76c9a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110078Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751779}

Bug: none
Change-Id: I2d087cef6278cf12d03149ae9d80c51d806437ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018591
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751778}

See go/faster-javac for a detailed analysis of why turbine was chosen to
speed up our java builds. The current implementation is an initial
implementation that can be further optimized. It already gives savings
of 10-30% of our java incremental builds depending on the target in
question (see go/project-turbo for timing details).

This implementation does remove some of the benefits of the previous way
that java_library_impl was implemented, namely when a target's
.interface.jar file changes, it no longer short-circuits dependent
targets from being built since we now use group(target_name). This is
arguably more correct as prebuilts depend on javac jars directly. In the
future (after the androidx migration and other build improvements) this
can be improved by having prebuilts depend on the interface jars
instead.

Original CL: https://crrev.com/c/2105415

Fixed jacoco instrument not having header deps.

Bug: 1056299, 1062704
Change-Id: I9a6c3242a04c6c57bb3c8f5bb7542c5a4301d1b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110431Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751777}

Bug: 1062984, 1063079
Change-Id: I04c06d75d05836b2c1dbced3a9a1d9385349d2ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110510Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751776}

The tests make sure that the updates end up in the right store(s).

Bug: 1058339, 1012203
Change-Id: I958e9510845fc909fbce89cb573f29b0b4c19b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109759
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751775}

The callsites were dereferencing return value of
ParseJsonDeprecated anyway, so make it use non-deprecated ParseJson.

Bug: 932873
Test: Unit test cleanup, no behavior change.
Change-Id: I80fd06bc3ecfa39d0f5cad9cb88631e685bc122c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108004
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751774}

https://chromium.googlesource.com/angle/angle.git/+log/a38e20e4b435..7daf31d8029b

git log a38e20e4b435..7daf31d8029b --date=short --first-parent --format='%ad %ae %s'
2020-03-19 m.maiya@samsung.com Vulkan: Use device local memory for conversion buffers that can be converted with the GPU
2020-03-19 jmadill@chromium.org Vulkan: Remove public FramebufferVk::getFramebuffer.
2020-03-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 25ede1ced679..18d3896a15fc (2 commits)
2020-03-19 jian.li@arm.com Skip some tests on Mali because of a known issue

Created with:
  gclient setdep -r src/third_party/angle@7daf31d8029b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ice4432b86cc578f92b8200ae1c0d9a06c19eafd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110041Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751773}

Bug: None
Test: CQ
Change-Id: I64ba530176aa572cd6a2433c15176d0842738f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109235
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751772}

For remote desktop environment, vkEnumeratePhysicalDevices() will
fail to get any available GPU. In this case, we should fallback
to GL instead of continuing using Vulkan.

Bug: 1062696
Change-Id: I610a62364cb7ca9120451edfec1ef3f97f0a8d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110080
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751771}

As the ImageLayerBridge::MakeAccelerated only accept an accelerated
resource, we should not need the fallback mechanism here, so the create
method can be replaced only by a CreateSharedImageProvider in GPU mode.

Bug: 1035589
Change-Id: Iff8adc008332532312f5b809f44e378cb7bab192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108800Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751770}

Bug: 1062285
Change-Id: I0f9d1f97e77dc446a7a622b24c693a285efafef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110810
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751769}

In some instances it may be confusing how the navigation controller
should be initialized in the ChromeCoordinator. To avoid confusion
about who should be setting this parameter set to readonly in
ChromeCoordinator and update the relevant constructors.

Bug: 971989
Change-Id: If2ee713d074e0c9b7168a4f472c2fb20dc2ed6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107866Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751768}

Bug: 1062285
Change-Id: I0680058bc3e35ae0bf5d2e19e114899b0e71b65f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106487
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751767}

This reverts commit 5e72b886.

Reason for revert: Fix was landed

Original change's description:
> [iOS][Sheriff] Disable UrlWithSpecialSuffixNavigation
> 
> TBR=eugenebut@chromium.org
> 
> Bug: 1063015
> Change-Id: Ic74d8e26f365daad546ce35b210b1d856d8d7225
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110021
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751707}

TBR=javierrobles@chromium.org

Change-Id: I96e394b03c322cbfc0a12e422ff2ead0f4f7e99d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1063015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110514Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751766}

Looks like it also sometimes times out on Win10.

TBR=lanwei

Bug: 947951
Change-Id: I83202a04e10741391e972363ab5ac59b0b92111c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110217Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751765}

Change helper methods ToJavaFooArray() and to ToJavaArrayOfFoo() to take
their input as base::span<> instead of const std::vector<>&. base::span
is implicitly converted from most array-like container types; so
existing callers work unmodified, and new callers can choose to convert
from other types like std::array<>.

Also add an overload of ToJavaArrayOfByteArray() that takes an input
bytes as std::vector<uint8_t> instead of std::string.

Change-Id: Ic9b9327220c4836c01b716299b3ce4ec973b32a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109036Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#751764}

StartSurfaceToolbar* is used when start surface is enabled right now.

Bug: 990600
Change-Id: Ib63ae8423c1027cacd27d88179a451f014055f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094713Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751763}

This tests that the PopupMenu item is enabled/disabled based on the
state of page being displayed.

Bug: 1062101
Change-Id: Ide6f00c7e8315054bd74c68c584aaa81ae819e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109765
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751762}

This reverts commit 89ee6b6a.

Reason for revert: Caused test flakiness/failures, crbug.com/1063037

Original change's description:
> [TabSelectionEditor] Add List mode supports
>
> This CL enables TabSelectionEditor to show a List for low-end devices.
>
> Change-Id: Ie60c1e7ddcda09c2f32e23c4de52be7e642e09e0
> Bug: 1042889
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103313
> Commit-Queue: Mei Liang <meiliang@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751588}

TBR=wychen@chromium.org,meiliang@chromium.org

Change-Id: I10615c8368f003844193ad535db1c5ca810e912b
No-Presubmit: true
No-Tree-Checks: true
Bug: 1042889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109827
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751761}

NonEmptyPaint3 now compares to application start time instead of process
creation time.

This CL refactors startup.LoadTime steps to be cross-platform, with:
- process creation
- application start time
- ChromeMain() time

This CL also updates a histograms that measure delta between these for
validation.

The metric is behaving weird on mac. It's less error prone to use TimeTicks
sampled early than aligning clocks.

Context: https://groups.google.com/a/google.com/g/chrome-catan/c/BhJOc7JIYeY
Change-Id: I77c9791f4fe9129d2882fccd752640ec04bd9efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098403
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751760}

When URLLoaderFactoryOverride is used, the factory may want
to handle custom schemes and allow to accept CORS-enabled requests
for them.

This patch adds an argument in URLLoaderFactoryOverride to
specify if the factory wants to allow CORS-enabled requests for
such custom schemes.

Bug: 898589, 1062250
Change-Id: Ia5ecc825df6a9cfc3b7c1e87f1bf16b55fd5436a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106047Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751759}

Apparently no longer needed.

Change-Id: I19cca28fea7b647a7613b06b7c0c4754e09172ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106812
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751758}

Actually check the flag that tells whether we're in an NG inline
formatting context, rather than DCHECKing RootInlineFormattingContext().
I had forgotten about this cheap flag when I introduced this method.

This means that CanTraversePhysicalFragments() can now be called on any
object. Previously we assumed that, if the object was non-atomic inline,
the container had to be NG, or the DCHECK would fail.

Bug: 1043787
Change-Id: Ia6d2f301c842c25365558a10952214d9fada77c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107844
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751757}

This changes default behaviour of clients to correctly
match display transform instead of needing to use
command line switches as a convenience to those
running the clients.

Bug: 1011977
Test: Run sample client with and without cmd line flag
Change-Id: Idf0bb9e4df8c48f2b8244354f25d9a77a97790a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108285
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751756}

The tests are being removed completely instead of
just annotating them to enable them for only past milestones.
This is simpler since it removes the dependency
on the server being enabled and working.

Bug: 1048736
Change-Id: Ib20a3c48a2ee2e6a90888517977cc45444ebf7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109631Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751755}

Add a last discovery time which is when
we last saw the Media Feed.

BUG=1057765

Change-Id: Iab3e255c511135c75c27355484dc6c52aaaf393d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107689Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751754}

Bug: 1044841
Change-Id: I2ab179dfc0a321d076c64ae99590e3052926889a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107596
Commit-Queue: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751753}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a1e6c065240..747295674924

git log 8a1e6c065240..747295674924 --date=short --first-parent --format='%ad %ae %s'
2020-03-19 mathias@chromium.org Add e2e test for vision deficiency simulation
2020-03-19 pfaffe@chromium.org Implement Mock Plugin Test
2020-03-19 tvanderlippe@chromium.org Enable common/Settings test

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@747295674924

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1003700,chromium:1061125
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib70f1c011439045f0fe898625a860a5234ab1ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110036Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751752}