GitLab

AudioNode::dispose() must be called before the AudioNode is destructed.
This is currently guaranteed in both oilpan builds and non-oilpan builds.
However the logic is not trivial, so this CL adds the ASSERT about it.

BUG=340522

Review URL: https://codereview.chromium.org/455353002

git-svn-id: svn://svn.chromium.org/blink/trunk@179941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Auto-rebaseline r179870 for r179857 appears to have failed with respect to Mac10.8.

TBR=wangxianzhu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/461583002

git-svn-id: svn://svn.chromium.org/blink/trunk@179940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaElementAudioSourceNode::dispose() should call HTMLMediaElement::setAudioSourceNode(0) in oilpan builds

Currently HTMLMediaElement::setAudioSourceNode(0) is called only in non-oilpan builds.
However, there is no reason why oilpan builds cannot call HTMLMediaElement::setAudioSourceNode(0).
It's better to call it both in oilpan builds and non-oilpan builds and reduce #if branches.

BUG=340522

Review URL: https://codereview.chromium.org/456273002

git-svn-id: svn://svn.chromium.org/blink/trunk@179939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. For case TraceIfNeeded, modify TraceIfNeededTester to inherit from GarbageCollectedFinalized and at the end of test case TraceIfNeeded trigger a GC.
   After GC, the destructor of TraceIfNeededTester will dereference the RefPtr<OffHeapInt> instance, stop the leak.
2. For case MapWithCustomWeaknessHandling and MapWithCustomWeaknessHandling2, need clear the Persistent handle and trigger a GC at the end of test case.

R=ager@chromium.org, oilpan-reviews@chromium.org
BUG=401018

Review URL: https://codereview.chromium.org/452723002

git-svn-id: svn://svn.chromium.org/blink/trunk@179938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402263,402218

Review URL: https://codereview.chromium.org/455333002

git-svn-id: svn://svn.chromium.org/blink/trunk@179937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=iliia, semeny, yurys

Review URL: https://codereview.chromium.org/454873006

git-svn-id: svn://svn.chromium.org/blink/trunk@179936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/463433002

git-svn-id: svn://svn.chromium.org/blink/trunk@179935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Wrapped arguments in remaining addConsoleMessage and addMessage methods in ConsoleMessage class.

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/419203004

git-svn-id: svn://svn.chromium.org/blink/trunk@179934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have a lot of remaining raw pointer members to RenderObject. Follow-up
patches will resolve them.

BUG=398342

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179196

Review URL: https://codereview.chromium.org/423093002

git-svn-id: svn://svn.chromium.org/blink/trunk@179933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Oilpan: Prepare moving AsyncCallChain to Oilpan
> 
> BUG=340522
> 
> Review URL: https://codereview.chromium.org/413113003

TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/458163002

git-svn-id: svn://svn.chromium.org/blink/trunk@179932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/413113003

git-svn-id: svn://svn.chromium.org/blink/trunk@179931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391593

Review URL: https://codereview.chromium.org/452083002

git-svn-id: svn://svn.chromium.org/blink/trunk@179930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395991
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/453943003

git-svn-id: svn://svn.chromium.org/blink/trunk@179929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/457283002

git-svn-id: svn://svn.chromium.org/blink/trunk@179928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change just brings the code in line with the current spec text.

BUG=397769
TEST=LayoutTest/http/tests/media/media-source/mediasource-remove.html

Review URL: https://codereview.chromium.org/453473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As ScriptPromiseProperty::reset is implemented, ReadableStream now uses it
and this CL removes FIXMEs about it.

BUG=393911
R=tyoshino

Review URL: https://codereview.chromium.org/456233002

git-svn-id: svn://svn.chromium.org/blink/trunk@179926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://heycam.github.io/webidl/#es-operations states that an API returning
a Promise should return a rejected Promise when an error occurs rather than
throwing an exception.

BUG=359386, 362992
R=bashi@chromium.org, eroman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171450

Review URL: https://codereview.chromium.org/232563003

git-svn-id: svn://svn.chromium.org/blink/trunk@179925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: use setImmediate instead of setTimeout for dispatching messages on devtools frontend in debug mode.

R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/438333003

git-svn-id: svn://svn.chromium.org/blink/trunk@179924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=zerny@chromium.org
BUG=402379
NOTRY=true

Review URL: https://codereview.chromium.org/462553002

git-svn-id: svn://svn.chromium.org/blink/trunk@179923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a TaskObserver that run Microtasks at the end of each Task
to WorkerThread. This CL also fixes a Promise resolution timing issue
caused by V8RecursionScope in the ScriptPromiseResolver implementation.
Because the microtask running timing has changed, We fix affected tests.

BUG=374772

Review URL: https://codereview.chromium.org/441063003

git-svn-id: svn://svn.chromium.org/blink/trunk@179922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

devtools.gyp* contents ordering is highly confusing, and it usually
takes some time to find certain snippets when modifying the deployment setup.

TBR=vsevik

Review URL: https://codereview.chromium.org/458463003

git-svn-id: svn://svn.chromium.org/blink/trunk@179921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402043

Review URL: https://codereview.chromium.org/459753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're going to need to pass credentials up into Chromium, and back down
into Blink. This patch makes that possible by adding a shared
"Platform*Credential" type which can be used by both the Blink module's
"*Credential" objects, and the platform's "Platform*Credential" objects.

BUG=400674

Review URL: https://codereview.chromium.org/457683002

git-svn-id: svn://svn.chromium.org/blink/trunk@179919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a preload request for <img> preload fails, the request will be retried
on parsing the element as per normal. This might result in more than
one request for the same resource, and consequently more than one console
error message might be output.

For img-crossorigin-no-credentials-prompt.html, avoid having the preloader
kick in by not relying on an external script.

R=
BUG=239918

Review URL: https://codereview.chromium.org/461563002

git-svn-id: svn://svn.chromium.org/blink/trunk@179918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When testing web animations test htmls on chrome, "Uncaught ReferenceError:
testRunner is not defined" exception is fired.
So guard testRunner for convenience.

BUG=N/A

Review URL: https://codereview.chromium.org/436883002

git-svn-id: svn://svn.chromium.org/blink/trunk@179917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=401953

Review URL: https://codereview.chromium.org/454893003

git-svn-id: svn://svn.chromium.org/blink/trunk@179916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes the type of the internal pointers ScriptWrappableBase* so we can check
pointer conversions between the internal pointers and the native objects.
ScriptWrappableBase* is much safer than void* here because we can avoid
unintentional pointer conversions.

This CL also includes fixes of misconversions from/to the internal pointers.

Note that the definition of the internal pointers does not change by this CL.
We'll change the actual definition at the coming http://crrev.com/420233002 .

BUG=235436

Review URL: https://codereview.chromium.org/456683002

git-svn-id: svn://svn.chromium.org/blink/trunk@179915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The bug hasn't been fixed, but now any unrelated change to the test
result will result in a failure, instead of being silently ignored.

BUG=246077

Review URL: https://codereview.chromium.org/456743002

git-svn-id: svn://svn.chromium.org/blink/trunk@179914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=aandrey

Review URL: https://codereview.chromium.org/462513002

git-svn-id: svn://svn.chromium.org/blink/trunk@179913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's been green since it was converted to a reftest in r179707:
https://codereview.chromium.org/451483004
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=parent-flow-inline-with-block-child.html

BUG=331576

Review URL: https://codereview.chromium.org/455803002

git-svn-id: svn://svn.chromium.org/blink/trunk@179912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399803

Review URL: https://codereview.chromium.org/458093002

git-svn-id: svn://svn.chromium.org/blink/trunk@179911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change WebAnimation to WebCompositorAnimation
Change WebAnimationCurve to WebCompositorAnimationCurve
Change WebAnimationDelegate to WebCompositorAnimationDelegate

This is patch 3 of 3. It builds on http://crrev.com/413983002

BUG=396358

Review URL: https://codereview.chromium.org/412123002

git-svn-id: svn://svn.chromium.org/blink/trunk@179910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399803

Review URL: https://codereview.chromium.org/461543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the Layout tests for shadow so that they dont use child
elements of <shadow>. In this patch, childs which are added through
JS is being removed.

BUG=334957

Review URL: https://codereview.chromium.org/450533007

git-svn-id: svn://svn.chromium.org/blink/trunk@179908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=396400
NOTRY=true

Review URL: https://codereview.chromium.org/458053004

git-svn-id: svn://svn.chromium.org/blink/trunk@179907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

What is happening is:
1. User opens popup
2. PopupListBox::layout measure's row width
  2-1. text width is calculated as ltr
  2-2. this width for ltr is registered to the WidthCache
3. PopupListBox::paintRow is called
  3-1. WidthCache has a interval mechanism so the cached ltr width is not used
  3-2. text width is calculated as rtl
  3-3. Text is  drawn as rtl
4. User hovers over items
5. PopupListBox::paintRow is called each time the selection changes
  5-1. WidthCache's cached ltr width is used
  5-2. Text is  drawn as rtl (rtl width is shorter than the rtl width so there is extra space on the right side)

There are two problems
- PopupListBox::layout is measuring row width using ltr always
- WidthCache is returning ltr width for rtl text

This just fixes PopupListBox::layout.
BUG=398929

Review URL: https://codereview.chromium.org/451983004

git-svn-id: svn://svn.chromium.org/blink/trunk@179906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CallbackData created by InjectedScriptManager should be deleted when
an associated worker thread terminates. The most straightforward way
to do that is to make the InjectedScriptManager hold a list of
OwnPtr<CallbackData> that the InjectedScriptManager created.
Since the the InjectedScriptManager is destructed in ~WorkerScriptController(), it's guaranteed that all associated CallbackData is destructed
in
~WorkerScriptController() as well.

This change will fix a couple of inspector-protocol/debugger tests in oilpan builds.

BUG=398472

Review URL: https://codereview.chromium.org/452043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added an assertion to the patch in https://codereview.chromium.org/444223004/

In StyleSheetContents::checkLoaded after parentStyleSheet check, "this pointer" is guaranteed to be equal to rootStyleSheet.
So we can only use this pointer instead of rootStyleSheet.

Review URL: https://codereview.chromium.org/456673002

git-svn-id: svn://svn.chromium.org/blink/trunk@179904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change...
- adds 'onupdatefound' event and version attribtues (eg. '.installing') into
ServiceWorkerRegistration interface.
- adds WebServiceWorkerRegistrationProxy interface to talk to the registration
object from embedder.

[NOTE] ServiceWorkerRegistration is still disabled by the macro since Chromium
side is still actively being implemented:
https://codereview.chromium.org/427523002/

[Spec] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj


BUG=396400
TEST=compile (layout tests will be added after enabling the registration interface)

Review URL: https://codereview.chromium.org/424693004

git-svn-id: svn://svn.chromium.org/blink/trunk@179903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/457263002

git-svn-id: svn://svn.chromium.org/blink/trunk@179902 bbb929c8-8fbe-4397-9dbb-9b2b20218538