- 15 Jul, 2018 14 commits
-
-
Douglas Creager authored
Per https://github.com/w3c/network-error-logging/issues/74, NEL policies that have include_subdomains set can only be used to report errors during DNS resolution. They cannot be used to report on successes, or on errors in other phases, since once we contact a server, that server has to explicitly consent to NEL reporting by delivering its own policy. Bug: 862188 Change-Id: If051f6787344b9385af3e46384370636a6bafc5d Reviewed-on: https://chromium-review.googlesource.com/1135599 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#575180}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I21368d1bf5a4fae30f55608e2dda23a1db4d8fcb Reviewed-on: https://chromium-review.googlesource.com/1137914Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575179}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c604ed06b71..c053fb8e34db git log 0c604ed06b71..c053fb8e34db --date=short --no-merges --format='%ad %ae %s' 2018-07-15 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@c053fb8e34db The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I2fb92cd3b00c3da7ecd9548bc094a2a3fbb3f721 Reviewed-on: https://chromium-review.googlesource.com/1137779Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575178}
-
yiyix authored
The metrics Scheduling.*.SwapAckWasFast records True if the swap ack was received within approximately 8 seconds of the swap. Based on the past few month of data, this metrics always report true, true -> 100%. In addition, metrics Scheduling.*.SwapToAckLatency2 measures the same data - it reports the exact time that takes for the swap ack to return after a swap. Bug: 856860 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I00cf9e545a9a55054fe7dd8af948693625cac08b Reviewed-on: https://chromium-review.googlesource.com/1134040Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#575177}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: Ide4e1d9dd014515b114c3989abbd00ffe9101338 Reviewed-on: https://chromium-review.googlesource.com/1137879 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575176}
-
Ryan Sleevi authored
The introduction of SSLConfigServiceMojo finally provided the cut point in the SSLConfigService interface that allows it to no longer be refcounted, and instead fully owned by the URLRequestContextStorage. TBR=sergeyu@chromium.org Bug: 56213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d2fa53f93d76b18937fd615ed976ced18241822 Reviewed-on: https://chromium-review.googlesource.com/1129327 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#575175}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6f6fdf91f66d..0c604ed06b71 git log 6f6fdf91f66d..0c604ed06b71 --date=short --no-merges --format='%ad %ae %s' 2018-07-15 fmalita@chromium.org [skottie] Teach skottie_tool to dump frame SKPs Created with: gclient setdep -r src/third_party/skia@0c604ed06b71 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I6aedb294f8c80c9d6ff73a8d3a6f43c963791a62 Reviewed-on: https://chromium-review.googlesource.com/1137778Reviewed-by:
-
Gabriel Charette authored
This reverts commit 4714a9fc. Reason for revert: perf regression (crbug.com/863125). I think I've identified the culprit but reverting to avoid compounding CLs if I'm wrong. Will reland with fix shortly. Original change's description: > [MessageLoop] Refactor ScheduleWork and TaskAnnotator logic out of IncomingTaskQueue > > This was extracted from > https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17 > in an attempt to simplify it (and is now a precursor to it). > (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController > there but after grokking the resulting CL it's simpler under MessageLoop > as done in this CL) > > This CL splits the logic in IncomingTaskQueue which took care of > scheduling the MessageLoop into a dedicated class. In that follow-up CL: > MessageLoopTaskRunner will interact directly with the task Observer and > take IncomingTaskQueue completely out of the picture (merely a data > structure holding various task queues at that point). > > IncomingTaskQueue also took care of detaching on MessageLoop shutdown > which was moved to the new Controller class as well. > > message_loop.cc is the best place for this extracted logic as it all > pertains precisely to MessageLoop's implementation detail (how > ScheduleWork should be invoked). > > This CL simplifies locking as well by having a clear separation between > the two locks instead of two locks in the same class used > interchangibly. |incoming_queue_lock_| is now strictly for incoming > tasks. |message_loop_lock_| is now strictly for > ScheduleWork()/DisconnectFromParent(). > > Note: |message_loop_scheduled_| was dropped as it was redundant (always > equal to |!was_empty|). > > Performance wise, the perf tests show that this change is a noop : > * While BasicPostTaskPerfTest became simpler (executed less code) with > this CL : > The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead > reintroduces that overhead to show that it's still the same (or > slightly in favor of this CL). > * And the IntegratedPostTaskPerfTest are the same. > * Augmented perf tests to 30 seconds which yields more reliable results. > (and ran old ones under 30s mode too when comparing) > * Results : > https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit > > Bug: 860252 > Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe > Reviewed-on: https://chromium-review.googlesource.com/1127262 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574048} TBR=danakj@chromium.org,gab@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 860252, 863125 Change-Id: I871a9e87d799b7966558708826d97400162e0e82 Reviewed-on: https://chromium-review.googlesource.com/1137893Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#575173}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I6a4b2eb9e258267edca8e97c88e7384568c617c8 Reviewed-on: https://chromium-review.googlesource.com/1137875Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575172}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/27e21b72d0d7..106662954167 git log 27e21b72d0d7..106662954167 --date=short --no-merges --format='%ad %ae %s' 2018-07-15 vapier@chromium.org memoize: split out of cros_build_lib 2018-07-15 dhanyaganesh@chromium.org CQ: Remove subsytem-based logic Created with: gclient setdep -r src/third_party/chromite@106662954167 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I01b27916731982a4252642ae26e2c8e2a84a8638 Reviewed-on: https://chromium-review.googlesource.com/1137777Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575171}
-
Michael Müller authored
So far XFCE was only detected using the DESKTOP_SESSION environment variable, which is not sufficient on all systems. The variable might contain different values like lightdm-xsession. This change adds support to detect XFCE using the XDG_CURRENT_DESKTOP environment variable, like it is done for Gnome, KDE and other desktop environments. R=thomasanderson@chromium.org Bug: 863706 Change-Id: I30f8471a8e8fbea1d25c6b3586c9919d27d83e09 Reviewed-on: https://chromium-review.googlesource.com/1137814Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#575170}
-
David Black authored
Accomplished by "hl" query parameter and client side locale API. See bug for demo. Bug: b:111352574 Change-Id: I4cbca266921ecc1009de29d23642e3c4225826da Reviewed-on: https://chromium-review.googlesource.com/1137452 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575169}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74ff2c23. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21282 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: panicker@chromium.org: external/wpt/page-visibility TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I4072f0d7c562ffbbb106f9ddeacb313ceda71965 Reviewed-on: https://chromium-review.googlesource.com/1137840 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575168}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc2e86dd5900..6f6fdf91f66d git log bc2e86dd5900..6f6fdf91f66d --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 92e955f2c4ab..76c1d14b8e21 (1 commits) Created with: gclient setdep -r src/third_party/skia@6f6fdf91f66d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Ie3591f2445d7d7623c2e3a24efcdbb76e33a369b Reviewed-on: https://chromium-review.googlesource.com/1137776Reviewed-by:
-
- 14 Jul, 2018 26 commits
-
-
Anders Hartvoll Ruud authored
This patch fixes two similar problems: 1. Computed list-valued properties show up as a CSSStyleValue when calling computedStyleMap().get(name). 2. Computed list-valued properties show up as a CSSStyleValue when calling computedStyleMap().getAll(name). The fixes are also similar: 1. StylePropertyMapReadOnly::get only checked property.IsRepeated() when determining whether it should look inside a possible list. However, CSSPropertyVariable is never repeated. This is because CSSPropertyVariable does not represent a single, specific custom property, but rather _all_ custom properties. For CSSPropertyVariable, if we have a CSSValueList, it means that it is registered with either '<foo>+', or '<foo>#', and that makes it a "list valued property" [1]. 2. Similar to (1), the value would be treated as unsupported if property. IsRepeated() was false. Again, a situation of CSSPropertyVariable+ CSSValueList means that the property is registered as a list. Note1: The value for a custom property can only be a CSSValueList if the runtime enabled feature CSSVariables2 is enabled. In all other cases, it's a CSSCustomPropertyDeclaration. See ComputedStyleCSSValueMapping::Get ('registry' is nullptr without the feature). Note2: It might make more sense to ignore the repeatability of the property, and instead just look at whether we actually have a CSSValueList, but such a change would require a change of the css-typed-om spec. [1] https://drafts.css-houdini.org/css-typed-om-1/#list-valued-properties https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue R=chrishtr@chromium.org Bug: 862152 Change-Id: Ic854f54f14313b6b683601d0677dcc1dd4205ccd Reviewed-on: https://chromium-review.googlesource.com/1136295Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#575166}
-
Patti authored
Add functionality to sort the All Sites list, with an initial option to sort by a site group's eTLD+1 name. Note that sites shown individually (ungrouped) in All Sites will also be sorted by their eTLD+1. See a screenshot of this feature at https://bugs.chromium.org/p/chromium/issues/detail?id=835712#c19 Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic58e1bf294189b4fefc2cf0f8532725a71f2b36c Reviewed-on: https://chromium-review.googlesource.com/1128782 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#575165}
-
Bailey Berro authored
This change adds StartCopy and ContinueCopy on SmbProviderClient so that SmbFileSystem can call these methods on the SmbProvider daemon over D-Bus. These methods enable chunking units of work of a copy operation since the SmbProvider daemon is single threaded and we do not want to block it during long running copies. Bug: 757625 Change-Id: I3de4df31907c29d872820d13ff5004f82160d663 Reviewed-on: https://chromium-review.googlesource.com/1130821Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#575164}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92e955f2c4ab..76c1d14b8e21 git log 92e955f2c4ab..76c1d14b8e21 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 jmadill@chromium.org D3D11: Lift dEQP-GLES3 uniform_api test expectations. Created with: gclient setdep -r src/third_party/angle@76c1d14b8e21 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I73bf917b663f7baedd0fd8548d32ca63563ecbdd Reviewed-on: https://chromium-review.googlesource.com/1137775Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575163}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1d28414e337..bc2e86dd5900 git log d1d28414e337..bc2e86dd5900 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 06ca634eba4a..92e955f2c4ab (1 commits) Created with: gclient setdep -r src/third_party/skia@bc2e86dd5900 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5d3e1e3f522e8e1c34d9816ce237a97d57891e9a Reviewed-on: https://chromium-review.googlesource.com/1137774Reviewed-by:
-
Anders Hartvoll Ruud authored
Registered custom properties should behave as if they weren't registered for parsing and cascading purposes. Only at computed-value time does the syntax from the registration come into play. R=chrishtr@chromium.org Bug: 641877 Change-Id: I5ed5b334318e653da660b88b2dd912cc0b59f36d Reviewed-on: https://chromium-review.googlesource.com/1136448Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2efdb333ae27..d1d28414e337 git log 2efdb333ae27..d1d28414e337 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@d1d28414e337 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I1a8eb8184738f4b0937bc59ba971d90f488c48fe Reviewed-on: https://chromium-review.googlesource.com/1137773Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia0ed04bf8a2c625164a65ec545af3c036562198b Reviewed-on: https://chromium-review.googlesource.com/1137747Reviewed-by:
-
Ned Nguyen authored
TBR=eyaich@chromium.org Bug: 713357 Change-Id: Ib99ad0590a266895c25336747cf202b5406206a5 Reviewed-on: https://chromium-review.googlesource.com/1137378Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575158}
-
Yngve N. Pettersen authored
Commit f8b7b43d introduced a CRLF into the services/audio/DEPS file. This CL fixes that CRLF to an LF Bug: 832129 Change-Id: I58128d5f5da76c219ab6de040d87d7465da7a317 Reviewed-on: https://chromium-review.googlesource.com/1136876Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Cr-Commit-Position: refs/heads/master@{#575157}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4e94c6f5b5c..2efdb333ae27 git log a4e94c6f5b5c..2efdb333ae27 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2efdb333ae27 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5b003a958b4ca0e771b57e6e94c3a3fbd0902b7e Reviewed-on: https://chromium-review.googlesource.com/1137514Reviewed-by:
-
rbpotter authored
Overriding Polymer properties defined in a behavior was never fully specified, and could lead to weird corner cases, which Polymer 2 explicitly decided to address. One new specification is that properties declared as computed in a behavior should not be overridden in elements implementing the behavior. As a result the indicatorTooltip property in CrPolicyIndicatorBehavior can no longer be overridden in Polymer2. Remove this property from the behavior and put it in the 3 elements implementing the behavior individually, while retaining the behavior's computation method since it is used by all 3. This causes CrElementsPolicyNetworkIndicatorTest.All (CrOS only) and CrElementsPolicyPrefIndicatorTest.All to pass with Polymer 2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iab7824c5d69c59b00fa0f1a173e3d5c85ec7d2e4 Reviewed-on: https://chromium-review.googlesource.com/1135631 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575155}
-
Patti authored
Add search function to the All Sites page. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1bfe1ff81a3293962a6263e2a54d38bb06d3d382 Reviewed-on: https://chromium-review.googlesource.com/1126596 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575154}
-
Aga Wronska authored
Bug: 827376 Test: Run DemoSetpTest and WizardController browser tests. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0decf05a353fa8e76823b286e3442d6c0bf98814 Reviewed-on: https://chromium-review.googlesource.com/1116246 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575153}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0cd3404ce483..27e21b72d0d7 git log 0cd3404ce483..27e21b72d0d7 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 vapier@chromium.org lint: clean up old statements 2018-07-14 xiaochu@chromium.org script to generate a DLC artifact 2018-07-14 dgarrett@google.com config_lib: Remove unused shared_user_password. 2018-07-14 mka@chromium.org command_vm_test: disable debug test Created with: gclient setdep -r src/third_party/chromite@27e21b72d0d7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iea613d64ff5f18ea6b497fb248a29a7dc74850d9 Reviewed-on: https://chromium-review.googlesource.com/1137471Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/455ee3a61e2b..2f38df65f95e git log 455ee3a61e2b..2f38df65f95e --date=short --no-merges --format='%ad %ae %s' 2018-07-14 ehmaldonado@chromium.org gclient: Reset the fetch config also when --force is passed. Created with: gclient setdep -r src/third_party/depot_tools@2f38df65f95e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: I209237bd8578ef1903e4544fc23aa5b1e0f8f8e7 Reviewed-on: https://chromium-review.googlesource.com/1137513Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575151}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06ca634eba4a..92e955f2c4ab git log 06ca634eba4a..92e955f2c4ab --date=short --no-merges --format='%ad %ae %s' 2018-07-14 theoking@google.com Vulkan: Fix premature pointer freeing Created with: gclient setdep -r src/third_party/angle@92e955f2c4ab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0e39285b0af1aaa708f49974b37c199e9f988b8d Reviewed-on: https://chromium-review.googlesource.com/1137512Reviewed-by:
-
Sammie Quon authored
Test: manual Bug: 863472 Change-Id: Ifac38e4a217204e1d4fe311d625b62f52d8be925 Reviewed-on: https://chromium-review.googlesource.com/1136843 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#575149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0df97e8c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21208 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I15bbcb3254c7f59ffc2db3c1fa9e85ffec0a6274 Reviewed-on: https://chromium-review.googlesource.com/1137734 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Pavel Feldman authored
Change-Id: I1ddb0f06353aa88673cb690dfb35d82f8b4559ac Reviewed-on: https://chromium-review.googlesource.com/1136895 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575147}
-
Michael Giuffrida authored
The URLBlacklistManager used to take a callback for overriding the blacklist. This was used for limited guest sessions in OOBE, but all code paths that actually triggered this code have been removed, and these limited guest sessions will no longer be supported. Bug: 850213 Change-Id: I299ccace10529696ba2b581ed861e8c6a6cd769b Reviewed-on: https://chromium-review.googlesource.com/1119073 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575146}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1128ebcb6dde..a4e94c6f5b5c git log 1128ebcb6dde..a4e94c6f5b5c --date=short --no-merges --format='%ad %ae %s' 2018-07-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0cc291365934..06ca634eba4a (7 commits) Created with: gclient setdep -r src/third_party/skia@a4e94c6f5b5c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I5f7672e3336a616d9c3a0d8711c2dda6263996f4 Reviewed-on: https://chromium-review.googlesource.com/1137511Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/579c98612b6f..455ee3a61e2b git log 579c98612b6f..455ee3a61e2b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 ehmaldonado@chromium.org bot_update: Don't pass reset-fetch-config to gclient Created with: gclient setdep -r src/third_party/depot_tools@455ee3a61e2b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: Ib5211668747e1ca339123b4efa6058c774768b63 Reviewed-on: https://chromium-review.googlesource.com/1137491Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4b9e51747be22bd43e5b0b364b716b09032b13b3 Reviewed-on: https://chromium-review.googlesource.com/1137375Reviewed-by:
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/offline_pages and components/previews and components/safe_browsing Bug: 561800 Change-Id: I5162d0c53126edf6b5cd12fae5fcacab634d2719 Reviewed-on: https://chromium-review.googlesource.com/1134936Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#575142}
-
Francois Doray authored
With this CL, Hangouts should no longer be discarded during a screenshare session. See privacy doc update: https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAACBUojIc Bug: 775644, 857495 Change-Id: I2fa58efc58d1a9c92ae49c5eb308514722637c14 Reviewed-on: https://chromium-review.googlesource.com/1136513Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#575141}
-
