- 17 Mar, 2020 27 commits
-
-
David Tseng authored
In particular, this change makes it so we precisely pass through only the next sequence of key downs/ups that follow the pass through shortcut (Search+Shift+Esc). Previously, we would only partially pass through the shortcut after the Search+Shift+Esc command. Test: browser_tests --gtest_filter=ChromeVox*.* Change-Id: Ic9d41d35bd5cce47eb3151bdba6b435f385d56e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104449Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750813}
-
Tibor Goldschwendt authored
This util code will be used by the WebUI NTP to implement the fakebox. Bug: 1061073 Change-Id: I5bbbdeb2c05119d006618baed309234308ad76a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101854 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750812}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91af93d4..55bf4ea1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id987b6f43d8298997f28dc4cd842f1adf8f8458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106636Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750811}
-
Jordan Taylor authored
A test has been added to verify that startScrollOffset and endScrollOffset still affect animations as they should. Current implementation returns 0 for when the timeline current time is before startScrollOffset and time_range for when timeline current time is at, or after endScrollOffset. All based on the spec: https://drafts.csswg.org/scroll-animations-1/#current-time-algorithm Removal of CC ScrollTimeline fill is included here because there is conversion from main thread ScrollTimelines to CC ScrollTimelines in scroll_timeline_util.cc and passing in a default fill value seems wrong. CC ScrollTimelines currently do not support phase though, so the case of current_time 0 will be ambiguous until that is implemented. Bug: 1041621 Change-Id: I938679f0c61b42b588933bf9e5a8e7bd2776f529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028173 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#750810}
-
Eric Willigers authored
sqlite/src was recently added to the DEPS for gclient sync: https://chromium-review.googlesource.com/c/chromium/src/+/2013741 Synced files should be ignored by git. Bug: 945204 Change-Id: If335b901b32b992b019cde8aaf24622acd37411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105657 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750809}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6149083d74e9..2d7d65c5e8ac git log 6149083d74e9..2d7d65c5e8ac --date=short --first-parent --format='%ad %ae %s' 2020-03-16 aerotwist@chromium.org [global] Remaps self.Common.settings Created with: gclient setdep -r src/third_party/devtools-frontend/src@2d7d65c5e8ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I394525ec7d4b4cdf164815e5cf443715a92ebe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750808}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8cf12290bab8..34d90bebd8ba git log 8cf12290bab8..34d90bebd8ba --date=short --first-parent --format='%ad %ae %s' 2020-03-16 brucedawson@chromium.org Allow customizable build-type grouping Created with: gclient setdep -r src/third_party/depot_tools@34d90bebd8ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061326 Tbr: agable@chromium.org Change-Id: I74d8cbdce686443690f417aacd0f162f6c1bc895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106137Reviewed-by:
-
Xiaohan Wang authored
- Set EXPECT_CALL on OnVideoFrameRateChange to avoid uninterested mock call warnings. - Remove old MOJO_RENDERER PipelineIntegrationTest code which should have been removed in the previous CL. See https://chromium-review.googlesource.com/c/chromium/src/+/1896054 Bug: 597904 Change-Id: Ia6af5dfe7641ddc1e9710ec4e1f4c142fc80394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106762Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#750806}
-
Robert Woods authored
Now that Bookmark Apps and BMO web apps share a representation for file handlers (apps::FileHandler), migrating Bookmark App file handlers to the new web apps system is simply a matter of copying the data. This CL implements WebAppMigrationManager::MigrateBookmarkAppFileHandlers. For more context, see: https://chromium-review.googlesource.com/c/chromium/src/+/2087306 Bug: 938103 Change-Id: Ic0a4ad85e84ef5c2b6adedb6e28c3b95a9160bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086453 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#750805}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f0a34f2a3061..8bc88340292b git log f0a34f2a3061..8bc88340292b --date=short --first-parent --format='%ad %ae %s' 2020-03-16 handellm@webrtc.org webrtc_video_engine_unittest.cc: fix using directives. Created with: gclient setdep -r src/third_party/webrtc@8bc88340292b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I61558c79c4f477fc95f29415c20532ab06dc0f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106758Reviewed-by:
-
Christopher Cameron authored
Rename ExtensionAppShimHandler to AppShimManager, and rename the file. Rename what I just called AppShimHandlerDelegate to ExtensionAppShimManagerDelegate because this is the version of the delegate that uses the extensions API. There will be a different AppShimManager::Delegate sub-class that doesn't. R=loyso TBR=avi (for chrome/) Bug: 1057195 Change-Id: Ie80e1bfd0683587bb8476855d3895c6c937e02d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103522 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Joel Hockey authored
We don't want VMs to ever restart automatically. Bug: 1062113 Change-Id: I0761eba18ed162714cc753653764529f8b0555db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106694 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#750802}
-
Tommy Nyquist authored
The BackgroundTaskScheduler on Android is a core part of many features, and is not considered an experiment. Consolidate all expiry times to a single one for all related histograms. BUG=1053235 R=fgorski@chromium.org,knollr@chromium.org,hanxi@chromium.org Change-Id: Ie16f03f17adf4fd11ca878eb1780d01674a71be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094240 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#750801}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f1eb10ef75a8..41b4ab193a14 git log f1eb10ef75a8..41b4ab193a14 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src dd3d91691f1e..25ede1ced679 (5 commits) 2020-03-16 jmadill@chromium.org Fix documentation typo. 2020-03-16 jmadill@chromium.org Add more documentation on testing infrastructure. Created with: gclient setdep -r src/third_party/angle@41b4ab193a14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ifc8541f5846f9f5461bd8cdb56d784c56cc4c47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106506Reviewed-by:
-
Robin Lewis authored
Bug: 1061794 Change-Id: I4ab0acc586fd3071c213a00a357d5e8dc23d995b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104454 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#750799}
-
Tibor Goldschwendt authored
This CL is preparing to add the fakebox to the WebUI NTP. The new OmniboxTabHelper lets the WebUI NTP register an observer for omnibox events such as focus changes. At the same time, it also lets the local NTP register observers to support existing behavior. Calling the WebUI NTP directly from the omnibox, or letting the WebUI NTP register an observer at the omnibox was considered. However, there is no convenient handle pointing to the WebUI NTP the omnibox has access to. Furthermore, the omnibox responsible for the WebUI NTP may change when moving tabs to other windows. The OmniboxTabHelper makes this loose connection more mangeable. Bug: 1061073 Change-Id: I7d0edee57176cb051ee9d77a2bb9300c24f54b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101700 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
If AXPlatformNodeDelegate::HitTestSync returns a node that's not a descendant, we will end up calling accHitTest recursively on that node, which will result in an endless loop. Fix this by explicitly requiring that the result of HitTestSync is a descendant, and ignoring it if not. Bug: 1061323 Change-Id: I006163fdc431a41ccbafc692a43993ddb7f383cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102783 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750797}
-
Robert Woods authored
At the moment, two apps::FileHandler-related helper functions are defined in the web_app namespace alongside FileHandlerManager: GetMimeTypesFromFileHandlers and GetFileExtensionsFromFileHandlers. Now that apps::FileHandler has been established in app_service, it makes sense that these helpers should exist alongside it, to avoid unnecessarily depending on file_handler_manager.h in other parts of the code base. For example, in a subsequent CL, linked below, we will refactor RegisterFileHandlersWithOs to take an apps::FileHandlers vector rather than separate sets of MIME type and file extension strings. Moving these helpers will mean that web_app_file_handler_registration_win.cc doesn't need to call WebAppProviderBase to get a FileHandlerManager, etc etc... Following CL for context: https://chromium-review.googlesource.com/c/chromium/src/+/2096423 Bug: 938103 Change-Id: I439926b952ed03d5caeed391ac223d1b0be004e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098160 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#750796}
-
Thomas Guilbert authored
This CL removes |new_frame_presented_cb_lock_|, and instead uses |current_frame_lock_|. Also removing |callback_lock_| proves to be difficult and not worth the effort at this time. Bug: 1057304 Change-Id: Ic08eb8a13890356a6dae1b009cdda1584513dccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106713 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change does the following: 1. Refactors LanguageSwitching to be a singleton object. 2. Separates node and sub-node switching behavior into separate methods. 3. Performs general clean up on verbose comments, variable names, etc. 4. Simplifies logic where possible. Note: this is a pure refactor. No functionality is affected by this change. Change-Id: I8412dfcb457b34e53d168266fdb43c40e2054832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094714 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750794}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04ef810839cb..6b48e62ed204 git log 04ef810839cb..6b48e62ed204 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 mtklein@google.com remove unused mutate() apis 2020-03-16 herb@google.com Check fullness and purge on every strike lookup 2020-03-16 mtklein@google.com impl SkTDynamicHash with SkTHashTable 2020-03-16 csmartdalton@google.com Add pass-through helper methods from GrOpFlushState to GrOpsRenderPass Created with: gclient setdep -r src/third_party/skia@6b48e62ed204 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ie5e17df1409aa5808600562fabfd6e1ce13d36ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106501Reviewed-by:
-
Varun Khaneja authored
This reverts commit 894001eb. Reason for revert: Enabling this feature by default disables some Safe Browsing features for some users. For details, please see http://shortn/_T8HNQcH6yR Original change's description: > SafeBrowsingRealTimeUrlLookup: Enable by default for Desktop platforms > > Bug: 963165 > Change-Id: I782470e37747c460da3ba167a966af6d21023306 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069478 > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Auto-Submit: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744061} TBR=vakh@chromium.org,xinghuilu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963165 Change-Id: I3aafe160c611c218934fe8660fd4e0c363c3619f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106347Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750792}
-
Ayu Ishii authored
Convert DictionaryResultCallback Bug: 1007660 Change-Id: If1792a5089f396c10bdc331e48ac2b522296b60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048414Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#750791}
-
nancy authored
When discard the webpage, the webcontents is reloaded, and OnTabReplaced is called, then UpdateAppItemState remove the icon on Shelf. However, for the new webcontents, the icon is not added back to Shelf. Update OnTabReplaced, for web apps, add the icon back to Shelf. BUG=1056064 Change-Id: I90bd8d3677d287d020a6078b90845ca0b735396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103590Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#750790}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/341085a69375..9170376d36ad git log 341085a69375..9170376d36ad --date=short --first-parent --format='%ad %ae %s' 2020-03-16 rwkeane@google.com mDNS: Improved Receiver-Side Logging Created with: gclient setdep -r src/third_party/openscreen/src@9170376d36ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia70dce978eff245f044f988a384372ba11231c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106753Reviewed-by:
-
Yves Arrouye authored
Also adds a way to specify the signature algorithm when requesting secure remote commands which is using a signed policy data for the security of the response. Bug: chromium:1047328 Test: N/A Change-Id: I0fa9c47380272a02b217a450923476731d903718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031596Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#750788}
-
Luciano Pacheco authored
Change selectAll() to force a leadIndex if there is none, because having something selected without a leadIndex doesn't make sense. leadIndex is the currently focused item. This fixes renaming from context menu or selection menu when user has selected files only via "select all", without selecting any file file before the "select all" command. Bug: 1051899 Fixed: 1051899 Change-Id: I2a2f565af1341abd89f8bc9900e8a5b10595ee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104737 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750787}
-
- 16 Mar, 2020 13 commits
-
-
David Bienvenu authored
If a browser window is minimimized w/o focus in the location bar, and Chrome is launched from a shortcut or the command line, the window is restored, but doesn't get focus, which breaks keyboard accessibility. This CL adds a HandleWindowMinimizedOrRestored notification to HwndMessageHandler::PostProcessActivateMessage, when restoring a minimized top level window from ::Activate(). This causes the root window to get shown, which allows the view to subsequently get focus. Bug: 1048195 Change-Id: I147ffccc2a6d9b20623f1989a8ea4395ad56334d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088293 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Josh Simmons authored
Added SmbService as a power manager observer so that it can forcefully unmount any mounted smbfs shares during suspension, and remount them when the device powers back up. Bug: 1052729 Change-Id: I8c5d06a847322b7da063a3255afe4237d18e112b Test: Manually tested by suspending the machine with a mounted smbfs share Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097675Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#750785}
-
Daniel Clark authored
The purpose of this change is to work around an issue encountered when adding AX roles to the time picker popup to implement proper screen reader accessibility. The trick used to create hour/day/minute columns that loop infinitely when navigated by arrow key involves duplicating all the cells and placing them out-of-order in the DOM. This confuses screen readers so that they read out confusing things like "minutes column, 25, item 70 out of 120 selected", even with the right ARIA roles. I looked at two alternative fixes for this issue: 1) Applying aria-posinset and aria-setsize to the TimeCells. This seems like it should work, but these stop functioning when the number of items in the DOM is greater than aria-setsize or when the aria-posinset values are not increasing with respect to DOM order of the cells. 2) Marking cells aria-hidden and controlling screen reader announcements with an aria-live region. This could mostly work, but Windows Narrator doesn't draw proper focus rects for aria-hidden items, and this behavior is explicitly warned against in the spec per https://www.w3.org/TR/using-aria/#fourth so there could be interoperability issues. So as a last resort, this change re-implements the infinite scrolling behavior by dynamically manipulating the layout of the TimeCells so that they can be present in the DOM in an order and number that makes sense for a11y. This is achieved by a scroll event handler and ArrowUp/Down keydown event handlers that rotate the cells' layouts to ensure that more cells are always visible in the direction that the user is navigating. These rotations handle outside of the visible portion of the scroller so they are not visible to the user, who just sees an infinitely looping column of cells. One advantage to this change aside from the a11y issue is that mouse scrolling no longer bottoms out after 1-2 trips through the values; it now appears really 'infinite'. The obvious disadvantage is that this approach is more complicated and likely has more performance overhead. A subsequent (much simpler!) change will add the ARIA roles to finally make the control accessible. Bug: 1026544 Change-Id: If4eeb2e84731d3107b1f516544761b908cc62e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097250Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750784}
-
Adam Langley authored
This change allows a Finch parameter to list domains which will not receive attestations. BUG=846559 Change-Id: I8515ecef827e9df8b674e75f7690b1b0f3320fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103552 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#750783}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a72674ab7b4..f66f59d1fe63 Created with: gclient setdep -r src-internal@f66f59d1fe63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I79b42dd78360141b12e0a70fefa54156a9ed125c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106508Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750782}
-
Kevin Babbitt authored
This is a reland of 756820dd The original CL was reverted due to test failures on Win7. On both Win10 and Win7, UI Automation was generating an initial focus event when the test listener first connects. On Win10, this initial focus event comes from a window managed by the operating system (ClassName=ApplicationManager_ImmersiveShellWindow). Since that element is outside the scope of the test app, the test listener throws it out. On Win7, the initial focus event comes from an element in our web content, so the test listener logs it. My suspicion is that the difference in behavior is due to mitigations for focus stealing introduced between Win7 and Win10. Regardless, the fix is to generate separate expectation files for Win7. Original change's description: > Ensure UI Automation GetFocus reaches focused node in web content > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > node's subtree that currently has focus. When an element in web content > has focus, and a delegate in Views is asked for focus, that delegate can > only reach as far as the web content root. Calling GetFocus() again on > the web content root ensures that the platform API returns the currently > focused node. > > Bug: 928811 > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#749386} Bug: 928811 Change-Id: I32e59febfb6dbb7b5386c155c252c880a0f2ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101930 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Bo Liu authored
There are roughly two changes in this CL. First is in CompositorImpl and BrowserGpuChannelHostFactory to drop the gpu channel from the browser process when all CompositorImpls are destroyed. BGCHF will check if it has the only reference to the GpuChannelHost, and if so, destroy it. The check is performed in CompositorImpl destructor to minimize impact to chrome; it is possible to consider checking when CompositorImpl becomes invisible in the future. Second piece is GpuChannelManager in the GPU process will send a message when all GpuChannels are destroyed. This message is passed to GpuHostImpl, which will has a timeout of 10s. If there are no pending or new establish channel requests in this time, then it will tell GpuProcessHost. GpuProcessHost will give the content embedder a chance to decide whether to kill the GPU process, and if yes, shutdown the GPU process. There are different GPU shutdown paths. This implementation just deletes GpuProcessHost. The benefit over paths that tell the GPU process to quit its main loop is deleting GpuProcessHost can guarantee no trasient failures. All establish channel request are routed through the browser IO thread. GpuHostImpl makes sure to only shutdown when there are no requests and the GpuProcessHost is deleted synchrnously on the IO thread. So subsequent requests will start by creating a new GpuProcessHost and launching a new GPU process. On Android, deleting GpuProcessHost will remove all bindings to the GPU process, at which point Android OS will kill the GPU process; most desktop platforms will send sigterm, then after a timeout, sigkill to the GPU process. This does not involve cleanly exiting the GPU main loop, which in the past has caused crashes. Enable this behavior in weblayer, which does not use any other gpu-hosted services. Bug: 1058509 Change-Id: I81055a118d0e9b3f7e8ed8203780ad1b124e3f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102592 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750780}
-
Clark DuVall authored
This will be needed to componentize GeolocationPermissionContext. The main change here is switching LocationSettings from taking a WebContents to take a WindowAndroid, which reduces the deps needed in the location component. Bug: 1025625, 1025609 Change-Id: Icd8e9aafd2ed04e7570e75299c4fb4175749b7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105194 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#750779}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/022952303c1a..93f88af15b3c git log 022952303c1a..93f88af15b3c --date=short --first-parent --format='%ad %ae %s' 2020-03-16 rharrison@chromium.org Rolling 5 dependencies 2020-03-16 enga@chromium.org Fix D3D12 over-eager lazy zero initialization for textures Created with: gclient setdep -r src/third_party/dawn@93f88af15b3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8fbf36e99aa490afb1d2775a337bf94d1d647976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106500Reviewed-by:
-
Hongchan Choi authored
This is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/2091226. Bug: 1058680 Change-Id: I5089b560d1208e0fc678f5cfd8b511bbab623bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105566 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750777}
-
Martin Šrámek authored
This was previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/2090424 but reverted due to a BUILD.gn failure. The compilation failure was caused by the fact that the payments section had been migrated to Polymer3, whereas the metrics proxy hadn't. After https://chromium-review.googlesource.com/c/chromium/src/+/2099026 landed and migrated it, this CL fixes the BUILD.gn dependencies and JS imports. Bug: 1032584, 1062071 Change-Id: I732cd4cfe82b87062e8b4c845cd69423db0467b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098723Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#750776}
-
Kevin Ellis authored
animation.effect Transition events were dropped after a call to animation.effect. CSSTransitions uses an event delegate to dispatch events as a result of changes to the timing phase. The event delegate was getting dropped when the effect changed. A special case is when effect is set to null. In this case, we need to dispatch a transitioncancel prior to losing the old event delegate. Bug: 1059936 Change-Id: I9eda3484fb0c9de08e8398e1975031d6a1f58940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103034 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Robert Woods authored
apps::FileHandlers. This CL is related to two ongoing projects: the implementation of file handling APIs for PWAs in Chrome (go/chrome-file-handling-api), and BMO (go/chrome-bmo), which is concerned with moving PWAs off the Extensions stack and establish them on an independent web apps platform. As part of the first project, we created a new representation for file handlers (apps::FileHandler) that has some properties needed for OS integration. Pre-BMO PWAs ("Bookmark Apps") use apps::FileHandlerInfo. It's simple to convert from FileHandler to FileHandlerInfo, but impossible to do the reverse. This means that if file handling lands before BMO, migrating installed PWAs to the new system will be a destructive operation. The goal for the set of CLs to which this one belongs is to have BMO web apps and Bookmark Apps share the apps::FileHandler representation. We have added a new "web_app_file_handlers" key to the Extension manifest, along with parsing for the new format (crrev.com/c/2081714). We serialize the apps::FileHandlers attached to a web app on that key when installing it as a Bookmark App (crrev.com/c/2087327). Here we effectively replace apps::FileHandlerInfo with apps::FileHandler across both Bookmark Apps and BMO web apps by having GetAllFileHandlers return the new struct. Finally, we implement migrating Bookmark Apps file handlers to the new platform as a simple copy (crrev.com/c/2086453). Since file_manager::file_tasks::FindWebTasks receives file handlers via this route, changes have been made there and some new utility functions have been added to chrome/browser/chromeos and extensions/browser/api. These mirror existing functionality for apps::FileHandlerInfo, and sit alongside it. Existing browser and unit tests for GetAllFileHandlers (via GetEnabledFileHandlers, which wraps it) can be found here: https://cs.chromium.org/chromium/src/chrome/browser/ui/web_applications/web_app_file_handling_browsertest.cc https://cs.chromium.org/chromium/src/chrome/browser/web_applications/components/file_handler_manager_unittest.cc Bug: 938103 Change-Id: I4b7f1f50dd62ed68b13e7522dc1261019c1e4ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087306 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
