- 17 May, 2019 40 commits
-
-
Brian White authored
This reverts commit 81046e57. Reason for revert: Mac ASAN tests are failing: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29?limit=200 This seems the most likely culprit between the last good and when the (very frequent) failures began. https://chromium.googlesource.com/chromium/src.git/+log/17f09d5d92fc142fae6863b6c0d8bae17355ab95..8dde0a59b1362fc7a19186ca686cd5c6960003f5 [33545:775:0516/215851.235197:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [90mtracing_service_impl.cc:[0m [39mConfigured tracing, #sources:2, duration:0 ms, #buffers:1, total buffer size:12 KB, total sessions:1[0m [90mshared_memory_arbiter_im[0m [31mShared memory buffer overrun! Stalling[0m ... Original change's description: > Migrate blink::MediaStreamVideoSource to WTF::Bind > > This CL is the 3rd out of n CLs to convert modules/mediastream/ > away from base::Bind{Once,Repeating} to their respective Blink/WTF > counterparts. > > In this particular CL, a weak reference of MediaStreamVideoSource is > passed to VideoTrackAdapter ctor to avoid double-bind methods with > CrossThreadBind -> ConvertToBaseCallback -> CrossThreadBind. > > R=dgozman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: Ibd75c5fef80bef1a4328c4abb007fb07efbcc095 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594114 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660725} TBR=haraken@chromium.org,hiroshige@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,tzik@chromium.org Change-Id: I082573534da71adbb7b56a70d3b34ccd15272ba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616857Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660986}
-
Robert Sesek authored
Bug: 958976 Change-Id: I7fc2bcdb8f2fadeab82a88a8c9b5a66c5b1aca25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618041Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#660985}
-
Gayane Petrosyan authored
This reverts commit 1843462f. Reason for revert: Color calculation is too long and freezes the browser for 1-2sec. Original change's description: > [NTP] Calc and store custom background color V2. > > When user selects new custom background, use thumbnail from image > collections to fetche and calculate calculate the most frequent color on > the image. The calculated color is then stored in prefs with the rest of > the background info. > > Bug: 874325 > Change-Id: I5905b583f22174a491749543e922512e6b47caf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612235 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660899} TBR=gayane@chromium.org,kmilka@chromium.org,nicolaso@chromium.org Change-Id: Id7ce0fd7255fcacd7322777e32d914defd8003d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616855Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#660984}
-
Mehran Mahmoudi authored
This shows the progressbar that includes the current URL when the activity is resumed. Bug: 961404 Change-Id: I61bbc4ac02006c39b3e32d8615489bcc785719ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617646Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660983}
-
James MacLean authored
This reverts commit fb42e13e. Reason for revert: MSAN test failing. Original change's description: > Refactor to remove RenderWidget::PageScaleFactorChanged(). > > This refactor moves the logic in RenderWidget::PageScaleFactorChanged() > to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for > RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). > > This is a re-land of > https://chromium-review.googlesource.com/c/chromium/src/+/1614080. > > TBR=dcheng@chromium.org > TBR=collinbaker@chromium.org > > Bug: 924336 > Change-Id: Id076ddc805c62069984181914f3722d4d081a3b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617064 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660834} TBR=dcheng@chromium.org,wjmaclean@chromium.org,collinbaker@chromium.org Change-Id: Ied08b30c3363b2cee0d3e01994b06e50835bb27d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616739Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#660982}
-
Yutaka Hirano authored
No one inherits it, so replace protected with private. Also make it a final class. Bug: None Change-Id: Icc7d927c711514f9a64d29290826ae3f824f33bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616876 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#660981}
-
Lan Wei authored
This reverts commit 9a00ff2b. Reason for revert: <INSERT REASONING HERE> Merge to M75 beta is failed, so I need to reland it in master and then try to merge it again to M75. Original change's description: > Use IMM32 instead of TSF on Win7. > > On Windows 7, there are many IMM32-based IMEs are relying on IMM32 > support. We should continue supporting those legacy IMEs on Win7. We > should disable TSF on Win7 and use IMM32. All other Windows platforms > are not affected. > > Bug: 963558 > Change-Id: I8f77afbdb734c355f4393880e80fafd98e25ae88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613974 > Reviewed-by: Yohei Yukawa <yukawa@chromium.org> > Commit-Queue: Siye Liu <siliu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#660261} TBR=yukawa@chromium.org,siliu@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963558 Change-Id: I4341bed006e86e756a21997c167c9526c6ce2901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618010Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#660980}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c5202e607426..b6220d071585 git log c5202e607426..b6220d071585 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 thestig@chromium.org Avoid an integer overflow in CJBig2_SDDProc::DecodeHuffman(). Created with: gclient setdep -r src/third_party/pdfium@b6220d071585 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:963885 TBR=pdfium-deps-rolls@chromium.org Change-Id: I84780ac8a160f39fb1465fcc4aaf9ce12a59fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660979}
-
Pavel Yatsuk authored
In this change: - Remove getActivity() from TouchlessContextMenuManager.Delegate and adjust consumers. Implementation of handleMenuItemClick should supply context - Remove TouchlessExploreSitesSiteViewBinder and optimize code around it. BUG=959317 R=dewittj@chromium.org,dominickn@chromium.org Change-Id: Ie30ee4a5448fb67fc7d01b4ae2f9322fbfc556ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615832Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#660978}
-
Stephen Martinis authored
Bug: 888810 Change-Id: I5a751c764fe5b43c9604b52abf7d4b6e73a19d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618021 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#660977}
-
Erik Jensen authored
Instead of attempting to maintain a persistent identifer for our mobile clients, create a unquie UUID to be used for the session. Change-Id: I284c76480ce19c19e39bfb4acc4af02be160fe1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613961 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660976}
-
David Tseng authored
This change: - reports network changes - does not report signal changes on the same network name - splits the connection status string into name (e.g. connected to foobar) description (e.g. weak signal) which are more semantically meaningful for ChromeVox - omits hints for ChromeVox alerts Bug: 955815 Change-Id: I0972026772a2f523af51a9c77016d6ec47818ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614123 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#660975}
-
Adam Langley authored
With r660884, the “rotate” animation now sets the visibility of the layer and so we no longer need to override it and use the “fade” animation instead to avoid DCHECKs. This effectively reverts r659735. Change-Id: I6fbbc47a606b0bb9cbf8017e14b9f3719c16f887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617207 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#660974}
-
John Lee authored
Bug: 964448 Change-Id: Ia44cae0803d49bf16c5df3bb945f0c8ea2841c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617095 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#660973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09eabed99d0e..52bfbd35fc96 git log 09eabed99d0e..52bfbd35fc96 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 ynovikov@chromium.org docs: Update Android Test Instructions reference 2019-05-17 syoussefi@chromium.org Vulkan: Tighten descriptor stage usage hints Created with: gclient setdep -r src/third_party/angle@52bfbd35fc96 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I31ebfd54dcebd3343f075130350bad9548ca1d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660972}
-
Lloyd Pique authored
When processing systrace events, a decimal timestamp in seconds like "123.456000" was being parsed as a pair of int32_t's separated by the dot, and then converted into an microsecond integer value by scaling the integer seconds value appropriately, and adding the fractional part. However if the number of seconds was large enough, the multiplication would overflow an int32_t, resulting in an incorrect timestamp being computed, which then caused those events to be filtered out as they were not in the expected range. The fix was to simply implicitly convert to an int64_t to hold the result of the multiplication. This was enough to fix the bug. However the parsing makes a potentially unsafe and unchecked assumption that the number of digits after the decimal point is always the expected amount. If it was ever different, the computed timestamps would be incorrect. I also went and corrected most of the code to use a uniform type for the timestamp of uint64_t, as parts of the code used int64_t, and other parts used double. Doubles are still used however for JSON serialization and deserialization. To verify the timestamp parsing, I added some specific tests to the unit test. TEST=Unit tests pass, arc-graphics-tracing works BUG=b:132907802 Change-Id: I8608fae90eb4708f5c6abd7088ca4b859aeab91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616325Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/master@{#660971}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cd707e6f223e..62ad1eeb0e6b git log cd707e6f223e..62ad1eeb0e6b --date=short --no-merges --format='%ad %ae %s' 2019-05-17 sugoi@google.com Allow ImageView to cast compressed texture into other formats 2019-05-17 bclayton@google.com LLVMReactorDebugInfo: Fix warning that function may end without return. 2019-05-17 bclayton@google.com CMakeLists: Allow the sanitizers to be enabled for GCC Created with: gclient setdep -r src/third_party/swiftshader@62ad1eeb0e6b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Iebf8e696de5ebcf20b2fb0d4573c5f7f0938a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660970}
-
sczs authored
Creates a Histogram and enum for an InfobarBadgeTapped either active or inactive. Adds IsInfobarBadgeActive flag to InfobarBadgeTabHelper, this is needed to update the active state whenever switching webstates.* *Unit test update coming up in a followup CL since I want to keep this one simple, and testing that requires some changes to the unittest setup. Bug: 892376, 963482 Change-Id: I5d2f62bdac3d930929674b315ac6e7d54ba9b385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612362 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660969}
-
Koji Ishii authored
This patch implements a specialized painter for `::first-line` background for LayoutNG. LayoutNG tried to avoid this special code by inserting anonymous inline box. Because the spec[1] states "behaves similar to that of an inline-level element" and that it can utilize existing paint code for regular inline boxes. However, special code to build and manage LayoutObject tree is getting bigger and bigger. It's started to be more complex than writing a special code in paint. This approach is more similar to what legacy does. [1] https://drafts.csswg.org/css-pseudo-4/#first-line-styling Bug: 963575 Change-Id: I69120ccf44fe9055d68181b83dc1bc4b91c542d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611700Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#660968}
-
Justin Cohen authored
Bug: 964323 Change-Id: Ibf17edb4b9f736887c8c6ebfd81d8e59e838124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618042 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#660967}
-
Jesse Selover authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935, https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4, and go/allow-credentials-tracker for the motivation and progress of this change. This is the only place where a request is configured with LOAD_DO_NOT_SEND_COOKIES without either of the other two load flags. The request currently saves cookies, but doesn't send them. I've conservatively put allow_credentials = true on this request, which will cause the saved cookies to be sent. If your service doesn't require cookies then it should be allow_credentials = false. Bug: 799935 Change-Id: Ibd435acc810359482ec97d633637e42dc53923a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600546 Commit-Queue: Jesse Selover <jselover@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Jesse Selover <jselover@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660966}
-
Mason Freed authored
This feature has received 3LGTM's on the I2S: see [1]. SHERIFFS: If this commit causes layout (or other) tests to fail, especially anything related to filters or backdrop-filter, feel free to revert it. There are some known bugs (see [2]) but none should have much impact. Perhaps the most impactful is [3], which is that when running with GPU rendering disabled (--disable-gpu), backdrop-filter is not fully implemented. That is in progress now, but I would like to begin gathering other latent bugs. [1] https://groups.google.com/a/chromium.org/forum/m/#!topic/blink-dev/GRl1_Qy97jM [2] https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3ATopic-Backdrop-Filter [3] https://crbug.com/916318 Bug: 497522 Change-Id: Ib2241d45e59b7b68e9e3073fd4e32028d93a2d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614683 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660965}
-
David Bokan authored
This reverts commit 07da8ba6. Reason for revert: Causing issues in 962784 and 951901 Original change's description: > Reland "Recreate DirectManipulationHelper when every LRWHH UpdateParent" > > This is a reland of 61450bbc > > Original change's description: > > Recreate DirectManipulationHelper when every LRWHH UpdateParent > > > > Compositor and window event target is associated with window's parent. We call > > LRWHH UpdateParent when window's parent update, includes window's parent > > actually update and window initialize. Recreate DirectManipulationHelper on > > every window's parent update helps keep DirectManipulationHelper lifecycle > > tracking simpler. We also make CompositorAnimationObserver owned by > > DirectManipulationHelper. > > > > With this changes, we start the DirectManipulation event polling when > > DirectManipulationHelper created and stop when it destroyed. The issue should be > > fix since event polling start no more depends on DM_POINTERHITTEST. > > > > > > This also includes 2 refactoring changes: > > > > 1. Move CompositorAnimationObserver into DirectManipulationHelper. > > 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is > > actually transformed in RUNNING - READAY sequence. > > > > Bug: 914914 > > Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#649342} > > TBR=sky@chromium.org > > Bug: 914914 > Change-Id: Ic0c8aa84d21fe7a88fd9d3552dbd5ffdb6adcc4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562582 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649682} TBR=sky@chromium.org,chaopeng@chromium.org Bug: 914914,951293,951901,956579 Change-Id: I4252717e2f708643b1d6b3f8305c32142a1a2735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618008Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660964}
-
Kyle Milka authored
Update the default background tile to use the correct icon. Screencast: http://go/scrcast/NTA1MjYwODk1NzkwNjk0NHw5MDBlYzU5YS1mMg Bug: 937570 Change-Id: Ib1aa03cb0fab2e681774424492511d239f62dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618001Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#660963}
-
Sam Maier authored
This change enables binary resources (instead of the deprecated legacy mode) for Robolectric. Also, this CL fixes a number of tests which are broken by this change. Updated some robolectric Android jars to enable usage of this newer feature. TBR=Last 2 files are just updating from J to K Bug: 963624, 635199 Change-Id: If99f8850baa5de9d8ec8eaf2c58b2c0b16be0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611875 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660962}
-
Yuwei Huang authored
This is a reland of 7432ef1a It fixes the issue of remoting_support_host_messages.proto using host_info.proto without depending on it. Original change's description: > [remoting][IT2ME] Register support host over remoting API > > This CL adds a RemotingRegisterSupportHostRequest that registers an > IT2ME host using the new remoting API. This will be used for the > ChromeOS enterprise use case but the website will still use the old > XMPP-based registration request until it is updated to support that. > > Bug: 962765 > Change-Id: Ifcf2eb6eaba76db6386ae27f86f20e06088383f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611023 > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660738} Bug: 962765 Change-Id: Ia5e6bf1263ad7f2e4f353c9fc0e0c13d73bb8be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617100 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660961}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/819795047c32..fdbb15913346 git log 819795047c32..fdbb15913346 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 evanhernandez@chromium.org api: Regenerate binhost proto 2019-05-17 mikenichols@chromium.org upload_symbols: Refactor duplicate to utilize batch api Created with: gclient setdep -r src/third_party/chromite@fdbb15913346 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9156b72e613f3ddaa0cd94a079bf3eca83e44e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660960}
-
Xianzhu Wang authored
Change-Id: I13a4bbd5f919a744ac4fecc0a48651e95a9138b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612358 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660959}
-
Timothy Loh authored
This CL updates the Plugin VM strings used in the settings page, fixes some errors in the descriptions and marks them as translatable. Bug: 950431 Change-Id: I45252e977860abfcbdab22649a1141eee8a49bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614727 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660958}
-
Pavel Shmakov authored
Support the api added here: https://android-review.googlesource.com/c/platform/frameworks/support/+/958733 Since CustomTabActivity is recreated when system setting is changed, it's enough to pick correct scheme parameters when activity is launched and new instance of CustomTabIntentDataProvider is created. Bug: 960453 Change-Id: I975682a8f6dd57a5ab6fa0bc12dc769e80631bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599591 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#660957}
-
David Maunder authored
Bug: 961356 Change-Id: Ibc00f936ffe9978e8599e132dfdf7f1a1a70c2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612662 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#660956}
-
John Budorick authored
Bug: 790202 Change-Id: Icb8d353adb84747d5791c7a38e3ef211690cf712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614025Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#660955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6e50309dcbd..bbaaf61f1d99 Created with: gclient setdep -r src-internal@bbaaf61f1d99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I92ebb34e7beb1fe32a7f3aa6c9a0002bfc604100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660954}
-
Mounir Lamouri authored
This is also delaying resolving the promise to make sure the order stays the same. Bug: 960657 Change-Id: I92095affb8223dd60346796eec1b6cd7d3f0efc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617552Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#660953}
-
Ken Rockot authored
This is a replacement for the global content_browser service instance. Necessary because some random services (like pdf_compositor) connect directly to content_browser by name. There are multiple instances of content_browser -- the global one, and one per Browser Context -- and it is impossible in general for the Service Manager to correctly resolve these connection requests to the global instance. It only works today because of a combination of luck and subtle Service Manager complexity which is about to be deleted. Furthermore, the work done and interfaces exposed by the global instance vs the per-BrowserContext instances are almost entirely non-overlapping, so they are functionally different services already anyway. For now content_system's service manifest programmatically mirrors the content_browser manifest (plus overlays), without its packaged services. All non-renderer clients which connected to content_browser before are updated in this CL to connect to content_system instead, and content_system is designated as a singleton service to ensure the Service Manager can always properly route to it. This is a precursor to removing the content_packaged_services service, as well as removing packaged services from content_browser and generally simplifying service registration across the system. Bug: 961869, 895615 Change-Id: I9b022f1600ff25e72795e9f63d9b9b978079f80f TBR: avi@chromium.org TBR: blundell@chromium.org TBR: boliu@chromium.org TBR: halliwell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606764Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#660952}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: Ica6b02cfca8e95e5e41871153359fe36f33c0599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613372 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660951}
-
Tanya Gupta authored
This JNI layer is needed for the SendTabToSelfInfobarController to listen for model changes and show an infobar accordingly. This required refactoring the code that converted the native SendTabToSelfEntry to the Java version. Change-Id: I2b63c2bfbfa66ac70a2fd320ae7d9652b1ff996b Bug: 949233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611223Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#660950}
-
John Williams authored
CastDialogSinkButton::RequestFocus is called recursively, resulting in a DCHECK failure. As a workaround, this function now detects when it is called recursively and aborts prematurely. Change-Id: I4847f862868ef9c15ed0ca6cd54cb36cc559a901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488581 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#660949}
-
Joey Arhar authored
Currently in the websocket message viewer, sent text messages have a green background, received text messages have a white background, and binary messages are yellow on yellow. This patch removes all of these interesting colors and replaces them with data grid striping to look more like the other datagrids in devtools. Screenshots: http://crbug.com/963949#c2 Bug: 963949 Change-Id: I0403a8c67a36e5ad0bd006d59e60fc02d371d7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614036Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#660948}
-
Eric Roman authored
Bug: 962523 Change-Id: Ie88be0e1cd3d132e1124aded16cdcec0bd65c2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613936Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660947}
-