- 14 Nov, 2017 40 commits
-
-
Mathias Bynens authored
9fcebbe1 temporarily disabled these tests in preparation for shipping RegExp Unicode property escapes in V8. Now that Unicode property escapes have shipped, the test expectations can be updated accordingly, and the tests can be re-enabled. BUG=v8:4743 Change-Id: I6fc3add3692dd1da7da59b83704b98db415fcd8e Reviewed-on: https://chromium-review.googlesource.com/765368Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#516266}
-
Sylvain Defresne authored
Remove the -isPrerenderTab public property from Tab (keep it as a helper internal method as Tab is still responsible for most of the behaviour of the WebState during pre-rendering after this CL). A Tab is considered as pre-rendering if the corresponding WebState is owned by PreloadController. Currently most of the logic is still in Tab class itself, but once most of the code has been moved to tab helpers, a pre-rendering tab will only have a subset of the tab helpers, and the logic of cancelling the pre-rendering will move to PreloadController. Add a boolean to track when a pre-rendered Tab is converted to a real Tab in BrowserViewController (some of the callbacks invoked when the WebState is inserted in the WebStateList needs to know that the WebState was pre-rendering but most of the code want to be able to assert that no pre-rendering Tab is in TabModel). With this CL, TabModel does not contain any pre-rendering Tab at any point in time (this becomes a new invariant of the class). Bug: 754050 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8b5eeec8edc7911481ea28953dcc6a338ccfe87a Reviewed-on: https://chromium-review.googlesource.com/732263 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#516265}
-
Patrik Höglund authored
Found this bug when I saw files were getting uploaded (after landing chromium:767857), even when the test was succeeding. This is not WAI, it should only upload when the test fails. Turns out it's a bug in the test where we missed to delete one file. Bug: chromium:767857 Change-Id: I750173bc479bd9d084defb5e7cfbd63ef2d4c2ca Reviewed-on: https://chromium-review.googlesource.com/768667Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#516264}
-
Morten Stenshorne authored
Hopefully I'm not touching any flaky tests by doing this, but I need a clear overview over what's failing and not, so keeping them around was bad for coverage. TBR=atotic@chromium.org Change-Id: Ia19789bcc045ccd9731040c02a01ae76041da94e Reviewed-on: https://chromium-review.googlesource.com/768380Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#516263}
-
Patrik Höglund authored
The sound card has been re-installed on all win bots so this should work now. Bug: chromium:677256 Change-Id: I993f14dc8e6c4bb1ace09d1a793b1e79214209fe Reviewed-on: https://chromium-review.googlesource.com/768379Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#516262}
-
Han Leon authored
BUG=772793 Change-Id: I48b56e1da07429a4630c6ba7bc7625c13e85a252 Reviewed-on: https://chromium-review.googlesource.com/758154Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#516261}
-
Sylvain Defresne authored
Convert AutofillTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If3881f8241ec52fd54499c178eb77580e2404fd6 Reviewed-on: https://chromium-review.googlesource.com/757316 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516260}
-
Tatiana Gornak authored
BUG=739343 Change-Id: I5821dd6bdf1eee4fd7aa3798818da307106ca4f6 Reviewed-on: https://chromium-review.googlesource.com/768710 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#516259}
-
Sriram authored
Removing the following test cases infavor of the web platform tests in html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/ 1. endTime.html 2. id.html 3. onenter.html 4. onexit.html 5. pauseOnExit.html 6. startTime.html 7. track.html Bug: 782555 Change-Id: Ie80b99918d2a230f3b0e1c72a8ed22a381707d38 Reviewed-on: https://chromium-review.googlesource.com/768354Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#516258}
-
jdoerrie authored
TBR=sky@chromium.org Bug: 784792 Change-Id: Ib1cb7e3d38f887ce7e1411c06e40d4d58f677ea7 Reviewed-on: https://chromium-review.googlesource.com/768381Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#516257}
-
Marti Wong authored
Remove unwanted accessibility element from reused cells. Bug: 783577 Change-Id: Ife56a9c514c19d5966ec135e4d8f293ab59c3b4c Reviewed-on: https://chromium-review.googlesource.com/768333 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#516256}
-
Marti Wong authored
After crrev.com/c/757887, there are still some broken egtests when new iOS bookmarks feature flag is enabled (some only broken on iPad iOS 11). This CL fixes them or adds scoped feature list to them so that they will not break for the new iOS bookmarks. Bug: 782127 Change-Id: Ic830fdc8d096c22a953bd13eb1c47446ac88c4c8 Reviewed-on: https://chromium-review.googlesource.com/765407 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#516255}
-
Sriram authored
Removing the following test cases infavor of the web platform tests in html/semantics/embedded-content/media-elements/ interfaces/HTMLElement/HTMLTrackElement/ 1. default.html 2. kind.html 3. label.html 4. readyState.html 5. srclang.html 6. track.html Bug: 782555 Change-Id: I0e72be580c3bf7b9e8b9249882d677fb7e477c32 Reviewed-on: https://chromium-review.googlesource.com/768507Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#516254}
-
cathiechen authored
Apply the design which align the vertical position of marker according to content to lists with first child like: 1. Writing-mode root 2. LayoutBlock which isn't LayoutBlockflow, such as: flex\table\grid 3. Also fixed overflow with block children. Bug: 767408 Change-Id: I0a3550f146a396b86f7d1db77fc0707f179fee26 Reviewed-on: https://chromium-review.googlesource.com/754768Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#516253}
-
Rob Percival authored
Identifies where the address list held by that entry came from, e.g. a DNS lookup or HOSTS file. This will be used to prevent Certificate Transparency checks being performed over DNS if the website's IP address was not obtained over DNS in the first place (to preserve privacy). Bug: 506227 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea6603b89cd29fb8b9cfae6b581583e1ee896eb5 Reviewed-on: https://chromium-review.googlesource.com/716483Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#516252}
-
Erik Språng authored
Bug: chromium:763949 Change-Id: I90c24774e24332d53fa8daa376c8401632ab3738 Reviewed-on: https://chromium-review.googlesource.com/763454Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Erik Språng <sprang@chromium.org> Cr-Commit-Position: refs/heads/master@{#516251}
-
Robert Hogan authored
Bug: 417223 Change-Id: I4decce9019f69a35b1c5fefcdbb19d14e480ec36 Reviewed-on: https://chromium-review.googlesource.com/755714Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#516250}
-
Christos Froussios authored
DD and mocks are in the bug. Bug: 784334 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1fd6778552902c67d94d063acab0b564b6b8f92d Reviewed-on: https://chromium-review.googlesource.com/766188Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#516249}
-
Hiroki Nakagawa authored
This CL disallows Worklets on insecure contexts based on the decision on the intent-to-ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Jex3idOld48/VeOxMUNDBAAJ Bug: 779938 Change-Id: I5fde5f15f444769c4e7f08b1a7ae7746717707f0 Reviewed-on: https://chromium-review.googlesource.com/746494Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#516248}
-
Luciano Pacheco authored
CL 7 of 10. Bug: 755727 Change-Id: I4187020dc9b8ae50d80f3bd4826dd8e16371fd58 Reviewed-on: https://chromium-review.googlesource.com/768512Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516247}
-
Gauthier Ambard authored
This CL removes the code used by the StackView to do the previous animation when entering/leaving. Bug: 779514, 778226 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0b4b0207fcad38c95bb1b46d895354ce623a0d0 Reviewed-on: https://chromium-review.googlesource.com/747421Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#516246}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9b9010d87517..74c8436f2c34 $ git log 9b9010d87..74c8436f2 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ ff7aac5e4..f4f293eff (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I78b2cad79c7b8cbaff88b1e1d9f1807352eb8a7b Reviewed-on: https://chromium-review.googlesource.com/768648Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516245}
-
Stuart Langley authored
This CL removes the WTF type traits they were just forwarding through to the std:: equivalents. I kept the test code so we can be sure that the traits are what we expect them to be across different compilers and different platforms. Bug: 579462 Change-Id: Ia7ec17e1289d130dbafe13f6796acfa079a73805 Reviewed-on: https://chromium-review.googlesource.com/768100Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#516244}
-
Luciano Pacheco authored
Fix missing include for <memory> and some for <utility> as pointed by lint. CL 10 of 10. After all 10 CLs are merged, I'll remove WTF::MakeUnique. Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id7021e32bc2c366ec35cdc31074cd7e3a04405ef Reviewed-on: https://chromium-review.googlesource.com/768597Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516243}
-
Colin Blundell authored
In several parts of the implementation of the chrome.identity.getAuthToken() extension API, it can launch a signin flow. This signin flow gets launched in response to discovering that the user isn't signed in or in response to an error occurring that indicates that the user needs to reauthenticate. However, the policies on launching the signin flow are flawed in ways that negatively impact users: (1) Several parts of the flow do not gate the number of times that they launch a signin UI. This can result in the browser becoming unusable if there are bugs that result in the flow looping without user intervention (see crbug.com/772122). (2) The implementation launches a signin UI even in cases where the user's refresh token is in a valid state, i.e., when the error is not one that can be fixed by the user reauthenticating. This is unnecessarily intrusive to the user. This CL solidies and unifies all of these policies into one: - Start a signin flow at most once and only if the user's refresh token is not in a valid state. This is a behavioral change that eliminates the possibility of hammering the user with login pages and avoids asking the user to reauth if we don't think that the problem is due to reauth. This CL also adds several tests that fail without the policy changes made in the CL. Note that this change *is* a behavioral change. To test that this change has not broken the common case of the user needing to reauth due to their refresh token being in a bad state, do the following: - Install an extension with the identity API in its manifest. - Sign in to Chrome. - Go to accounts.google.com and revoke your refresh token for Chrome there. - Ensure that your account in Chrome goes into an error state (verify that a red exclamation point appears in the top right by your account name). - Go to chrome://extensions, enable developer mode, and inspect the background page of the above app. At the JS console that that brings up, execute: chrome.identity.getAuthToken({interactive: true}, (token) => {console.log(token);} ) - Verify that a signin prompt then opens. - Sign in to Chrome. - Verify that at the JS console referenced above a token gets printed. Bug: 772122 Change-Id: I779134f706ca1e693612ae3352a5c5dd0a3e468f Reviewed-on: https://chromium-review.googlesource.com/758647Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#516242}
-
Lei Zhang authored
Change-Id: Ic7a5c9dda06f2556f2d4ea572394ae93d0372164 Reviewed-on: https://chromium-review.googlesource.com/768323Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516241}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2eea3727..4e1cd28a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I53aef59301dab84cfd4e4085b95962bfa6bfd801 Reviewed-on: https://chromium-review.googlesource.com/768489Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#516240}
-
Yoshifumi Inoue authored
This patch introduces |CanUseInlineBox()| as a preparation to add |DCHECK(CanUseInlineBox())| to functions using |InlineBox| for marker of progress of LayoutNG project. To release LayoutNG, we should not hit these |DCHECK()|. Following patch will utilize |CanUseInlineBox()| into layout/ and editing/. The patch[1] is a sample of utilization. [1] http://crrev.com/c/763188 [LayoutNG] Utilize DCHECK(CanUseInlineBox()) in core/layout/ Bug: 591099, 707656 Change-Id: Id71c39ae8520ab18fd1b8b8f3e18a66e8a7d567c Reviewed-on: https://chromium-review.googlesource.com/768572Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#516239}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf7e8d8a5001..a0e6b95cbb47 $ git log bf7e8d8a5..a0e6b95cb --date=short --no-merges --format='%ad %ae %s' 2017-11-13 iannucci [led] Roll led to latest version. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I02d88474b5dd600bd7e582f5f1a74b1edbd40bfb Reviewed-on: https://chromium-review.googlesource.com/768523Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516238}
-
Luciano Pacheco authored
Add missing <memory> and some other std headers as pointed by lint. CL 6 of 10. Bug: 755727 Change-Id: I0781468ccceb4b6bb22ced01290918cec241a1fb Reviewed-on: https://chromium-review.googlesource.com/768510Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516237}
-
Luciano Pacheco authored
Add include <memory> where needed according to lint. Bug: 755727 Change-Id: I4d0e52593f789fc4c23112d8dc178f21c766907c Reviewed-on: https://chromium-review.googlesource.com/765610Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516236}
-
Takashi SAKAMOTO authored
virtual/layout_ng/fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html virtual/layout_ng/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html virtual/layout_ng/fast/block/float/overhanging-float-add-in-static-position-block.html virtual/layout_ng/fast/block/float/overhanging-float-add-in-static-position-block2.html virtual/layout_ng/fast/block/float/overhanging-float-remove-from-absolute-position-block.html virtual/layout_ng/fast/block/float/overhanging-float-remove-from-absolute-position-block2.html BUG=635619 TBR=dgozman Change-Id: I74707ebf7aa96f9cc911dffd2a7de4d9c2aa6ddd Reviewed-on: https://chromium-review.googlesource.com/768607 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#516235}
-
Han Leon authored
BUG=783563 Change-Id: Ia722365d7c893829366caa80116176dcde4015f5 Reviewed-on: https://chromium-review.googlesource.com/765294Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#516234}
-
Olivier Robin authored
This reverts commit 0cd65fc5. Reason for revert: breaks official builds Original change's description: > Reland "Generate frameworks in target_gen_dir instead of root_build_dir." > > This reverts commit d16c535e. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I978fde2edb396307d896a2027beb04457e5f1972 > Reviewed-on: https://chromium-review.googlesource.com/758809 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516077} TBR=sdefresne@chromium.org,liaoyuke@chromium.org Change-Id: Ib18cb06cd301b9e1d9067c834f8a8cce41e779fc No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/768687Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#516233}
-
Christopher Lam authored
This CL fixes an issue where Desktop PWAs would show their URLs before the page had loaded due to the implementation of NavigationEntry::GetTitleForDisplay(). This has been fixed by adding a GetTitle() to HostedAppBrowserController which uses NavigationEntry::GetTitle() instead. Bug: 784226 Change-Id: I7bb8bf32026cf2b623ecaa2aa278a73fe23b6250 Reviewed-on: https://chromium-review.googlesource.com/765560 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#516232}
-
tzik authored
This contains: - Replace base::Callback with base::RepeatingCallback in //gin - Replace custom tuple index handling with std::index_sequence - Remove no longer needed specialization for empty binding Change-Id: I866578017f79aca4979e6f4665292cdae5df3f69 Reviewed-on: https://chromium-review.googlesource.com/760376Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#516231}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/36f34243334f..ff7aac5e4f5d $ git log 36f342433..ff7aac5e4 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Re-land "Export angle::PlatformMethods." Created with: roll-dep src/third_party/angle BUG=778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2356b9e91c2950edfe3dc88097ad654b99373f34 Reviewed-on: https://chromium-review.googlesource.com/768573Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516230}
-
Tarun Bansal authored
TBR: dougarnett@chromium.org Bug: 784714 Change-Id: I973dba3d3b58b25fddc2e826d2452cb97492db18 Reviewed-on: https://chromium-review.googlesource.com/768579Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516229}
-
Kenichi Ishibashi authored
This CL adds "use_component_callbacks" field trial parameter (true by default). When it is true, NearOomMonitor uses Android's onLowMemory() to detect near-OOM situation instead of userland heuristics. Bug: 776665 Change-Id: I905e254acfb280d40d90218124ebe0bc605d9679 Reviewed-on: https://chromium-review.googlesource.com/762690 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#516228}
-
Luciano Pacheco authored
modules/websockets/ and modules/serviceworkers/ Fix missing include for <memory> and some for <utility> as pointed by lint. CL 9 of 10. Bug: 755727 Change-Id: Iadc120e5f4f54767966414bc6169facafdf14e80 Reviewed-on: https://chromium-review.googlesource.com/768593Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516227}
-