- 26 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a9042f8a77b..b847c567e717 git log 2a9042f8a77b..b847c567e717 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 vapier@chromium.org Reland "cros: switch CrOS programs to python3" Created with: gclient setdep -r src/third_party/depot_tools@b847c567e717 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:997354 Tbr: agable@chromium.org Change-Id: I53fbd052eeb847a73643bd108bc7b5b667579552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744750}
-
Maksim Ivanov authored
This makes the buttons of the LoginPinView view untabbable. It affects the quick_unlock and smart card PIN keypad UI in the user pod in Ash, and also the Parent Access Code dialog. This should NOT be an accessibility regression, since these buttons don't provide any extra functionality: i.e., the PIN can still be directly entered into the input field via other methods. The change was also approved by the a11y team (see the attached bug). This also makes it consistent with the HTML/Polymer-based PIN keyboard, which was recently changed to not support tabbing through the buttons (see the attached bug). The main motivation is to avoid struggling with the a11y behavior of these buttons (specifically, issues of keeping the focus and of pronouncing the "bullet" word of the screen reader). Bug: 1043194 Test: log in via a smart card, log out, start a login again, in the PIN dialog press Tab a few times, verify that the buttons of the PIN keyboard ("1", "2", etc.) don't get selected Change-Id: I650878e2fcecb2fd5e35d9fe847664fa8e4a6d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074441 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#744749}
-
Maksym Onufriienko authored
Bug: 1011498 Change-Id: Ie72335fb20a8ee5c47ba8edaf4ed8299068a7f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067325 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744748}
-
Mark Schillaci authored
This CL adds unit tests for WebContentsAccessibility. These tests expand on an existing test and cover more cases. This set of tests checks the ToIndex and FromIndex of the accessibility events being sent from Chrome to the system. In some cases not all indices are important, and so the incorrect indices can be sent and a defect will only appear in the rare edge or corner case that that index is relevant. A previous CL level-set all these indices to correct values: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 This CL now unit tests all these indices to ensure we do not deviate from the API expectations again. The unit tests cover every combination of: - Traversing forwards vs backwards - Navigating by line or word - Checking ToIndex and FromIndex - Checking indices of both traverse and selection events - Navigating with and without selection mode on Change-Id: I5c59017380ea0f8e5c59b4bc0c535dfb20f2930c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068887 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744747}
-
Mia Glaese authored
This reverts commit e4d87e3b. Reason for revert: This is not the culprit CL, the fix has been landed Original change's description: > Revert "[Start Surface] Add toolbar animations" > > This reverts commit a70166fd. > > Reason for revert: May cause crashes on Canary crbug.com/1052744 > > Original change's description: > > [Start Surface] Add toolbar animations > > > > Screen capture: > > https://drive.google.com/drive/folders/1VSZGz0yMwmYBV0uG0Zv5jgtLzKQt8DVM?usp=sharing > > > > Bug: 1025296 > > Change-Id: I6d3671252578fa9f37e5f1173b8d55b364a898c1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981853 > > Commit-Queue: Mia Glaese <glamia@chromium.org> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741772} > > TBR=yusufo@chromium.org,gogerald@chromium.org,pnoland@chromium.org,glamia@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1025296 > Change-Id: I1b86c55bf43601536eff5cc3b8f24ce867aed1fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058819 > Reviewed-by: Mia Glaese <glamia@chromium.org> > Commit-Queue: Mia Glaese <glamia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741973} TBR=yusufo@chromium.org,gogerald@chromium.org,pnoland@chromium.org,glamia@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025296 Change-Id: I8dd7efa70e967bba81ac31195f685b230d50ae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063663Reviewed-by:
Mia Glaese <glamia@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#744746}
-
Esmael El-Moslimany authored
When a history item is removed, we want to move the focus to next menu button. This was done by updating the items and focusing on the item with the same index. When removing the last item, this was causing an error since the index is now out of bounds of the items. This CL focuses on the new last item if there is one. Fixed: 1055956 Change-Id: I41934486f01c1c10afcf34a296585cb23d955592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073149 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744745}
-
Istiaque Ahmed authored
ContentVerifier::ShouldVerifyAnyPaths forces verification of JavaScript and html files by checking the extension of the resource (.js or .html/.htm) as they are considered sensitive resources. However, it didn't used to take case variants of extension into account, this CL fixes that by turning comparison of extension of files case-insensitive on all platforms. Added unit test for the behavior change. Bug: 1051396 Test: See bug description Change-Id: I0fed253ad5241db5b89c8abf6d0ab445dd403b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071486 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744744}
-
Omer Katz authored
Visiting a TraceWrapperV8Reference checked whether the reference is empty or not. If that check happens on a concurrent thread, it could race with v8 setting that reference. The fix is to check only on main thread. For concurrent threads, the reference is put into the worklist regardless of whether it is empty or not. The main thread then checks if its empty when popping from the worklist before pushing that reference to v8's worklist. Bug: 986235, 1054852 Change-Id: I877844c72994b0b6cb97559d25d225a78a2b3649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075278Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744743}
-
Michael Lippautz authored
Same as with HeapVectorBacking, move the GC support for HeapHashTableBacking into its own file instead of distributing it over the GC internals. Bug: 1056170 Change-Id: Ie4d26fd4135258c5cf4f4a133e7084d8105e02fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074617 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744742}
-
David Tseng authored
TBR=dmazzoni Change-Id: Ide2a25f35c31dbee75096a96c480c8b149cf6761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074810Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744741}
-
Andy Locascio authored
ARIA trees were previously un-navigable with VoiceOver on macOS. This was because it didn't properly fulfill the NSAccessibilityRowsAttribute attribute. In webkit, this attribute is fulfilled by diving on the row's children and surfacing any TreeItem elements. This CL represents a port of their implementation. Additionally, I noticed a confusing spot where the subrole is being compared in a long line of role comparisons. I moved this around to be less foot-gunny/confusing and added more attributes for the OutlineRow subrole that macOS accessibility suggests are necessary (and exist in the webkit implementation). Link to webkit impl: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm#L2836 https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp#L1804 Bug: 868480 Test: Use VoiceOver to navigate the table at https://cookiecrook.com/test/aria/tree/ariatree2.html. Note that the table is no longer announced as empty. Change-Id: Ibb86049efa23e12875aa9aeda541e0145242e3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062913Reviewed-by:
-
Evan Stade authored
1. Tab#dismissTabModalOverlay is added to hide the active tab modal dialog, if any. This is useful so the client can hide the dialog on system back, for example. 2. TabCallback#onTabModalStateChanged informs the client of changes to tab modal state, so the client can disable parts of its chrome. For example, Chrome disables the app menu and hides the contextual search manager. Bug: 1045499 Change-Id: I2f2f51a91dc24092a789769b5361ee23fd0c1c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065403 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744739}
-
Qingwen Pi authored
This is part of an effort to remove //media dependency from chromecast/media. Merge-With: eureka-internal/365986 Bug: b/149771309 Change-Id: I6b8c9b2233295d44214273171315590afcc6d36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065417 Commit-Queue: Qingwen Pi <qwp@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#744738}
-
Sergio Collazos authored
This reverts commit 2472108d. Reason for revert: A bad rebase broke reverted the change in https://crrev.com/c/2067642. Will land again with that fix. Original change's description: > [ios] Prevents InfobarBanner from being dismissed twice. > > Bug: 1049088 > Change-Id: I435c8b4c0bbec9130cecf845321391914df529d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071241 > Reviewed-by: Chris Lu <thegreenfrog@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744388} TBR=sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I08e153ee5b79af6988cef1c36b36ffcf04769359 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075139Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744737}
-
Natalie Chouinard authored
Move Notification settings alongside Notification code. Bug: 1047357 Change-Id: I973fa65703b5f0cc2efce0885e7cf93461d56a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073340Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744736}
-
Andrew Xu authored
Bug: 1045269 Change-Id: Iffd263f44955be6247a5fcdce0d82e6bd1f5e9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067649 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744735}
-
Mikhail Khokhlov authored
This CL provides a fallback for cases where the trace processor can't be found in the output directory. The necessary binary is downloaded from the cloud. Bug: b/148777584 Change-Id: Ie7e39bf7b0927cc41ef92675e71482ac7106841b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059998 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744734}
-
Fredrik Söderquist authored
Would assert a tuple not the actual expression. Remove parentheses. Bug: 1056217, 1051750 Change-Id: Id21e440ea5f095b167bf3906b192021210d5cbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#744733}
-
Tim Song authored
This is the first of a series of CLs to implement the UI for the built-in privacy screen feature. BUG=1040648 Change-Id: I0dc9d559dabd4ea4819d5e7977ae4b52add60db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071742 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#744732}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6426a06c..68e2a460 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf47662cbed691442a1bea3d59279cb38a6b62cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744731}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3cb141bbce3f..65314c068c43 git log 3cb141bbce3f..65314c068c43 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 jacktfranklin@chromium.org Typescriptify Common/Progress.js 2020-02-26 jacktfranklin@chromium.org Typecheck CharacterIdMap with TypeScript 2020-02-26 jacktfranklin@chromium.org Move `Common/Revealer.js` to TypeScript 2020-02-26 wolfi@chromium.org ESModules for IssuesPane Created with: gclient setdep -r src/third_party/devtools-frontend/src@65314c068c43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98eb6dfd7fefa568c7650275990c046bd10a8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074594Reviewed-by:
-
chrome://device-logSteven Bennetts authored
This improves the chrome://device-log UI as follows: * Log level is a dropdown instead of separate checkboxes * Type checkboxes are on a separate row with a 'clear' button Bug: 1054951 Change-Id: Ie0694dfab61045d10b6d9d32b698d62a1d3950b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068877Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#744729}
-
Saurabh Nijhara authored
The element is to be used during the OOBE update and update required screen. This CL also changes the browser tests for the update screen to be in-line with the new extracted component. The "G" iron-icon with size 24 is removed and the common icon size is being used as in other OOBE screens. Bug: 1048607 Change-Id: I69f9969f8600f5a6b91919e40d65f61305afe605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056818 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#744728}
-
chrome://crashesRobert Sesek authored
This redesigns the page to show the data for each crash report in a tabular fashion, rather than intermixed as prose. It also hides the local crash ID/context by default, though it can be accessed by toggling a new "Show developer details" checkbox. See https://crbug.com/761076#c2 for screen shots. Bug: 761076 Change-Id: Ia8f5cc88d4b44ceec3e625573d17f621dde8253a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073002Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#744727}
-
llin@chromium.org authored
This CL is to prepare for adding translation as Quick Answers backend: * Create a base result loader class. The existing SearchResultLoader is a child of the base class. * Add a intent type enum. Currently, always return unknown intent. The actual intent prediction logic will be added after integrating with on device text classifer. * Create result loader based on intent type. Currently, always create the |SearchResultLoader|. Will add other loaders in follow up CLs. This CL doesn't change any UI and behavior. Bug: b/150034512 Test: unit tests Change-Id: Ibb30a910892b2f782a8fc989544a83c2b1618ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069025Reviewed-by:
-
Rouslan Solomakhin authored
Patch #1: Add Blink API for CanMakePaymentEvent.respondWithMinimalUI() and CanMakePaymentEvent.currency according to the explainer for Minimal UI payment handlers: https://gist.github.com/rsolomakhin/eba91c185028899883d2c7f37f357d7c The additional API surface is disabled by default and can be enabled via chrome://flags/#enable-experimental-web-platform-features. Demo: https://rsolomakhin.github.io/pr/apps/micro/ Chrome feature status: https://chromestatus.com/feature/5661524146257920. Blink-dev intent to prototype: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kTLpgFJz6Ck/IQeiGDtOAwAJ Bug: 1005076 Change-Id: Id3d472a07992007e17c7dec4f4d826eaa84c309b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071108Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744725}
-
Gabriel Charette authored
Split directories [a* - components] (%chrome + fuchsia) from https://chromium-review.googlesource.com/c/chromium/src/+/2026350 as it had trouble landing in one go. The following script was used to generate this CL (run on every C++ file in the codebase; processing .h before matching .cc/.mm): https://bugs.chromium.org/p/chromium/issues/detail?id=1026641#c22 (intentionally ignores cleaning post_task.h for now). TBR=fdoray@chromium.org Bug: 1026641 Change-Id: I611ee5abce6daf14f80fbbf41e1fc14b6a1411d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075097Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#744724}
-
Tanmoy Mollik authored
Bug: 1049540 Change-Id: I918562e135600769120247f82840c00c23350eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066743Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#744723}
-
Saurabh Nijhara authored
Adding delegate in the policy handler to take care of the external dependencies. This CL adds 2 unit tests for MinimumVersionPolicyHandler. The test RequirementsNotMetState verifies that when policy contains a requirement with version greater than current version, then the state in the policy handler is set to the strongest requirement among those. The strongest requirement is defined in the policy description. The test RequirementsMetState verifies that if the current version satisfies all the requirements in the policy, then there is no change in the state in the policy handler. The keys in the policy schema have been moved to the header file so that they can be reused in the unit test without duplication. Bug: 1048607 Change-Id: I59625dd1c16e7097b814cb85f93de6ee2a3f87c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044116Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc2a97774bb6..19f466d399f1 git log dc2a97774bb6..19f466d399f1 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 robertphillips@google.com Adds gpu stats for program cache 2020-02-26 mtklein@google.com renable SkM44.h checks Created with: gclient setdep -r src/third_party/skia@19f466d399f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ie560b4e9826c182058c87274d137339f37f9eeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074590Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c8abd05a95c..9f9fdd5a2a7e Created with: gclient setdep -r src-internal@9f9fdd5a2a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0dec2ac660e74a13a18783f6401c95c97411aa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074591Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744720}
-
Aya ElAttar authored
Bug: 1044716 Change-Id: I43d49a8c1a9033c5c6c1ae184401647b1f821fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074884Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#744719}
-
Samuel Huang authored
This CL adds basic background, caveats, and basic instructions on adding native resources to a DFM, and updates docs and examples re. |load_native_on_get_impl|. TBR=yfriedman@chromium.org Bug: 1048740 Change-Id: I0c7adc21df568ce3ffc8895c81141bbe1db1850c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069845 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744718}
-
Vadym Doroshenko authored
This CL makes that Chrome Password Manager on iOS will detect some form submissions that are done with JavaScript w/o html form submission. Bug: 1042196 Change-Id: I53c0b7090d843e963259944f629ba7fee6d570d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047026 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744717}
-
Wenyu Fu authored
Some existing logic does not have a correct order in RadioButtonGroupHomepagePreference. 1. RadioButtonWithEditText will release focus for EditText when it is checked; 2. RadioButtonGroupHomepagePreference will check CustomUri radio button when its text changes; This will result in whenever the radio button is checked as NTP, changes for EditText will be interrupted whenever the text changed. This fix addresses the issue by improving #setChecked for RadioButtonWithDescription. If a radio button is set checked to be true and it is in a radio button group, the rest of the buttons will be unchecked. After fix, when touching the edit text, radio button will be checked at the same time when edit text gains focus. Bug: 1048863, 1053747 Change-Id: I86c7c74acfb68ecb6e6b7f4e1785ff245a8e8145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067237 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744716}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/da659b374113..e3621dca1542 git log da659b374113..e3621dca1542 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 capn@google.com Build with -Bsymbolic to prevent symbol preemption Created with: gclient setdep -r src/third_party/swiftshader@e3621dca1542 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6f81b6d77f346764c2d89c6e7b848ab2442a18d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074589Reviewed-by:
-
Ted Meyer authored
Add logs to the pre-sandbox dll loading calls, to see if this is the original source of the error. Bug: 1055602 Change-Id: I022036006a92dd5f454e6336127b9f19be163c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071908 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744714}
-
Roman Sorokin authored
Fixed: 1051867 Change-Id: Idae22190f05a870645aa55f62d0c77dc9f366595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073719 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de3b97eb1f52..b9b4569b9b76 git log de3b97eb1f52..b9b4569b9b76 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 courtneygo@google.com Save binding information when caching shader Created with: gclient setdep -r src/third_party/angle@b9b4569b9b76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I00abf6ab4b037dc4a4b9679827e7a29d0f972fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074584Reviewed-by:
-
Stefan Zager authored
Change-Id: I87fca2b760bb07100a12a02cb25556438cc57fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072936Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#744711}
-
