- 04 Dec, 2020 40 commits
-
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /chrome. The methods themselves will be removed in a follow-up CL once all call sites have been removed. Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Iee7432af1c85476a4f052f08ba1e2e62660574da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575328 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#833920}
-
Ben Pastene authored
crrev.com/i/3447173 allocates the machines for this. Bug: 1140727 Change-Id: I0b92100a9b9f449202d7a8c13f4ff1d3f76e1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575749Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833919}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib895e1f00288155e9c8f58fc5bda773cc58f456b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572985Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833918}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607070900-a3f370d99263588b261e824540349b020ef94941.profdata to chrome-win64-master-1607082643-c2f5265b374c0786e9c504f581789ab6e6bb2b7f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8b2bc7b0581471877af97ec193ed0d5071ed3d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833917}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /services/device/usb. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Id274f5e9679078c6071f058b95969d7dfae9d19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575333 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833916}
-
Xiaocheng Hu authored
This patch adds a basic UA style sheet for the 'decimal' and 'disc' counter styles, and plumbs them into RuleSet. This is in preparation to implement tree-scoped counter style references. Bug: 687225 Change-Id: If4effec939a2bfdedc5079e95c4c593f622db652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574071Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833915}
-
Jeffrey Kardatzke authored
This reverts commit 883c24e8. Reason for revert: Segfaults if not encrypted content Original change's description: > media: Fix crash when releasing decoder with ChromeOS CDM > > When the VaapiVideoDecoder was released, if it was using the CdmContext > it would have a callback associated with the CDM. Upon destruction of > the decoder, that callback would be destroyed automatically which makes > a call into the CDM. The CDM is being destructed on another thread, so > there was a race and this could cause a crash. > > The fix is to maintain a CdmContextRef in the decoder which keeps the > CDM alive until the decoder is destroyed. > > BUG=b:153111783 > TEST=Page refresh 10 times in a row w/ CDM did not crash > > Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833863} TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I11cd7d74a92bca26e51727ccbc494cc178008320 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:153111783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575717Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#833914}
-
Ian Kilpatrick authored
After some investigation (building testcases) this doesn't appear to be needed. Bug: 958381 Change-Id: Iaaac7e3579ecfff5fcee1a4b2055dcaabf3cd3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575739 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833913}
-
Carlos IL authored
Hidden class sections of interstitials are used for UI that is not being displayed, but for main-content and details, display:block was being added (and replacing display:none). This caused the sections to become audible in screen readers even when they were not visible. Since any section with class=hidden is not visible, this does not change the visible layout of the interstitial at any point. Bug: 1061611 Change-Id: I18179097e4b15659c2bb0ad5ebb556d9cebb114d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575329 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833912}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fab6700b9188..e6a623392d60 2020-12-04 gavinmak@google.com [depot_tools] Use logging.warning 2020-12-04 gavinmak@google.com [depot_tools] Fix CMDlol If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097402,chromium:1106660 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3862a6901af910946a83397bc154c3e547bb9b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575797Reviewed-by:
-
Haiyang Pan authored
It runs fine in the past week: http://shortn/_IILmyFI7dT Also the host pool (http://shortn/_jSF6ym5jrX) and test pool (http://shortn/_nTRsiMFi2n) are in good shape. Bug: 1127110 Change-Id: I334ec90bd9eb5cd736894d5762f764a2326c874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575596 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#833910}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5886280043b..9d48f8afe510 2020-12-04 kimanh@chromium.org [LMI] Open LMI drawer also when revealing an already existing tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I290a54d5bc407cac722aa23cf70b652e452906ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575796Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1147605 Change-Id: I3aead63cdb84b4bc31b992194de22244d6c0242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570030Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#833908}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51a0e95d78eb..f42409e60211 2020-12-04 jmadill@chromium.org Program: Allow non-fragment program input variables. 2020-12-04 courtneygo@google.com Ignore redundant Texture state changes 2020-12-04 jmadill@chromium.org Translator: Collect gl_in as a varying. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib9939311d85ca8e333c5af4e6a845f0ff3851972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575440Reviewed-by:
-
Ryan Hansberry authored
Change-Id: Ifdd5fe7272e029682e82a3308d247505b393b7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575394Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#833906}
-
Igor Ruvinov authored
Replace non-localized AddError(std::string) instances with the variant which accepts a message ID (and optionally placeholder arguments). Remove AddError(std::string) variants to encourage developers to define localization-supported policy strings instead of hard-coding errors. Bug: 1153894 Change-Id: I014522a16e6bff74832c2de797763623037c7000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566692 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#833905}
-
Yann Dago authored
Bug: 1154687 Change-Id: I3545d2d9d53b809529edf5a5e135b98892e4f026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569119 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#833904}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/crash/core/app. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=tiborg@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ic0e31127c5fb8b08f4df6950fa62f71726907567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575053 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833903}
-
Michael Hansen authored
The cr-lottie element was blocking the overlapping "learn more" links because the "position" attribute was pushing it to the front of the stack. Using "pointer-events: none" prevents it from interfering. Fixed: 1138445 Change-Id: I6eed177fd6ce47a598a68594233775d6a2a195cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572700Reviewed-by:
-
Mitsuru Oshima authored
1) until clients release their wl_output outputs. 2) but up to 9 seconds, then destroy the global output object. ug: b/168545216 Change-Id: I1035f417c5461ba9337a61506acba83d6ba08080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553527 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#833901}
-
Patrick Noland authored
As of this change, LocationBarLayout does not track the active profile or manage an OmniboxPrerender instance. This logic is moved to LocationBarMediator, with an associated unit test. This entails moving most of the implementation of onSuggestionsChanged() to LocationBarMediator as well. Bug: 1147581 Change-Id: I3cbb921074c7db893658388405ef8bdb514fd83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553040 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/d637672ffd93..330a1eec8132 $ git log d637672ff..330a1eec8 --date=short --no-merges --format='%ad %ae %s' 2020-12-04 dschinazi Fix QuicOneBlockArena for Windows 2020-12-04 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-04 fayang Deprecate gfe2_reloadable_flag_quic_fix_out_of_order_sending2. 2020-12-04 wub Add QUIC connection option B2RC to disable reno coexistence for BBR2. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 mattm Deprecate --gfe2_reloadable_flag_quic_enable_aead_limits. 2020-12-03 mattm QUIC+TLS server should temporarily retain 0-RTT keys so that re-ordered packets can be decoded. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 mattm Deprecate --gfe2_reloadable_flag_quic_key_update_supported. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 renjietang Fix typo in QuicPathValidator. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 wub Add a flag count for --gfe2_reloadable_flag_quic_tls_use_early_select_cert. 2020-12-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_arm_pto_for_application_data. 2020-12-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_address_validation. 2020-12-03 bnc Add HttpEncoder method to serialize ACCEPT_CH frame. 2020-12-02 dschinazi Clean up QuicTransportVersion use 2020-12-02 quiche-dev Refactor Http2Dispatcher (et al.) to prepare for --shinkansen_trace_logging. 2020-12-02 bnc Add ACCEPT_CH HTTP/3 frame type struct; add HttpFramesTest. 2020-12-02 fayang Enable QUIC Retransmittable-On-Wire-PING experiment on server side. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I948bfd352da6ef165ae0ffd22a6bc440cdb51b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575330 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833899}
-
Trent Begin authored
This change adds the framework for network health cr_component tests and adds a test for the routine-group element. Bug: chromium:1142857 Change-Id: I8299749f0ed3c5a77271919db211f46cb4d7d621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572996Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
If Nearby Share is actively broadcasting itself as able to receive content (by making the device discoverable over Bluetooth), do not display the "Your device is discoverable..." notification. This change requires the addition of a new method, NearbyShareDelegateImpl::IsEnableHighVisibilityRequestActive(). Using the existing method NearbyShareDelegateImpl::IsHighVisibilityOn() is not sufficient because BluetoothNotificationController::AdapterDiscoverableChanged() is triggered before NearbyShareDelegateImpl::IsHighVisibilityOn() becomes true. Making generic Bluetooth UI logic (BluetoothNotificationController) aware of the inner workings of Nearby is not ideal, but is the quickest solution we have available before launch. We will clean up this behavior leak in crbug.com/1155669. Bug: 1155668 Change-Id: I3174d9e1af777b97ef6e5daed9a80f75831ca41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566407 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833897}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/browser_ui/share. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=sebsg@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ib051ef18efe0d07dfdf5361537d038d95d3dea3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575331 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833896}
-
Sorin Jianu authored
This CL is not expected to address the test flakiness issue but it is cleaning the test code a bit for style and functional issues. The following has been done: - renamed the file to .cc so that it can be linted - moved the type aliases into an anonymous namespace and used :: because we aliased names in namespaces we did not own. - replaced a static base::FilePath - used the test server handle to guarantee the shutdown of the test server, as suggested by the documentation - cleaned up the request handler - inlined some local variables - removed a UT for creating the fetcher, since that code was already tried in other tests. Bug: 1153304 Change-Id: I01ef5d21ea354a6fcc7a08d0acd1e744f19e816c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575383 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#833895}
-
Chris Mumford authored
Bug: None Change-Id: Ifc00e3ac28743ed78d504d5ffe69f6d6ef5e07c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575036 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833894}
-
Akihiro Ota authored
This change adds a base class for panel tests and makes ChromeVoxPanelTest and ChromeVoxTutorialTest inherit from it. Bug: 1127967 Change-Id: I68131a5d12e79910779cd41ad0ae51a923d6f214 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568685 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833893}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/external. Bug: 1113033 Change-Id: I23683087348b268c9bd13a06a509ffc119d3811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573127Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#833892}
-
Gavin Williams authored
Opening Scan app from OS Settings does not need to pass an extra value to recordSettingChangeWithDetails() so underlying C++ function should be able to handle this case. Fixed: 1155694 Change-Id: Iff2cafaf12c5294ebfb52d16ed3dc42858171c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575386Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff8800deaa33..b37eb4854762 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858 Tbr: sergeyu@google.com,mmentovai@google.com Change-Id: I796c8cf004aed22c354952a6b0baad76ae8a53b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574831Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833890}
-
adamta authored
Creates a view controller for the NTP, the NewTabPageViewController. This VC is managed by the NewTabPageCoordinator and contains all the content that is presented on the regular NTP. First step of the refactoring effort; more content will be added to it in later CLs. Bug: 1114792 Change-Id: I38ce3fc3b386f9d93deed4ca28c9ec879b47a781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555662Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#833889}
-
Nate Fischer authored
Android: inline deprecated BuildInfo methods (/content/public/android/java/src/org/chromium/content/browser/selection) No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /content/public/android/java/src/org/chromium/content/browser/selection. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=ctzsm@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ia6d519d756b84bc8b116bfc0b9bf1dabd025cc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575385 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#833888}
-
Elly Fong-Jones authored
They will be re-enabled as part of fixing the linked bug. Bug: 1154345 Change-Id: I313ae9f360acbf5680245ad8934f0c91c9dc5d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575222Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833887}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b28382109909..fab6700b9188 2020-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I87c8cf4c9067e798d4d2822089727c0131ba30c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574833Reviewed-by:
-
Thomas Lukaszewicz authored
This CL updates tab search to correctly announce list items when navigating with arrow keys from the input field. Bug: 1152579 Change-Id: I6a13b688c01d7d7df8ceaca47001de2ad539d62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570452Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833885}
-
Justin Cohen authored
There's some speculation that MainThreadFreezeDetector is catching too many hangs that eventually recover, especially on change from foreground to background. If a hang report is generated, but the app recovers, return early before |reportGenerated| can be set. Change-Id: Ib4a4f9b1db44eeb42ce15da7f312f4df0033e401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536386 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833884}
-
Meilin Wang authored
Bug: 1150634 Change-Id: I84ad38c9eb8af368c0c34ba56305da0088d121ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568364 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The tasks on shutdown are not scheduled if not mark as "BLOCK_SHUTDOWN". This behavior leads FileTraceDataEndpoint object into an inconsistant state since its assumes tasks are executed to close the endpoint. The following stackframe shows the problem: [26692:22732:1204/131653.908:ERROR:tracing_controller_impl_data_endpoint.cc(68)] FileTraceDataEndpoint: c:\src\chromium\startup.json [26692:21808:1204/131719.958:ERROR:tracing_controller_impl_data_endpoint.cc(102)] OpenFileIfNeededOnBlockingThread! [26692:22732:1204/131735.498:FATAL:tracing_controller_impl_data_endpoint.cc(86)] Check failed: file_ == nullptr. Backtrace: base::debug::CollectStackTrace [0x00007FF87DAE24B2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:303) base::debug::StackTrace::StackTrace [0x00007FF87D9D6AE2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:195) logging::LogMessage::~LogMessage [0x00007FF87D9F2C94+148] (C:\src\chromium\src\base\logging.cc:566) logging::LogMessage::~LogMessage [0x00007FF87D9F3B80+16] (C:\src\chromium\src\base\logging.cc:559) content::`anonymous namespace'::FileTraceDataEndpoint::~FileTraceDataEndpoint [0x00007FF8603C5A50+96] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl_data_endpoint.cc:86) content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C1B88+114] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206) content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C3F20+16] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206) content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD41EA7+295] (C:\src\chromium\src\content\browser\browser_main_loop.cc:549) content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD46480+16] (C:\src\chromium\src\content\browser\browser_main_loop.cc:545) content::BrowserMainRunnerImpl::Shutdown [0x00007FF85FD476B8+312] (C:\src\chromium\src\content\browser\browser_main_runner_impl.cc:193) content::BrowserMain [0x00007FF85FD41935+213] (C:\src\chromium\src\content\browser\browser_main.cc:52) content::RunBrowserProcessMain [0x00007FF8609437C8+104] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:520) content::ContentMainRunnerImpl::RunBrowser [0x00007FF86094469D+1005] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:1008) content::ContentMainRunnerImpl::Run [0x00007FF860944289+457] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:888) content::RunContentProcess [0x00007FF860943295+1573] (C:\src\chromium\src\content\app\content_main.cc:372) content::ContentMain [0x00007FF86094338D+61] (C:\src\chromium\src\content\app\content_main.cc:398) ChromeMain [0x00007FF84BD11225+389] (C:\src\chromium\src\chrome\app\chrome_main.cc:133) MainDllLoader::Launch [0x00007FF749A926B5+391] (C:\src\chromium\src\chrome\app\main_dll_loader_win.cc:169) wWinMain [0x00007FF749A91ADF+2783] (C:\src\chromium\src\chrome\app\chrome_exe_main_win.cc:345) __scrt_common_main_seh [0x00007FF749B89926+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) BaseThreadInitThunk [0x00007FF8BF304034+20] RtlUserThreadStart [0x00007FF8C0913691+33] R=gab@chromium.org, eseckler@chromium.org, fdoray@chromium.org Bug: 1082916 Change-Id: I715d13e47de44c974a80ee80bec0f44639691786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575257Reviewed-by:Eric Seckler <eseckler@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#833882}
-
Jeffrey Young authored
Dead code will be removed in follow-up CL. https://chromium-review.googlesource.com/c/chromium/src/+/2567093 BUG=b:174506130 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I60505ad3ceb2bec51486b28271bcf96811c1c3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567255Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#833881}
-
